Commit graph

10772 commits

Author SHA1 Message Date
Kai
0c7d1422ee new link for HTML5 audio 2022-03-13 16:14:14 +00:00
Kai
51894d3fec README.md: HTTP => HTTPS 2022-03-13 03:44:14 +00:00
wisp3rwind
b76a3fcaa4 artresizer: move ImageMagick/PIL code from thumbnails plugin to ArtResizer
Makes the dispatch to the chosen backend simpler in the thumbnails
plugin. Given that ArtResizer is not only about resizing art anymore,
these methods fit there quite nicely.
2022-03-12 23:34:46 +01:00
wisp3rwind
e44a08eeb6 artresizer: style fixes 2022-03-12 23:34:46 +01:00
wisp3rwind
5d07b5390c artresizer: remove unused enum 2022-03-12 23:34:46 +01:00
wisp3rwind
f751893be2 artresizer: add FIXME notes where we should probably add some warnings
There's a lot of places where ArtResizer fails or falls back to
completely silently. We should at least log this, or maybe even raise
exceptions in some cases so that the caller can take a decision on how
to handle the failure.
2022-03-12 23:34:46 +01:00
wisp3rwind
bc364bc7d4 artresizer: merge _check_method into ArtResizer.__init__
more concise since _check_method became much shorter due to introduction
of backend classes
2022-03-12 23:34:46 +01:00
wisp3rwind
b097b19506 artresizer: move can_compare property to backend classes 2022-03-12 20:44:41 +01:00
wisp3rwind
cb9a765997 artresizer: move compare functions to backend classes 2022-03-12 20:42:35 +01:00
wisp3rwind
68e762c203 artresizer: move convert_format functions to backend classes 2022-03-12 20:39:40 +01:00
wisp3rwind
a781e6a9bf artresizer: move get_format functions to backend classes 2022-03-12 20:37:31 +01:00
wisp3rwind
1b92dea995 artresizer: move deinterlace functions to backend classes 2022-03-12 20:37:20 +01:00
wisp3rwind
279c081f23 artresizer: move get_size functions to backend classes
also rename getsize -> get_size for consistency with the ArtResizer
method
2022-03-12 20:27:14 +01:00
wisp3rwind
c45d2e28a6 artresizer: move resize functions to backend classes 2022-03-12 20:23:37 +01:00
wisp3rwind
8a969e3041 artresizer: backend classes part 1: stub classes, version checks 2022-03-12 19:48:45 +01:00
wisp3rwind
bac93e1095 artresizer: add a few comments 2022-03-12 11:23:35 +01:00
Adrian Sampson
bf66895191
Merge pull request #4302 from DucNg/auto_keep
Add auto_keep option to convert plugin - attempt to fix #1840
2022-03-11 08:09:09 -05:00
Adrian Sampson
03499a3b1e
Expand changelog for #4302 2022-03-11 08:08:31 -05:00
Duc Nguyen
c4281ddacc add some documentation 2022-03-09 18:34:31 +01:00
Adrian Sampson
80a86c62b7
Merge pull request #4303 from JOJ0/master
discogs: Fix discogs_albumid extraction
2022-03-04 21:07:50 +01:00
Duc Nguyen
a2325e72ad refactoring 2022-03-04 10:42:18 +01:00
Duc Nguyen
af5858d200 doc + linter + changelog 2022-03-04 10:42:17 +01:00
Duc Nguyen
18e8b73c33 add option to convert items after import
convert items after imports but also keep original files intact
2022-03-04 10:40:59 +01:00
J0J0 T
b2f4834b76 discogs: Add URI to test_parse_minimal_release data 2022-03-04 08:17:49 +01:00
J0J0 T
c85f903cae Revert "discogs: Add extract_release_id_regex sanity check"
This reverts commit c3cc055fdd3830bbe1c5470fe540684278a6ecc7.

We assume the Discogs API never returns a release response without an
URI.
2022-03-04 08:17:49 +01:00
J0J0 T
b609047d64 discogs: Add extract_release_id_regex sanity check
Check whether any input worth pattern checking was passed.
2022-03-04 08:17:49 +01:00
J0J0 T
76e81199b5 discogs: Changelog entry for #4303 Fix discogs_albumid.. 2022-03-04 08:17:49 +01:00
J0J0 T
c9c1123756 discogs: Fix discogs_albumid extraction
Use extract_release_id_regex instead of extract_release_id to get the
release ID out ouf the Discogs release URL.
2022-03-04 08:17:49 +01:00
Adrian Sampson
1bc00105bd
Merge pull request #4304 from jdheyburn/jdheyburn-feat-discogs-append-style-to-genre
feat: discogs: allow style to be appended to genre
2022-03-03 11:17:40 +01:00
Adrian Sampson
e1d19c3a3f
Docs refinement 2022-03-03 11:17:07 +01:00
Joseph Heyburn
4bde4d082d discogs: allow style to be appended to genre
- Added more verbose documentation to `append_style_genre`
- Refactor based on code review
2022-03-03 10:03:31 +00:00
Joseph Heyburn
55e4917df3 discogs: allow style to be appended to genre
- Adds a configuration that, when enabled, will append the style to genre
- Rationale is to have more verbose genres in genre tag of players that only support genre
2022-03-02 22:04:36 +00:00
Adrian Sampson
bd7793211c
Merge pull request #4299 from Neurrone/fix/dont-deduplicate-results-when-musicbrainz-id-is-not-set
fix: dont deduplicate matches if musicbrainz ID is not set for album matches
2022-02-27 14:02:27 -05:00
Adrian Sampson
5e057078a6
Slight rewording 2022-02-27 14:01:48 -05:00
Dickson
6d6bb51fde Update changelog 2022-02-27 13:28:17 +08:00
Dickson
8e40473453 fix: dont deduplicate matches if musicbrainz ID is not set for album candidates 2022-02-26 21:15:28 +08:00
Adrian Sampson
5f45e9e108
Tiny wording tweaks for #4281 2022-02-16 16:34:38 -05:00
Adrian Sampson
5a96037853
Merge pull request #4281 from jaimeMF/fish-completion-output
fish plugin: Add --output option
2022-02-16 16:33:14 -05:00
Jaime Marquínez Ferrándiz
8e921e4d74
fish plugin: Style fix
Co-authored-by: Adrian Sampson <adrian@radbox.org>
2022-02-16 21:51:19 +01:00
Jaime Marquínez Ferrándiz
fedb8b0b8f fish plugin: Assign the default output path to the option instead of using None 2022-02-16 21:42:08 +01:00
Jaime Marquínez Ferrándiz
b46b4d2045 fish plugin: Simplify directory creation 2022-02-16 21:34:24 +01:00
Jaime Marquínez Ferrándiz
40fcb25221 fish plugin: Split long line 2022-02-16 08:15:30 +01:00
Jaime Marquínez Ferrándiz
8e5156d01c fish plugin: Add --output option 2022-02-15 23:11:30 +01:00
Benedikt
6d401343e8
Merge pull request #4275 from wisp3rwind/pr_art_comp_v2
Fix embedart with compare_threshold on ImageMagick 7
2022-02-15 22:45:39 +01:00
wisp3rwind
1815d08392 artresizer: fix image comparison test
Since the ImageMagick based comparison is now abstracted via ArtResizer,
it becomes a little more involved to mock it for testing.
2022-02-14 22:52:00 +01:00
wisp3rwind
959e24e463 artresizer: whitespace fixes 2022-02-12 23:35:13 +01:00
wisp3rwind
f558c091b4 update changelog 2022-02-12 23:35:13 +01:00
wisp3rwind
8235af9770 art: log errors more explicitly, add some comments
error handling was previously implicit in the
`if not check_art_similarity(...)`
check, which is pretty unintuitive
2022-02-12 23:35:13 +01:00
wisp3rwind
03ce35f4d3 art: whitespace/comment improvements 2022-02-12 23:10:22 +01:00
wisp3rwind
2fa37aa22b artresizer: return None explicitly
`None` is used both as a marker when errors occured, and when a function
is not implemented by the backend. That is already confusing enough
without there being implicit `None` return values when falling of the
tail of a method
2022-02-12 22:59:52 +01:00