Adrian Sampson
82d41446a2
Use fsdecode for template substitution
...
The idea in this PR is to converge on Python's `fsdecode` and `fsencode`
for argument manipulation. This seems to match up with the Python
standard library's assumptions: namely, on Windows, we use `fsdecode` to
get back to Unicode strings:
54bbb5e336/Lib/subprocess.py (L561)
2022-10-01 16:37:47 -07:00
Adrian Sampson
c8ab0cfa6b
Merge pull request #4506 from beetbox/replaygain-fix-exc
...
replaygain: Fix error handling for parallel runs
2022-10-01 16:35:38 -07:00
Adrian Sampson
675dd7b9a9
Add logging for command output on errors
2022-10-01 16:08:32 -07:00
Adrian Sampson
eaabf291f7
Changelog for #4506
2022-10-01 15:51:44 -07:00
Adrian Sampson
9803939a1c
replaygain: Fix error handling for parallel runs
...
The parallelism strategy in #3478 , in retrospect, used a pretty funky
way to deal with exceptions in the asynchronous work---since
`apply_async` has an `error_callback` parameter that's meant for exactly
this. The problem is that the wrapped function would correctly log the
exception *and then return `None`*, confusing any downstream code.
Instead of just adding `None`-awareness to the callback, let's just
avoid running the callback altogether in the case of an error.
2022-10-01 15:47:41 -07:00
Adrian Sampson
7f977079c3
Merge pull request #4505 from beetbox/fix-unidecode
...
Adapt tests to latest Unidecode version
2022-10-01 10:44:20 -07:00
Adrian Sampson
5ae1e0f3c8
Adapt tests to latest Unidecode version
...
Unidecode 1.3.5 (a yanked PyPI version) changed the behavior of
Unidecode for some specific characters:
> Remove trailing space in replacements for vulgar fractions.
As luck would have it, our tests used the 1/2 character specifically to
test the behavior when these characters decoded to contain slashes. We
now pin a sufficiently recent version of Unidecode and adapt the tests
to match the new behavior.
2022-10-01 10:33:26 -07:00
Jordi
c6d623241b
Fix beets#4472 - set 'max_bitrate' default param to none
2022-10-01 01:20:30 +02:00
Callum Brown
aa09d2a9eb
AURA: document cors for local browser clients
2022-09-28 21:04:33 +01:00
David Logie
cfb32d9bc5
Add a import.ignored_alias_types option to ignore alias types.
...
Sometimes a user may want to use an artist's locale-specific alias but
*not* want to use their legal name, for example.
2022-09-24 15:36:46 +01:00
Benedikt
b11df49705
Merge pull request #4492 from arsaboo/spotify_date
...
Fix spotify_updated bug so that the date is not "null"
2022-09-18 12:03:13 +02:00
Alok Saboo
4692199166
Add dateype back
2022-09-17 21:05:16 -04:00
Alok Saboo
e4063b5880
remove datetype
2022-09-17 20:56:48 -04:00
Alok Saboo
85b500e41a
Fix spotify_updated bug
2022-09-17 20:25:36 -04:00
Adrian Sampson
44a7cc74bf
Merge pull request #4485 from c00ldude1oo/master
...
Fix typo in albumtypes plugin docs
2022-09-14 16:13:29 -07:00
Chris
f5d7967646
Fix typo in albumtypes plugin docs
2022-09-14 04:06:16 -04:00
Adrian Sampson
50bd693057
Merge pull request #4456 from arsaboo/mbsubmit
...
Extend mbsubmit plugin to run after initial import
2022-08-27 13:18:24 -07:00
Adrian Sampson
b65bdd7f06
Add plugin link to changelog for #4456
2022-08-27 13:16:42 -07:00
Adrian Sampson
0c8bf6d7c7
Remove a stray dot
2022-08-27 13:16:02 -07:00
Adrian Sampson
010bacd1ea
Merge pull request #4457 from konlaasz/patch-1
...
Fix typo
2022-08-26 08:17:36 -07:00
László Koncz
27bc317fed
Fix typo
2022-08-26 12:04:47 +02:00
Alok Saboo
1a2fcdd4e3
Adjust line length
2022-08-24 10:04:01 -04:00
Alok Saboo
8ee1a9e508
Updated docs
2022-08-24 09:39:25 -04:00
Alok Saboo
f01eca756f
Update changelog.rst
2022-08-24 09:34:06 -04:00
Alok Saboo
d267f9a8a9
Remove f-string
2022-08-24 09:32:39 -04:00
Alok Saboo
9d8ce14e9a
Cleanup mbsubmit
2022-08-24 09:24:33 -04:00
Alok Saboo
c48aef3f33
Update mbsubmit.py
2022-08-24 09:16:20 -04:00
Alok Saboo
2168292455
Update mbsubmit.py
2022-08-24 09:11:45 -04:00
Adrian Sampson
e584b043be
Merge pull request #4199 from jcassette/duplicate
...
Allow to configure which fields are used to find duplicates
2022-08-21 10:44:31 -07:00
Adrian Sampson
2ebc28d6cb
Improve changelog for #4199
2022-08-21 10:36:40 -07:00
Adrian Sampson
1054b729d3
Merge branch 'master' into duplicate
2022-08-21 10:34:15 -07:00
Adrian Sampson
3c945cba0c
Change config key from "single" to "item"
...
For consistency with the rest of the terminology in the docs/config.
Also, correct the documentation (which previously only covered albums).
2022-08-21 10:31:45 -07:00
Adrian Sampson
bcc8903036
Refactor query utilities
...
We now use somewhat more general query constructors in `dbcore`,
avoiding the need for somewhat special-purpose `duplicates` methods on
the model objects.
2022-08-21 10:27:31 -07:00
Adrian Sampson
ca38486b83
Clarify some control flow
2022-08-21 10:12:47 -07:00
Adrian Sampson
7467bc3919
Merge pull request #4450 from beetbox/deprecations
...
Resolve some deprecation warnings
2022-08-21 10:01:37 -07:00
Adrian Sampson
8cb314350c
Avoid BeautifulSoup deprecation warning
...
The `text` parameter to `SoupStrainer` was renamed to `string` in 2015
(4.4.0) and started producing a warning this year (4.11.0).
https://bazaar.launchpad.net/%7Eleonardr/beautifulsoup/bs4/view/head:/CHANGELOG
2022-08-21 09:50:53 -07:00
Adrian Sampson
8c84bae689
Remove match_querystring in responses
...
Quoth the responses documentation:
> querystring is matched by default
Not sure how recent this is, unfortunately---but probably 0.17.0, since
that's the version where `match_querystring` was deprecated.
2022-08-21 08:18:49 -07:00
Adrian Sampson
63b7595bd4
Remove use of imp
...
The replacements in `importlib.util` have been available since Python
3.5.
2022-08-21 08:13:07 -07:00
Adrian Sampson
2c9f699ffd
Use non-deprecated name for notify_all
...
`notifyAll` was deprecated in:
https://github.com/python/cpython/issues/87889
The new name, `notify_all`, has been available since Python 3.0.
2022-08-21 08:06:10 -07:00
Adrian Sampson
6e0f7a1e68
Merge pull request #4412 from beetbox/album-items
...
Document Album.items() / LibModel.items() conflict
2022-08-21 07:09:12 -07:00
Adrian Sampson
f0a6bbb38c
Merge pull request #4447 from wisp3rwind/pr_version_regex
...
release.py: fix version regex (remove u'' string prefix)
2022-08-21 07:07:23 -07:00
Callum Brown
bf8fbed2e8
Clarify Album.items() conflict
2022-08-21 14:34:18 +01:00
Adrian Sampson
40d7fa6f8e
Merge pull request #4095 from Duncaen/formatted-modify
...
Formatted modify and import --set-field.
2022-08-20 17:14:02 -07:00
Adrian Sampson
fb9e95b324
Fix some long lines
2022-08-20 16:50:20 -07:00
Adrian Sampson
b207224d57
Further document formatted modify with examples
...
I think these can make it clearer why someone would want to use this
feature. (Part of #4095.)
2022-08-20 16:47:01 -07:00
Adrian Sampson
dad918e63c
Out-of-date changelog fixes
2022-08-20 16:43:55 -07:00
Adrian Sampson
7af40db050
Merge branch 'master' into formatted-modify
2022-08-20 16:37:52 -07:00
Benedikt
4761c35afd
Merge pull request #4395 from clach04/patch-1
...
Version bump to 1.6.1
2022-08-20 07:33:23 +02:00
wisp3rwind
fafddced6e
release.py: fix version regex (remove u'' string prefix)
2022-08-20 07:30:15 +02:00
Adrian Sampson
18ab44169d
Merge pull request #4444 from BinaryBrain/master
...
Add Beetstream in the plugin list
2022-08-19 17:54:52 -07:00
