Commit graph

10772 commits

Author SHA1 Message Date
maffo999
51210cb649 Updated changelog 2021-07-14 20:36:52 +02:00
maffo999
653181a296 Fix subsonicupdate plugin 2021-07-14 20:10:04 +02:00
Adrian Sampson
0f9ffeec3e
Merge pull request #3995 from wisp3rwind/pr_lyrics_tekstowo_no_crashes
Crash-resilient Tekstowo lyrics source
2021-07-05 09:52:05 -04:00
wisp3rwind
c336191cdf lyrics: update and condense Tekstowo changelog entries 2021-07-04 13:54:03 +02:00
wisp3rwind
0c285753fb lyrics: Add some missing None-checks to the Tekstowo source
The previous code had the potential to crash if (when?) Tekstowo changes
their website structure sufficiently.

The new code is rather ugly due to the explicit checks after each and
every function call. Unfortunately, the alternative would be to catch a
bunch of very generic Exceptions (AttributeError, ...), since there's no
such thing as a `BeautifulSoupNotFoundError`.
2021-07-04 10:38:00 +02:00
wisp3rwind
09be82bd75 lyrics: slightly more consistent white space in Tekstowo source 2021-07-04 00:35:42 +02:00
Benedikt
ed695f20a1
Merge pull request #3994 from matlads/patch-2
return None for lyrics if Tekstowo fails to extract lyrics
2021-07-04 00:34:11 +02:00
Martin Atukunda
efcc5b3fae
return None for lyrics if Tekstowo fails to extract lyrics
I experienced a failure to parse Tekstowo for song lyrics. 

This patch allowed the lyrics plugin to fetch the lyrics from another provider as opposed to failing.
2021-07-01 09:39:42 +03:00
Adrian Sampson
eadeead565
CI: Freshen apt packages 2021-06-29 09:39:10 -04:00
Adrian Sampson
87f5acebee
More changelog futzing 2021-06-28 17:44:45 -04:00
Benedikt
7e702a0318
Merge pull request #3980 from wisp3rwind/pr_fix_duplicate_empty_query
duplicates: fix crash on empty query
2021-06-18 17:21:48 +02:00
wisp3rwind
0e1c102337 duplicates: update changelog 2021-06-18 17:19:16 +02:00
wisp3rwind
d6ca1cc242 duplicates: fix crash when query return empty results 2021-06-18 17:18:50 +02:00
Benedikt
027474b86a
Merge pull request #3978 from wisp3rwind/handle_lyrics_errors
Always handle errors in the lyrics plugin
2021-06-18 17:17:32 +02:00
wisp3rwind
dfd834cf8f lyrics: update changelog 2021-06-18 17:16:47 +02:00
wisp3rwind
316b79f72f lyrics: slightly refactor beautifulsoup checks
instead of having a global list of sources that require the package,
indicate the dependency using an attribute of the source class
2021-06-18 17:16:04 +02:00
wisp3rwind
038cebfa9b lyrics: remove duplicate check for beautifulsoup
The plugin already disables these sources entirely when beautifulsoup is
not available
2021-06-18 17:16:04 +02:00
wisp3rwind
867d383544 lyrics: wrap BeautifulSoup() constructor to centralize error handling
also ensure that the return value is always checked for None
2021-06-18 17:16:04 +02:00
wisp3rwind
b34442f5d1 lyrics: always check for fetch_url() returning None 2021-06-18 17:16:04 +02:00
wisp3rwind
f8a4c661fa lyrics: return None explicitly 2021-06-18 17:16:04 +02:00
wisp3rwind
76aa97827d lyrics: rename html -> soup for consistency 2021-06-18 17:16:04 +02:00
Adrian Sampson
bc2fd38690
Merge pull request #3982 from adsultana/fix-ifdef-nonstring-fields
Fix ifdef behavior with non-string fields (bug #3852)
2021-06-17 11:12:44 -04:00
Andrew Sultana
4c86520479 template: update changelog 2021-06-16 16:50:20 +01:00
Andrew Sultana
86e11fb582 template: fix ifdef bug #3852 involving non-string fields with missing values 2021-06-16 16:49:16 +01:00
Benedikt
5fad8ee0b2
Merge pull request #3930 from arogl/fix_#2873
Attempt to fix duplicates
2021-06-15 11:19:55 +02:00
Adrian Sampson
0d62419132
Merge pull request #3957 from beetbox/move-official-irc-to-libera
Document Libera.Chat as the new official IRC home
2021-05-24 16:13:21 -07:00
Adrian Sampson
d124c2f224
Merge pull request #3958 from jackwilsdon/fix-tekstowo-test
Add missing test data for tekstowo
2021-05-24 16:12:21 -07:00
Jack Wilsdon
6a98e5d8db
Add missing test data for tekstowo 2021-05-24 18:20:33 +01:00
Frederik “Freso” S. Olesen
1e07d7b223
Document Libera.Chat as the new official IRC home
freenode has had a hostile takeover (see DWF CVE-2021-1000189[1]) and
the network is no longer safe, as a result the official IRC channel is
moved to the Libera.Chat network.

[1] https://github.com/distributedweaknessfiling/dwflist/blob/main/2021/1000xxx/CVE-2021-1000189.json

Resolves https://github.com/beetbox/beets/discussions/3953
2021-05-24 17:37:19 +02:00
Andrew Rogl
78f25575c3 Resolve changelog conflict 2021-05-24 16:23:04 +10:00
Andrew Rogl
51d922df27 Merge branch 'master' into fix_#2873 2021-05-24 16:21:27 +10:00
Adrian Sampson
ebce4bd5bd
Merge pull request #3956 from arogl/patch-1
Update ci.yaml
2021-05-23 12:37:17 -07:00
arogl
7f45131f1a
Update ci.yaml
Remove deprecated Python version
2021-05-23 16:28:44 +10:00
Andrew Rogl
81e50cb630 Too quick to delete 2021-05-23 15:43:14 +10:00
Andrew Rogl
39ca5b7be6 Changes as requested 2021-05-23 14:45:02 +10:00
Benedikt
eef26d1886
Merge pull request #3927 from bertbesser/set-fields-persist-to-tracks
persist set_fields to media files
2021-05-14 10:51:34 +02:00
Bert Besser
8dc960b1f6 fix: formatting 2021-05-14 10:19:59 +02:00
Benedikt
1faa41f8c5
Merge pull request #3942 from sandersantema/master
Add itunes_dateadded to metasync plugin
2021-05-13 21:40:00 +02:00
Bert Besser
e98f78e29b fix: transactions and stricter tests 2021-05-13 15:09:55 +02:00
sandersantema
81ef3c2fc3
Update changelog 2021-05-13 14:44:51 +02:00
sandersantema
f3e1d90470
Avoid usage of walrus operator which is only compatible with > 3.8 2021-05-13 12:58:26 +02:00
sandersantema
51b22a41f0 Add tests for new itunes_dateadded function of metasync plugin 2021-05-13 12:42:59 +02:00
sandersantema
2cd15a7434 Add itunes_dateadded to itunes metasync plugin 2021-05-13 12:32:42 +02:00
bertbesser
a25a2a6cbb
Merge branch 'master' into set-fields-persist-to-tracks 2021-05-13 07:38:26 +02:00
Adrian Sampson
56e902671e
Merge pull request #3814 from aereaux/add_isrc
Add ISRC identifiers from musicbrainz.
2021-05-12 07:55:26 -07:00
Aidan Epstein
b6fda634c4 Add ISRC identifiers from musicbrainz. 2021-05-12 07:44:55 -07:00
Benedikt
c0af155323
Merge pull request #3831 from dosoe/beets_tag_hook
Add two events extracting_trackdata and extracting_albumdata
2021-05-11 23:01:54 +02:00
Dorian
c64fc68b16 more detailed documentation 2021-05-11 22:17:38 +02:00
Dorian Soergel
c9c2c81df6
Merge branch 'master' into beets_tag_hook 2021-05-11 10:46:15 +02:00
Dorian
64238ca8c6 complete documentation 2021-05-11 10:44:33 +02:00