xarph
ffcaf33845
add -f argument to play command
2017-04-18 15:30:24 -07:00
Adrian Sampson
0cbb40869a
Merge pull request #2403 from antlarr/master
...
Run python2 or python3 depending on what's being used
2017-04-15 11:28:45 -04:00
Adrian Sampson
fb7296711c
Fix Windows encoding in convert stub ( #2516 )
2017-04-15 11:27:19 -04:00
discopatrick
d466f8802c
passes flake8
2017-04-14 14:45:51 +01:00
discopatrick
ff4c0abcf1
tests ‘added’ instead of ‘mtime’ , and uses a correct date format
2017-04-14 13:05:13 +01:00
discopatrick
ed0ea1dee5
tests more invalid date queries
2017-04-14 01:49:58 +01:00
discopatrick
8e6909bf4b
raises error when date string has too many components
2017-04-14 01:32:18 +01:00
discopatrick
a3251ef7c6
skips tests for now
2017-04-14 01:13:02 +01:00
discopatrick
1744ca6e88
raises error when dates passed to query as long numbers
2017-04-14 00:40:06 +01:00
Antonio Larrosa
85e0c0dcee
Fixed E501 and E305 PEP8 errors
2017-04-04 09:08:30 +02:00
Antonio Larrosa
fa468ce9d1
Properly quote executable and command line parameter
...
Use shlex.quote (on python3) or pipes.quote (on python2) to properly
quote the python executable and parameter instead of using single quotes
2017-04-04 09:08:30 +02:00
Antonio Larrosa
44ddd2e8f5
Shell-escape sys.executable
...
sys.executable needs to be shell-escaped on windows.
2017-04-04 09:08:30 +02:00
Antonio Larrosa
42b4e54391
Use sys.executable instead of composing the executable name
...
Better use sys.executable than using sys.version_info.major and compose
the name of the python executable.
2017-04-04 09:08:30 +02:00
Antonio Larrosa
1e4378d636
Run python2 or python3 depending on what's used
...
On a system with dependencies installed for python3 but not for python2,
we have to make sure python3 is used everywhere since 'python' might be running
the python2 interpreter.
This helps with some problems in #2400 , but doesn't fix the issue completely.
2017-04-04 09:08:30 +02:00
Aaron
64d69f0817
embedart: Added test case for inputting “no” option interactively.
2017-03-10 23:30:49 -08:00
Aaron
f6df3befac
Added interactive test method for embedart plugin.
2017-03-08 19:06:09 -08:00
Adrian Sampson
5a71ce722a
Simplify embedart test changes for #2422
...
Whenever possible, it's nice to avoid using DummyIO---it can make debugging
difficult.
2017-03-06 23:55:14 -05:00
Adrian Sampson
74df2788c0
Merge branch 'master' into Stunner-master
2017-03-06 23:51:10 -05:00
Adrian Sampson
17ad3e83db
Test updates for #2466 fix
2017-03-03 12:10:26 -06:00
Aaron Jubbal
864aa11ec5
Merge branch 'master' into master
2017-02-21 04:43:45 -08:00
Jacob Gillespie
1fd22604fb
Fix linter issues
2017-02-19 17:33:26 -06:00
Jacob Gillespie
902b955696
Fix test_hardlink_arrives
2017-02-19 17:22:01 -06:00
Jacob Gillespie
ccd0f5d129
Remove not-found hardlink test (the OS prevents this from happening)
2017-02-19 17:19:42 -06:00
Jacob Gillespie
b4efecb709
Add option to hardlink when importing
2017-02-19 15:56:13 -06:00
Aaron
d1ac893915
Style changes to pass PEP8 tests.
2017-02-13 01:58:31 -08:00
Aaron
9c97f95073
Updated embedart test cases to accomodate confirmation prompt.
2017-02-13 01:58:31 -08:00
wordofglass
c252b9256b
Merge pull request #2415 from beetbox/fetchart_cleanup
...
fetchart: Clean-up data structures
2017-01-30 10:18:33 +01:00
wordofglass
7c79d8ce89
fetchart: minor restructuring of tests.
2017-01-30 10:01:19 +01:00
wordofglass
bc582701ff
fetchart: Internally pass settings in a cleaner way.
...
Dump the 'extra' dictionary which only duplicated attributes of the
plugin onject in favor of passing a reference to the plugin directly.
2017-01-25 00:01:05 +01:00
Adrian Sampson
3a6967eb7a
Remove dependencies from convert_stub.py
...
See: https://github.com/beetbox/beets/pull/2403#issuecomment-274358494
2017-01-22 12:59:04 -08:00
diomekes
04f7915d41
change no-bracket argument from white space to empty
2017-01-20 22:47:47 -05:00
diomekes
eaa2161a90
fix empty disambig string test
2017-01-20 19:40:09 -05:00
diomekes
d10df34c65
add test for aunique without brackets
2017-01-20 09:06:38 -05:00
diomekes
3a967df396
simplify check for empty disam_val, update changelog and docs, add change bracket test
2017-01-19 20:41:44 -05:00
diomekes
377a2a6964
add bracket argument to aunique
2017-01-19 20:39:12 -05:00
Steve Johnson
e3707e45f3
Maybe fix code and tests for Windows
2017-01-15 11:21:59 -08:00
Steve Johnson
6b7a6baaf2
Add test for /item/path/ endpoint
2017-01-15 11:21:59 -08:00
Steve Johnson
05bc4996a8
Rename and invert new config option
2017-01-15 11:21:33 -08:00
Steve Johnson
cedd93b778
Add tests for exclude_paths_from_items
2017-01-15 11:21:33 -08:00
Adrian Sampson
0f1a93c666
Add missing unittest suite declaration ( #2389 )
2017-01-14 17:33:36 -08:00
Adrian Sampson
703f47ae97
Use flexible attribute for track_alt
...
No need for a built-in field for a simple string-type optional field like
this.
2017-01-10 21:01:36 -05:00
Mike Cameron
bba5a7c712
Fixed (?) failing test where
...
umber was rack_alt was missing during import.
2017-01-10 19:08:18 -05:00
Mike Cameron
3cd4f1c091
Fixed failing test where track number was missing from mocked data.
2017-01-10 18:57:42 -05:00
Mike Cameron
3f67a27989
Fixed failing test because mocked data was missing property
...
umber.
2017-01-10 18:21:28 -05:00
Adrian Sampson
f7ebf5524f
flake8 fix for #2379
2017-01-10 13:25:24 -05:00
Adrian Sampson
f137f87878
More test docs about the image.* mixin
2017-01-10 12:41:34 -05:00
Adrian Sampson
5863859a5d
Remove image tests for DSF ( #2379 )
...
There isn't currently an `image.dsf`, so those tests fail.
2017-01-10 12:38:44 -05:00
Adrian Sampson
5e20cfd26e
flake8 fixes for 2379
2017-01-10 12:33:23 -05:00
Adrian Sampson
96350ab7db
Merge pull request #2379 from docbobo/feature/dsf-support
...
Support for DSF files
2017-01-10 12:28:29 -05:00
Boris Pruessmann
e0a4dc67a8
Test improvements for DSF.
...
- Fixed unparseable.dsf
- Added DSF feature detection to test_mediafile.py
2017-01-10 11:21:40 +01:00
Adrian Sampson
a2d37dd588
Document how to add tests for a new format ( #2379 )
2017-01-09 13:02:28 -05:00
Boris Pruessmann
1e10e62d82
Added DSF to test_mediafile
2017-01-09 18:54:30 +01:00
Adrian Sampson
e5e710033c
Remove old test for misspelled config option
...
See 6b9d766 , which removed the option.
2017-01-07 17:19:02 -05:00
Adrian Sampson
fbc0f322f6
Merge branch 'tigranl-https_fix'
2017-01-02 20:54:17 -05:00
Adrian Sampson
33a8e81f08
Simplify test changes
...
We don't need quite so many checks now that SSL isn't conditional most of the
time.
2017-01-02 20:49:12 -05:00
Diego M. Rodriguez
37cb1c295f
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
...
Conflicts:
docs/changelog.rst
test/test_discogs.py
2016-12-30 10:42:50 +01:00
Diego M. Rodriguez
0a9cb1fd3d
discogs: revise subtrack merging based on subindex
...
Modify the coalescing of subtracks by taking into account the subindices
of the subtracks for deciding if they represent "logical" tracks
(merging them into one single track, as previously) or if they represent
physical tracks (treating them as individual tracks).
Add unit tests for nested logical/physical subtracks, and disc titles.
2016-12-29 18:03:54 +01:00
Diego M. Rodriguez
4364757fcc
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
...
Conflicts:
docs/changelog.rst
2016-12-29 13:27:06 +01:00
Diego M. Rodriguez
30f238151e
discogs: additional sanity checks parsing release
...
Add extra checks for the presence of specific field (artists, title,
id, tracklist) when parsing a Release from discogs, failing gracefully
if the fields could not be found.
Add a test for releases without required fields.
2016-12-29 13:19:01 +01:00
Diego M. Rodriguez
02666424d4
discogs: improve robustness when parsing an album
...
Improve the robustness of `get_album_info()` by preferring the use of
`get()` over accesing the dictionary keys directly for several fields,
plus adding extra checks for fields that depend on nested containers on
the Release data.
Add a test for parsing a release that contains a minimal amount of
fields.
2016-12-28 21:07:18 +01:00
Adrian Sampson
8763be5423
Revert "Fix tests for new prompt order"
...
This reverts commit a357cc4e1a .
We no longer need the tests to change---I was able to fix the order by
bringing the "abort" action into the standard list of options.
2016-12-28 14:33:11 -05:00
Adrian Sampson
a357cc4e1a
Fix tests for new prompt order
2016-12-28 14:23:22 -05:00
Adrian Sampson
7c6eafa285
Refactor manual search options to use Proposal
...
This is the first step to making them behave like plugin actions.
2016-12-28 13:50:53 -05:00
Adrian Sampson
8408264142
Update test file for new set of tags
...
The new MediaFile tags in #2333 mean that the `test_unicode_path` test will
write new tags to this test fixture file.
2016-12-26 17:41:44 -05:00
Josh Brown
7833469261
add confirmation for empty query
2016-12-26 14:13:01 -06:00
Josh Brown
2903925e2f
Rewrite zero plugin manual mode
2016-12-26 13:34:34 -06:00
Josh Brown
ef80229350
additional zero tests
2016-12-26 12:10:19 -06:00
Josh Brown
4cc4fe1290
added zero subcommand
2016-12-26 12:10:18 -06:00
nathdwek@laptop
7de97df209
Zero: rewrite tests.
...
Rely on plugin interface only.
Unregister listeners by hand for the moment.
2016-12-25 17:10:16 +01:00
Adrian Sampson
10f0d03d79
Test "true" FLAC bitrate from Mutagen 1.35
...
Fix #2343 .
2016-12-23 20:23:23 -05:00
Shen-Ta Hsieh
7060b512b8
Add Composer, Lyricist and Arranger tags
...
MusicBrainz provids composer, lyricist and arranger infomations related
to individual recordings. This commit adds query parameters to fetch them, and
write down to media files.
Tagging mapping is implemented according MusicBrainz Picard's data:
https://picard.musicbrainz.org/docs/mappings/
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
2016-12-21 01:52:42 +08:00
tigranl
0868299e92
PEP8 corrections
2016-12-10 20:08:27 +03:00
tigranl
68b4a03ecd
Add tests for https
2016-12-10 19:54:44 +03:00
Adrian Sampson
4bbb05b009
Merge pull request #2303 from tweitzel/master
...
Decompose unicode paths and unidecode each component. Fixes #1087 #1159 #1541 #2286
2016-12-08 21:35:01 -05:00
tigranl
9bba178b5c
Add tests for https
2016-12-08 18:44:17 +03:00
xarph
53a677b8fd
* break the asciify-paths code out into the util.asciify_paths function
...
* make asciifying handle both os.sep and os.altsep (testing needed as I
don't have a windows box handy)
* make %asciify{} use the same code path as the asciify_paths goop.
* added a discrete test to %asciify{} so my life acts as a warning to
others
* changelog note now with 80% less antihistamine-induced runon sentences
2016-12-07 20:59:33 -08:00
xarph
cb8e57536c
remove unused unicode_path_sep.mp3
2016-12-05 22:04:07 -08:00
xarph
4461835cda
sampsyo's better test of unicode path escaping
...
revert my lame test
2016-12-05 22:03:00 -08:00
Adrian Sampson
ae5e55cad6
Always use syspath to construct MediaFile
...
Related to #1966 . Previously, we used a `syspath` call inside MediaFile, which
probably wasn't right: the constructor should behave like `open` in that we
need to use pass an OS path.
2016-12-04 21:00:56 -05:00
xarph
87942af4c4
fix line wrapping for py34-flake8
2016-12-03 16:15:40 -08:00
xarph
edd34267c6
modify DestinationTest.test_asciify_and_replace to include unicode
...
titles that decode to path separator.
Added an empty .mp3 file with problematic characters for asciify_paths
in id3v2 tags for future tests if needed.
2016-12-03 15:29:27 -08:00
Adrian Sampson
9de27c6b70
Sync up with separate MediaFile repository
2016-11-26 20:48:12 -05:00
Adrian Sampson
d8c0a42e6c
Avoid TestHelper dependency in MediaFile tests
...
Part of #1966 . This also introduces a nicer, more lightweight way to create and
destroy temporary directories, decoupling that functionality from the
giant morass that is TestHelper.
2016-11-26 18:55:58 -05:00
Adrian Sampson
a88682e7bb
Undo from _common import unittest indirection
...
This was a vestige from when we used to need the unittest2 library for pre-2.7
compatibility. Now that we require Python 2.7, we aren't using that library
and this indirection wasn't doing any good.
2016-11-26 18:46:44 -05:00
Adrian Sampson
24940c0de7
In MediaFile tests, use simpler import path
...
This will make it easier to copy these tests into their own repository.
2016-11-26 18:27:20 -05:00
Adrian Sampson
788654736d
Obviate the need for a beets utility in MF tests
...
Even more on #1966 .
2016-11-26 18:26:18 -05:00
Adrian Sampson
47049e1ff1
Avoid one last beets utility in MediaFile tests
...
This is a little dirty, what with the hard-coded encoding, but I don't feel
too bad about it because we're only manipulating our test fixtures and
temporary directory that way.
More on #1966 .
2016-11-26 18:23:46 -05:00
Adrian Sampson
54cb0b2a15
Separate beets-specific MediaFile tests
...
Part of the #1966 separation effort.
2016-11-26 18:08:00 -05:00
Adrian Sampson
fc6658c110
Add a missing __future__ import
2016-11-26 17:31:54 -05:00
Adrian Sampson
d54ef99ea5
Fix a forgotten test
2016-11-25 21:33:44 -05:00
nathdwek@laptop
eb1ea6177d
acousticbrainz: drop DefaultList, be explicitly careful
...
* I don't see DefaultList be really helpful in many other cases, so having
a beets.util.collections module (which could also conflict with the collections
module from standard library) with only that in it is a little silly.
* It was elegant and concise, but there are implementation issues: it is not
recommended to subclass builtin types, but the alternatives differ between python
2 and 3 (subclass sequence or container or collections.abc?), moreover,
interpreters can differ in the way they map syntaxic sugar to magic functions.
* Also, slicing and negative indexing could do weird things, so the class wouldn't
be really intuitive and simple at the same time
2016-11-20 22:03:41 +01:00
nathdwek@laptop
51243240f6
acousticbrainz: Test _map_data_to_scheme with real data
2016-11-20 22:03:41 +01:00
nath@home
4586e2df5a
acousticbrainz: Add unit tests
2016-11-20 22:03:41 +01:00
Christoph Reiter
31f91129f3
Use mutagen id3 encoding constants
2016-11-19 10:36:31 +01:00
Christoph Reiter
31898111ed
mediafile: prefer latin-1 encoding for ID3 APIC descriptions. Fixes #899
...
iTunes has problems with everything but latin-1
Try to use latin-1 if possible and fall back to utf-16.
2016-11-18 01:09:53 +01:00
Nathan Dwek
2eae2d6d17
Merge pull request #2262 from beetbox/fix-2260
...
Convert: Don't prompt for confirmation if query result is empty
Fix #2260
2016-11-13 20:37:09 +01:00
nathdwek@laptop
a0a9f5a7a8
Fix typos in tests
2016-11-13 17:49:18 +01:00
nathdwek@laptop
8067d82be8
convert: test for #2260
2016-11-13 17:47:07 +01:00
Adrian Sampson
d6242ec207
Tiny whitespace fix
2016-11-11 20:00:14 -05:00
michaelbub
58fe63764e
reduced line length
2016-11-11 22:34:46 +01:00