Commit graph

4332 commits

Author SHA1 Message Date
Adrian Sampson
30c5f4ddf4 Changelog for #810 (fix #320) 2014-06-08 17:27:06 +01:00
Adrian Sampson
3056da2d1d Merge pull request #810 from brunal/show-path-on-delete
Show file path when deleting items
2014-06-08 17:25:58 +01:00
Adrian Sampson
3e1e8eea16 Changelog for #811 (fix #475) 2014-06-08 17:24:22 +01:00
Adrian Sampson
41666fe2f3 Merge pull request #811 from brunal/zero-conserve-important-fields
Zero plugin: do not zero important fields
2014-06-08 17:23:27 +01:00
Bruno Cauet
469ec40c0f Zero plugin: do not zero important fields
Prevent zeroing fields id, album_id and path.

Fix issue #475.
2014-06-08 17:26:17 +02:00
Bruno Cauet
f40517b09e Show file path when deleting items
Using `beets remove -d <target>" now shows the file path when asking for
confirmation.

The format string is '$path - $title'.

Fix issue #320.
2014-06-08 17:22:15 +02:00
Adrian Sampson
63af350eaa Diff output shows formatted values for strings
This is why, in #807, the album field was appearing to "work" while the year
field was displaying the issue. We were colorizing the wrong value.

Now, of course, we need to fix the underlying issue: we're confusingly
displaying album-level information for these items.
2014-06-05 16:53:23 -07:00
Adrian Sampson
29e11f1ddb Changelog for #772/#806 2014-06-04 17:16:47 -07:00
Adrian Sampson
94ceba40d4 Merge pull request #806 from kljohann/on_stop
mpdstats: update rating on 'stop' (e.g. last song in playlist)
2014-06-04 17:14:31 -07:00
Johann Klähn
b590cfebf2 mpdstats: update rating on 'stop' (e.g. last song in playlist)
Fixes #772
2014-06-04 15:41:15 +02:00
Adrian Sampson
ee16396f8c Update Confit to "next generation"
These recent updates vastly simplify validation in the configuration system.
We should now be able to validate whole subtrees of the configuration at a
time.
2014-06-03 21:35:00 -07:00
Adrian Sampson
48189b4a54 keyfinder: Unicode literals in logging call
Log messages should *always* be Unicode. I wish we had a flake8 checker for
this...
2014-06-02 22:12:57 -07:00
Adrian Sampson
0c5fbdcefd Merge pull request #802 from geigerzaehler/embed
Merge pull request #802
2014-06-02 21:30:28 -07:00
Thomas Scholtes
2813cd26c1 Refactor embedart to work at item level
Embedding images now triggers the `*_write` plugin events. This
allows *beets-check* to update the checksum. See the [beets-check
issue][1].

[1]: https://github.com/geigerzaehler/beets-check/issues/7
2014-06-02 17:10:48 +02:00
Thomas Scholtes
f19fa1567e Test converter embeds album art 2014-06-02 17:09:16 +02:00
Thomas Scholtes
9c6491a65d Embedart TestCase 2014-06-02 16:04:55 +02:00
Adrian Sampson
d2b1fd4da9 Merge branch 'master' of github.com:sampsyo/beets 2014-06-01 12:04:48 -07:00
Adrian Sampson
61083325e3 Fix #796: flat import of empty directories 2014-06-01 12:04:16 -07:00
Adrian Sampson
85ee7b2b0c Merge pull request #794 from drm00/beets-on-openbsd
beets installation instructions on openbsd
2014-05-29 09:23:22 -07:00
Nils R
96fd33903b beets installation instructions on openbsd 2014-05-29 13:30:28 +02:00
Adrian Sampson
632d3a9612 dbcore: Add shared instances of common types
Following click's example:
https://github.com/mitsuhiko/click/blob/master/click/types.py#L414
2014-05-25 16:38:47 -07:00
Adrian Sampson
23d884b6e8 Move MusicalKey type out of dbcore module
This is library-specific.
2014-05-25 16:25:47 -07:00
Adrian Sampson
394e4e45eb dbcore: Add types for non-fixed fields
The base Type class now serves as the catch-all logic for untyped fields.
2014-05-25 16:23:15 -07:00
Adrian Sampson
429188e8e1 Changelog for #776 2014-05-25 15:44:21 -07:00
Lucas Duailibe
e3c86f24ae Fix lint error :) 2014-05-25 19:30:16 -03:00
Lucas Duailibe
d1d166b5b5 Enable use of files with play -a (closes #776)
This commit changes the output of the play plugin to always use files instead of folders when generating a playlist when using the `-a` option. A new `use_folders` option was added to preserve the old behavior for anyone who wishes it.
2014-05-25 18:47:02 -03:00
Adrian Sampson
a71f929a3c Merge branch 'master' of github.com:sampsyo/beets 2014-05-24 17:07:52 -07:00
Adrian Sampson
70b5a44ef4 Move query parsing to new dbcore.queryparse
Fix #649.
2014-05-24 17:07:18 -07:00
Adrian Sampson
95a036d510 Move implicit path query identification out (#649)
This is not the most elegant solution, but it does let us move most of the
query-parsing logic out of library.py. It would still be nice to get rid of
most of beets.library.get_query, but I don't yet know how to do that.
2014-05-24 16:52:16 -07:00
Thomas Scholtes
fe6c7819d3 More informative MediaFile exceptions
* Remove generic messages for `UnreadableFileError`. The class
  carries that information—so we see it if the exceptions crashes the
  program. If the exception is caught (in `library`, `importer`,
  and `autotag`) the type of the exceptions is logged.

* Attach file path to the exceptions. This allows us to determine
  the file that crashed the application.

See #788
2014-05-23 11:29:17 +02:00
Adrian Sampson
7339559359 Factor prefixes out of query parser (#649) 2014-05-22 22:27:24 -07:00
Adrian Sampson
1d8a4d0143 Changelog for #784 and #757 2014-05-22 08:37:08 -07:00
Adrian Sampson
a65ea653d5 Merge pull request #784 from ghedo/info_props
Print all readable fields in info plugin
2014-05-22 08:34:42 -07:00
Alessandro Ghedini
331674159b Print all readable fields in info plugin
This includes all audio properties (format, bit rate, channels, ...) too.
2014-05-22 16:43:59 +02:00
Thomas Scholtes
38f300248c Run replaced item query only once 2014-05-21 17:18:05 +02:00
Thomas Scholtes
180433e72c Convert path to bytestring
This is in line with `beets/library.py:336`. Closes #757
2014-05-21 17:16:40 +02:00
Thomas Scholtes
de08059da4 Fix replaced items in importer
Previously, `task.replaced_items[item]` was a `Result` instance.
This meant that iterating over these, in the plugin stage for
example, would fetch them from the database. But by then the
items had been replaced with the imported versions.

Now we instantiate the list of replaced items so that we always
get the same, old ones.
2014-05-21 11:58:18 +02:00
Adrian Sampson
b8143d2561 Changelog for #782 (fix #779) 2014-05-20 17:25:26 -07:00
Adrian Sampson
908584bde8 Revamp FormattedItemMapping
This subclass was not cleanly conforming to the Mapping abstract base. Now
we're in business -- the thing looks like a dict. Brought up by #782.
2014-05-20 16:24:40 -07:00
Adrian Sampson
452382bffa Merge pull request #782 from PierreRust/fixRemoveFlexAttr
Fix remove flex attr
2014-05-20 16:00:00 -07:00
Pierre Rust
4aa626d263 Add defaut value to formatted mapping dict.
This mimics dict get method behavior.
2014-05-21 00:01:20 +02:00
Pierre Rust
9901d6a4eb Add Test case for flexattr removal (#779) 2014-05-20 23:55:42 +02:00
Adrian Sampson
e41ae47ebf Changelog for #767 2014-05-18 15:35:37 -07:00
Adrian Sampson
3d12508cc1 Fix default config (#767) 2014-05-18 15:31:56 -07:00
Adrian Sampson
2b227f57f8 Undo variable name obfuscation (#767) 2014-05-18 15:22:10 -07:00
Adrian Sampson
9ec26f7402 Merge pull request #767 from ghedo/play_cmd
Support commands with options in play plugin
2014-05-18 15:21:09 -07:00
Adrian Sampson
943cbe0838 MediaFile: allow setting date fields to None 2014-05-18 15:14:36 -07:00
Adrian Sampson
dfa8445980 Style and wording for Google Images (#766) 2014-05-17 22:10:39 -07:00
Adrian Sampson
7f675dbf64 Merge branch 'Lemutar-master' 2014-05-17 22:02:09 -07:00
Adrian Sampson
79aef50c25 AIFF support (fix #250)
Thanks to @EvanPurkhiser, AIFF is now supported in Mutagen 1.23! Now we can
support it too.
2014-05-17 21:13:40 -07:00