Commit graph

9644 commits

Author SHA1 Message Date
Jacob Pavlock
4e93469421 fix missing docstring-convention declaration 2020-07-29 20:32:53 -07:00
Jacob Pavlock
02fcbea676 add google docstring convention to CONTRIBUTING.rst 2020-07-29 17:21:15 -07:00
Jacob Pavlock
019055c156 add docstring checks to flake8
currently ignore all errors on a per-file basis
2020-07-29 17:21:15 -07:00
jtpavlock
0cd102b0dd Update pytest test writing restriction
I think the basics sections is fairly self explanatory at this point especially with the copious amounts of examples we have. Also, if we kept it, we'd have to expand on pytest basics as well. I'd rather just point to the docs/getting started guides for each.
2020-07-29 12:39:59 -07:00
Adrian Sampson
2408f6b36f
Merge pull request #3691 from chipsnblip/chipsnblip-patch-1
update link to current homepage
2020-07-26 17:04:08 -04:00
chipsnblip
30173b7331
update link to current homepage
update link from non-existent page (https://2.python-requests.org/en/latest/) to the plugin's current homepage: https://requests.readthedocs.io/en/master/
2020-07-26 13:50:05 -07:00
Adrian Sampson
b258e060a8
Merge pull request #3688 from gschmidl/master
fix #3685
2020-07-26 15:13:05 -04:00
Gunther Schmidl
08b51ee5bc add changelog entry 2020-07-26 20:53:30 +02:00
Jacob Pavlock
9ee341374a fix subheading in contributing.rst 2020-07-25 15:57:02 -07:00
Gunther Schmidl
1eda0d39e6 better regex for drive letter; hopefully fixed tests for 2.7; added test to show only drive-letter like colons are affected 2020-07-25 22:11:07 +02:00
jtpavlock
043fa10f55 Add tox windows issue to CONTRIBUTING.rst 2020-07-25 13:03:17 -07:00
jtpavlock
f73a438dce
Add python 3.9-dev to CI tests (#3687)
* Add python 3.9-dev to ci tests

* test integration tests on latest versions of python
2020-07-25 15:02:19 -05:00
Gunther Schmidl
0a9a801b05 add unit tests 2020-07-25 21:50:33 +02:00
Gunther Schmidl
1e6db94045 remove whitespace 2020-07-25 20:32:11 +02:00
Gunther Schmidl
b91efb88f4 extract config to variable 2020-07-25 20:30:13 +02:00
Gunther Schmidl
8dad7fa67f fix linting error again 2020-07-25 20:26:21 +02:00
Gunther Schmidl
dfdb068b51 fix linting error 2020-07-25 20:24:39 +02:00
Gunther Schmidl
6febcf1190 fix #3685 2020-07-25 20:14:43 +02:00
Adrian Sampson
a2f66a0427
Merge pull request #3680 from beetbox/contributing.rst
Add CONTRIBUTING.md to the docs
2020-07-22 07:55:52 -04:00
Jacob Pavlock
9690e4d51f improve code blocks 2020-07-21 14:49:51 -07:00
Jacob Pavlock
bf868be10e fix-up adding testing wiki to contributing.rst 2020-07-21 14:44:02 -07:00
Jacob Pavlock
3dfd0414e6 Merge branch 'master' into contributing.rst 2020-07-20 20:03:07 -07:00
Jacob Pavlock
cb4bab175a fix link to contributing page in readme 2020-07-20 19:56:05 -07:00
Jacob Pavlock
f677fd2407 add testing wiki to contributing.rst 2020-07-20 19:56:05 -07:00
Jacob Pavlock
66e6af48be add table of contents to contributing.rst 2020-07-20 19:56:05 -07:00
Jacob Pavlock
2982f245e1 add CONTRIBUTING.rst to the docs 2020-07-20 19:56:05 -07:00
Jacob Pavlock
faa5553468 convert CONTRIBUTING.md to rst 2020-07-20 19:46:12 -07:00
jtpavlock
c5b82e0134
Merge pull request #3679 from beetbox/jtpavlock-patch-1
Adjust wording of CONTRIBUTING.md
2020-07-20 17:22:49 -07:00
jtpavlock
b309ed95c2 Remove duplicate forum mention
Forums are already mentioned in the 'Contact' section
2020-07-20 17:18:17 -07:00
jtpavlock
c1b9e99722
maintainers *will* reciprocate respect :) 2020-07-20 19:07:32 -05:00
jtpavlock
5544c7a881
Fix wording 2020-07-20 19:04:44 -05:00
jtpavlock
426cb08003
fix CONTRIBUTING.md link and spelling 2020-07-20 19:02:38 -05:00
jtpavlock
335776ff30
Merge pull request #3666 from jtpavlock/flake8-errors
Unignore flake8 E221, E226, E242, E704
2020-07-20 12:24:52 -07:00
jtpavlock
62ce5d15db
add contributing.md & update readme (#3643)
* add contributing.md & update readme

* add for developers section of docs to contributing.md

* remove relative wiki links

* readme spelling fix

* clarify discourse/docs idea for user 'recipes' to get featured

* remove coveralls from testing section

* fix api links & clarify docstring standard

* Contributing -> Contribute

* remove manual pip module installation instructions

* add link to testing wiki page on "how to contribute"

* add databse access examples

* added voting clarification

* Rename contributing.md to CONTRIBUTING.md

* remove out of date info

Includes references to gitter, the old 'good first issue' label and also
some updates to testing.

* No need for backticks around beets

We usually just typeset it as an ordinary noun, not as code. :)

* Whitespace

* End-to-end CONTRIBUTING pass

Co-authored-by: Adrian Sampson <adrian@radbox.org>
2020-07-20 10:12:34 -05:00
jtpavlock
441cfebff1
add .venv/ to gitignore
.venv/ is recommended via https://docs.python.org/3/library/venv.html
2020-07-19 13:25:55 -05:00
José Albornoz
dc7e433768
Fix thumbnail plugin pathlib bug (#3360)
PathlibURI.uri() would fail if given a path as bytes instead of as string.

Co-authored-by: Jacob Pavlock <jtpavlock@gmail.com>
2020-07-15 21:00:50 -05:00
Adrian Sampson
05516f9503 Thanks & bug number for #2554 2020-07-14 06:59:48 -04:00
Adrian Sampson
8537d1e36d Merge pull request #2554 from musoke/python3-plugin-ipfs
compatibility of IPFS plugin with Python 3
2020-07-14 06:58:20 -04:00
jtpavlock
d9272fcb88
fix integration test job name 2020-07-13 14:20:20 -05:00
Adrian Sampson
9c054e9588
Merge pull request #3668 from wisp3rwind/pr_fix_bad_triggers
Fix a regression in the heuristic for detecting valid lyrics from the google source
2020-07-12 16:46:46 -04:00
wisp3rwind
44e4d558c9 lyrics: fix bad_triggers in the google plugin
regression from 117d16f
2020-07-12 22:23:17 +02:00
Jacob Pavlock
52afd717aa remove docstring-convention and update comment 2020-07-11 19:10:04 -07:00
Jacob Pavlock
124c882b4d un-ignore E221 2020-07-11 18:33:08 -07:00
Jacob Pavlock
abad0f9c08 un-ignore flake8 E226, E242, E704
none of these required any code changes
2020-07-11 18:22:43 -07:00
Jacob Pavlock
1db46dfeb6 reformat flake8 errors 2020-07-11 18:15:41 -07:00
jtpavlock
16fddbaef6
add line break to stale-bot comments 2020-07-11 17:27:37 -05:00
jtpavlock
cc9f4ab251
Add a stale-bot (#3659)
will apply the `stale` label to any issues and pull requests with >60/120 days inactivity respectively
2020-07-11 15:59:34 -05:00
Adrian Sampson
97378c6c90
Merge pull request #3418 from RollingStar/patch-1
Clarify getitem docstring. Log when falling back.
2020-07-11 10:04:42 -04:00
Adrian Sampson
d230b3b870 Roll back logging changes 2020-07-11 10:04:00 -04:00
jtpavlock
8b8156c493
Merge pull request #3661 from jtpavlock/testing-cleanup
Testing cleanup & nose -> pytest
2020-07-09 18:53:09 -05:00