Commit graph

9644 commits

Author SHA1 Message Date
Adrian Sampson
8bef21a4d5 More permissive log check for #3247 2019-05-02 09:38:11 -04:00
Adrian Sampson
83ac5ed022 Changelog for #3247 2019-05-02 09:35:14 -04:00
Adrian Sampson
6fa93935ec Merge pull request #3247 from jackwilsdon/b1770gain-malformed-xml
replaygain: Handle invalid XML output from bs1770gain
2019-05-02 09:33:08 -04:00
Jack Wilsdon
f09088df43
replaygain: Handle invalid XML output from bs1770gain 2019-05-02 01:24:19 +01:00
Adrian Sampson
6ec061b8a5 Changelog for #3236 2019-04-30 16:57:27 -04:00
Adrian Sampson
0ef50ed246 Minor cleanup for #3236 2019-04-30 16:53:54 -04:00
Adrian Sampson
7773a0f117 Merge pull request #3236 from ababyduck/2093-update-imagemagick-cmds
Update artresizer's ImageMagick commands to use the magick binary
2019-04-30 16:47:48 -04:00
Adrian Sampson
ff73a056f5 Changelog for #3238 (fixes #2790) 2019-04-30 11:52:29 -04:00
Adrian Sampson
644c814695 Clarify docstring for Float's digits parameters
Introduced in #3238.
2019-04-30 11:49:39 -04:00
Adrian Sampson
b6ac986526 Merge pull request #3238 from rain0r/2790-acousticbrainz
Fix for #2790 - acousticbrainz: Really small float values are stored as strings
2019-04-30 11:48:41 -04:00
Adrian Sampson
fc084ae975 More changelog proofreading 2019-04-30 11:47:26 -04:00
Adrian Sampson
0bfe0e9a67 Link to the aunique config option 2019-04-30 11:42:44 -04:00
Adrian Sampson
42f03a1121 Merge pull request #3235 from arcresu/release
Prepare for releasing 1.4.8
2019-04-30 11:40:11 -04:00
Jack Wilsdon
9190ce7602
Merge pull request #3243 from jackwilsdon/dbcore-globals
Stop using beets.config['sort_case_insensitive'] in beets.dbcore
2019-04-28 03:40:03 +01:00
Adrian Sampson
8ab9af1f5f
Merge pull request #3241 from arcresu/issue-template
Use new GitHub issue template format
2019-04-27 15:51:47 -04:00
Jack Wilsdon
aaea23809b
Merge pull request #3244 from jackwilsdon/unpin-tox
Revert "Travis: temporarily pin tox to <=3.8.1"
2019-04-27 17:19:00 +01:00
Rainer Hihn
62c1d37bcc Formatting 2019-04-27 17:58:48 +02:00
Rainer Hihn
941dd6e48f Formatting 2019-04-27 17:58:26 +02:00
Rainer Hihn
36dc105dc9 undid quotes in log messages 2019-04-27 17:57:48 +02:00
Jack Wilsdon
9467fc7557
Revert "Travis: temporarily pin tox to <=3.8.1"
This reverts commit 777cfbbf61.
2019-04-27 15:56:55 +01:00
Jack Wilsdon
e10be98b66
Stop using beets.config['sort_case_insensitive'] in beets.dbcore 2019-04-27 15:44:56 +01:00
Carl Suster
df26f2e8f8 Use new GitHub issue template format
Inspired by examples at 457e1d0ae0/system/ISSUE_TEMPLATE/
2019-04-27 23:51:32 +10:00
Carl Suster
86a0f04f26 setup.py: add optional PyGObject dependency 2019-04-27 13:43:58 +10:00
Carl Suster
75f8372a89 Update optional dependencies in setup.py 2019-04-27 12:43:50 +10:00
Carl Suster
9b0fcff216 playlist: remove "smart" from title in docs 2019-04-27 12:43:33 +10:00
Carl Suster
2e0230789f docs: fix some markup issues and typos 2019-04-27 12:43:13 +10:00
ababyduck
278d87f25a Make more requested changes for PR 3236
- Moved several variable assignments outside of try blocks
- Added and clarified various comments and docstrings
- Modified the command loop in `get_im_version()` to a slightly more
readable approach
- `get_im_version()` now returns None when ImageMagick is unavailable
- Updated `ArtResizer._check_method` to handle our new returns in a way
that is more readable
- Fixed an issue where `get_im_version()` could crash if the regex
search failed to find a match
2019-04-25 07:50:12 -07:00
ababyduck
09abd9802a Make get_im_version() return same types across all conditions
`get_im_version` should now always return a tuple containing:
- index 0: a tuple representing the version
- index 1: a bool or None, representing legacy status
2019-04-25 05:50:11 -07:00
ababyduck
48be3a7eaf Make requested changes for PR 3236
- Refactored convert and identify command names to an ArtResizer
member variable, set on ArtResizer init. Functions that use this info
will now access it from there.
- Changed the way `cmd` variables are written so that the command name
and command args are assigned directly to `cmd`, rather than doing
`command_output(cmd + args)`
- `get_im_version()` will now always return a tuple containing two
values: a tuple representing the version, and either a bool or None
flag representing whether we should send legacy commands to ImageMagick
- Improved readability of successful return value in `get_im_version()`
2019-04-24 18:43:50 -07:00
Rainer Hihn
e1c061a010 Merge branch '2790-acousticbrainz' of github.com:rain0r/beets into 2790-acousticbrainz 2019-04-24 20:42:07 +02:00
Rainer Hihn
55fe077e54 Removed PaddedFloat in favour of adding a constructor parameter 2019-04-24 20:39:05 +02:00
Rainer Hihn
7240a826bc Fixed PaddedFloat-type and set precision to 8 2019-04-24 20:05:26 +02:00
Rainer Hihn
07b617b307 Converted all float types to PaddedFloat 2019-04-24 19:55:44 +02:00
Rainer Hihn
7676d2ae5a PaddingInt -> PaddingFloat 2019-04-24 19:54:12 +02:00
Rainer Hihn
3f3b102885 added PaddingFloat 2019-04-24 19:53:01 +02:00
ababyduck
a8f137bf95 Rename isLegacy to im_legacy for consistency and flake8 compliance 2019-04-24 10:09:31 -07:00
ababyduck
e00640e7dd Handle TypeError exception when no ImageMagick install is present
Fixes an error introduced in 1a6e0a7 where a TypeError exception was
raised when calling `_check_method()` with no ImageMagick installation
present.
2019-04-24 09:35:56 -07:00
ababyduck
666790bd83 Refactor to eliminate use of global variable
`get_im_version` now returns an additional bool `isLegacy`, which
indicates whether the the `magick` binary is accessible. It is stored
in `self.im_legacy` on initialization of an `ArtResizer` object, and
can be accessed via `ArtResizer.shared.im_legacy`
2019-04-24 09:07:38 -07:00
ababyduck
1a6e0a7a29 Fix whitespace for flake8 compliance
Fixed various whitespace issues and a global variable reference to
comply with flake8 linting.
2019-04-24 07:00:27 -07:00
ababyduck
f15f8a08f9 Added fallback to ImageMagick's legacy utilities
When the `magick` binary is not available, artresizer will fall back
to the "legacy" binaries (`convert`, `identify`, etc.)
2019-04-24 05:30:17 -07:00
Adrian Sampson
8ba2ccdc63 Improve changelog text
Co-Authored-By: arcresu <carl@contraflo.ws>
2019-04-24 11:06:19 +10:00
Rainer Hihn
76e333c054 Added item_types 2019-04-23 19:20:55 +02:00
ababyduck
ad9f256058 Update artresizer's ImageMagick commands to use the magick binary
Updated artresizer's ImageMagick commands to use the magick binary
added in ImageMagick 7.x, rather than the legacy utilities ('convert',
'identify', etc.) This resolves an issue where beets is failing to
detect or use ImageMagick on Windows even when it is set correctly
on the PATH, which in turn restores functionality to the fetchart and
embedart plugins on Windows.

Closes #2093
2019-04-22 23:12:51 -07:00
Carl Suster
2aeb0fa80d Improve message for packagers 2019-04-23 12:35:41 +10:00
Jack Wilsdon
750ddc1129
Update docs/changelog.rst
Co-Authored-By: arcresu <carl@contraflo.ws>
2019-04-23 12:30:58 +10:00
Carl Suster
0a7c5cb163 Prepare changelog for 1.4.8 2019-04-23 12:26:36 +10:00
Rainer Hihn
a60935ed1c Prevent scientific notation 2019-04-22 19:50:11 +02:00
Adrian Sampson
4d55e6dfbb Add changelog link for #3220 (fix #3219) 2019-04-21 20:41:18 -04:00
Adrian Sampson
8b23411767 Simplify docs for #3220 2019-04-21 20:40:18 -04:00
Adrian Sampson
5f9b28124d Merge pull request #3220 from rain0r/3219
Update __init__.py
2019-04-21 20:39:46 -04:00