Commit graph

9644 commits

Author SHA1 Message Date
Adrian Sampson
68e1093e28
Merge pull request #3348 from Vexatos/convert-link
convert: add option to symlink or hardlink instead of copying
2019-08-21 10:54:09 -04:00
Vexatos
7aab50b7b8
convert: Reduce amount of duplicate code for linking.
Also slightly reworded documentation.
2019-08-21 12:19:47 +02:00
Vexatos
aeb7d8846e
convert: disable album-art embedding for linked files.
Fixed flag precedence of link and hardlink over their options.
Fixed formatting issue.
2019-08-20 16:40:02 +02:00
Vexatos
a61aa74061
convert: add option to hardlink instead of copying.
Overrides the --link option.

As proposed in #2324.
2019-08-20 16:07:01 +02:00
Kier Davis
4820cee35c
convert: add option to symlink instead of copying
As proposed in #2324.

Updated commit from #2326.

Co-authored-by: Vexatos <stuarzt@gmx.de>
2019-08-20 14:50:44 +02:00
Benedikt
96d61b8b93
Merge pull request #3347 from wisp3rwind/pr-fix-track-number-0
Correctly display track number 0 in show_change
2019-08-20 09:31:01 +02:00
wisp3rwind
29d6967fa7 update changelog 2019-08-20 09:29:35 +02:00
wisp3rwind
0bc3727fcf Correctly display track number 0 in show_change
fixes issue #3346: When the per_disc_numbering option was set, the UI would
previously show a #0 -> #1 change when actually the index would be set
to 0 (a valid index, such as for hidden tracks).  Now, properly
distinguish index 0 and None (i.e. not set)
2019-08-20 00:02:32 +02:00
Adrian Sampson
27e0e7600d
Merge pull request #3345 from smopucilowski/simple-clean
Refactor magic values in discogs_client
2019-08-11 08:38:57 +02:00
Sebastian Pucilowski
a2ee8da8d6 Refactor magic values in discogs_client 2019-08-11 11:21:22 +10:00
Adrian Sampson
75eb2f4621 Changelog thanks & bug link to #3343 2019-08-03 22:40:50 -04:00
Adrian Sampson
5d6366a92d Merge pull request #3343 from rhlahuja/spotify-year-unpack
Fix handling of Spotify year-only release dates
2019-08-03 22:40:12 -04:00
Rahul Ahuja
7ec3632309 Fix year assignment with year-only release date 2019-08-03 19:07:56 -07:00
Adrian Sampson
3275081d09
Merge pull request #3342 from samuelnilsson/replaygain
Fix #3341
2019-08-03 17:40:51 -04:00
Samuel Nilsson
6e24669d61 Fix #3341 2019-08-03 22:51:40 +02:00
Adrian Sampson
c74c9a46a9 Punctuation improvements 2019-08-01 09:32:33 -04:00
Adrian Sampson
345e0d5315 Merge pull request #3339 from octos/master
improve readability
2019-08-01 09:31:48 -04:00
octos
5f6d1f0f96
improve readability 2019-07-31 22:41:32 -05:00
Adrian Sampson
e4b93de616
Merge pull request #3338 from beetbox/discogs-error
Use the 'resource_url' from discogs_client to not throw exception
2019-07-30 16:46:03 -04:00
Guilherme Danno
63594386c2
Add the changelog 2019-07-30 17:09:00 -03:00
Guilherme Danno
4908028985
Use the 'resource_url' from discogs_client 2019-07-30 16:46:59 -03:00
Adrian Sampson
32b33922cb
Merge pull request #3336 from samuelnilsson/replaygain
ffmpeg replaygain backend: Only calculate replaygain for audio stream
2019-07-29 08:12:03 -04:00
Samuel Nilsson
60c174101f ffmpeg replaygain backend: Only calculate replaygain for audio stream. Fixed documentation for backend option. 2019-07-29 10:32:19 +02:00
Adrian Sampson
ddede4e39e
Merge pull request #3065 from zsinskri/r128-targetlevel-config
replaygain: target level refactor
2019-07-25 19:28:28 -04:00
Zsin Skri
e3645dfd59
Merge branch 'master' into r128-targetlevel-config 2019-07-25 23:22:32 +02:00
Zsin Skri
a9f70f8151 apply suggested improvements
Apply improvements suggested in GitHub PullRequest #3065:
- be idiomatic
  - 0 is falsy
  - check enum equality, not identity
  - mutate list by constructing a new one
- improve documentation
  - fix a typo
  - do not mention deprecation of a config option
2019-07-26 01:02:03 +02:00
Adrian Sampson
9392256993 Spelling & changelog for #3334 2019-07-24 22:13:53 -04:00
Adrian Sampson
84032e56e2 Merge pull request #3334 from MartyLake/martylake_add_forward_slash_option
Add option to force forward slashes in paths
2019-07-24 22:11:59 -04:00
MartyLake
fb96660171 Review: simpler implementation and test
Because **all** the path are bytestrings
2019-07-24 18:09:54 +02:00
MartyLake
819f03f0e0 Add special case for string 2019-07-24 10:11:32 +02:00
MartyLake
7ee11b0f1a Review: add missing lines 2019-07-24 10:08:40 +02:00
MartyLake
c52973e1c0 Review: Adds missing point to finish sentences 2019-07-24 09:53:54 +02:00
Adrian Sampson
897100cb3b
Merge pull request #3335 from malcops/feature/pm/acousticbrainz-extra-fields
Feature/pm/acousticbrainz extra fields
2019-07-23 23:04:11 -04:00
Paul Malcolm
aa17625551 changelog entry: additional acousticbrainz fields 2019-07-23 20:25:26 -04:00
Paul Malcolm
5f9a394ca9 Issue #2860 Fetch more acousticbrainz fields 2019-07-23 20:25:26 -04:00
MartyLake
076a82daa6 Review: Rename method 2019-07-24 00:09:52 +02:00
MartyLake
68ccfe0e6c Review: Add missing blank line 2019-07-23 23:54:54 +02:00
MartyLake
ee7f939336 Review: Remove stray blank line 2019-07-23 23:53:50 +02:00
MartyLake
aa1da3166f Review: Remove unnecessary parens 2019-07-23 23:53:17 +02:00
MartyLake
3a5ea58f7a Review: format docstring on the following line 2019-07-23 23:52:26 +02:00
MartyLake
dd9de05968 Review: Remove unnecessary split of concat 2019-07-23 23:50:20 +02:00
MartyLake
da864402d5 Review: Remove unnecessary get 2019-07-23 23:49:17 +02:00
MartyLake
1a4699d0ee Add documentation 2019-07-23 23:46:31 +02:00
MartyLake
d1ba309f36 Add a new method that copied pathlib.path.as_posix 2019-07-23 17:17:40 +02:00
Zsin Skri
da602d779c changelog: new r128_targetlevel option
Add changelog entries for the introduction of the `r128_targetlevel`
configuration option, superseding the `method` option.
2019-07-22 13:42:26 +02:00
Zsin Skri
fbc8cc484d update replaygain target level documentation
- document `r128_targetlevel`
- explain difference between `targetlevel` and `r128_targetlevel`
- deprecate `method` option: use `targetlevel` instead.
2019-07-22 13:42:26 +02:00
Zsin Skri
88ab5474c5 replaygain: add R128_* tag test
Assert that the replaygain plugin does not write REPLAYGAIN_* tags but R128_*
tags, when instructed to do so.

This test is skipped for the `command` backend as it does not support OPUS.
2019-07-22 13:42:26 +02:00
Zsin Skri
5a8bdb67f7 replaygain: add target_level test
Assert that analysing the same track with different target levels yields
different gain adjustments.
2019-07-22 13:42:26 +02:00
Zsin Skri
e7e2c424e7 replaygain: targetlevel and peak_method depends on tag format
Allow to configure the target level for R128_* tags separately from REPLAYGAIN_*
tags and skip peak calculation for R128_* tags if possible.
2019-07-22 13:42:22 +02:00
Zsin Skri
0c8eead459 replaygain: pass target_level and peak to backends
Configure the replaygain analysis by passing arguments to the Backends. This
avoids the difference between ReplayGain and EBU r128 backends; every Backend
can now fulfil both tasks. Additionally it eases Backend development as the
difference between the two tag formats is now completely handled in the main
Plugin, not in the Backends.
2019-07-22 12:58:54 +02:00