Adrian Sampson
362db8f22f
Merge pull request #728 from sampsyo/lastgenre-tests-new
...
Tests for lastgenre (cleaned up)
2014-04-29 08:38:56 -07:00
Adrian Sampson
2fac1567ec
Remove redundant quotes in exception
...
Indicated in #731 .
2014-04-29 08:34:56 -07:00
Adrian Sampson
233f71a457
Use real booleans for whitelist/canonical options
...
As opposed to the strings "true" and "false".
2014-04-28 23:00:00 -07:00
Adrian Sampson
add309b57d
Isolate lastgenre tests
...
We now appropriately set up and tear down the fixture for the lastgenre tests.
(This was causing unpredictable failures elsewhere before.)
2014-04-28 22:35:32 -07:00
Fabrice L.
f6337d2d1f
Update lastgenre.rst
2014-04-28 10:44:53 +02:00
Fabrice L.
5a0a97c7e0
undo previous commit (wrong branch)
2014-04-28 10:43:21 +02:00
Fabrice L.
6fff2a5097
Update lastgenre.rst
2014-04-28 10:38:17 +02:00
Fabrice Laporte
ef3c1cd1ff
use booleans for whitelist and c14n options
...
homogenise options setup using booleans, while keeping the empty string
(synonym of ‘true’) for backward compatibility.
2014-04-28 10:31:22 +02:00
Adrian Sampson
d5dbaeff7a
lastgenre: Restore default whitelist
2014-04-27 13:54:32 -07:00
Adrian Sampson
dfd9a4c397
Merge branch 'KraYmer-lastgenre-tests-new' into lastgenre-tests-new
...
Conflicts:
test/test_lastgenre.py
2014-04-27 13:52:06 -07:00
Fabrice Laporte
d1cc95984e
Rename/add tests
...
Rewrite tests now that empty whitelist is allowed.
2014-04-27 22:32:31 +02:00
Fabrice Laporte
0613cb7d13
Update _setup_config
...
Give an empty string to obtain default whitelist, None for no whitelist
or a stringlist for a custom one.
2014-04-27 22:31:31 +02:00
Fabrice Laporte
0b3c5ddbe0
Canonicalization only return most common genre
2014-04-27 22:27:20 +02:00
Fabrice Laporte
817b8cc96e
Allowing the whitelist to be disabled
...
By default it is disabled, setting the value to the empty
string will use the built-in whitelist (same behaviour than
c14n).
2014-04-27 22:26:09 +02:00
Fabrice L
4af96f316d
fix mailing list link
2014-04-27 10:45:01 -07:00
Adrian Sampson
9f5f70aeab
Merge pull request #720 from sampsyo/import-refactor
...
Import refactor
2014-04-27 09:51:10 -07:00
Fabrice L.
e442749cd4
add a test that would fail with the restricted whitelist approach
...
If no option is set, valid genres should not be rejected. Which is an argument
to have a wide default whitelist.
2014-04-27 16:05:16 +02:00
Fabrice Laporte
e399173f7e
add a test that would fail with the restricted whitelist approach
...
If no option is set, valid genres should not be rejected. Which is an argument
to have a wide default whitelist.
2014-04-27 15:59:43 +02:00
Adrian Sampson
35b6602795
Use self.config instead of global config
2014-04-26 21:00:59 -07:00
Adrian Sampson
e7af3319f8
lastgenre: Restore min_weight option
2014-04-26 20:59:39 -07:00
Fabrice Laporte
d0d3c18da2
lastgenre: rewrite filtering logic to make tests pass
...
- remove filter_tags() as genres should not be removed this soon while
c14n has not been applied
- group all filtering logic in the function _resolve_genres (formerly
_strings_to_genre)
2014-04-26 20:51:13 -07:00
Fabrice Laporte
2e8e55736d
get rid of module level options variable
...
Conflicts:
beetsplug/lastgenre/__init__.py
2014-04-26 20:51:00 -07:00
Fabrice Laporte
4e5bb262a7
wip: rewrite setup_config
2014-04-26 20:50:04 -07:00
Fabrice Laporte
21f1607e8f
lastgenre: add tests functions
2014-04-26 20:50:04 -07:00
Fabrice Laporte
499a7b868e
Move the filtering logic of '_tags_for' function into a dedicated 'filter_tags' function.
2014-04-26 20:50:04 -07:00
Fabrice Laporte
3d30708839
add test_lastgenre.py
2014-04-26 20:50:04 -07:00
Adrian Sampson
8c2763ffdc
Collapse finalize stage into manipulate_files
2014-04-26 20:35:41 -07:00
Adrian Sampson
e9355f336b
Rename remove_duplicates and do_remove_duplicates
2014-04-26 20:21:20 -07:00
Adrian Sampson
38eba4af31
Remove obsolete null checks
...
Along with their tests. Background:
https://github.com/sampsyo/beets/pull/720/files#r12027386
2014-04-26 20:07:26 -07:00
Fabrice Laporte
cee5e81500
remove _lyricstext.py
2014-04-27 00:27:11 +02:00
Thomas Scholtes
fea5df2339
covert: embed coverart into converted files
2014-04-26 19:49:29 +02:00
Thomas Scholtes
c20c62409d
convert: log error instead of crashing
2014-04-26 19:47:50 +02:00
Thomas Scholtes
9090f0979f
Use new _embed api
2014-04-26 19:44:29 +02:00
Thomas Scholtes
9b88525736
Make function to embed art agnostic of items
2014-04-26 19:41:44 +02:00
Fabrice Laporte
af468f5259
Move lyrics listings from .py to .yaml file
2014-04-26 19:26:28 +02:00
Fabrice Laporte
74898347c0
is_page_candidate() handle more languages
...
Add translations in spanish and german for tokens to
ignore when comparing an url title with a song title.
2014-04-26 19:25:25 +02:00
Fabrice Laporte
8ba91a49c6
change chars replacements done by slugify()
...
adapt slugify() to make it return strings that can be used
as yaml keys (no spaces, etc.)
adapt is_page_candidate() accordingly
2014-04-26 19:22:40 +02:00
Thomas Scholtes
1d787e0b38
Adapt FetchArt tests to new task api
2014-04-26 18:51:56 +02:00
Thomas Scholtes
ba60431319
Fix typo and return early from stage
2014-04-26 18:31:54 +02:00
Thomas Scholtes
cb3354bd6e
Resolve duplicates in user_query stage
2014-04-26 18:19:52 +02:00
Fabrice L
9e39946da5
Update lyrics_sources.py
...
add copyright header
2014-04-26 07:27:23 +02:00
Fabrice Laporte
567e6300fd
fix flake8
2014-04-26 07:27:13 +02:00
Fabrice Laporte
117d16f2ad
lyrics: add tests to track which websites can be scraped by our algo and be
...
used as sources fot the google custom search engine.
2014-04-26 07:26:50 +02:00
Adrian Sampson
0b315cf8c8
Document/check non-emptiness in add_album
2014-04-25 13:50:03 -07:00
Adrian Sampson
a81d01b969
Changelog for #723
2014-04-25 13:45:45 -07:00
Thomas Scholtes
7700f19135
Added comment on importer ui
2014-04-25 13:56:01 +02:00
Thomas Scholtes
e96753f96a
Plugins use import_task.album
2014-04-25 13:52:03 +02:00
Thomas Scholtes
ac9ee8ed66
Decouple session and import task methods
2014-04-25 13:36:17 +02:00
Thomas Scholtes
e38a33a569
Clarify comments in importer
2014-04-25 13:29:37 +02:00
Thomas Scholtes
07dbe042f5
Move set_candidate logic
2014-04-25 13:23:35 +02:00
