Malte Ried
14543589ed
Removed some testing code which was checked in accidentally
2014-12-29 11:52:33 +01:00
Marc Addeo
e71c464c14
Initialize feat_part as None
2014-12-28 21:27:58 -05:00
Marc Addeo
8f41818434
Fix formatting to pass flake8 tests
2014-12-28 20:58:59 -05:00
Marc Addeo
a70820d8a1
Fix a bug in ftintitle with the order of album artist
...
There was a bug in the find_feat_part function that would cause it to
fail if the album artist was the second part of the featured string.
For example, if the Artist field was Alice & Bob, and the Album Artist
field was Bob it would return None due to the order.
This fixes that and adds test cases to ensure it doesn't return.
2014-12-28 20:23:17 -05:00
Marc Addeo
4d4113e3a4
Refactor ftintitle to extract the code to find the featured artist
...
This removes the code that extracts the featured artist from the
original artist field from the ft_in_title function and puts it into its
own.
It also adds a custom ArtistNotFoundException that find_feat_part will
throw if the album artist is not in the artist field.
This allows us to easily test the results of finding a featured artist
in the artist sting, and thus adds tests for the usual test cases that
the split_on_feat gets tested for.
2014-12-28 20:15:09 -05:00
Adrian Sampson
50a9c2c7d8
Merge pull request #1182 from Freso/patch-1
...
changelog: #1175 is unrelated to the fix in #1176
2014-12-28 19:05:44 -04:00
Frederik "Freso" S. Olesen
25171568b1
changelog: #1175 is unrelated to the fix in #1176
2014-12-29 00:02:59 +01:00
Adrian Sampson
9cfe575c3a
Changelog for #1181
2014-12-28 19:00:36 -04:00
Adrian Sampson
d0dcc74c7e
Merge pull request #1181 from marcaddeo/fix-ftintitle-duplicate-album-artist
...
Fix handling of duplicate album artists in ftintitle
2014-12-28 18:58:36 -04:00
Adrian Sampson
9c9d3ddb70
Changelog for #1176
2014-12-28 18:54:32 -04:00
Adrian Sampson
375f9259b9
Merge pull request #1176 from Freso/issue-1172-ftintitle-less-import-verbosity
...
ftintitle: use log.log() for outputting
2014-12-28 18:52:21 -04:00
Marc Addeo
8c484a273c
Fix handling of duplicate album artists in ftintitle
...
The code that determines the featured artist part of the artist only
handles two element lists. When the album artist is duplicated, it
splits into a three element list causing no featured artist to be found.
This ensures the albumartist_split can ever only have 2 elements.
Fixes #1179
2014-12-28 17:51:48 -05:00
Adrian Sampson
ac07b6915e
Changelog for #1170
2014-12-28 18:50:42 -04:00
Adrian Sampson
b6606afd79
Merge pull request #1170 from silb/importadded-in-place-link-support
...
ImportAdded support for in-place and link imports
2014-12-28 18:49:06 -04:00
Stig Inge Lea Bjørnsen
9227a51588
Add a missing space
2014-12-28 20:40:46 +01:00
Frederik "Freso" S. Olesen
0ec3396d3f
ftintitle: Use log.log() instead of ui.print_().
...
Fixes #1172 .
2014-12-28 20:33:56 +01:00
Frederik "Freso" S. Olesen
6182ef1b1e
ftintitle: Remove empty ui.print_() call.
2014-12-28 20:33:15 +01:00
David Logie
148d9048d5
Update _cached_lookup() docstring.
2014-12-28 18:38:42 +00:00
David Logie
433d68724a
Escape Unicode characters so we don't need the encoding headers.
2014-12-28 18:38:15 +00:00
Malte Ried
53c44d9a97
Added the import_task_created event
...
Improved the IHatePlugin to filter files based on file names
2014-12-28 16:18:51 +01:00
David Logie
3015c22d40
Fix indent level.
2014-12-26 14:17:49 +00:00
David Logie
d9673ef9b5
lastgenre: Only replace a small set of unicode characters.
2014-12-26 14:08:22 +00:00
Stig Inge Lea Bjørnsen
a2188d475b
ImportAdded support for in-place and link imports
...
Fix for the `ImportAdded` plugin crashing during in-place imports (#1107 ).
Add support for the new link imports introduced in Beets 1.3.9.
Note that link-imports that preserve file modification times will follow
the links and preserve the mtimes on the link targets. The mtimes on the
links aren't modified.
2014-12-25 21:39:28 +01:00
Adrian Sampson
a892128996
Changelog and rewording for import --pretend
...
(#1162 )
2014-12-23 09:10:28 -05:00
Adrian Sampson
74466fff89
Merge pull request #1162 from mried/import-pretend
...
Added option --pretend to only print the filenames
2014-12-23 09:08:09 -05:00
Malte Ried
af36d85ef8
Implemented a better solution for the pretend flag
...
Corrected the documentation (shortcut -e is not available any more)
2014-12-23 13:52:22 +01:00
Adrian Sampson
40359b5bd4
Changelog for #1163
2014-12-22 09:35:37 -05:00
Adrian Sampson
a7959cfc00
Merge pull request #1163 from mluds/embedart-windows-fix
...
embedart: Windows fix
2014-12-22 09:34:37 -05:00
Malte Ried
5f67f3ae51
The last commit broke the tests. Repaired...
2014-12-21 21:52:09 +01:00
Malte Ried
440fe9a2ea
Reduced the count of accesses of the pretend config option. Now it's only one place where it is read.
...
Changed the output to use the log system rather than print_.
2014-12-21 21:37:44 +01:00
Michael Ludwig
c76f8bee46
embedart: Added syspath call to art exists check
2014-12-21 13:08:02 -05:00
Adrian Sampson
016c901e6f
Fix 2.6 compatibility with subprocess
...
We can add this back once we go 2.7-only.
2014-12-21 10:09:43 -05:00
Malte Ried
2db346388a
Added option --pretend to only print the filenames of files to import without importing them
2014-12-21 15:56:56 +01:00
Adrian Sampson
b15102608c
Fix convert tests
...
Use some shell trickery to get the pipelined command to work.
2014-12-21 09:50:57 -05:00
Adrian Sampson
e8158194d6
More robust templating ( #1157 )
...
Don't require $source and $dest to be bare tokens.
2014-12-21 09:42:58 -05:00
Adrian Sampson
867b3a2d70
Changelog for #1026 , #1157 , #1158
2014-12-21 09:33:11 -05:00
Adrian Sampson
8579412a76
No shell execution ( #1157 )
...
Now that we do the proper thing, we do not need shell parsing.
2014-12-21 09:31:41 -05:00
Adrian Sampson
4180f42194
Encoding and other fixes for #1157
...
Log as one statement. No need to hold the filesystem lock. New variable name.
2014-12-21 09:30:25 -05:00
Adrian Sampson
c4eba5c741
Apply #1157 by @mluds as patch ( fix #1158 , #1026 )
2014-12-21 09:22:56 -05:00
Adrian Sampson
f45d6c2364
Merge pull request #1161 from Kraymer/lyrics_hotfixes_musixmatch
...
Musixmatch hotfixes
2014-12-21 09:11:45 -05:00
Fabrice Laporte
802d1521ed
lyrics: don't throw when extraction fails
2014-12-21 14:38:19 +01:00
Fabrice Laporte
dfc1aa20b3
lyrics: musixmatch, disable https verification
2014-12-21 14:35:16 +01:00
David Logie
c7b6f75ca8
lastgenre: Automatically retry asciified lookups if the initial lookup fails.
2014-12-21 12:58:15 +00:00
Thomas Scholtes
1c0fffed24
Changelog for #1146 fix
2014-12-21 12:33:28 +01:00
Thomas Scholtes
ec65408c3e
Escape path queries for SQLite
...
Fixes #1146
2014-12-21 12:26:04 +01:00
Adrian Sampson
02e341cded
Fix #1152 : mbcollection: choose release collection
2014-12-20 22:21:58 -05:00
Adrian Sampson
807ff344fd
Little lyrics docs language tweaks ( #1155 )
2014-12-20 20:14:45 -05:00
Adrian Sampson
297e8b66f9
Merge pull request #1155 from Kraymer/lyrics-doc
...
lyrics: improve docs
2014-12-20 20:12:37 -05:00
Adrian Sampson
a586beac1a
Add beets-follow to external plugin list
2014-12-20 20:11:55 -05:00
Adrian Sampson
021cdb7b4a
Fix log statement in inline
2014-12-20 20:06:17 -05:00
