Adrian Sampson
d6c62d08c4
Fill out changelog with prose summary
2016-07-02 10:17:53 -07:00
Adrian Sampson
b49d3344d4
Next release version is 1.4.0, not 1.3.20
...
It's time for a minor version bump with our six dependency and "experimental"
Python 3 support.
2016-07-02 10:11:31 -07:00
Adrian Sampson
40ab3f2992
Disable PyPI download badge
...
PyPI has disabled its download statistics tracking:
https://github.com/pypa/pypi-legacy/issues/396
So this badge was just saying "0 downloads." 😢
2016-07-02 10:09:50 -07:00
Adrian Sampson
093d6ecea2
Clean up changelog errors
2016-07-02 10:07:36 -07:00
Johnny Robeson
527b51147e
add py3_path to NamedTemporaryFile suffixes
2016-07-02 04:53:57 -04:00
Johnny Robeson
915ec59500
bytestringify path from tempfile name in fetchart
2016-07-02 04:53:14 -04:00
Johnny Robeson
ce8d1c0c28
ignore undefined name (F821) warning for buffer
2016-07-02 02:42:29 -04:00
Johnny Robeson
be08d4b129
replace unichr with six.unichr in lyrics plugin
2016-07-02 02:36:05 -04:00
Johnny Robeson
ea3d4978c7
Merge pull request #2102 from jrobeson/add-unrar-to-travis
...
add unrar to .travis.yml
2016-07-02 02:31:08 -04:00
Johnny Robeson
e83b9ce14a
add unrar to .travis.yml
2016-07-02 02:24:26 -04:00
Johnny Robeson
02680eba59
bytestringify a few more paths in test_importer
2016-07-02 01:52:00 -04:00
Johnny Robeson
24ae4bb056
encode path as utf-8 for is_path_query tests
...
is_path_query is not supposed to accept bytestrings
2016-07-02 01:24:25 -04:00
Adrian Sampson
6919d6980f
Fix path types in test_unicode_path
...
This is lifted directly from 658e814ad718610004cbe6d865c8f2f62e676ffb.
2016-07-01 21:54:37 -07:00
Adrian Sampson
4ddb7cfe9e
ID3 desc fields also use unicode strings
...
The old version *also* silently led to the string "b'foo'" being stored in the
frame on Python 3.
2016-07-01 21:47:18 -07:00
Adrian Sampson
30a172fff3
Properly handle exceptions in custom tag tests
2016-07-01 21:29:50 -07:00
Adrian Sampson
b68150a0b4
Merge branch 'master' of github.com:beetbox/beets
2016-07-01 21:24:07 -07:00
Adrian Sampson
17927303ed
Store Vorbis image blocks using text strings
2016-07-01 21:21:31 -07:00
Adrian Sampson
a3236cbee0
Set APIC frame desc to unicode
...
Weirdly, using binary data here resulted in Mutagen storing a string
containing "b'foo'", i.e., the `repr` of a bytes object.
2016-07-01 21:15:33 -07:00
Johnny Robeson
9020dc1f45
use text_string() in a few places for io output
2016-07-02 00:03:46 -04:00
Johnny Robeson
45727c56e2
treat DummyIO as text on py3
2016-07-02 00:03:46 -04:00
Adrian Sampson
b1fb17c29c
UFID tags store strings as encoded bytes
2016-07-01 21:03:00 -07:00
Adrian Sampson
eea4c02d54
Fix a bytes(s) call in MediaFile
2016-07-01 20:57:35 -07:00
Johnny Robeson
fee33d12a4
Merge pull request #2097 from jrobeson/drop-py3.3
...
Remove support for Python 3.3
2016-07-01 16:34:12 -04:00
Johnny Robeson
aa0a0a0f22
use util.py3_path for confit and env paths in tests
2016-06-30 22:24:17 -04:00
Johnny Robeson
dd729f0ce8
mark more paths as bytestrings in tests
2016-06-30 22:21:56 -04:00
Adrian Sampson
f65cf62c80
Use py3_path for plugin search paths (from #2096 )
2016-06-30 15:49:42 -07:00
Adrian Sampson
ec08272a06
Replace map with list comprehension
2016-06-30 15:47:39 -07:00
Adrian Sampson
d04fe42cee
Use py3_path for sqlite3.connect (part of #2096 )
2016-06-30 14:54:38 -07:00
Johnny Robeson
e25a95b2d3
add py3_path() for methods the only accept strings on py3
...
It returns bytes on py2, and native strings on py3.
This function was created by @sampsyo.
2016-06-30 14:50:55 -07:00
Adrian Sampson
61805b9994
Marginally more readable bytes/memoryview switch
2016-06-30 14:48:07 -07:00
Adrian Sampson
a6830ae7d1
Remove dead path normalization
...
The `self.path` field was immediately overwritten in the __init__ from dbcore,
so this was doing nothing.
2016-06-30 14:29:50 -07:00
Adrian Sampson
c532860613
Apply simple type consistency changes from #2096
...
These are the changes from that PR that just enforce the path type invariants
we already want---they're a good idea regardless of Python 3.
2016-06-30 14:22:16 -07:00
Johnny Robeson
2617536294
Remove support for Python 3.3
...
It doesn't seem like Python 3.3 is worth supporting anymore. I'm not
sure if any popular(ish) distro supports Python 3.3, only 3.2 or >=3.4
2016-06-30 07:15:40 -04:00
Johnny Robeson
75c226bd37
remove pathlib tests that just test pathlib itself
2016-06-30 02:09:52 -04:00
Adrian Sampson
cec632f359
Python 3 compatible formatting in unique_path
2016-06-29 22:53:51 -07:00
Adrian Sampson
386f582364
Invent a new utility to deal with native strings
2016-06-29 22:25:03 -07:00
Johnny Robeson
ecfda77f5a
bytestringify a few more paths in tests
2016-06-30 00:08:38 -04:00
Johnny Robeson
a2a4926598
replace .decode('utf-8') with as_string() from #2094
...
They are strings in py3, so they need to stay that way
2016-06-29 23:42:14 -04:00
Adrian Sampson
3d9b43fd06
Update codecov.yml for new configuration format?
...
Their web interface confusingly just says that the file is missing, but
perhaps that means the formatting is invalid? I *really* wish this stuff were
more transparent. 😢
2016-06-29 11:38:58 -07:00
Johannes Baiter
4c324fae2a
beatport: Use track numbers from API ( #2091 )
...
* beatport: Use trackNumber from API instead of enumerating the tracks
* beatport: Set medium_index to track number
* Update changelog with fixes to beatport plugin
2016-06-29 20:34:05 +02:00
Adrian Sampson
ce59658aec
Merge branch 'master' of github.com:sampsyo/beets
2016-06-29 10:55:42 -07:00
Adrian Sampson
44ca6938ff
Add FIXMEs to functemplate about py3
2016-06-29 10:51:56 -07:00
Adrian Sampson
f3df7b5dd3
Merge pull request #2095 from beetbox/pipeline_invalidation_workaround
...
Workaround for a race condition on queue invalidation
2016-06-29 10:48:48 -07:00
Adrian Sampson
89c7b78994
Disable PyPy on Travis for now
...
Travis has a very old version of PyPy which seems to be running into a
Unicode-related bug in our tests.
2016-06-29 10:43:51 -07:00
Adrian Sampson
a6098928f5
Merge branch 'master' of github.com:sampsyo/beets
2016-06-29 10:33:00 -07:00
Adrian Sampson
d5205915cc
Avoid dangerous string conversions ( #2094 )
...
This rolls back the places in #2094 where `six.text_type(s)` was used where
`s` might be a bytestring. We almost never want that conversion, because it
uses the default encoding (almost always ASCII). The need for it indicates a
problem somewhere else, where bytes were produced when we were expecting
unicode strings.
2016-06-29 10:30:26 -07:00
wordofglass
e2c6547635
fetchart: Clarify the deprecation of remote_priority in docs and
...
warning, closes #2092
2016-06-29 19:18:06 +02:00
Adrian Sampson
4ae7448c25
Simplify print_ changes ( #2094 )
2016-06-29 10:12:38 -07:00
Adrian Sampson
dc0fff0ca0
Merge pull request #2094 from jrobeson/ui-print_-args-must-be-unicode
...
make sure ui.print_() only accepts unicode strings
2016-06-29 10:08:26 -07:00
wordofglass
ebf44fd6cd
Workaround for a race condition on queue invalidation, Issue #2078
2016-06-29 18:22:44 +02:00
