Adrian Sampson
86c8cffa6c
Fix some whitespace ( #2433 )
2017-02-11 19:24:47 -05:00
Adrian Sampson
e2b9a3fca6
Merge pull request #2433 from karpinski/badfiles-checkers
...
badfiles: continue execution to other files instead of stopping after a checker error
2017-02-11 19:22:15 -05:00
Marcin Karpinski
8ef9f68843
badfiles: only output corrupt files by default
...
badfiles now only outputs corrupt files by default — to get full output enable verbose mode using -v or --verbose
2017-02-10 21:51:23 +00:00
karpinski
b46fb956b7
Making logging level consistent when checker is not found.
2017-02-10 12:49:16 +01:00
karpinski
291803d49a
Fixing a small typo.
2017-02-10 12:49:16 +01:00
karpinski
ffca8f549f
Allowing the execution to continue to other files if validator is not found or exits with an error.
2017-02-10 12:49:16 +01:00
Adrian Sampson
0216ef294a
badfiles: Python 3 compatibility
...
Discovered while working on #2428 that we were using an implicit bytes-to-str
conversion on the extension. This broke dict lookup on Python 3.
2017-02-04 13:43:23 -06:00
Adrian Sampson
0131ce263d
badfiles: Better logging and error handling ( #2428 )
2017-02-04 13:42:24 -06:00
Jeffrey Aylesworth
8638157e17
Change license and email address in mbcollection plugin.
2017-01-30 23:37:01 -05:00
wordofglass
bc582701ff
fetchart: Internally pass settings in a cleaner way.
...
Dump the 'extra' dictionary which only duplicated attributes of the
plugin onject in favor of passing a reference to the plugin directly.
2017-01-25 00:01:05 +01:00
Artem Utin
40eef2056c
Add changelog entry, wrap long comment lines.
2017-01-24 11:41:55 +10:00
Artem Utin
2ab1f3ae89
More general approach to multiple on_play calls for the same song - now it ignores such calls, if time between calls was below threshold
2017-01-23 23:15:14 +10:00
Pauligrinder
ca8832809d
Removed a couple of unnecessary imports
...
json and requests.BasicAuthentication
2017-01-23 13:14:36 +02:00
Pauligrinder
77d155cdea
Add a plugin to update a Kodi music library
...
I created one for an older version before, but it didn't work since the change to Python 3. So I created a new one that works.
2017-01-23 12:43:40 +02:00
Adrian Sampson
44963598e8
Remove unused import
2017-01-21 23:32:36 -08:00
Adrian Sampson
ca904a9d0c
mpdstats: Fix Python 3 compatibility ( fix #2405 )
...
We previously needed a hack to get the client to consume and produce Unicode strings. The library has since added Unicode support, behind a constructor flag. We can remove the hack now, which was causing a crash on Python 3 because the library uses Unicode by default there, and instead use its built-in support.
2017-01-21 23:21:11 -08:00
Adrian Sampson
958ad430fc
bpd: Use integers for time values (fix 2394)
2017-01-17 11:37:10 -08:00
Steve Johnson
926dce241c
Use util.displayable_path instead of naive .decode()
2017-01-15 11:25:03 -08:00
Steve Johnson
e3707e45f3
Maybe fix code and tests for Windows
2017-01-15 11:21:59 -08:00
Steve Johnson
e2be6ba781
Query path with bytestring. Might fix tests.
2017-01-15 11:21:59 -08:00
Steve Johnson
4434569ddc
beets.library.Library adds custom bytelower function to all connections, not just one
2017-01-15 11:21:59 -08:00
Steve Johnson
866a650bc0
Rename /item/by_path to /item/path and use PathQuery instead of direct file access
2017-01-15 11:21:33 -08:00
Steve Johnson
05bc4996a8
Rename and invert new config option
2017-01-15 11:21:33 -08:00
Steve Johnson
50ea74635b
Fix tests I broke
2017-01-15 11:21:33 -08:00
Steve Johnson
f6cb46d490
Fix broken tests (no new ones yet)
2017-01-15 11:21:33 -08:00
Steve Johnson
43936cd84c
/item/at_path/ endpoint
...
More at_path
/item/by_path docs
2017-01-15 11:21:33 -08:00
Steve Johnson
29d61ca634
web.exclude_paths_from_items option
...
More exclude_paths_from_items
2017-01-15 11:21:33 -08:00
Mike Cameron
c58c49d77f
Fixed trailing whitespace issue. Changed alternate track property name.
2017-01-10 18:39:01 -05:00
Mike Cameron
24b02e8215
Merge remote-tracking branch 'upstream/master'
2017-01-10 17:33:45 -05:00
Adrian Sampson
998e6ac1c7
Remove unused import
2017-01-10 14:54:17 -05:00
Adrian Sampson
bc93a11141
Fix #2382 : replaygain backend parsing on Python 3
2017-01-10 14:45:57 -05:00
Adrian Sampson
153b01e5a6
replaygain: Don't muck with logging level
...
This is now handled by the central logging infrastructure; no need to change
it here. I think this must be a leftover from the era when plugins had to
explicitly muck with their verbosity level, but even still it doesn't make
sense to do set the level to INFO unconditionally...
2017-01-10 14:24:18 -05:00
Adrian Sampson
2706339a83
Fix #2381 : mpdupdate on Python 3
...
Communicate bytes over the socket, obvi.
2017-01-10 12:22:30 -05:00
Adrian Sampson
0b5b20d799
Robust import of distutils submodule ( fix #2376 )
...
This would fail if the `spawn` module in the `distutils` package was not
already imported somewhere else.
2017-01-07 17:15:13 -05:00
Adrian Sampson
6b9d766082
Remove compatibility with misspelled config option
...
This has been hanging around long enough; it's about time to drop the old
name.
2017-01-07 17:09:51 -05:00
Adrian Sampson
c9ec5e411c
A little fiddling with embyupdate
...
Clean up some wording w/r/t efbd58cd55
2017-01-07 17:07:01 -05:00
Adrian Sampson
ffa22d6ce1
Merge pull request #2360 from diomekes/importer-play
...
play: Add prompt choice to importer
2017-01-07 17:02:22 -05:00
diomekes
8d613425fd
small docstring rewrite
2017-01-06 23:46:16 -05:00
Marvin Steadfast
efbd58cd55
embyupdate: fix bug that config for password and api is needed
...
even if it only used api key it needed the password key. this is fixed
now.
2017-01-06 11:52:53 +01:00
diomekes
8d97257647
use shlex_split, clean up code and docs
2017-01-03 22:10:35 -05:00
Adrian Sampson
d389ac15e1
Use HTTPS for MS translator API (from #2247 )
2017-01-02 21:00:01 -05:00
Adrian Sampson
fbc0f322f6
Merge branch 'tigranl-https_fix'
2017-01-02 20:54:17 -05:00
Adrian Sampson
f941fd42de
Always use SSL on servers that don't require SNI
...
I did a little audit using the `openssl` command-line tool to find the servers
that don't require SNI. Here's what I found:
icbrainz.org: SNI
images.weserv.nl: inconclusive, but docs say yes SNI
coverartarchive.org: SNI
webservice.fanart.tv: *no* SNI
dbpedia.org: *no* SNI
en.wikipedia.org: *no* SNI
ws.audioscrobbler.com: *no* SNI
api.microsofttranslator.com: *no* SNI
In summary, *only* MusicBrainz and CoverArtArchive were found to require SNI.
So I'm using SSL unconditionally on all the other sites.
2017-01-02 20:39:10 -05:00
inytar
a5aee3f677
Absubmit close temporary file
...
Fix error when deleting the file under Windows
2017-01-02 14:05:59 -05:00
inytar
0975ee709b
Absubmit fix failing to load distutils.spawn
2017-01-02 14:05:17 -05:00
Adrian Sampson
f621d7f4f1
Merge pull request #1992 from jackwilsdon/add-write-bpm
...
Add write option to bpm plugin
2017-01-01 23:09:41 -05:00
Mike Cameron
8a00791ecc
Oops. Forgot to actually stage the correct file.
2017-01-01 04:52:32 -05:00
Adrian Sampson
4c1b8c2935
Merge pull request #2342 from inytar/master
...
Implement the basic AcousticBrainz Submit plugin
2017-01-01 00:45:24 -05:00
inytar
b57b3f761e
Add header to the absubmit plugin
2016-12-31 18:27:27 -05:00
inytar
cfe9c0f3d4
Remove fixed TODO comment
2016-12-31 14:11:55 -05:00
Tigran Kostandyan
1c5c74f1d7
Fix a typo
2016-12-31 18:46:01 +03:00
diomekes
ab4246c5db
add prompt choice to play items before import
...
fix line number
add comments
2016-12-30 23:51:20 -05:00
Adrian Sampson
8bb24e3134
lyrics: Set User-Agent header ( fix #2357 )
2016-12-30 10:55:24 -05:00
Diego M. Rodriguez
3f36f67940
discogs: tweak pruning of empty candidate albums
2016-12-30 11:39:19 +01:00
Diego M. Rodriguez
37cb1c295f
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
...
Conflicts:
docs/changelog.rst
test/test_discogs.py
2016-12-30 10:42:50 +01:00
Diego M. Rodriguez
5f83f8db1f
Merge remote-tracking branch 'upstream/master' into discogs-subtrack-handling
...
Conflicts:
docs/changelog.rst
2016-12-30 10:20:58 +01:00
Diego M. Rodriguez
072e6de3ae
discogs: add changelog for #2318 , fix typo
2016-12-30 10:17:53 +01:00
Adrian Sampson
1e215aedef
Merge branch 'master' of github.com:beetbox/beets
2016-12-29 13:31:00 -05:00
Adrian Sampson
ac41b6d6e5
Fix #2339 : scrub resets art type
...
We now use the richer `images` field instead of the more basic `art` field.
2016-12-29 13:30:17 -05:00
Diego M. Rodriguez
0a9cb1fd3d
discogs: revise subtrack merging based on subindex
...
Modify the coalescing of subtracks by taking into account the subindices
of the subtracks for deciding if they represent "logical" tracks
(merging them into one single track, as previously) or if they represent
physical tracks (treating them as individual tracks).
Add unit tests for nested logical/physical subtracks, and disc titles.
2016-12-29 18:03:54 +01:00
Diego M. Rodriguez
4364757fcc
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
...
Conflicts:
docs/changelog.rst
2016-12-29 13:27:06 +01:00
Diego M. Rodriguez
30f238151e
discogs: additional sanity checks parsing release
...
Add extra checks for the presence of specific field (artists, title,
id, tracklist) when parsing a Release from discogs, failing gracefully
if the fields could not be found.
Add a test for releases without required fields.
2016-12-29 13:19:01 +01:00
dopefishh
8bb703619f
use util.py3_path for web attachment filenames ( #2353 )
...
Web attachment filenames must be passed as a string for Python 3
2016-12-29 05:38:27 -05:00
Adrian Sampson
413666a825
Fix #2351 : crash in scrub on MediaFile errors
2016-12-28 16:36:51 -05:00
Diego M. Rodriguez
02666424d4
discogs: improve robustness when parsing an album
...
Improve the robustness of `get_album_info()` by preferring the use of
`get()` over accesing the dictionary keys directly for several fields,
plus adding extra checks for fields that depend on nested containers on
the Release data.
Add a test for parsing a release that contains a minimal amount of
fields.
2016-12-28 21:07:18 +01:00
Adrian Sampson
a414872430
Fix a missing parameter ( #2349 )
2016-12-28 13:36:19 -05:00
Adrian Sampson
8a62087376
Documentation tweaks for #2349
2016-12-28 12:03:57 -05:00
Adrian Sampson
2a3f3d9bfa
acousticbrainz: Make some strings into comments
...
When not in the docstring position, it's better to use "real" comments instead
of string literals.
2016-12-28 12:01:08 -05:00
Adrian Sampson
c27879edbc
Slight code formatting tweaks for #2349
2016-12-28 11:59:14 -05:00
Adrian Sampson
9db79835d6
Merge pull request #2349 from SusannaMaria/#2347
...
#2347 : First hack of ignoring already tagged items
2016-12-28 11:55:21 -05:00
Susanna Maria Hepp
7e1e31bddd
E128: continuation line under-indented for visual indent?
2016-12-28 15:30:57 +01:00
Susanna Maria Hepp
165f2e189e
Repair findings from Travis CI
2016-12-28 15:11:03 +01:00
Susanna Maria Hepp
00371de0bb
Changes suggested by @sampsyo
2016-12-27 21:56:39 +01:00
Susanna Maria Hepp
c632949b64
Changes suggested by @Kraymer
2016-12-27 21:48:06 +01:00
nath@home
8e29a3ffcb
Zero: Last minute unimportant fixes:
...
*Remove the artifact of a debug log.
*Remove meaningless version number.
*Rephrase some docstrings.
*Remove tautological comments.
2016-12-27 19:13:29 +01:00
Susanna Maria Hepp
bbaad2f17d
Introduce force option in acousticbrainz
2016-12-27 13:22:16 +01:00
Susanna Maria Hepp
f93ee3accc
First hack of ignoring already tagged items
2016-12-26 23:54:24 +01:00
Adrian Sampson
a92323945e
Merge pull request #2329 from SJoshBrown/master
...
Add manually triggered mode for zero plugin
2016-12-26 17:29:17 -05:00
Adrian Sampson
641e62f2e0
Vastly simplify main random function
...
This is the payoff from the earlier refactorings: the control flow is now
consistent and clear, and the two factors (time vs. number, equal-chance or
not) are orthogonal. See also #2322 .
2016-12-26 17:04:21 -05:00
Adrian Sampson
33eb4ff91b
Refactor time-based selection ( #2322 )
2016-12-26 17:01:02 -05:00
Adrian Sampson
d053f98e81
random: Refactor equal chance logic
2016-12-26 16:43:47 -05:00
Adrian Sampson
5bbf16c2b1
Refactor length calculation ( #2322 )
...
Also, avoid setting an unnecessary field on the album objects. :/
2016-12-26 16:32:03 -05:00
Adrian Sampson
4c2457d6ce
Refactor random plugin a bit
...
Separate the callback function from the random selection logic.
2016-12-26 16:27:31 -05:00
inytar
146516704f
Update comments for clarification
2016-12-26 16:11:48 -05:00
Adrian Sampson
9adfcbddd1
Merge pull request #2322 from diomekes/random-timelimit
...
random: add --time option, update docs
2016-12-26 16:08:14 -05:00
inytar
b86187089b
Update errors and logging of ABSubmit plugin
...
A UserError is now raised if the plugin can be started.
If an item fails to be analyzed or be submited an error is logged and
the next item is tried.
2016-12-26 16:05:10 -05:00
Josh Brown
b6577b4226
refactor long line for PEP8
2016-12-26 14:42:10 -06:00
Josh Brown
7833469261
add confirmation for empty query
2016-12-26 14:13:01 -06:00
Josh Brown
2903925e2f
Rewrite zero plugin manual mode
2016-12-26 13:34:34 -06:00
nathdwek@laptop
96d331ace0
Zero: cleanup plugin
2016-12-24 19:13:10 +01:00
inytar
f61aa7a016
Move extractor sha calculation to pluging init.
2016-12-23 17:48:29 -05:00
inytar
fd3ff917d2
Implement the basic AcousticBrainz Submit plugin
2016-12-23 17:27:46 -05:00
Adrian Sampson
a063336446
Fix #2332 : Unicode trouble in bpd
2016-12-20 15:16:46 -05:00
diomekes
1bc5456986
random: make --album work with --time
2016-12-17 17:24:58 -05:00
Kier Davis
eb85ff422b
convert plugin: fix braces in filenames causing tracebacks in "pretend" mode
...
Previously "pretend" mode (a.k.a. dry run mode) passed the command to be
printed directly to _log.info, whose first argument is technically a
format string. Thus the command string was parsed for replacement fields, such
as '{foo}', which could cause the format evaluation to fail if the filenames
contained in the command contained valid (or partially valid) replacement fields.
This fix simply inserts an argument '{0}' to the call to _log.info, which is a
format string that simply evaluates to the second argument to _log.info (the
command string). By doing this, the command string is not parsed for replacement
fields.
2016-12-16 00:21:35 +00:00
diomekes
fc8411f3b8
random: add --time option, update docs
2016-12-15 16:15:38 -05:00
tigranl
dd115b1310
Add ui import
2016-12-11 00:35:51 +03:00
tigranl
5ca664e4aa
Fix typos
2016-12-11 00:25:37 +03:00
tigranl
471f875dc1
Fix typo
2016-12-10 21:26:51 +03:00
tigranl
68b4a03ecd
Add tests for https
2016-12-10 19:54:44 +03:00
