Adrian Sampson
a414872430
Fix a missing parameter ( #2349 )
2016-12-28 13:36:19 -05:00
Adrian Sampson
8a62087376
Documentation tweaks for #2349
2016-12-28 12:03:57 -05:00
Adrian Sampson
2a3f3d9bfa
acousticbrainz: Make some strings into comments
...
When not in the docstring position, it's better to use "real" comments instead
of string literals.
2016-12-28 12:01:08 -05:00
Adrian Sampson
c27879edbc
Slight code formatting tweaks for #2349
2016-12-28 11:59:14 -05:00
Susanna Maria Hepp
7e1e31bddd
E128: continuation line under-indented for visual indent?
2016-12-28 15:30:57 +01:00
Susanna Maria Hepp
165f2e189e
Repair findings from Travis CI
2016-12-28 15:11:03 +01:00
Susanna Maria Hepp
00371de0bb
Changes suggested by @sampsyo
2016-12-27 21:56:39 +01:00
Susanna Maria Hepp
c632949b64
Changes suggested by @Kraymer
2016-12-27 21:48:06 +01:00
Susanna Maria Hepp
bbaad2f17d
Introduce force option in acousticbrainz
2016-12-27 13:22:16 +01:00
Susanna Maria Hepp
f93ee3accc
First hack of ignoring already tagged items
2016-12-26 23:54:24 +01:00
nath@home
147ced9eaa
acousticbrainz: latest adjustments
...
* Readability and consistency
* Better logging: warn by default for attributes that were not found,
but don't drown user with info when everything is going well.
2016-11-20 22:45:07 +01:00
nathdwek@laptop
eb1ea6177d
acousticbrainz: drop DefaultList, be explicitly careful
...
* I don't see DefaultList be really helpful in many other cases, so having
a beets.util.collections module (which could also conflict with the collections
module from standard library) with only that in it is a little silly.
* It was elegant and concise, but there are implementation issues: it is not
recommended to subclass builtin types, but the alternatives differ between python
2 and 3 (subclass sequence or container or collections.abc?), moreover,
interpreters can differ in the way they map syntaxic sugar to magic functions.
* Also, slicing and negative indexing could do weird things, so the class wouldn't
be really intuitive and simple at the same time
2016-11-20 22:03:41 +01:00
nathdwek@laptop
1d972b9907
acousticbrainz: rewrite _map_dict_to_scheme:
...
* Less lazy names
* Separate root function from childs more naturally
* Actually use defaultdict
2016-11-20 22:03:41 +01:00
nathdwek@laptop
324c67191d
acousticbrainz: log fetched attributes and values as info
2016-11-20 22:03:41 +01:00
nathdwek@laptop
3979619f9f
acousticbrainz: remove redundant comments
2016-11-20 22:03:41 +01:00
nath@home
7a676400dc
acousticbrainz: Refactor the json handling part
2016-11-20 22:03:41 +01:00
nath@home
1963b52903
acousticbrainz: Initial cleanup
2016-11-20 22:03:41 +01:00
Jelle Besseling
b4caa0e475
Add BPM data with acousticbrainz
...
The bpm plugin is a very slow way to add bpm data to songs, using the acousticbrainz plugin is much faster and can doesn't need a new plugin.
2016-07-26 15:42:35 +02:00
Johnny Robeson
a405a072f7
use reduce() from functools
2016-05-26 23:52:35 -04:00
Frederik “Freso” S. Olesen
37b9360706
acousticbrainz plugin: Access acousticbrainz.org over HTTPS.
2016-05-20 01:08:15 +02:00
Adrian Sampson
e54c7eec3d
Standardize __future__ imports without parentheses
...
Since the list is short enough now, we don't need parentheses for the line
wrap. This is a little less ugly.
2016-02-28 15:03:51 -08:00
Peter Kessen
6852ab5472
Removed unicode_literals from plugins
...
* acousticbrainz
* badfiles
* bpm
2016-02-20 11:49:10 +01:00
Adrian Sampson
04618f9aef
acousticbrainz ( #1787 ): Fix typos in keys
2016-01-03 14:17:39 -08:00
Adrian Sampson
4041c3ceb2
acousticbrainz ( #1787 ): Write tags
...
Now that we modify the built-in field, this is necessary.
2016-01-03 14:14:10 -08:00
Ohm Patel
a1db349bf9
ABrainz: Variable parameters
2016-01-02 19:20:20 -06:00
Ohm Patel
b5f71a88e8
ABrainz: replace lambda with operator
2016-01-02 19:05:53 -06:00
Ohm Patel
e5c46cf6ac
PEP-8 Cleanup
2016-01-02 18:59:47 -06:00
Ohm Patel
39b565d8d8
Refactor JesseW's suggestions
2016-01-02 18:52:28 -06:00
Ohm Patel
1bb55c5c13
ABrainz: Used existing initial_key variable
2016-01-02 14:55:34 -06:00
Ohm Patel
4184f9dd13
ABrainz: Chords metadata from low_level
2016-01-02 12:03:07 -06:00
Ohm Patel
17dd7496a2
ABrainz: Added low-level data and updated docs
2016-01-02 11:33:19 -06:00
Ohm Patel
c5f25429e9
ABrainz: Fixed docstrings and documentation
2016-01-01 18:29:36 -06:00
Ohm Patel
52de238076
ABrainz: Removed PEP8 Whitespace violation
2016-01-01 01:32:42 -06:00
Ohm Patel
82709f1c1b
ABrainz: Added more metadata for plugin to fetch and updated docs
2016-01-01 01:28:17 -06:00
Ohm Patel
26679f891e
ABrainz: Added acousticbrainz to autotagger and updated docs
2016-01-01 01:01:14 -06:00
Adrian Sampson
aad2cf1feb
acousticbrainz: Log an error for missing data
2015-12-31 11:38:05 -08:00
Adrian Sampson
3a3dc8b3ae
acousticbrainz: Don't write tags
...
Since we aren't updating any on-disk tags anyway.
2015-12-31 11:35:14 -08:00
Adrian Sampson
5d89b7da67
acousticbrainz: Allow filtering on a query
...
Like other, similar commands.
2015-12-31 11:33:58 -08:00
Adrian Sampson
878161bb4f
acousticbrainz: Avoid re-parsing the JSON
2015-12-31 11:31:32 -08:00
Adrian Sampson
18e5b30d19
acousticbrainz: Handle requests errors
2015-12-31 11:29:57 -08:00
Adrian Sampson
eb2b081dfd
acousticbrainz: A bit more logging
...
This way, the command shows you that it's making progress.
2015-12-31 11:28:28 -08:00
Ohm Patel
ad57943819
Updated Copyright Year
2015-12-31 09:35:01 -06:00
Ohm Patel
6337b7ff08
Rename commands and files
2015-12-31 08:57:19 -06:00
Ohm Patel
5201e1cde7
Rename
2015-12-31 08:56:55 -06:00
