Jan Holthuis
c07903ed66
fetchart: Add some error handling to prevent crashes
...
Today I had some network problems regarding dbpedia.org, which made
beets crash because a requests.exceptions.ConnectionError was raised
("[Errno 113] No route to host"). This commits adds some error handling
around network requests to prevent further crashes in the future.
2019-02-19 16:16:56 +01:00
Reg
2ea77652a7
Fetchart: Respect ignore and ignore_hidden settings when fetching art
...
from the local filesystem.
2018-12-20 18:44:46 +01:00
Jack Wilsdon
5ad16983d4
Fix miscellaneous typos
2018-10-09 01:11:06 +01:00
nath@dp7510
399bfb985e
fetchart: fix itunes debug info
...
Some typos + make it more useful overall
2018-08-15 13:56:39 +02:00
nath@dp7510
0107262ed3
fetchart: restore itunes art source
...
Reimplement minimalistic itunes scraper from scratch
2018-08-15 13:55:55 +02:00
wisp3rwind
318f0c4d16
Advanced fetchart source config: pep8
2018-02-24 11:26:50 +01:00
wordofglass
e7a3e27ed9
Advanced fetchart source config: Actually use the new syntax
2018-02-24 11:26:50 +01:00
wordofglass
2c1e4d878b
Advanced fetchart source config: add the (still unused) match_by constructor argument
2018-02-24 11:26:50 +01:00
test
842f6afd7f
Fix indentation
2017-11-10 14:04:16 +01:00
test
8544b3a830
Fix long line and add changelog entry
2017-11-10 13:46:26 +01:00
test
54297dbab4
Tentative fix for issue 2734: also check for RETAG
2017-11-05 12:04:40 +01:00
euri10
25fb2453b4
Modified the name of the fetchart plugin switch from missing to quiet
2017-09-05 18:27:47 +02:00
euri10
b2fd274e2c
Added a missing switch to the fetchart command so that only missing albums
...
are displayed
2017-09-05 16:34:26 +02:00
wordofglass
bc582701ff
fetchart: Internally pass settings in a cleaner way.
...
Dump the 'extra' dictionary which only duplicated attributes of the
plugin onject in favor of passing a reference to the plugin directly.
2017-01-25 00:01:05 +01:00
Adrian Sampson
f941fd42de
Always use SSL on servers that don't require SNI
...
I did a little audit using the `openssl` command-line tool to find the servers
that don't require SNI. Here's what I found:
icbrainz.org: SNI
images.weserv.nl: inconclusive, but docs say yes SNI
coverartarchive.org: SNI
webservice.fanart.tv: *no* SNI
dbpedia.org: *no* SNI
en.wikipedia.org: *no* SNI
ws.audioscrobbler.com: *no* SNI
api.microsofttranslator.com: *no* SNI
In summary, *only* MusicBrainz and CoverArtArchive were found to require SNI.
So I'm using SSL unconditionally on all the other sites.
2017-01-02 20:39:10 -05:00
tigranl
471f875dc1
Fix typo
2016-12-10 21:26:51 +03:00
tigranl
68b4a03ecd
Add tests for https
2016-12-10 19:54:44 +03:00
tigranl
21208b8c39
Add SNI_SUPPORTED
2016-12-08 19:09:15 +03:00
tigranl
efa90416a0
Add SNI_SUPPORTED
...
Add SNI_SUPPORTED
2016-12-06 19:51:15 +03:00
tigranl
73a7a4ff67
Add SNI_SUPPORTED variable for https check
2016-12-06 18:38:26 +03:00
nathdwek@laptop
a0877dc092
images: Make sure all jpegs work everywhere
...
Apply #1545 to a public function used everywhere
2016-11-08 18:48:44 +01:00
Johnny Robeson
fcbfce3984
replace deprecated log.warn() with log.warning()
2016-08-09 00:33:38 -04:00
Johnny Robeson
527b51147e
add py3_path to NamedTemporaryFile suffixes
2016-07-02 04:53:57 -04:00
wordofglass
e2c6547635
fetchart: Clarify the deprecation of remote_priority in docs and
...
warning, closes #2092
2016-06-29 19:18:06 +02:00
Adrian Sampson
e16cc58cb9
Walk back some six.iter* uses
...
In places where it doesn't much matter whether we use an iterator or the old
Python 2 list way, using the six name just hurts legibility.
2016-06-25 18:29:55 -07:00
Adrian Sampson
736ad66518
Merge pull request #2066 from beetbox/use-six
...
Use the six package to handle py2/p3 compatibility
2016-06-25 18:09:56 -07:00
wordofglass
5d00ca8bda
fetchart: do not unnecessarily reset Candidate.path on download failure
2016-06-25 14:10:55 +02:00
wordofglass
697291b04e
fetchart: improve error resilience of the Content-Type detection by file magic
2016-06-25 14:10:50 +02:00
wordofglass
9968288358
fetchart: update comments
2016-06-25 13:49:15 +02:00
Johnny Robeson
edb1cbc5fc
replace iter{items|values} with six.iter{items|values}
2016-06-24 05:53:55 -04:00
Johnny Robeson
e8afcbe7ec
replace unicode with six.text_type
2016-06-24 05:53:49 -04:00
wordofglass
34cdf0f3f3
fetchart: complain about unsupported images only after validating the Content-Type
2016-06-23 17:38:01 +02:00
wordofglass
d47182a3e5
fetchart: do not rely on the server-provided Content-Type, but determine the image format from the file magic
2016-06-23 17:37:55 +02:00
Johnny Robeson
ea02269dee
remove ext encode from fetchart (py3 fix for #2068 )
2016-06-23 02:29:53 -04:00
wordofglass
c4617c2c1f
fetchart: do not hardcode the downloaded extension to jpg, fixes #2053
2016-06-21 10:57:45 +02:00
Johnny Robeson
1c761c60fb
bytstringify extra cover_names in fetchart
2016-06-17 03:37:28 -04:00
Johnny Robeson
a76de95183
return a bytestring path from RemoteArtSource
2016-06-12 01:19:39 -04:00
Johnny Robeson
ab67727283
wrap the cover_names map with a list in fetchart
...
most `cover_names` users expect to operate on a list
2016-06-10 00:09:15 -04:00
Adrian Sampson
f400a2431e
fetchart: Fix path types on Windows
2016-06-08 10:20:25 -07:00
Johnny Robeson
81484529c9
remove b' from a few more stdlib calls
2016-05-31 00:13:09 -04:00
Adrian Sampson
09bc250413
Fix #1960 : Unicode in fetchart Wikipedia source
...
The SparQL query needed to use a Unicode literal.
2016-04-26 16:59:23 -07:00
wordofglass
ac2f7fe712
Fix the fanarttv source failing when there were images found, but no cover art
2016-04-20 12:59:18 +02:00
wordofglass
5fbca32ea4
reuse the 'sources' names from the configuration for art_source
2016-04-19 11:25:03 +02:00
wordofglass
740efc0a0e
small fixes; consistently use 'source' instead of 'origin'
2016-04-19 11:23:57 +02:00
wordofglass
c27907b043
enable fetchart to store the artworks origin in a flexible field; as of now untested
2016-04-19 11:23:42 +02:00
wordofglass
9e774fdccd
Merge branch 'master' into fetchart_almost_square
2016-04-18 19:00:45 +02:00
wordofglass
c3be244109
remove the personal key warning altogether; it's also in the docs and rather obtrusive
2016-04-18 18:52:18 +02:00
wordofglass
20235264a4
rewire logic a bit; reasonable debug messages
2016-04-18 15:23:38 +02:00
wordofglass
30bca5c8af
fix unconditionally printing the personal key warning for in fanart.tv in fetchart
2016-04-18 11:39:09 +02:00
wordofglass
6cbbba7dae
initial work on allowing slightly non-square images in fetchart
2016-04-18 01:47:39 +02:00
