Fabrice Laporte
b32838b519
fix flake8
2014-10-09 06:47:23 +02:00
Fabrice Laporte
2b908b48bc
lastgenre: use an ordinary Item instead of a Mock
2014-10-09 06:38:40 +02:00
Fabrice Laporte
b95990ee9c
lastgenre: add unit tests
2014-10-09 00:00:26 +02:00
Thomas Gordon
98adb35e3f
Change expected result for compatibility with updated genres-tree.yaml
2014-09-06 08:51:31 -04:00
Fabrice Laporte
df47f19e86
lastgenre: remove duplicate genres
2014-06-28 10:31:12 +02:00
Adrian Sampson
233f71a457
Use real booleans for whitelist/canonical options
...
As opposed to the strings "true" and "false".
2014-04-28 23:00:00 -07:00
Adrian Sampson
add309b57d
Isolate lastgenre tests
...
We now appropriately set up and tear down the fixture for the lastgenre tests.
(This was causing unpredictable failures elsewhere before.)
2014-04-28 22:35:32 -07:00
Fabrice Laporte
ef3c1cd1ff
use booleans for whitelist and c14n options
...
homogenise options setup using booleans, while keeping the empty string
(synonym of ‘true’) for backward compatibility.
2014-04-28 10:31:22 +02:00
Adrian Sampson
d5dbaeff7a
lastgenre: Restore default whitelist
2014-04-27 13:54:32 -07:00
Adrian Sampson
dfd9a4c397
Merge branch 'KraYmer-lastgenre-tests-new' into lastgenre-tests-new
...
Conflicts:
test/test_lastgenre.py
2014-04-27 13:52:06 -07:00
Fabrice Laporte
d1cc95984e
Rename/add tests
...
Rewrite tests now that empty whitelist is allowed.
2014-04-27 22:32:31 +02:00
Fabrice Laporte
0613cb7d13
Update _setup_config
...
Give an empty string to obtain default whitelist, None for no whitelist
or a stringlist for a custom one.
2014-04-27 22:31:31 +02:00
Fabrice L.
e442749cd4
add a test that would fail with the restricted whitelist approach
...
If no option is set, valid genres should not be rejected. Which is an argument
to have a wide default whitelist.
2014-04-27 16:05:16 +02:00
Fabrice Laporte
e399173f7e
add a test that would fail with the restricted whitelist approach
...
If no option is set, valid genres should not be rejected. Which is an argument
to have a wide default whitelist.
2014-04-27 15:59:43 +02:00
Fabrice Laporte
d0d3c18da2
lastgenre: rewrite filtering logic to make tests pass
...
- remove filter_tags() as genres should not be removed this soon while
c14n has not been applied
- group all filtering logic in the function _resolve_genres (formerly
_strings_to_genre)
2014-04-26 20:51:13 -07:00
Fabrice Laporte
2e8e55736d
get rid of module level options variable
...
Conflicts:
beetsplug/lastgenre/__init__.py
2014-04-26 20:51:00 -07:00
Fabrice Laporte
4e5bb262a7
wip: rewrite setup_config
2014-04-26 20:50:04 -07:00
Fabrice Laporte
21f1607e8f
lastgenre: add tests functions
2014-04-26 20:50:04 -07:00
Fabrice Laporte
3d30708839
add test_lastgenre.py
2014-04-26 20:50:04 -07:00
