Mike Cameron
8a00791ecc
Oops. Forgot to actually stage the correct file.
2017-01-01 04:52:32 -05:00
Mike Cameron
76b3212e78
Added alternate track numbers for Discogs.
2017-01-01 04:51:34 -05:00
Mike Cameron
0d68a12609
Added alternate track field when importing from MusicBrains.
...
Useful when importing multi-sided medias such as vinyls and cassettes.
2017-01-01 04:36:48 -05:00
Adrian Sampson
32dc808f71
Changelog entry for #2342 ( fix #2253 )
2017-01-01 00:47:03 -05:00
Adrian Sampson
4c1b8c2935
Merge pull request #2342 from inytar/master
...
Implement the basic AcousticBrainz Submit plugin
2017-01-01 00:45:24 -05:00
inytar
b57b3f761e
Add header to the absubmit plugin
2016-12-31 18:27:27 -05:00
inytar
1a4c74ae5e
More spelling corrections for the absubmit plugin documentation
2016-12-31 18:26:56 -05:00
inytar
9ab67d5ffe
Fix typos in absubmit documentation
2016-12-31 14:12:28 -05:00
inytar
cfe9c0f3d4
Remove fixed TODO comment
2016-12-31 14:11:55 -05:00
Tigran Kostandyan
1c5c74f1d7
Fix a typo
2016-12-31 18:46:01 +03:00
diomekes
af99ee21aa
add documentation for play importer prompt choice
2016-12-31 00:15:36 -05:00
diomekes
ab4246c5db
add prompt choice to play items before import
...
fix line number
add comments
2016-12-30 23:51:20 -05:00
Johnny Robeson
2eb47e9ea5
Temporarily allow empty checksum for unrar on appveyor ( #2359 )
...
Obviously it'd be best if we didn't have to do it, but I doubt we can
wait forever for the packagers to add it.
2016-12-30 21:30:20 -05:00
Adrian Sampson
8bb24e3134
lyrics: Set User-Agent header ( fix #2357 )
2016-12-30 10:55:24 -05:00
Diego M. Rodríguez
87266be5a6
Merge pull request #2354 from diego-plan9/discogs-relax-assumptions
...
discogs: more graceful handling of missing fields
2016-12-30 12:03:02 +01:00
Diego M. Rodriguez
3f36f67940
discogs: tweak pruning of empty candidate albums
2016-12-30 11:39:19 +01:00
Diego M. Rodriguez
37cb1c295f
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
...
Conflicts:
docs/changelog.rst
test/test_discogs.py
2016-12-30 10:42:50 +01:00
Diego M. Rodríguez
7d943301ef
Merge pull request #2355 from diego-plan9/discogs-subtrack-handling
...
discogs: revise subtrack merging based on subindex
2016-12-30 10:35:15 +01:00
Diego M. Rodriguez
5f83f8db1f
Merge remote-tracking branch 'upstream/master' into discogs-subtrack-handling
...
Conflicts:
docs/changelog.rst
2016-12-30 10:20:58 +01:00
Diego M. Rodriguez
072e6de3ae
discogs: add changelog for #2318 , fix typo
2016-12-30 10:17:53 +01:00
Adrian Sampson
2642544867
Changelog note for #2353
2016-12-29 13:34:23 -05:00
Adrian Sampson
1e215aedef
Merge branch 'master' of github.com:beetbox/beets
2016-12-29 13:31:00 -05:00
Adrian Sampson
ac41b6d6e5
Fix #2339 : scrub resets art type
...
We now use the richer `images` field instead of the more basic `art` field.
2016-12-29 13:30:17 -05:00
Diego M. Rodriguez
0a9cb1fd3d
discogs: revise subtrack merging based on subindex
...
Modify the coalescing of subtracks by taking into account the subindices
of the subtracks for deciding if they represent "logical" tracks
(merging them into one single track, as previously) or if they represent
physical tracks (treating them as individual tracks).
Add unit tests for nested logical/physical subtracks, and disc titles.
2016-12-29 18:03:54 +01:00
Diego M. Rodriguez
4364757fcc
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
...
Conflicts:
docs/changelog.rst
2016-12-29 13:27:06 +01:00
Diego M. Rodriguez
30f238151e
discogs: additional sanity checks parsing release
...
Add extra checks for the presence of specific field (artists, title,
id, tracklist) when parsing a Release from discogs, failing gracefully
if the fields could not be found.
Add a test for releases without required fields.
2016-12-29 13:19:01 +01:00
dopefishh
8bb703619f
use util.py3_path for web attachment filenames ( #2353 )
...
Web attachment filenames must be passed as a string for Python 3
2016-12-29 05:38:27 -05:00
Adrian Sampson
413666a825
Fix #2351 : crash in scrub on MediaFile errors
2016-12-28 16:36:51 -05:00
Adrian Sampson
24d43635cd
Slightly more helpful UnreadableFileError ( #2351 )
...
The exception now says something about what caused it, instead of just
listing the path that led to the error.
2016-12-28 16:33:43 -05:00
Adrian Sampson
c7351d9086
Flip an erroneous execute bit
2016-12-28 16:18:02 -05:00
Diego M. Rodriguez
0efb0c3472
discogs: add changelog entry for robustness fix
2016-12-28 21:16:44 +01:00
Diego M. Rodriguez
02666424d4
discogs: improve robustness when parsing an album
...
Improve the robustness of `get_album_info()` by preferring the use of
`get()` over accesing the dictionary keys directly for several fields,
plus adding extra checks for fields that depend on nested containers on
the Release data.
Add a test for parsing a release that contains a minimal amount of
fields.
2016-12-28 21:07:18 +01:00
Adrian Sampson
63f50287d5
Rename some choice-related variables
...
These are no longer "extra"---they're *all* the choices that will be used.
2016-12-28 14:54:25 -05:00
Adrian Sampson
c98972894a
Better prompt order
2016-12-28 14:49:26 -05:00
Adrian Sampson
f5e4853bb3
Move as-is and skip choices to declarative choices
...
That's all the standard choices that don't depend on which prompt you're
looking at! Woohoo!
2016-12-28 14:46:33 -05:00
Adrian Sampson
1e8be0a19f
Use declarative style for ALBUMS/TRACKS choices
...
This unifies the set of choices that are shown at each prompt variant in
`choose_candidate`, making its code much shorter. Declarative programming FTW.
2016-12-28 14:40:06 -05:00
Adrian Sampson
9dff841afe
Fix class anme of PromptChoice
2016-12-28 14:33:55 -05:00
Adrian Sampson
8763be5423
Revert "Fix tests for new prompt order"
...
This reverts commit a357cc4e1a .
We no longer need the tests to change---I was able to fix the order by
bringing the "abort" action into the standard list of options.
2016-12-28 14:33:11 -05:00
Adrian Sampson
e5a12615e4
Subsume abort action into declarative style
2016-12-28 14:32:41 -05:00
Adrian Sampson
a357cc4e1a
Fix tests for new prompt order
2016-12-28 14:23:22 -05:00
Adrian Sampson
3ede874e96
Changelog note about new prompt interface
2016-12-28 14:18:27 -05:00
Adrian Sampson
6afe407f45
Remove one last duplicated set of prompts
2016-12-28 14:16:33 -05:00
Adrian Sampson
8937eec50a
Refactor built-in stnadard choices
2016-12-28 14:15:40 -05:00
Adrian Sampson
2f6538aee2
Refactor search options to ordinary choices
...
`PromptChoice`s can now return `Proposal` values, which makes these two
options just "normal" actions that could be provided by plugins.
2016-12-28 14:08:09 -05:00
Adrian Sampson
6c825970ac
Tolerate missing AlbumInfo.mediums field
2016-12-28 13:54:04 -05:00
Adrian Sampson
7c6eafa285
Refactor manual search options to use Proposal
...
This is the first step to making them behave like plugin actions.
2016-12-28 13:50:53 -05:00
Adrian Sampson
a414872430
Fix a missing parameter ( #2349 )
2016-12-28 13:36:19 -05:00
Adrian Sampson
22610b7684
Refactor extra choice return value
...
The `choose_candidate` function now returns the `PromptChoice` object instead
of a short letter that selects the `PromptChoice`.
2016-12-28 13:34:27 -05:00
Adrian Sampson
3578f0d429
Introduce a new Proposal type for tag results
...
tag_album and tag_item now return a Proposal. The idea is that plugin actions
should also be able to return Proposal values, just like the built-in actions.
2016-12-28 13:21:55 -05:00
Adrian Sampson
9b0a867c73
Expand some comments in choose_match
2016-12-28 12:40:33 -05:00