Jacob Pavlock
f677fd2407
add testing wiki to contributing.rst
2020-07-20 19:56:05 -07:00
Jacob Pavlock
66e6af48be
add table of contents to contributing.rst
2020-07-20 19:56:05 -07:00
Jacob Pavlock
2982f245e1
add CONTRIBUTING.rst to the docs
2020-07-20 19:56:05 -07:00
Jacob Pavlock
faa5553468
convert CONTRIBUTING.md to rst
2020-07-20 19:46:12 -07:00
jtpavlock
c5b82e0134
Merge pull request #3679 from beetbox/jtpavlock-patch-1
...
Adjust wording of CONTRIBUTING.md
2020-07-20 17:22:49 -07:00
jtpavlock
b309ed95c2
Remove duplicate forum mention
...
Forums are already mentioned in the 'Contact' section
2020-07-20 17:18:17 -07:00
jtpavlock
c1b9e99722
maintainers *will* reciprocate respect :)
2020-07-20 19:07:32 -05:00
jtpavlock
5544c7a881
Fix wording
2020-07-20 19:04:44 -05:00
jtpavlock
426cb08003
fix CONTRIBUTING.md link and spelling
2020-07-20 19:02:38 -05:00
jtpavlock
335776ff30
Merge pull request #3666 from jtpavlock/flake8-errors
...
Unignore flake8 E221, E226, E242, E704
2020-07-20 12:24:52 -07:00
jtpavlock
62ce5d15db
add contributing.md & update readme ( #3643 )
...
* add contributing.md & update readme
* add for developers section of docs to contributing.md
* remove relative wiki links
* readme spelling fix
* clarify discourse/docs idea for user 'recipes' to get featured
* remove coveralls from testing section
* fix api links & clarify docstring standard
* Contributing -> Contribute
* remove manual pip module installation instructions
* add link to testing wiki page on "how to contribute"
* add databse access examples
* added voting clarification
* Rename contributing.md to CONTRIBUTING.md
* remove out of date info
Includes references to gitter, the old 'good first issue' label and also
some updates to testing.
* No need for backticks around beets
We usually just typeset it as an ordinary noun, not as code. :)
* Whitespace
* End-to-end CONTRIBUTING pass
Co-authored-by: Adrian Sampson <adrian@radbox.org>
2020-07-20 10:12:34 -05:00
jtpavlock
441cfebff1
add .venv/ to gitignore
...
.venv/ is recommended via https://docs.python.org/3/library/venv.html
2020-07-19 13:25:55 -05:00
José Albornoz
dc7e433768
Fix thumbnail plugin pathlib bug ( #3360 )
...
PathlibURI.uri() would fail if given a path as bytes instead of as string.
Co-authored-by: Jacob Pavlock <jtpavlock@gmail.com>
2020-07-15 21:00:50 -05:00
Adrian Sampson
05516f9503
Thanks & bug number for #2554
2020-07-14 06:59:48 -04:00
Adrian Sampson
8537d1e36d
Merge pull request #2554 from musoke/python3-plugin-ipfs
...
compatibility of IPFS plugin with Python 3
2020-07-14 06:58:20 -04:00
soergeld
72e91d84f2
names
2020-07-14 00:01:22 +02:00
soergeld
770664f27d
typo
2020-07-13 23:05:53 +02:00
soergeld
ef08fbee0c
correct test for parentwork
2020-07-13 23:01:18 +02:00
soergeld
08c1344639
correct test for parentwork
2020-07-13 22:57:05 +02:00
soergeld
8167870a7f
correct test for parentwork_id_current
2020-07-13 22:52:31 +02:00
soergeld
e3fb243782
parentwork force test doesn't work
2020-07-13 22:44:49 +02:00
soergeld
66bb2adf19
try something
2020-07-13 22:40:34 +02:00
soergeld
ccd44bc57c
complete mocked parentworks
2020-07-13 22:31:51 +02:00
soergeld
ab2d653d82
typo
2020-07-13 22:26:57 +02:00
soergeld
f87f271484
correct mock results of get_work_by_id
2020-07-13 22:22:16 +02:00
soergeld
55995a32cb
correct force check, correct arguments for get_work_by_id
2020-07-13 22:17:24 +02:00
soergeld
df91813609
pep-8
2020-07-13 22:13:49 +02:00
soergeld
a4a9f0daa9
different way of mocking
2020-07-13 22:12:13 +02:00
soergeld
82411c67cf
minor fixes
2020-07-13 21:51:45 +02:00
soergeld
1cb23e5c5c
no hybrid mocking, two classes
2020-07-13 21:48:06 +02:00
soergeld
dba2e2320d
hybrid mocking
2020-07-13 21:41:10 +02:00
soergeld
d71ee6bc31
exchanged tests with and without MB
2020-07-13 21:38:02 +02:00
soergeld
58b11d9d3c
make tests both with MB and without
2020-07-13 21:34:24 +02:00
jtpavlock
d9272fcb88
fix integration test job name
2020-07-13 14:20:20 -05:00
soergeld
94dd7cee70
unused library
2020-07-13 21:20:18 +02:00
soergeld
2d756df5b7
second try
2020-07-13 21:16:51 +02:00
soergeld
e943486da9
first try at mocking get_work_by_id
2020-07-13 21:11:30 +02:00
Adrian Sampson
9c054e9588
Merge pull request #3668 from wisp3rwind/pr_fix_bad_triggers
...
Fix a regression in the heuristic for detecting valid lyrics from the google source
2020-07-12 16:46:46 -04:00
wisp3rwind
44e4d558c9
lyrics: fix bad_triggers in the google plugin
...
regression from 117d16f
2020-07-12 22:23:17 +02:00
Jacob Pavlock
52afd717aa
remove docstring-convention and update comment
2020-07-11 19:10:04 -07:00
Jacob Pavlock
124c882b4d
un-ignore E221
2020-07-11 18:33:08 -07:00
Jacob Pavlock
abad0f9c08
un-ignore flake8 E226, E242, E704
...
none of these required any code changes
2020-07-11 18:22:43 -07:00
Jacob Pavlock
1db46dfeb6
reformat flake8 errors
2020-07-11 18:15:41 -07:00
jtpavlock
16fddbaef6
add line break to stale-bot comments
2020-07-11 17:27:37 -05:00
jtpavlock
cc9f4ab251
Add a stale-bot ( #3659 )
...
will apply the `stale` label to any issues and pull requests with >60/120 days inactivity respectively
2020-07-11 15:59:34 -05:00
Adrian Sampson
97378c6c90
Merge pull request #3418 from RollingStar/patch-1
...
Clarify getitem docstring. Log when falling back.
2020-07-11 10:04:42 -04:00
Adrian Sampson
d230b3b870
Roll back logging changes
2020-07-11 10:04:00 -04:00
jtpavlock
8b8156c493
Merge pull request #3661 from jtpavlock/testing-cleanup
...
Testing cleanup & nose -> pytest
2020-07-09 18:53:09 -05:00
Jacob Pavlock
f6855cb284
add py_colors to all github workflows
2020-07-07 19:58:27 -07:00
Jacob Pavlock
7280ab2be0
remove nosetest.xml from .gitignore
2020-07-07 19:54:12 -07:00