Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-07 09:04:33 +01:00
Code Issues Projects Releases Wiki Activity
10167 commits 43 branches 64 tags 60 MiB
Commit graph

3247 commits

Author SHA1 Message Date
Thorsten
05d202760b
Update genres.txt 
Added more heavy metal genres: https://en.wikipedia.org/wiki/Heavy_metal_genres
 2020-05-16 00:34:10 +02:00
soergeld
fe418b946e forgot one mb_workid_current occurence 2020-05-14 22:40:37 +02:00
Adrian Sampson
b3656bcab9
Merge pull request #3586 from dosoe/beet_update_parentwork 
Fetching parentwork if changed, even if not force
 2020-05-14 08:26:30 -04:00
Adrian Sampson
1dcfa03b5b Merge branch 'master' of github.com:beetbox/beets 2020-05-13 08:21:09 -04:00
Adrian Sampson
5db2b4ccaa Fix new flake8 warnings 2020-05-13 08:20:50 -04:00
soergeld
918fea5eca small changes, documentation 2020-05-12 16:05:08 +02:00
Adrian Sampson
4ea69da745
Merge pull request #3588 from MrNuggelz/subsonicplaylist 
Fix: subsonicplaylist wrong song selection
 2020-05-11 19:11:19 -04:00
MrNuggelz
fd1fd2182b changed "SubstringQuery" to "MatchQuery" to prevent wrong song selection 2020-05-11 20:09:04 +02:00
soergeld
1f93ce5a49 small changes, docs 2020-05-11 16:14:52 +02:00
soergeld
c948530279 Fetching parentwork if changed, even if not force 2020-05-10 13:05:55 +02:00
Adrian Sampson
a907dac16c
Merge pull request #3568 from dosoe/beet_test_new_albuminfo 
First try adding new albuminfo and trackinfo class
 2020-05-09 10:53:43 -04:00
Adrian Sampson
31a264b299
Merge pull request #3425 from MrNuggelz/subsonicplaylist 
Subsonic Playlist Plugin
 2020-05-09 10:52:10 -04:00
MrNuggelz
5d90296a20 fixed flake8 issues 2020-05-09 13:16:56 +02:00
Dorian Soergel
d07c1dece9
Merge branch 'master' into beet_test_new_albuminfo 2020-05-09 12:45:13 +02:00
MrNuggelz
4933671c10 review: updated subsonicplaylist.py 2020-05-08 21:37:05 +02:00
soergeld
7c71bb87a2 cleaning up, renaming dup_XXInfo() to copy() 2020-05-08 16:32:12 +02:00
pants108
1a79ae5a9f code review 1 2020-05-05 18:39:05 +00:00
pants108
a553693677 fetchart: clean up invalid tmp files 2020-05-03 17:58:44 +00:00
MrNuggelz
5c3debe236 removed unused imports 2020-05-03 16:07:27 +02:00
Joris
08180f2b5d
Merge branch 'master' into subsonicplaylist 2020-05-03 14:59:22 +02:00
MrNuggelz
13b4a1413d update all songs in one transaction 2020-05-03 14:58:34 +02:00
MrNuggelz
cb7dfe3f6f review: updated subsonicplaylist.py 2020-05-03 14:05:22 +02:00
Sören Tempel
6a03afc65d web plugin: support path queries by separating them with a backslash 
Without this change the web plugin does not support path queries as
slashes are currently used for joining keywords in the QueryConverter.
Moreover, flask cannot distinguish between an URL encoded and a plain
'/' character during routing [0]. To work around this issue without
introducing a breaking change (i.e. removing the QueryConverter) use the
backslash character for path queries and convert it later on.

Fixes #3566

[0]: https://github.com/pallets/flask/issues/900
 2020-04-27 13:36:36 +02:00
soergeld
f507f04639 reintroduce default arguments, adapt all occurences of TrackInfo and AlbumInfo to the absence of positional arguments 2020-04-27 11:21:13 +02:00
Adrian Sampson
47deb2f084 Switch log level for #3563, fix #3533 2020-04-23 08:03:51 -04:00
Michal Koutenský
5143e630d8 Fix #3533 - crash when calculating RG/R128 mix 2020-04-23 11:05:33 +02:00
Adrian Sampson
99dbe93f85
Merge pull request #3559 from somasis/master 
fetchart: improve description of -q flag
 2020-04-19 20:47:32 -04:00
Kylie McClain
1c03f58e0d
fetchart: improve description of -q flag 2020-04-19 14:56:15 -04:00
Ashhar Hasan
625e9253c0
Add tests for artist_sort as lyrics search fallback 
Adjust doc comment to highlight that artist_sort is used as a fallback
 2020-04-19 19:19:07 +05:30
Ashhar Hasan
45c8e51d6c
Fix redundant requests for artist == artist_sort 2020-04-19 19:14:00 +05:30
Ashhar Hasan
a5ef8c7b09
Add artist_sort as the last entry in the artists to search 
This will handle cases where the artist name includes some
characters which can cause a search failure for some
websites - mainly unicode.

Fixes https://github.com/beetbox/beets/issues/3340.
 2020-04-19 00:50:14 +05:30
Adrian Sampson
269e309513 Slight simplification for #3554 2020-04-17 18:28:21 -04:00
lijacky
9ec0d725e5 Changes given feedback on https://github.com/beetbox/beets/pull/3554 and trimmed sample html 2020-04-17 17:14:21 -04:00
lijacky
8e28f0b694 added null check for genius lyrics scrape 2020-04-16 19:06:17 -04:00
Jack Wilsdon
333d5d1dd3
fetchart: Add Last.fm artwork source 2020-03-30 20:20:59 +01:00
Xavier Hocquet
38ea35aa5e Lint 2020-03-28 11:44:56 -06:00
Xavier Hocquet
58bfe4567e Code review 2020-03-28 11:34:03 -06:00
Andrew Rogl
f306591a99 add the extra_tags option to all required plugins 2020-03-28 17:36:02 +10:00
Xavier Hocquet
1266a04998 Docs, lint, and cleanup beautifulsoup source check 2020-03-19 21:10:52 -06:00
Xavier Hocquet
306571883e Implement tekstowo lyrics provider 2020-03-18 23:00:51 -06:00
Justin Mayer
f465c90e78 Enforce PEP-8 compliance on Fish completion plugin 2020-03-04 07:15:46 +01:00
Justin Mayer
05db0d18eb Don't escape question marks in Fish completions 
Fish shell previously interpreted question marks as glob characters, but
that behavior has been deprecated and will soon be removed. Plus, the
completion for `help` and its alias `?` does not currently seem to behave
as expected anyway and is thus, at present, of limited utility.
 2020-03-04 07:15:46 +01:00
Justin Mayer
82c3867fc0 Rewrite Fish completion plugin docs & code comments 2020-03-04 07:15:46 +01:00
jmwatte
d2d2b646c1 Add plugin for Fish shell tab completion 2020-03-02 09:51:36 +01:00
Daniel Barber
fe8ba17ced Add quality setting to fetchart plugin 2020-02-22 13:36:35 -05:00
Daniel Barber
96b0e8a33e No longer need to pass a default quality here 2020-02-18 16:44:45 -05:00
Daniel Barber
036202e1c5 Default quality to 0 which means don't specify 
From the ImageMagick docs: "The default is to use the estimated quality
of your input image if it can be determined, otherwise 92."

In order to get the original behaviour we need to conditional add the
quality parameter to the `magick` call. The quality range can be
anything from 1 to 100, which gives us the convenience of using 0 to
specify no specific quality level.
 2020-02-18 14:50:57 -05:00
Daniel Barber
86946ad4b7 Allow the quality to be set for embedded/fetched cover art 2020-02-17 21:12:20 -05:00
Aidan Epstein
535af4bdb2 parentwork: Only call store when the metadata has changed. 
Otherwise, this rewrites all your files every time.
 2020-02-17 09:05:52 -08:00
Adrian Sampson
d43d54e21c Try to work around a Werkzeug change? 2020-02-06 22:22:54 -05:00
Adrian Sampson
91be732bf4 Fix whitespace (#3453) 2020-02-06 22:18:15 -05:00
Adrian Sampson
f9088a3eb7
Merge pull request #3453 from faulkt/master 
added merge_environment_settings call
 2020-02-06 21:54:14 -05:00
Tyler Faulk
964a6c2e63 restored whitespace to please style checker 2020-02-06 12:10:38 -05:00
ybnd
63ea17365a Modify patched stdout in test_malformed_output 2020-02-05 09:04:24 +01:00
ybnd
7005691410 Add comment to clarify unexpected AttributeError handling 2020-02-05 08:52:50 +01:00
ybnd
1ab46c69be Merge remote-tracking branch 'origin/master' into bs1770gain-v0.6.0-parsing 
# Conflicts:
#	docs/changelog.rst
 2020-02-05 08:45:30 +01:00
ybnd
9bd78424c1 Handle keyboard interrupts more cleanly 2020-02-04 19:16:33 +01:00
Adrian Sampson
95e0f54d7c Fix too-long lines (#3448) 2020-02-02 21:04:55 -05:00
Adrian Sampson
d4d04c61aa
Merge pull request #3448 from xhocquet/genius-lowercase-artist-fix 
Genius lyrics fix for API capitalization behaviors
 2020-02-02 20:46:24 -05:00
Xavier Hocquet
9f43408f1b Changelog and cleanup 2020-02-02 15:57:43 -07:00
ybnd
4970585b0a Remove temporary workaround for silent exceptions 2020-01-31 14:08:28 +01:00
ybnd
4a427182cd Handle exceptions in pooled threads 
* ExceptionWatcher instance running in parallel to the pool, monitoring a queue for exceptions
* Pooled threads push exceptions to this queue, log non-fatal exceptions
* Application exits on fatal exception in pooled thread

* More front end info logs in the CLI
 2020-01-31 13:50:38 +01:00
ybnd
bef473c8e8 Remove spliced progress regex and add --suppress-progress flag 2020-01-31 07:42:50 +01:00
ybnd
506be02597 Remove packaging dependency 2020-01-30 20:11:09 +01:00
ybnd
f51a68c7e1 Implement comments 2020-01-30 19:53:05 +01:00
ybnd
c3817a4c06 Implement review comments 
* safer version comparison

* regex bytes directly

* handle b'\x08 ...' case

* test_replaygain.py: injected command output should match the type of the actual output
 2020-01-30 19:21:53 +01:00
ybnd
65ffca215a Exception handling in main & worker threads 
* With `bs1770gain` installed the `Bs1770gainBackend` tests fail, but this should be fixed by https://github.com/beetbox/beets/pull/3480.
 2020-01-30 18:04:20 +01:00
ybnd
c1cb78c908 Small fixes in replaygain.Bs1770gainBackend and test_replaygain.py 
* Fix unspecified `gain_adjustment` when method defined in config

* Fix difference between dB and LUFS values in case of mismatched `target_level`/`method`:

  ```
  db_to_lufs( target_level <dB> ) - lufs_to_dB( -23 <LUFS> )
  ```

* Ignore single assertion in case of bs1770gain

(cherry picked from commit 2395bf224032c44f1ea5d28e0c63af96a92b96df)
 2020-01-30 17:59:57 +01:00
ybnd
c78afb1a97 Don't call bs1770gain outside of try statement 2020-01-30 17:02:28 +01:00
ybnd
53820c0a98 Handle bs1770gain v0.6.0 XML output 
* Remove `0%\x08\x08` from output (backspace code doesn't resolve; progress percentages get spliced in)

* Handle changed attributes/fields:
  * `sample-peak` attribute `factor` is called `amplitude` instead
  * Album summary is not included in a `summary` tag now, but in two separate `integrated` and `sample-peak` tags

* Handle `lu` attribute

* Get bs1770gain version
  * If v0.6.0 or later, add `--unit=ebu` flag to convert `db` attributes to LUFS
  * May be useful later on

### Output examples

Track:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
  <track total="1" number="1" file="02 tïtle 0.mp3">
    <integrated lufs="-70.00" lu="52.00"/>
    <sample-peak spfs="-72.28" amplitude="0.00"/>
  </track>
  <integrated lufs="-70.00" lu="52.00"/>
  <sample-peak spfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```

Album:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
  <track total="2" number="1" file="02 tïtle 0.mp3">
    <integrated dbfs="-70.00" db="52.00"/>
    <sample-peak dbfs="-72.28" amplitude="0.00"/>
  </track>
  <track total="2" number="2" file="02 tïtle 1.mp3">
    <integrated dbfs="-70.00" db="52.00"/>
    <sample-peak dbfs="-72.28" amplitude="0.00"/>
  </track>
  <integrated dbfs="-70.00" db="52.00"/>
  <sample-peak dbfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```
 2020-01-30 16:13:29 +01:00
ybnd
b903584163 Fix --threads argument handling 2020-01-30 13:31:14 +01:00
ybnd
b126ecafdd Clean up single/multithreaded execution selection logic 
As suggested in https://github.com/beetbox/beets/pull/3478#discussion_r372467445
 2020-01-30 12:38:20 +01:00
ybnd
0fede91bbd Workaround to pass ReplayGainLdnsCliMalformedTest.test_malformed_output ~ Python 3.8 2020-01-30 12:07:42 +01:00
ybnd
79c5535cf6 Open/close pool at begin/end of import session 2020-01-30 09:35:22 +01:00
ybnd
388d2d2c0d Consolidate ThreadPool checking, opening and closing into methods 2020-01-30 09:35:22 +01:00
ybnd
42e895c239 Match --jobs default & signature to that of convert plugin (--threads) 
And change local function `func` to `ReplayGainPlugin` method `replaygain_func` so that `self` is passed explicitly
 2020-01-30 09:35:22 +01:00
ybnd
d95bb5683b Analyze replaygain in parallel with multiprocessing.pool.ThreadPool 
* Add `--jobs` or `-j` to `replaygain`-> set the pool size
* Single-threaded execution by default, if `--jobs` is unset

* If multithreaded, calls `Backend.compute_album_gain` or `Backend.compute_track_gain` asynchronously with metadata storing/writing in the callback
 2020-01-28 21:20:21 +01:00
BrainDamage
f118314682 support for keyfinder-cli, which doesn't want the -f flag for paths 2020-01-14 05:07:33 +01:00
MrNuggelz
6d69d01016 added database changed event to subsonicplaylist 2020-01-13 15:43:20 +01:00
Adrian Sampson
a08f2315ea Simplify Confuse usage (#3463) 2019-12-26 20:44:14 -05:00
Mat
2593a5be34 Use a local var to use high resolution option 2019-12-26 21:55:48 +00:00
Mat
3570f5cd56 New high_resolution config option in fetchart 2019-12-26 17:36:56 +00:00
Cole Miller
e945ed894d
Add trailing comma 
Co-Authored-By: Adrian Sampson <adrian@radbox.org>
 2019-12-18 14:31:59 -05:00
Cole Miller
6c948764fe Wrap comment lines 2019-12-17 17:56:56 -05:00
Cole Miller
614289af5f Remove use of `list.clear()' for compatibility 2019-12-17 17:46:43 -05:00
Cole Miller
3ccafa2495 Fix `str.join' usage 2019-12-17 17:40:16 -05:00
Cole Miller
8805ba28fd Add comments 2019-12-17 16:33:41 -05:00
Cole Miller
02e03be93d Incorporate divisions into track titles 2019-12-17 15:38:54 -05:00
Cole Miller
e31695b606 Trace hierarchy of index tracks 2019-12-17 15:27:26 -05:00
Cole Miller
6889b9ffdc Add `index_tracks' configuration option 2019-12-17 13:43:53 -05:00
Tyler Faulk
a1af5d280e added merge_environment_settings call in fetchart plugin to handle connections with proxy servers 2019-12-10 22:54:31 -05:00
Adrian Sampson
9739e9be9b Docs tweaks for #3449 2019-12-09 15:55:31 -05:00
Jef LeCompte
89f21d9601
Updated documentation 2019-12-09 07:13:25 -05:00
Jef LeCompte
5a38e1b35c
Refactored token generation and updated comments based on suggestions. 
Also updated documentation to note the password options.
 2019-12-06 18:30:52 -05:00
Jef LeCompte
1690c08e77
Added URL to config and deprecated old configuration 2019-12-06 15:05:36 -05:00
Xavier Hocquet
c8e8e587f8 Add debug logger for Genius lyrics no-match 2019-12-05 20:06:49 -07:00
Xavier Hocquet
d43cf35ad2 Strip and lowercase Genius lyrics artist comparison 2019-12-05 20:06:46 -07:00
Aidan Epstein
9c479659b2 Increment playlist_version when a track is consumed. 
This fixes the playlist not updating when in consume mode, at least in
ncmpcpp.
 2019-11-24 19:27:09 -08:00
MrNuggelz
e9dee5dca8 added flag to delete old tags 2019-11-16 20:30:53 +01:00
MrNuggelz
bb305b17e1 set tags instead of creating m3u 2019-11-16 14:37:41 +01:00
Joris
ec696f5e58
Removed unused sanitize_path import 2019-11-11 10:48:29 +01:00
MrNuggelz
0191794285 subsonicplaylist plugin 2019-11-10 22:34:12 +01:00
msil
1f665b0290 adding discogs_labelid and discogs_artistid fields 2019-10-24 10:13:37 +00:00
Adrian Sampson
a7671e16a6 Merge pull request #3409 from jackwilsdon/hook-check-call 
hook: switch to using check_call
 2019-10-17 11:12:06 -04:00
Jack Wilsdon
430eab2cf0
Switch to using check_call for hooks 2019-10-17 11:00:59 +01:00
Austin Marino
c1b646ff27
Merge branch 'master' into Extended_Export_Plugin_Support 2019-10-15 15:35:42 -07:00
Austin Marino
7f6630c006 removed xml configs from doc and code 2019-10-15 14:16:23 -07:00
Adrian Sampson
3aa2c33ac6
Merge pull request #3406 from MrNuggelz/unimported 
unimported files plugin
 2019-10-15 17:13:31 -04:00
MrNuggelz
d11e14b1a0 improvements from review #2 2019-10-15 21:54:35 +02:00
Austin Marino
eb6055eeca Cleaned up comments and code 2019-10-15 11:45:01 -07:00
Joris
3d15eaff2e
Removed unused import 2019-10-15 16:35:21 +02:00
MrNuggelz
6be6ded022 don't list album art paths as unimported 2019-10-15 16:03:12 +02:00
MrNuggelz
c7e81d8b81 improvements from review 2019-10-15 15:32:50 +02:00
MrNuggelz
b6588edac5 unimported files plugin 2019-10-15 12:04:04 +02:00
Austin Marino
4251ff70dc updated the way in which xml is outputted 2019-10-15 00:15:45 -07:00
Austin Marino
0d818eced5 Ran test to ensure it works 2019-10-14 17:02:39 -07:00
Austin Marino
fa2c9ba259 Aligned export related code with flake8 standards 2019-10-13 11:36:33 -07:00
Austin Marino
ec705fae1e Updated documents and comments to reflcet recent code changes. Cleaned up code to better follow PEP-8 conventions and just work more efficiently all around. 2019-10-12 15:41:06 -07:00
Austin Marino
0e2c1e0d56 Made changes to reflect comments and suggestions made by sampsyo 2019-10-12 14:47:44 -07:00
Austin Marino
c31b488e54 Updated class fields to allow for easier unit testing 2019-10-10 19:35:49 -07:00
Austin Marino
a8a480a691 Updated config formats 2019-10-10 16:33:46 -07:00
Jack Wilsdon
d91da56745
Fix various typos 2019-10-10 08:50:09 +01:00
Austin Marino
e5b43d4bf4 Extended the file type export options to include not only JSON but also XML and CSV 2019-10-09 00:52:49 -07:00
Rahul Ahuja
32ea225fad Guard against "empty" albums 2019-10-05 23:12:53 -07:00
Rahul Ahuja
ce90b2aae5 Improve documentation 2019-10-05 15:07:20 -07:00
Rahul Ahuja
a7cdaac5f8 Consistent naming 2019-10-03 22:57:28 -07:00
Rahul Ahuja
0685305efb Only sync tracks in library 2019-10-03 22:53:35 -07:00
Rahul Ahuja
6c49afaf22 Better naming 2019-10-03 22:49:32 -07:00
Rahul Ahuja
ea03c7fac2 Better readability 2019-10-03 22:16:32 -07:00
Rahul Ahuja
5e6b8f5264 DRY album/track distances 2019-10-03 22:04:30 -07:00
Rahul Ahuja
14b8f30ead Appease flake8 2019-10-03 19:13:40 -07:00
Rahul Ahuja
a1885a571b Add documentation, fix circular import 2019-10-03 19:03:04 -07:00
Rahul Ahuja
f14137fcc2 Add BPSyncPlugin 2019-10-03 18:04:12 -07:00
Rahul Ahuja
3ffaaa1f37 Default bpm to None 2019-09-28 11:37:58 -07:00
Rahul Ahuja
7b9ebcbf2f Properly guard against None key 2019-09-27 17:48:28 -07:00
Rahul Ahuja
13792bd8ab Always set musical_key 2019-09-27 17:33:49 -07:00
Rahul Ahuja
4bc057fd5e Exclude invalid musical keys 2019-09-27 17:11:47 -07:00
temrix
dfb6fc3f5b
Test for presence and non-emptiness in one go. 2019-09-21 21:14:11 +02:00
temrix
9a4175dcd0
Return value directly. 2019-09-21 21:13:41 +02:00
temrix
f98010ad23
Add 'look before you leap' defensive code. 2019-09-21 16:09:08 +02:00
temrix
b4edc1f832
Add bpm, musical_key and genre to plugin. 2019-09-19 00:29:43 +02:00
Rahul Ahuja
ca5806fb6e Restrict country code to alpha characters 2019-09-15 16:34:20 -07:00
Rahul Ahuja
01e8643cec Revert to optional capturing group 2019-09-15 16:24:32 -07:00
Rahul Ahuja
a5fadf0dcc Integrate MetadataSourcePlugin 2019-09-15 15:59:24 -07:00
Rahul Ahuja
0b2837dd4f Revert Spotify, Discogs changes 2019-09-11 00:37:23 -07:00
Rahul Ahuja
6cfe7adb6c Use qualified import 2019-09-11 00:26:48 -07:00
Rahul Ahuja
ed80e915fe Move get_distance --> beets.plugins 2019-09-11 00:07:43 -07:00
Rahul Ahuja
876c0f733f Appease flake8 2019-09-10 23:52:35 -07:00
Rahul Ahuja
dfdf8ded33 Add missing import 2019-09-10 22:55:41 -07:00
Rahul Ahuja
84b13475e0 Move get_distance to beets.autotag 2019-09-09 19:13:24 -07:00
Rahul Ahuja
c531b1628e Avoid circular import 2019-09-09 18:28:20 -07:00
Rahul Ahuja
68e91b18b0 Fix discogs.py MetadataSourcePlugin refs 2019-09-09 17:33:42 -07:00
Rahul Ahuja
732e372ed2 Rename/move to plugins.MetadataSourcePlugin, fix formatting 2019-09-09 17:31:42 -07:00
Rahul Ahuja
0a700c75a2 Optional capturing groups 2019-09-07 01:07:44 -07:00
Rahul Ahuja
bdb7565500 Avoid nested capturing groups 2019-09-07 00:48:19 -07:00
Rahul Ahuja
4a6fa5657b Formatting 2019-09-06 13:11:28 -07:00
Rahul Ahuja
12a8e0a792 Fix Spotify API error formatting 2019-09-06 12:41:24 -07:00
Rahul Ahuja
0d6df42d5f Use Abstract Base Class 2019-09-06 12:08:26 -07:00
Rahul Ahuja
a3fb8ebfff Formatting 2019-09-04 22:56:09 -07:00
Rahul Ahuja
f7c6b5ba7f Fix str format arg order 2019-09-04 22:32:55 -07:00
Rahul Ahuja
30cfd7ff80 Use positional str.format arg 2019-09-04 21:18:07 -07:00
Rahul Ahuja
8010488f37 Modularize distance 2019-09-04 21:03:22 -07:00
Rahul Ahuja
1b05912ab9 Appease flake8 2019-09-04 20:39:46 -07:00
Rahul Ahuja
f64bd65ddb Remove unnecessary indexing 2019-09-04 20:11:30 -07:00
Rahul Ahuja
bd0cea9f1b Factor out APIAutotaggerPlugin 2019-09-04 19:50:04 -07:00
Rahul Ahuja
4a552595df Simplify regex match 2019-09-02 14:27:51 -07:00
Rahul Ahuja
9babce582d Fix track data enumeration idx 2019-09-01 21:24:56 -07:00
Rahul Ahuja
2ab883a20e Fix track.index assignment 2019-09-01 21:23:16 -07:00
Rahul Ahuja
70264ee6ee Handle empty deezer_id upfront 2019-09-01 21:18:08 -07:00
Rahul Ahuja
cd1aa3e8aa Avoid empty deezer_id string 2019-09-01 20:10:34 -07:00
Rahul Ahuja
43f09296c9 Fix AlbumInfo.album_credit assignment 2019-09-01 19:50:55 -07:00
Rahul Ahuja
2177c7695a Stringify Deezer ID 2019-09-01 19:44:27 -07:00
Rahul Ahuja
790ca805d5 Formatting 2019-09-01 18:34:06 -07:00
Rahul Ahuja
2cf55ee893 Add deezer.rst doc, remove unused options 2019-09-01 18:33:27 -07:00
Rahul Ahuja
804397bb12 Appease flake8 2019-09-01 18:13:19 -07:00
Rahul Ahuja
6e5e8a9cb0 Add Deezer plugin 2019-09-01 17:53:56 -07:00
Vexatos
7aab50b7b8
convert: Reduce amount of duplicate code for linking. 
Also slightly reworded documentation.
 2019-08-21 12:19:47 +02:00
Vexatos
aeb7d8846e
convert: disable album-art embedding for linked files. 
Fixed flag precedence of link and hardlink over their options.
Fixed formatting issue.
 2019-08-20 16:40:02 +02:00
Vexatos
a61aa74061
convert: add option to hardlink instead of copying. 
Overrides the --link option.

As proposed in #2324.
 2019-08-20 16:07:01 +02:00
Kier Davis
4820cee35c
convert: add option to symlink instead of copying 
As proposed in #2324.

Updated commit from #2326.

Co-authored-by: Vexatos <stuarzt@gmx.de>
 2019-08-20 14:50:44 +02:00
Sebastian Pucilowski
a2ee8da8d6 Refactor magic values in discogs_client 2019-08-11 11:21:22 +10:00
Rahul Ahuja
7ec3632309 Fix year assignment with year-only release date 2019-08-03 19:07:56 -07:00
Samuel Nilsson
6e24669d61 Fix #3341 2019-08-03 22:51:40 +02:00
Guilherme Danno
4908028985
Use the 'resource_url' from discogs_client 2019-07-30 16:46:59 -03:00
Samuel Nilsson
60c174101f ffmpeg replaygain backend: Only calculate replaygain for audio stream. Fixed documentation for backend option. 2019-07-29 10:32:19 +02:00
Zsin Skri
e3645dfd59
Merge branch 'master' into r128-targetlevel-config 2019-07-25 23:22:32 +02:00
Zsin Skri
a9f70f8151 apply suggested improvements 
Apply improvements suggested in GitHub PullRequest #3065:
- be idiomatic
  - 0 is falsy
  - check enum equality, not identity
  - mutate list by constructing a new one
- improve documentation
  - fix a typo
  - do not mention deprecation of a config option
 2019-07-26 01:02:03 +02:00
Adrian Sampson
84032e56e2 Merge pull request #3334 from MartyLake/martylake_add_forward_slash_option 
Add option to force forward slashes in paths
 2019-07-24 22:11:59 -04:00
Paul Malcolm
5f9a394ca9 Issue #2860 Fetch more acousticbrainz fields 2019-07-23 20:25:26 -04:00
MartyLake
076a82daa6 Review: Rename method 2019-07-24 00:09:52 +02:00
MartyLake
ee7f939336 Review: Remove stray blank line 2019-07-23 23:53:50 +02:00
MartyLake
aa1da3166f Review: Remove unnecessary parens 2019-07-23 23:53:17 +02:00
MartyLake
dd9de05968 Review: Remove unnecessary split of concat 2019-07-23 23:50:20 +02:00
MartyLake
da864402d5 Review: Remove unnecessary get 2019-07-23 23:49:17 +02:00
MartyLake
d1ba309f36 Add a new method that copied pathlib.path.as_posix 2019-07-23 17:17:40 +02:00
Zsin Skri
e7e2c424e7 replaygain: targetlevel and peak_method depends on tag format 
Allow to configure the target level for R128_* tags separately from REPLAYGAIN_*
tags and skip peak calculation for R128_* tags if possible.
 2019-07-22 13:42:22 +02:00
Zsin Skri
0c8eead459 replaygain: pass target_level and peak to backends 
Configure the replaygain analysis by passing arguments to the Backends. This
avoids the difference between ReplayGain and EBU r128 backends; every Backend
can now fulfil both tasks. Additionally it eases Backend development as the
difference between the two tag formats is now completely handled in the main
Plugin, not in the Backends.
 2019-07-22 12:58:54 +02:00
Zsin Skri
e5f2fe6fd3 avoid test failure 
Use the POSIX character class instead of `\s` to match all whitespace in a
regular expression describing the language of valid inputs, in order to avoid a
test failure for the invalid escape sequence `\s` in Python strings.
 2019-07-21 01:28:16 +02:00
Zsin Skri
f9ff56f496 improve wording in the ffmpeg replaygain backend 
This commit mostly addresses feedback:
- remove some unused parenthesis
- fix a typo
- expand some docstrings
- document that ffmpeg is usually easy to install
 2019-07-21 01:18:49 +02:00
Zsin Skri
271a3c980c replaygain: ffmpeg: increase parser readability 
Use keyword arguments to make the ffmpeg parser more readable.
 2019-07-19 21:54:47 +02:00
Zsin Skri
c3af5b3763 replaygain: add ffmpeg backend 
Add replaygain backend using ffmpeg's ebur128 filter.

The album gain is calculated as the mean of all BS.1770 gating block powers.
Besides differences in gating block offset, this should be equivalent to a
BS.1770 analysis of a proper concatenation of all tracks.

Just calculating the mean of all track gains (as implemented by the bs1770gain
backend) yields incorrect results as that would:
- completely ignore track lengths
  - just using length in seconds won't work either (e.g. BS.1770 ignores
    passages below a threshold)
- take the mean of track loudness, not power

When using the ffmpeg replaygain backend to create R128_*_GAIN tags, the
targetlevel will be set to -23 LUFS. GitHub PullRequest #3065 will make this
configurable.
It will also skip peak calculation, as there is no R128_*_PEAK tag.

It is checked if the libavfilter library supports replaygain calculation. Before
version 6.67.100 that did require the `--enable-libebur128` compile-time-option,
after that the ebur128 library is included in libavfilter itself. Thus we
require either a recent enough libavfilter version or the `--enable-libebur128`
option.
 2019-07-19 21:54:47 +02:00
Zsin Skri
7a7314ee3f Allow other ReplayGain backends to support R128. 
Previously using EBU R128 forced the use of the bs1770gain backend.
This change adds a whitelist of backends supporting R128. When the configured
backend is in that list it will also be used for R128 calculations. Otherwise
bs1770gain is still used as a default.

This should not change the overall behaviour of the program at all, but allow
for further R128-supporting backends to be added.
 2019-07-19 21:54:47 +02:00
Zsin Skri
30395911e2 util.command_output: return stderr, too 
Return a namedtuple CommandOutput(stdout, stderr) instead of just stdout from
util.command_ouput, allowing separate access to stdout and stderr.

This change is required by the ffmpeg replaygain backend (GitHub
PullRequest #3056) as ffmpeg's ebur128 filter outputs only to stderr.
 2019-07-14 18:32:59 +02:00
Adrian Sampson
e39341b282 Merge pull request #3322 from thedevilisinthedetails/master 
465 discogs: Fetch a few more metadata fields
 2019-07-01 17:22:50 -04:00
Peter
0cd46dab77 fixing per review comments 2019-07-01 21:04:35 +02:00
Peter
dd7e932a9a removing print log 2019-06-30 14:34:13 +02:00
Peter
e196c1dae6 fixing test 2019-06-30 13:54:38 +02:00
Peter
510276f653 fixing test 2019-06-30 13:44:13 +02:00
Adrian Sampson
73f8edd116 Simplify force check (#3318) 2019-06-27 22:44:57 -04:00
Adrian Sampson
0726123e41 Move PROBE_FIELD to module scope (#3318) 2019-06-27 22:43:18 -04:00
Susanna Maria
b20516e552 Small improvement of code doc 2019-06-26 20:29:17 +02:00
Susanna Maria
cab97c58d4 Pep8 drives me sometimes crazy 2019-06-25 20:57:43 +02:00
Susanna Maria
932d18a838 Pep8 error ... 2019-06-25 20:37:12 +02:00
Susanna Maria
f254b33c6e Findings from PR 2019-06-25 20:22:26 +02:00
Susanna Maria
6e179d86e6 Pep8 bugfix 2019-06-23 17:43:40 +02:00
Susanna Maria
0242176b40 Why binary import of json? 2019-06-23 16:59:33 +02:00
Susanna Maria
1643eea3f5 Parameter handling 2019-06-23 13:04:17 +02:00
Zsin Skri
f645400c5e replaygain: adapt to mediafile commit 95e569a 
Since commit 95e569a, mediafile takes care of the float -> Q7.8 conversion in
R128 GAIN tags by itself.

From `store_album_r128_gain` this conversion was already missing, remove it from
`store_track_r128_gain`, too.

fixes #3311
 2019-06-18 23:17:38 +02:00
Peter
90cf579ee3 adding genre, released_date and discogs_release_id 2019-06-16 21:55:35 +02:00
Adrian Sampson
7dd0ed77f9 Merge pull request #3302 from Holzhaus/fix-3301 
beetsplug/importadded: Add missing path kwarg to update_after_write_time()
 2019-06-11 11:50:36 -04:00
Adrian Sampson
ed30a7aed2 Merge pull request #3251 from thedevilisinthedetails/master 
#2579 Adding styles to discogs plugin
 2019-06-10 13:26:09 -04:00
Peter
7ec1fc934b removing unneeded condition 2019-06-10 15:54:19 +02:00
Peter
9bdadc5c73 removing extra line 2019-06-10 09:33:10 +02:00
Peter
55e003a3d4 fixing per review comments 2019-06-10 09:11:38 +02:00
Peter
f0c91b8f45 fixing per review comments 2019-06-09 20:01:55 +02:00
Peter
2c49c12166 fixing per review comments 2019-06-09 15:44:37 +02:00
Peter
5fc21a1e21 fixing per review comments 2019-06-09 15:39:49 +02:00
Peter
851c413976 adding config option for seperator and addressing review comments 2019-06-09 10:37:33 +02:00
Adrian Sampson
9fcb66b3c8 Nicer string wrap 2019-06-08 21:35:56 -04:00
Adrian Sampson
c2fdf04539 Merge pull request #3279 from dosoe/beets_parentwork_3 
add parentwork plugin
 2019-06-08 21:35:05 -04:00
Dorian Soergel
9d184e3cad docstrings and style 2019-06-08 22:58:05 +02:00
Dorian Soergel
fd14b5b649 docstrings and style 2019-06-08 22:55:05 +02:00
Dorian Soergel
c96dcfffb6 docstrings and style 2019-06-08 22:44:33 +02:00
Adrian Sampson
f865fc00cd replaygain: Fix py3 crash in audiotools backend 
Fixes #3305.
 2019-06-08 16:23:49 -04:00
Samuel Nilsson
b8b99d9396 Merge branch 'master' into replaygain 2019-06-08 16:15:27 +02:00
Dorian Soergel
070f50e1e7 docstring 2019-06-07 17:16:03 +02:00
Dorian Soergel
eacdb0d0e4 refetching works moved to new PR 2019-06-07 17:15:04 +02:00
Dorian Soergel
9c3c538dfb alternative way to refetch parent works 2019-06-07 16:51:33 +02:00
Dorian Soergel
765f7dc12d first try to implement event handler 2019-06-07 14:57:38 +02:00
Jan Holthuis
2b00e1de24 beetsplug/importadded: Add missing path kwarg to update_after_write_time() 
This resolves #3301.
 2019-06-07 14:17:39 +02:00
FichteFoll
728203e15a
beets.io now supports HTTPS 
See https://github.com/beetbox/beets/pull/3297.
 2019-06-06 15:34:15 +02:00
FichteFoll
9631616b53
Replace a couple URLs that don't point to anything 
I'm unsure regarding the pygst tutorial, so I just added another URL
of the best resource I could find with a quick web search.
 2019-06-05 23:08:18 +02:00
FichteFoll
c144141e9a
Update a few more http URLs to https that I missed 
Should really be all now (pending the next commit).
 2019-06-05 23:07:11 +02:00
FichteFoll
1a23eab8b6
Use https for lyrics.wikia.com, when supported 2019-06-05 23:00:52 +02:00
FichteFoll
670046dd9a
Build https URLS for beatport releases 
I'm not sure where these are used, but the website supports https and
the API url already uses https, so this should be a safe call and not
require a util.SNI_SUPPORTED check.
 2019-06-05 22:55:12 +02:00
Dorian Soergel
1d9e42567b flake8 2019-06-05 13:40:04 +02:00
Dorian Soergel
fae0656935 still dealing with cases where no parent composer 2019-06-05 13:39:13 +02:00
Dorian Soergel
8363dedaeb logging and minor comments 2019-06-05 11:10:11 +02:00
FichteFoll
aa31fea037
Update a lot of URLs to use HTTPS 
*All* URLs were checked manually, but only once per domain!

I mostly concerned myself with URLs in documentation rather than source
code because the latter may or may not have impactful changes, while the
former should be straight forward.

Changes in addition to simply adding an s:

- changed pip and pypi references as their location has changed
- MPoD (iOS app) url redirects to Regelian, so I replaced those
- updated homebrew references

Notable observations:

- beets.io does have HTTPS set up properly (via gh-pages)
- beatport.py uses the old HTTP url for beatport
- as does lyrics.py for lyrics.wikia.com
- https://tomahawk-player.org/ expired long ago, but the http page
  redirects to https regardless
- none of the sourceforge subdomains have https (in 2019!)
 2019-06-05 03:11:49 +02:00
FichteFoll
e17c478f74 Cache an item's album with a property 
Use Album.load() whenever the album is requested, which causes it to be
reloaded from the database.

Drawback: This adds a slowdown of 100% (6.2s to 12.6s) to `beet list`
on my setup.
 2019-06-05 02:39:56 +02:00