dosoe
23f172d03d
if there is no artist_sort, there should not be a composer_sort.
2017-04-28 13:49:50 +02:00
dosoe
4a17da8e10
requested changes: where there is no artist_sort, there is no need for composer_sort; cleaning up whitespaces.
2017-04-28 13:41:54 +02:00
dosoe
d4ff82e46f
adding image stuff for composer_sort
2017-04-28 12:45:31 +02:00
dosoe
e3c37981bb
little indentation stuff
2017-04-28 12:13:27 +02:00
dosoe
c51ecd46e3
add composer_sort tag#
2017-04-28 12:10:02 +02:00
discopatrick
50a2e37a4d
Keep function names lowercase to pass flake8 tests
2017-04-27 15:58:08 +01:00
discopatrick
6e6dd76513
Remove space separator tests from test_x_precision_intervals tests
...
This is not the correct place for space separator tests. Each test
should test one thing only. Space separator tests are now in a separate
test case.
2017-04-27 11:36:03 +01:00
discopatrick
5a3b74f681
Test an invalid datetime separator raises error
2017-04-27 11:29:45 +01:00
discopatrick
1ab913b200
Test each valid datetime separator
2017-04-27 11:28:10 +01:00
discopatrick
24890c77f1
Add a date query precision of ‘second’
2017-04-27 00:24:17 +01:00
discopatrick
02bd19fb32
Allow minute precision queries to use space separator
2017-04-27 00:06:36 +01:00
discopatrick
c3771f722c
Allow hour precision queries to use space separator
2017-04-27 00:04:46 +01:00
discopatrick
b8e1c5675e
Fix tests
2017-04-25 02:25:50 +01:00
discopatrick
ba324df0d1
Add a date query precision of ‘minute’
2017-04-25 01:38:31 +01:00
discopatrick
5f2c47ec18
Test further hour precision intervals
2017-04-25 01:38:31 +01:00
discopatrick
61b832990f
Add a date query precision of ‘hour’
2017-04-25 01:38:24 +01:00
discopatrick
58417526cb
Rename InvalidQueryArgumentTypeError to InvalidQueryArgumentValueError
...
The way we use `InvalidQueryArgumentTypeError` is more akin to a `ValueError` than a `TypeError`. For example, we try to parse a string as an int, float, or date, but the parsing fails - there was nothing wrong with the type of the variable (string), but its contents were not parseable into the type we wanted - there was a problem with the value of the string.
2017-04-22 18:07:30 +01:00
Adrian Sampson
78f19db511
Merge pull request #2521 from tweitzel/master
...
add --yes argument to play command
2017-04-19 18:59:50 -04:00
xarph
02aa6191c1
rename --force to --yes in play plugin
...
fix some pep8 goo
2017-04-19 10:51:44 -07:00
Adrian Sampson
31c7330de4
Merge pull request #2517 from discopatrick/date-value-field-validation
...
Date value field validation
2017-04-19 11:36:18 -04:00
xarph
ffcaf33845
add -f argument to play command
2017-04-18 15:30:24 -07:00
Adrian Sampson
0cbb40869a
Merge pull request #2403 from antlarr/master
...
Run python2 or python3 depending on what's being used
2017-04-15 11:28:45 -04:00
Adrian Sampson
fb7296711c
Fix Windows encoding in convert stub ( #2516 )
2017-04-15 11:27:19 -04:00
discopatrick
d466f8802c
passes flake8
2017-04-14 14:45:51 +01:00
discopatrick
ff4c0abcf1
tests ‘added’ instead of ‘mtime’ , and uses a correct date format
2017-04-14 13:05:13 +01:00
discopatrick
ed0ea1dee5
tests more invalid date queries
2017-04-14 01:49:58 +01:00
discopatrick
8e6909bf4b
raises error when date string has too many components
2017-04-14 01:32:18 +01:00
discopatrick
a3251ef7c6
skips tests for now
2017-04-14 01:13:02 +01:00
discopatrick
1744ca6e88
raises error when dates passed to query as long numbers
2017-04-14 00:40:06 +01:00
Antonio Larrosa
85e0c0dcee
Fixed E501 and E305 PEP8 errors
2017-04-04 09:08:30 +02:00
Antonio Larrosa
fa468ce9d1
Properly quote executable and command line parameter
...
Use shlex.quote (on python3) or pipes.quote (on python2) to properly
quote the python executable and parameter instead of using single quotes
2017-04-04 09:08:30 +02:00
Antonio Larrosa
44ddd2e8f5
Shell-escape sys.executable
...
sys.executable needs to be shell-escaped on windows.
2017-04-04 09:08:30 +02:00
Antonio Larrosa
42b4e54391
Use sys.executable instead of composing the executable name
...
Better use sys.executable than using sys.version_info.major and compose
the name of the python executable.
2017-04-04 09:08:30 +02:00
Antonio Larrosa
1e4378d636
Run python2 or python3 depending on what's used
...
On a system with dependencies installed for python3 but not for python2,
we have to make sure python3 is used everywhere since 'python' might be running
the python2 interpreter.
This helps with some problems in #2400 , but doesn't fix the issue completely.
2017-04-04 09:08:30 +02:00
Aaron
64d69f0817
embedart: Added test case for inputting “no” option interactively.
2017-03-10 23:30:49 -08:00
Aaron
f6df3befac
Added interactive test method for embedart plugin.
2017-03-08 19:06:09 -08:00
Adrian Sampson
5a71ce722a
Simplify embedart test changes for #2422
...
Whenever possible, it's nice to avoid using DummyIO---it can make debugging
difficult.
2017-03-06 23:55:14 -05:00
Adrian Sampson
74df2788c0
Merge branch 'master' into Stunner-master
2017-03-06 23:51:10 -05:00
Adrian Sampson
17ad3e83db
Test updates for #2466 fix
2017-03-03 12:10:26 -06:00
Aaron Jubbal
864aa11ec5
Merge branch 'master' into master
2017-02-21 04:43:45 -08:00
Jacob Gillespie
1fd22604fb
Fix linter issues
2017-02-19 17:33:26 -06:00
Jacob Gillespie
902b955696
Fix test_hardlink_arrives
2017-02-19 17:22:01 -06:00
Jacob Gillespie
ccd0f5d129
Remove not-found hardlink test (the OS prevents this from happening)
2017-02-19 17:19:42 -06:00
Jacob Gillespie
b4efecb709
Add option to hardlink when importing
2017-02-19 15:56:13 -06:00
Aaron
d1ac893915
Style changes to pass PEP8 tests.
2017-02-13 01:58:31 -08:00
Aaron
9c97f95073
Updated embedart test cases to accomodate confirmation prompt.
2017-02-13 01:58:31 -08:00
euri10
d2cd4c0f21
Change relative date's format to further simplify it
...
A relative date doesn't need to be prefixed by @ anymore.
The relative date pattern now displays named groups.
Digits have been change to [0-9] to avoid other digit characters.
Removed the @ character in tests.
Updated subsequent documentation.
2017-01-31 16:56:03 +01:00
wordofglass
c252b9256b
Merge pull request #2415 from beetbox/fetchart_cleanup
...
fetchart: Clean-up data structures
2017-01-30 10:18:33 +01:00
wordofglass
7c79d8ce89
fetchart: minor restructuring of tests.
2017-01-30 10:01:19 +01:00
euri10
e4a7d37a6d
implementing changes asked
...
corrected rst
fixed flake8 in test
2017-01-29 11:49:22 +01:00
euri10
d48d1f8e3c
fixed E226 flake8
2017-01-29 03:54:10 +01:00
euri10
af679de8ec
using a pattern may avoid copy-paste error when used 3 times after
...
fixed an error with the weeks that didn't use the sign correctly
added more tests, this is where py.test fixtures would shine
2017-01-29 03:51:24 +01:00
euri10
3e76c219fb
without dateutil
2017-01-28 22:39:37 +01:00
euri10
2b89b90ab6
tests flake8 fixed I think finally
2017-01-28 21:47:01 +01:00
euri10
8d054f3656
tests flake8 issues
...
added some doc
2017-01-28 21:40:26 +01:00
euri10
868746bb51
tests
2017-01-28 21:23:03 +01:00
wordofglass
bc582701ff
fetchart: Internally pass settings in a cleaner way.
...
Dump the 'extra' dictionary which only duplicated attributes of the
plugin onject in favor of passing a reference to the plugin directly.
2017-01-25 00:01:05 +01:00
Adrian Sampson
3a6967eb7a
Remove dependencies from convert_stub.py
...
See: https://github.com/beetbox/beets/pull/2403#issuecomment-274358494
2017-01-22 12:59:04 -08:00
diomekes
04f7915d41
change no-bracket argument from white space to empty
2017-01-20 22:47:47 -05:00
diomekes
eaa2161a90
fix empty disambig string test
2017-01-20 19:40:09 -05:00
diomekes
d10df34c65
add test for aunique without brackets
2017-01-20 09:06:38 -05:00
diomekes
3a967df396
simplify check for empty disam_val, update changelog and docs, add change bracket test
2017-01-19 20:41:44 -05:00
diomekes
377a2a6964
add bracket argument to aunique
2017-01-19 20:39:12 -05:00
Steve Johnson
e3707e45f3
Maybe fix code and tests for Windows
2017-01-15 11:21:59 -08:00
Steve Johnson
6b7a6baaf2
Add test for /item/path/ endpoint
2017-01-15 11:21:59 -08:00
Steve Johnson
05bc4996a8
Rename and invert new config option
2017-01-15 11:21:33 -08:00
Steve Johnson
cedd93b778
Add tests for exclude_paths_from_items
2017-01-15 11:21:33 -08:00
Adrian Sampson
0f1a93c666
Add missing unittest suite declaration ( #2389 )
2017-01-14 17:33:36 -08:00
Adrian Sampson
703f47ae97
Use flexible attribute for track_alt
...
No need for a built-in field for a simple string-type optional field like
this.
2017-01-10 21:01:36 -05:00
Mike Cameron
bba5a7c712
Fixed (?) failing test where
...
umber was rack_alt was missing during import.
2017-01-10 19:08:18 -05:00
Mike Cameron
3cd4f1c091
Fixed failing test where track number was missing from mocked data.
2017-01-10 18:57:42 -05:00
Mike Cameron
3f67a27989
Fixed failing test because mocked data was missing property
...
umber.
2017-01-10 18:21:28 -05:00
Adrian Sampson
f7ebf5524f
flake8 fix for #2379
2017-01-10 13:25:24 -05:00
Adrian Sampson
f137f87878
More test docs about the image.* mixin
2017-01-10 12:41:34 -05:00
Adrian Sampson
5863859a5d
Remove image tests for DSF ( #2379 )
...
There isn't currently an `image.dsf`, so those tests fail.
2017-01-10 12:38:44 -05:00
Adrian Sampson
5e20cfd26e
flake8 fixes for 2379
2017-01-10 12:33:23 -05:00
Adrian Sampson
96350ab7db
Merge pull request #2379 from docbobo/feature/dsf-support
...
Support for DSF files
2017-01-10 12:28:29 -05:00
Boris Pruessmann
e0a4dc67a8
Test improvements for DSF.
...
- Fixed unparseable.dsf
- Added DSF feature detection to test_mediafile.py
2017-01-10 11:21:40 +01:00
Adrian Sampson
a2d37dd588
Document how to add tests for a new format ( #2379 )
2017-01-09 13:02:28 -05:00
Boris Pruessmann
1e10e62d82
Added DSF to test_mediafile
2017-01-09 18:54:30 +01:00
Adrian Sampson
e5e710033c
Remove old test for misspelled config option
...
See 6b9d766 , which removed the option.
2017-01-07 17:19:02 -05:00
Adrian Sampson
fbc0f322f6
Merge branch 'tigranl-https_fix'
2017-01-02 20:54:17 -05:00
Adrian Sampson
33a8e81f08
Simplify test changes
...
We don't need quite so many checks now that SSL isn't conditional most of the
time.
2017-01-02 20:49:12 -05:00
Diego M. Rodriguez
37cb1c295f
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
...
Conflicts:
docs/changelog.rst
test/test_discogs.py
2016-12-30 10:42:50 +01:00
Diego M. Rodriguez
0a9cb1fd3d
discogs: revise subtrack merging based on subindex
...
Modify the coalescing of subtracks by taking into account the subindices
of the subtracks for deciding if they represent "logical" tracks
(merging them into one single track, as previously) or if they represent
physical tracks (treating them as individual tracks).
Add unit tests for nested logical/physical subtracks, and disc titles.
2016-12-29 18:03:54 +01:00
Diego M. Rodriguez
4364757fcc
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
...
Conflicts:
docs/changelog.rst
2016-12-29 13:27:06 +01:00
Diego M. Rodriguez
30f238151e
discogs: additional sanity checks parsing release
...
Add extra checks for the presence of specific field (artists, title,
id, tracklist) when parsing a Release from discogs, failing gracefully
if the fields could not be found.
Add a test for releases without required fields.
2016-12-29 13:19:01 +01:00
Diego M. Rodriguez
02666424d4
discogs: improve robustness when parsing an album
...
Improve the robustness of `get_album_info()` by preferring the use of
`get()` over accesing the dictionary keys directly for several fields,
plus adding extra checks for fields that depend on nested containers on
the Release data.
Add a test for parsing a release that contains a minimal amount of
fields.
2016-12-28 21:07:18 +01:00
Adrian Sampson
8763be5423
Revert "Fix tests for new prompt order"
...
This reverts commit a357cc4e1a .
We no longer need the tests to change---I was able to fix the order by
bringing the "abort" action into the standard list of options.
2016-12-28 14:33:11 -05:00
Adrian Sampson
a357cc4e1a
Fix tests for new prompt order
2016-12-28 14:23:22 -05:00
Adrian Sampson
7c6eafa285
Refactor manual search options to use Proposal
...
This is the first step to making them behave like plugin actions.
2016-12-28 13:50:53 -05:00
Adrian Sampson
8408264142
Update test file for new set of tags
...
The new MediaFile tags in #2333 mean that the `test_unicode_path` test will
write new tags to this test fixture file.
2016-12-26 17:41:44 -05:00
Josh Brown
7833469261
add confirmation for empty query
2016-12-26 14:13:01 -06:00
Josh Brown
2903925e2f
Rewrite zero plugin manual mode
2016-12-26 13:34:34 -06:00
Josh Brown
ef80229350
additional zero tests
2016-12-26 12:10:19 -06:00
Josh Brown
4cc4fe1290
added zero subcommand
2016-12-26 12:10:18 -06:00
nathdwek@laptop
7de97df209
Zero: rewrite tests.
...
Rely on plugin interface only.
Unregister listeners by hand for the moment.
2016-12-25 17:10:16 +01:00
Adrian Sampson
10f0d03d79
Test "true" FLAC bitrate from Mutagen 1.35
...
Fix #2343 .
2016-12-23 20:23:23 -05:00
Shen-Ta Hsieh
7060b512b8
Add Composer, Lyricist and Arranger tags
...
MusicBrainz provids composer, lyricist and arranger infomations related
to individual recordings. This commit adds query parameters to fetch them, and
write down to media files.
Tagging mapping is implemented according MusicBrainz Picard's data:
https://picard.musicbrainz.org/docs/mappings/
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
2016-12-21 01:52:42 +08:00
tigranl
0868299e92
PEP8 corrections
2016-12-10 20:08:27 +03:00