Commit graph

9622 commits

Author SHA1 Message Date
Jacob Pavlock
cb4bab175a fix link to contributing page in readme 2020-07-20 19:56:05 -07:00
Jacob Pavlock
f677fd2407 add testing wiki to contributing.rst 2020-07-20 19:56:05 -07:00
Jacob Pavlock
66e6af48be add table of contents to contributing.rst 2020-07-20 19:56:05 -07:00
Jacob Pavlock
2982f245e1 add CONTRIBUTING.rst to the docs 2020-07-20 19:56:05 -07:00
Jacob Pavlock
faa5553468 convert CONTRIBUTING.md to rst 2020-07-20 19:46:12 -07:00
jtpavlock
c5b82e0134
Merge pull request #3679 from beetbox/jtpavlock-patch-1
Adjust wording of CONTRIBUTING.md
2020-07-20 17:22:49 -07:00
jtpavlock
b309ed95c2 Remove duplicate forum mention
Forums are already mentioned in the 'Contact' section
2020-07-20 17:18:17 -07:00
jtpavlock
c1b9e99722
maintainers *will* reciprocate respect :) 2020-07-20 19:07:32 -05:00
jtpavlock
5544c7a881
Fix wording 2020-07-20 19:04:44 -05:00
jtpavlock
426cb08003
fix CONTRIBUTING.md link and spelling 2020-07-20 19:02:38 -05:00
jtpavlock
335776ff30
Merge pull request #3666 from jtpavlock/flake8-errors
Unignore flake8 E221, E226, E242, E704
2020-07-20 12:24:52 -07:00
jtpavlock
62ce5d15db
add contributing.md & update readme (#3643)
* add contributing.md & update readme

* add for developers section of docs to contributing.md

* remove relative wiki links

* readme spelling fix

* clarify discourse/docs idea for user 'recipes' to get featured

* remove coveralls from testing section

* fix api links & clarify docstring standard

* Contributing -> Contribute

* remove manual pip module installation instructions

* add link to testing wiki page on "how to contribute"

* add databse access examples

* added voting clarification

* Rename contributing.md to CONTRIBUTING.md

* remove out of date info

Includes references to gitter, the old 'good first issue' label and also
some updates to testing.

* No need for backticks around beets

We usually just typeset it as an ordinary noun, not as code. :)

* Whitespace

* End-to-end CONTRIBUTING pass

Co-authored-by: Adrian Sampson <adrian@radbox.org>
2020-07-20 10:12:34 -05:00
jtpavlock
441cfebff1
add .venv/ to gitignore
.venv/ is recommended via https://docs.python.org/3/library/venv.html
2020-07-19 13:25:55 -05:00
José Albornoz
dc7e433768
Fix thumbnail plugin pathlib bug (#3360)
PathlibURI.uri() would fail if given a path as bytes instead of as string.

Co-authored-by: Jacob Pavlock <jtpavlock@gmail.com>
2020-07-15 21:00:50 -05:00
Adrian Sampson
05516f9503 Thanks & bug number for #2554 2020-07-14 06:59:48 -04:00
Adrian Sampson
8537d1e36d Merge pull request #2554 from musoke/python3-plugin-ipfs
compatibility of IPFS plugin with Python 3
2020-07-14 06:58:20 -04:00
jtpavlock
d9272fcb88
fix integration test job name 2020-07-13 14:20:20 -05:00
Adrian Sampson
9c054e9588
Merge pull request #3668 from wisp3rwind/pr_fix_bad_triggers
Fix a regression in the heuristic for detecting valid lyrics from the google source
2020-07-12 16:46:46 -04:00
wisp3rwind
44e4d558c9 lyrics: fix bad_triggers in the google plugin
regression from 117d16f
2020-07-12 22:23:17 +02:00
Jacob Pavlock
52afd717aa remove docstring-convention and update comment 2020-07-11 19:10:04 -07:00
Jacob Pavlock
124c882b4d un-ignore E221 2020-07-11 18:33:08 -07:00
Jacob Pavlock
abad0f9c08 un-ignore flake8 E226, E242, E704
none of these required any code changes
2020-07-11 18:22:43 -07:00
Jacob Pavlock
1db46dfeb6 reformat flake8 errors 2020-07-11 18:15:41 -07:00
jtpavlock
16fddbaef6
add line break to stale-bot comments 2020-07-11 17:27:37 -05:00
jtpavlock
cc9f4ab251
Add a stale-bot (#3659)
will apply the `stale` label to any issues and pull requests with >60/120 days inactivity respectively
2020-07-11 15:59:34 -05:00
Adrian Sampson
97378c6c90
Merge pull request #3418 from RollingStar/patch-1
Clarify getitem docstring. Log when falling back.
2020-07-11 10:04:42 -04:00
Adrian Sampson
d230b3b870 Roll back logging changes 2020-07-11 10:04:00 -04:00
jtpavlock
8b8156c493
Merge pull request #3661 from jtpavlock/testing-cleanup
Testing cleanup & nose -> pytest
2020-07-09 18:53:09 -05:00
Jacob Pavlock
f6855cb284 add py_colors to all github workflows 2020-07-07 19:58:27 -07:00
Jacob Pavlock
7280ab2be0 remove nosetest.xml from .gitignore 2020-07-07 19:54:12 -07:00
Jacob Pavlock
7427bfbc58 clean github workflows 2020-07-07 19:54:01 -07:00
Jacob Pavlock
f2e7b3fdd7 remove references to nose 2020-07-07 15:28:38 -07:00
Jacob Pavlock
d5e5be5c8e simplify tox.ini 2020-07-07 15:05:40 -07:00
Jacob Pavlock
25c6843c28 classify integration tests in test_parentwork.py 2020-07-07 15:05:21 -07:00
Jacob Pavlock
917c7def4e test commit for windows ci
windows seems to be having issues with tox installing depencies
via `.[test]` this is a test to see if removing the inline comment changes anything
2020-07-07 09:37:22 -07:00
Adrian Sampson
32e54a29fa
Merge pull request #3655 from aereaux/add_parentwork_date
Get the date of the parentwork, which may be different from the date of the child work.
2020-07-07 07:48:23 -04:00
Jacob Pavlock
e4284cff55 reverting change to ci for python3.4
seems github actions doesn't support python3.4
2020-07-06 18:51:36 -07:00
Jacob Pavlock
dabde74683 nose -> pytest and clean-up tox 2020-07-06 17:03:11 -07:00
Jacob Pavlock
723e04ebb3 deprecate tests_require in favor of extras 2020-07-06 17:02:23 -07:00
jtpavlock
aedd77317f
Merge pull request #3658 from jtpavlock/integration_tests
Add weekly integration test github action
2020-07-06 11:37:46 -05:00
jtpavlock
45abc9ed7a
Clean up code and tests for Genius Lyrics plugin backend (#3641)
* clean-up code & add tests for genius lyrics backend

* add genius fetch tests

* organize imports: standard lib -> pip -> local

* check in sample genius lyrics page

* fix mock import

* force utf-8 encoding for opened files

* use io.open to force utf-8 encoding w/ python2.7
2020-07-06 08:41:27 -05:00
Jacob Pavlock
06553cc37c adjust test_lyrics.py to work with integration tests 2020-07-05 21:41:31 -07:00
Jacob Pavlock
c05ba5c814 add integration test github action 2020-07-05 21:41:22 -07:00
Aidan Epstein
27199abac8 Get the date of the parentwork, which may be different from the date of the child work.
Also add a changelog entry and docs.
2020-07-03 09:35:15 -07:00
Adrian Sampson
cb668ccdab
Merge pull request #3648 from jtpavlock/patch-2
Create pull request template
2020-06-29 09:08:51 -04:00
Adrian Sampson
6411a58c80 Slight formatting/wording improvements 2020-06-29 09:08:25 -04:00
Adrian Sampson
aed81da2fa Thanks & bug link for #3637 2020-06-28 21:19:35 -04:00
Adrian Sampson
8deef192e6
Merge pull request #3647 from trolley/topic/coverart-thumbs-2
fetchart: Use Cover Art Archive thumbnails
2020-06-28 21:18:39 -04:00
jtpavlock
def44e6f88
Update pull_request_template.md 2020-06-28 17:36:40 -05:00
jtpavlock
b458509ba1
spelling 2020-06-28 17:35:08 -05:00