Commit graph

7983 commits

Author SHA1 Message Date
Jack Wilsdon
ac06be1a5a Add flake8 check for blind excepts
Add flake8 check for blind excepts using flake8-blind-except (B901).
2017-04-29 00:03:45 +02:00
dosoe
23f172d03d if there is no artist_sort, there should not be a composer_sort. 2017-04-28 13:49:50 +02:00
dosoe
4a17da8e10 requested changes: where there is no artist_sort, there is no need for composer_sort; cleaning up whitespaces. 2017-04-28 13:41:54 +02:00
dosoe
d4ff82e46f adding image stuff for composer_sort 2017-04-28 12:45:31 +02:00
dosoe
2a418a6350 ASFStorageStyle corrected 2017-04-28 12:29:44 +02:00
dosoe
075e2432bf deleted one duplicate block 2017-04-28 12:15:37 +02:00
dosoe
e3c37981bb little indentation stuff 2017-04-28 12:13:27 +02:00
dosoe
c51ecd46e3 add composer_sort tag# 2017-04-28 12:10:02 +02:00
discopatrick
50a2e37a4d Keep function names lowercase to pass flake8 tests 2017-04-27 15:58:08 +01:00
discopatrick
6e6dd76513 Remove space separator tests from test_x_precision_intervals tests
This is not the correct place for space separator tests. Each test
should test one thing only. Space separator tests are now in a separate
test case.
2017-04-27 11:36:03 +01:00
discopatrick
5a3b74f681 Test an invalid datetime separator raises error 2017-04-27 11:29:45 +01:00
discopatrick
1ab913b200 Test each valid datetime separator 2017-04-27 11:28:10 +01:00
discopatrick
24890c77f1 Add a date query precision of ‘second’ 2017-04-27 00:24:17 +01:00
discopatrick
02bd19fb32 Allow minute precision queries to use space separator 2017-04-27 00:06:36 +01:00
discopatrick
c10eb8f69d Keep docstring line <= 79 characters 2017-04-27 00:05:06 +01:00
discopatrick
04e2975ee9 Separate date formats onto individual lines 2017-04-27 00:05:06 +01:00
discopatrick
c3771f722c Allow hour precision queries to use space separator 2017-04-27 00:04:46 +01:00
discopatrick
6a71504545 Allow multiple date formats for each precision
We want to allow datetime queries to be entered in multiple formats,
e.g. with a 'T' or a space separator between date and time. This
commit sets up that possibility, albeit with an additional dummy
format for the time being.
2017-04-26 23:53:51 +01:00
discopatrick
05f0072363 Update docstring 2017-04-26 23:46:17 +01:00
discopatrick
b8e1c5675e Fix tests 2017-04-25 02:25:50 +01:00
discopatrick
ba324df0d1 Add a date query precision of ‘minute’ 2017-04-25 01:38:31 +01:00
discopatrick
5f2c47ec18 Test further hour precision intervals 2017-04-25 01:38:31 +01:00
discopatrick
61b832990f Add a date query precision of ‘hour’ 2017-04-25 01:38:24 +01:00
Nathan Dwek
68089ac8e9 Merge pull request #2524 from beetbox/command-output-close-stdin
Close stdin when performing `command_output()`
2017-04-24 20:31:04 +02:00
Adrian Sampson
2c71092eaa Merge pull request #2526 from jwilk/errno
Don't hardcode errno constant
2017-04-23 23:14:34 -04:00
Jakub Wilk
95a868bb50 Don't hardcode errno constant
The value of ENOENT is architecture-dependent, so don't assume
it's always 2.
2017-04-23 23:28:32 +02:00
discopatrick
d24b373c87 Adjust indentation to pass flake8 tests 2017-04-22 18:23:33 +01:00
discopatrick
63cd799e8d Raise the correct error type
The incorrect error type was reintroduced in the previous merge commit.
2017-04-22 18:13:26 +01:00
discopatrick
bd48559b0a Merge branch 'master' into rename-error
# Conflicts:
#	beets/dbcore/query.py
2017-04-22 18:13:03 +01:00
discopatrick
58417526cb Rename InvalidQueryArgumentTypeError to InvalidQueryArgumentValueError
The way we use `InvalidQueryArgumentTypeError` is more akin to a `ValueError` than a `TypeError`. For example, we try to parse a string as an int, float, or date, but the parsing fails - there was nothing wrong with the type of the variable (string), but its contents were not parseable into the type we wanted - there was a problem with the value of the string.
2017-04-22 18:07:30 +01:00
nath@home
b38f34b2c0 command_output: insure py2/3 compat
This should make #2524 pass
2017-04-22 15:52:09 +02:00
nath@home
7a08e4a978 Changelog for 2524 2017-04-22 15:07:28 +02:00
nath@home
7a3c786215 command-output: Wire subproc stdin to /dev/null
This should fix 2488, where beet convert would prevent further
inputs.
2017-04-22 15:01:31 +02:00
Adrian Sampson
80f77aea4d Merge pull request #2522 from discopatrick/date-value-field-validation-method
Date value field validation method
2017-04-21 08:48:52 -04:00
discopatrick
4dbc4134b3 consolidates the declaration and incrementing of ordinal into one line 2017-04-21 12:55:44 +01:00
discopatrick
85adbd1383 gives variable the better name of ‘ordinal’ 2017-04-20 13:36:31 +01:00
discopatrick
713c00aea7 reverts order of precisions from broadest to narrowest 2017-04-20 13:20:22 +01:00
discopatrick
ab7cc8f1ab Merge branch 'master' into date-value-field-validation-method
# Conflicts:
#	beets/dbcore/query.py
2017-04-20 13:03:25 +01:00
Adrian Sampson
fae8fcc932 ftintitle: Clarify indexing
This can only be a two-element array, so just use the index 1. This matches
better with the comments, that say "right-hand side" instead of "the last
value in the list."
2017-04-19 19:08:15 -04:00
Adrian Sampson
9d42728f7f ftintitle: Clarify control flow
Assigning to this variable made it hard to tell what the function was actually
returning.
2017-04-19 19:07:29 -04:00
Adrian Sampson
78f19db511 Merge pull request #2521 from tweitzel/master
add --yes argument to play command
2017-04-19 18:59:50 -04:00
xarph
02aa6191c1 rename --force to --yes in play plugin
fix some pep8 goo
2017-04-19 10:51:44 -07:00
Adrian Sampson
18127ce6bf Merge branch 'master' of github.com:beetbox/beets 2017-04-19 11:37:36 -04:00
Adrian Sampson
29b57fb5a7 Changelog for #2517 2017-04-19 11:36:58 -04:00
Adrian Sampson
31c7330de4 Merge pull request #2517 from discopatrick/date-value-field-validation
Date value field validation
2017-04-19 11:36:18 -04:00
Adrian Sampson
21c59bfcdd Merge pull request #2508 from Mary011196/master
OperationalError from SQlite that indicates a permissions problem.
2017-04-19 11:25:37 -04:00
discopatrick
18c512893e more flake8 updates 2017-04-19 14:10:04 +01:00
SpirosChadoulos
60318f1e02 fixed line length 2017-04-19 13:07:04 +03:00
SpirosChadoulos
de57602e34 fixed certain errors 2017-04-19 12:54:03 +03:00
SpirosChadoulos
3e9076b451 deleted else 2017-04-19 12:47:31 +03:00