Commit graph

7983 commits

Author SHA1 Message Date
Adrian Sampson
692dea39e8 MediaFile: Use stock logging
This is part of the effort to separate MediaFile from beets (#1966). It avoids
using the beets-specific logging infrastructure. This commit is part of
fdebab657d6e85de56b3996e8fdece09796940ae from the new MediaFile repository.
2016-11-26 17:30:02 -05:00
Adrian Sampson
cf5fa501e2 Version bump: 1.4.2 2016-11-25 22:16:03 -05:00
Adrian Sampson
839a316673 Change released version to 1.4.1
Sadly, I uploaded the wrong file to PyPI for 1.4.0. Once you do this, PyPI
never lets you change the file associated with a given released version. So we
need to use 1.4.1 instead. 😢
2016-11-25 22:13:54 -05:00
Adrian Sampson
60ec732e10 Version bump: 1.4.1 2016-11-25 21:38:06 -05:00
Adrian Sampson
d99b46612f Fix version bumping in release.py 2016-11-25 21:37:25 -05:00
Adrian Sampson
d54ef99ea5 Fix a forgotten test 2016-11-25 21:33:44 -05:00
Adrian Sampson
8d902c0da3 Release date for 1.4.0 2016-11-25 21:29:06 -05:00
Adrian Sampson
9fb358d3c0 Even more little changelog fixes 2016-11-25 21:28:41 -05:00
Adrian Sampson
e15bee15f5 More changelog proofreading 2016-11-25 21:11:54 -05:00
Adrian Sampson
55d9233e39 Capitalize Python 2016-11-25 21:06:01 -05:00
Adrian Sampson
bdfa53c503 Changelog updates and proofreading 2016-11-25 21:05:34 -05:00
Adrian Sampson
f31e6110e6 Simplify #2280 docs
I've backed out the FAQ entry, since the main docs seem like the right place
for this.
2016-11-24 23:59:00 -05:00
Adrian Sampson
d6b15f4eaa Remove duplicated line in docs (#2280)
For consistency: we don't show the aliases here for the other commands.
2016-11-24 23:51:10 -05:00
Adrian Sampson
5d74e1c07e Merge pull request #2280 from pkess/selective_modify_doc
Extra documentation for #1843
2016-11-24 23:50:43 -05:00
Peter Kessen
488225d837 Added documentation and FAQ for selective modify 2016-11-24 19:41:31 +01:00
Peter Kessen
9f48338291 Corrected docs for modify command
added short form ´mod´ and added switch ´-f´
2016-11-24 19:04:42 +01:00
Nathan Dwek
31b23207a8 Merge pull request #2249 from beetbox/generators-decorators-core
[WIP]Use generators and decorators to match items:
2016-11-21 23:19:18 +01:00
nathdwek@laptop
7dc458aaf5 tagger: finish generator-decorator simplifications
* Propagate generators upwards without realizing them
* Use plugins.notify_info_yielded decorator
2016-11-21 13:43:00 +01:00
nathdwek@laptop
6e3a9d9bc5 collect search results from plugins with yield 2016-11-21 13:39:44 +01:00
nathdwek@laptop
a7fed5b2c4 plugins: document notify_info_yielded 2016-11-21 10:15:51 +01:00
nathdwek@laptop
2b468c1872 plugins: make the signature of notify_info_yielded clearer 2016-11-21 10:15:51 +01:00
nathdwek@laptop
91d1aa9763 plugins: rename notify_info_received->notify_info_yielded 2016-11-21 10:15:51 +01:00
nathdwek@laptop
18a14e8005 Use generators and decorators to match items:
The easy parts
2016-11-21 10:15:51 +01:00
Nathan Dwek
871a815281 Merge pull request #2251 from beetbox/drop-reduce
acousticbrainz: refactor plugin
2016-11-20 23:03:41 +01:00
nath@home
147ced9eaa acousticbrainz: latest adjustments
* Readability and consistency
* Better logging: warn by default for attributes that were not found,
  but don't drown user with info when everything is going well.
2016-11-20 22:45:07 +01:00
nathdwek@laptop
eb1ea6177d acousticbrainz: drop DefaultList, be explicitly careful
* I don't see DefaultList be really helpful in many other cases, so having
  a beets.util.collections module (which could also conflict with the collections
  module from standard library) with only that in it is a little silly.
* It was elegant and concise, but there are implementation issues: it is not
  recommended to subclass builtin types, but the alternatives differ between python
  2 and 3 (subclass sequence or container or collections.abc?), moreover,
  interpreters can differ in the way they map syntaxic sugar to magic functions.
* Also, slicing and negative indexing could do weird things, so the class wouldn't
  be really intuitive and simple at the same time
2016-11-20 22:03:41 +01:00
nathdwek@laptop
51243240f6 acousticbrainz: Test _map_data_to_scheme with real data 2016-11-20 22:03:41 +01:00
nath@home
4586e2df5a acousticbrainz: Add unit tests 2016-11-20 22:03:41 +01:00
nathdwek@laptop
1d972b9907 acousticbrainz: rewrite _map_dict_to_scheme:
* Less lazy names
* Separate root function from childs more naturally
* Actually use defaultdict
2016-11-20 22:03:41 +01:00
nathdwek@laptop
324c67191d acousticbrainz: log fetched attributes and values as info 2016-11-20 22:03:41 +01:00
nathdwek@laptop
3979619f9f acousticbrainz: remove redundant comments 2016-11-20 22:03:41 +01:00
nath@home
7a676400dc acousticbrainz: Refactor the json handling part 2016-11-20 22:03:41 +01:00
nath@home
1963b52903 acousticbrainz: Initial cleanup 2016-11-20 22:03:41 +01:00
Adrian Sampson
6b0249df08 Changelog for #2270 (fix #899, fix #2264) 2016-11-19 16:14:24 -05:00
Adrian Sampson
be7e718b28 Merge pull request #2270 from lazka/apic-encoding-compat
mediafile: prefer latin-1 encoding for ID3 APIC descriptions. Fixes #899
2016-11-19 16:12:32 -05:00
Christoph Reiter
31f91129f3 Use mutagen id3 encoding constants 2016-11-19 10:36:31 +01:00
Christoph Reiter
31898111ed mediafile: prefer latin-1 encoding for ID3 APIC descriptions. Fixes #899
iTunes has problems with everything but latin-1
Try to use latin-1 if possible and fall back to utf-16.
2016-11-18 01:09:53 +01:00
Adrian Sampson
02bd7946c1 Merge pull request #2269 from beetbox/drop-idfallback-dict
drop IdentityFallbackDict and use get(key, key) instead
2016-11-16 22:06:09 -05:00
nathdwek@laptop
b8213181f2 drop IdentityFallbackDict:
Used by mediafile to determine the preferred extension of an image
That solution looked cool for 2 days, but in hindsight it was pretty bad
2016-11-16 23:10:15 +01:00
Adrian Sampson
62e9a15f4d Fix a copy n' paste error found by flake8 2016-11-16 12:03:07 -05:00
Adrian Sampson
4c6bf782a2 Ignore a new flake8 style warning
It's always fun when the style checker suddenly decides something new is bad
style. :/
2016-11-16 12:01:37 -05:00
Adrian Sampson
dafde564f3 Add __future__ imports to a new module 2016-11-16 11:58:18 -05:00
Adrian Sampson
6d3497c560 Merge pull request #2268 from ggVGc/print_flexible_decode_fix
Removed call to  .decode('utf-8') when printing flexible attributes
2016-11-16 11:55:00 -05:00
walt
c3b70b5098 Removed call to .decode('utf-8') when printing flexible attributes 2016-11-16 11:33:16 +01:00
Nathan Dwek
2eae2d6d17 Merge pull request #2262 from beetbox/fix-2260
Convert: Don't prompt for confirmation if query result is empty
Fix #2260
2016-11-13 20:37:09 +01:00
nathdwek@laptop
862d89001f convert: changelog for #2262 2016-11-13 18:07:14 +01:00
nathdwek@laptop
a0a9f5a7a8 Fix typos in tests 2016-11-13 17:49:18 +01:00
nathdwek@laptop
8067d82be8 convert: test for #2260 2016-11-13 17:47:07 +01:00
nath@home
2e78628507 convert: Don't ask for confirmation if query result is empty 2016-11-13 17:46:29 +01:00
nath@home
d53b677e0f convert: initial cleanup of convert_func
Get cli options and configuration in a more readable, uniform way
2016-11-13 00:20:01 +01:00