Commit graph

7983 commits

Author SHA1 Message Date
Adrian Sampson
9e76c839f6 Changelog for #2307
Close #2247, close #2243, close #2245, close #2244, close #2248.
2017-01-02 20:58:18 -05:00
Adrian Sampson
fbc0f322f6 Merge branch 'tigranl-https_fix' 2017-01-02 20:54:17 -05:00
Adrian Sampson
33a8e81f08 Simplify test changes
We don't need quite so many checks now that SSL isn't conditional most of the
time.
2017-01-02 20:49:12 -05:00
Adrian Sampson
f941fd42de Always use SSL on servers that don't require SNI
I did a little audit using the `openssl` command-line tool to find the servers
that don't require SNI. Here's what I found:

icbrainz.org: SNI
images.weserv.nl: inconclusive, but docs say yes SNI
coverartarchive.org: SNI
webservice.fanart.tv: *no* SNI
dbpedia.org: *no* SNI
en.wikipedia.org: *no* SNI
ws.audioscrobbler.com: *no* SNI
api.microsofttranslator.com: *no* SNI

In summary, *only* MusicBrainz and CoverArtArchive were found to require SNI.
So I'm using SSL unconditionally on all the other sites.
2017-01-02 20:39:10 -05:00
Johnny Robeson
bd340b2910 Replace Python 3.4 with 3.6 on Appveyor (#2358)
Python 3.4 is quite old and offers little value on Windows.

Closes #2344
2017-01-02 19:06:49 -05:00
Adrian Sampson
2fcde98d4b Merge pull request #2367 from beetbox/timestamp-36
Use a new stdlib method for dbcore.query._to_epoch_time on Python 3
2017-01-02 18:45:36 -05:00
Adrian Sampson
3acd4480ff Use a stdlib method for _to_epoch_time on py3
This also works around a bug in Python 3.6.0 on Windows: see #2358.
2017-01-02 18:29:37 -05:00
Adrian Sampson
4711bf708b Docs tweaks for #2365 2017-01-02 15:59:14 -05:00
Adrian Sampson
7f73711d2f Merge pull request #2365 from inytar/absubmit_skip_doc
Absubmit add section in the documentation on skipped file by the plugin
2017-01-02 15:57:18 -05:00
Pieter Mulder
869d0781d5 Absubmit add section on skipped file by the plugin
Add a section to the absubmit plugin documentation about files that are skipped by this plugin.
2017-01-02 14:34:00 -05:00
inytar
a5aee3f677 Absubmit close temporary file
Fix error when deleting the file under Windows
2017-01-02 14:05:59 -05:00
inytar
0975ee709b Absubmit fix failing to load distutils.spawn 2017-01-02 14:05:17 -05:00
Adrian Sampson
b95c01fbea Improve absumbit docs (c.f. #2364) 2017-01-02 13:41:48 -05:00
Adrian Sampson
2d6ad4c5bd Merge pull request #2364 from tux-00/patch-1
Add notes about AcousticBrainz requirements
2017-01-02 13:38:24 -05:00
Raphaël B
e46a802ebb Add notes about AcousticBrainz requirements 2017-01-02 18:54:50 +01:00
Adrian Sampson
969e58841f Improve changelog for #1992 2017-01-01 23:10:58 -05:00
Adrian Sampson
f621d7f4f1 Merge pull request #1992 from jackwilsdon/add-write-bpm
Add write option to bpm plugin
2017-01-01 23:09:41 -05:00
Adrian Sampson
8cb6ff3892 Simplify the example config
I never meant for people to copy and paste this example---it's redundant and
probably wrong---but lots of people do! Removing a few weird options makes the
example clearer, I think, and will result in less-strange initial configs for
people who do copy & paste.
2017-01-01 19:18:25 -05:00
Mike Cameron
8a00791ecc Oops. Forgot to actually stage the correct file. 2017-01-01 04:52:32 -05:00
Mike Cameron
76b3212e78 Added alternate track numbers for Discogs. 2017-01-01 04:51:34 -05:00
Mike Cameron
0d68a12609 Added alternate track field when importing from MusicBrains.
Useful when importing multi-sided medias such as vinyls and cassettes.
2017-01-01 04:36:48 -05:00
Adrian Sampson
32dc808f71 Changelog entry for #2342 (fix #2253) 2017-01-01 00:47:03 -05:00
Adrian Sampson
4c1b8c2935 Merge pull request #2342 from inytar/master
Implement the basic AcousticBrainz Submit plugin
2017-01-01 00:45:24 -05:00
inytar
b57b3f761e Add header to the absubmit plugin 2016-12-31 18:27:27 -05:00
inytar
1a4c74ae5e More spelling corrections for the absubmit plugin documentation 2016-12-31 18:26:56 -05:00
inytar
9ab67d5ffe Fix typos in absubmit documentation 2016-12-31 14:12:28 -05:00
inytar
cfe9c0f3d4 Remove fixed TODO comment 2016-12-31 14:11:55 -05:00
Tigran Kostandyan
1c5c74f1d7 Fix a typo 2016-12-31 18:46:01 +03:00
diomekes
af99ee21aa add documentation for play importer prompt choice 2016-12-31 00:15:36 -05:00
diomekes
ab4246c5db add prompt choice to play items before import
fix line number

add comments
2016-12-30 23:51:20 -05:00
Johnny Robeson
2eb47e9ea5 Temporarily allow empty checksum for unrar on appveyor (#2359)
Obviously it'd be best if we didn't have to do it, but I doubt we can
wait forever for the packagers to add it.
2016-12-30 21:30:20 -05:00
Adrian Sampson
8bb24e3134 lyrics: Set User-Agent header (fix #2357) 2016-12-30 10:55:24 -05:00
Diego M. Rodríguez
87266be5a6 Merge pull request #2354 from diego-plan9/discogs-relax-assumptions
discogs: more graceful handling of missing fields
2016-12-30 12:03:02 +01:00
Diego M. Rodriguez
3f36f67940
discogs: tweak pruning of empty candidate albums 2016-12-30 11:39:19 +01:00
Diego M. Rodriguez
37cb1c295f
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
Conflicts:
	docs/changelog.rst
	test/test_discogs.py
2016-12-30 10:42:50 +01:00
Diego M. Rodríguez
7d943301ef Merge pull request #2355 from diego-plan9/discogs-subtrack-handling
discogs: revise subtrack merging based on subindex
2016-12-30 10:35:15 +01:00
Diego M. Rodriguez
5f83f8db1f
Merge remote-tracking branch 'upstream/master' into discogs-subtrack-handling
Conflicts:
	docs/changelog.rst
2016-12-30 10:20:58 +01:00
Diego M. Rodriguez
072e6de3ae
discogs: add changelog for #2318, fix typo 2016-12-30 10:17:53 +01:00
Adrian Sampson
2642544867 Changelog note for #2353 2016-12-29 13:34:23 -05:00
Adrian Sampson
1e215aedef Merge branch 'master' of github.com:beetbox/beets 2016-12-29 13:31:00 -05:00
Adrian Sampson
ac41b6d6e5 Fix #2339: scrub resets art type
We now use the richer `images` field instead of the more basic `art` field.
2016-12-29 13:30:17 -05:00
Diego M. Rodriguez
0a9cb1fd3d
discogs: revise subtrack merging based on subindex
Modify the coalescing of subtracks by taking into account the subindices
of the subtracks for deciding if they represent "logical" tracks
(merging them into one single track, as previously) or if they represent
physical tracks (treating them as individual tracks).
Add unit tests for nested logical/physical subtracks, and disc titles.
2016-12-29 18:03:54 +01:00
Diego M. Rodriguez
4364757fcc
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions
Conflicts:
	docs/changelog.rst
2016-12-29 13:27:06 +01:00
Diego M. Rodriguez
30f238151e
discogs: additional sanity checks parsing release
Add extra checks for the presence of specific field (artists, title,
id, tracklist) when parsing a Release from discogs, failing gracefully
if the fields could not be found.
Add a test for releases without required fields.
2016-12-29 13:19:01 +01:00
dopefishh
8bb703619f use util.py3_path for web attachment filenames (#2353)
Web attachment filenames must be passed as a string for Python 3
2016-12-29 05:38:27 -05:00
Adrian Sampson
413666a825 Fix #2351: crash in scrub on MediaFile errors 2016-12-28 16:36:51 -05:00
Adrian Sampson
24d43635cd Slightly more helpful UnreadableFileError (#2351)
The exception now says something about what caused it, instead of just
listing the path that led to the error.
2016-12-28 16:33:43 -05:00
Adrian Sampson
c7351d9086 Flip an erroneous execute bit 2016-12-28 16:18:02 -05:00
Diego M. Rodriguez
0efb0c3472
discogs: add changelog entry for robustness fix 2016-12-28 21:16:44 +01:00
Diego M. Rodriguez
02666424d4
discogs: improve robustness when parsing an album
Improve the robustness of `get_album_info()` by preferring the use of
`get()` over accesing the dictionary keys directly for several fields,
plus adding extra checks for fields that depend on nested containers on
the Release data.
Add a test for parsing a release that contains a minimal amount of
fields.
2016-12-28 21:07:18 +01:00