Commit graph

8756 commits

Author SHA1 Message Date
Reg
0696f915e5 test_fetchart: Avoid duplicate code in future tests. 2018-12-20 18:44:55 +01:00
Reg
2ea77652a7 Fetchart: Respect ignore and ignore_hidden settings when fetching art
from the local filesystem.
2018-12-20 18:44:46 +01:00
Reg
21145731e4 Fixed docstring typo. 2018-12-20 18:19:00 +01:00
Jan Holthuis
d2521d9256 Fix acoustid_fingerprint type confusion
Since pyacoustid returns the fingerprint as bytes (and thus causes the
database to store a bytes/BLOB object), but the tag value is a string,
the acoustid_fingerprint tag always causes file change when using beet's
"write" command, even if the actual value didn't change.

Issue #2942 describes the problem.

This commit fixes that issue for newly imported/fingerprinted files. However,
you still need to change the type of all acoustid_fingerprint fields
that are already present in the database:

    $ sqlite3 beets.db
    SQLite version 3.26.0 2018-12-01 12:34:55
    Enter ".help" for usage hints.
    sqlite> UPDATE items SET acoustid_fingerprint = CAST(acoustid_fingerprint AS TEXT);
2018-12-19 10:30:50 +01:00
Vladimir Zhelezov
3e0b2ad146 Fix #2826
Test for major Python version and use inspect.getargspec() or
inspect.getfullargspec() respectively to silence deprecation warnings in
Python 3
2018-12-10 08:40:32 +01:00
Adrian Sampson
ca359d7e0d
Merge pull request #3085 from jackwilsdon/modify-skip-remaining
Allow exiting object selection early
2018-12-02 14:57:16 -05:00
Adrian Sampson
17d9882389 Make the path-field-remover function more obvious
An amendment to #3084.
2018-12-01 16:57:25 -05:00
Adrian Sampson
1e051288a2 Merge pull request #3084 from domenn/master
Export plugin can now export path from library.
2018-12-01 16:52:49 -05:00
Guilherme Danno
fa1037ee28
Enhance %title (#3059)
Use string.capwords in %title to lower char after apostrophe
2018-11-29 11:30:48 -02:00
Domen
5de3ee9a5f Export plugin can now export path from library, if explicitly specified as field to export. Info plugin behaviour is unchanged. 2018-11-28 20:19:37 +01:00
Jack Wilsdon
bed3abd97a
Allow exiting object selection early 2018-11-28 17:17:12 +00:00
Frederik “Freso” S. Olesen
b380a4c9a3
docs: Fix typo: anique → aunique
Reported by M1dgard on IRC
2018-11-04 12:02:06 +01:00
Frederik “Freso” S. Olesen
338541c066
Add Python 3.7 to classifiers in setup.py
beets runs perfectly well under 3.7 on Arch Linux and we're also doing
automated testing/continuous integration for Python 3.7 in Travis.
2018-10-30 09:33:35 +01:00
Adrian Sampson
146eef390d
Merge pull request #3063 from milesial/master
Fixed typo in convert when copying cover art
2018-10-25 10:41:53 -04:00
milesial
d5caae12bd
Now logs both the source and the destination 2018-10-25 15:29:28 +02:00
milesial
b27dfed1ef
Added the bug emoji ! 2018-10-25 14:49:08 +02:00
milesial
af3e1dbbfa
Merge branch 'master' into master 2018-10-25 14:39:48 +02:00
milesial
0ff884daa7
Added a line in the changelog 2018-10-25 14:37:20 +02:00
Adrian Sampson
9556ab30fa
Merge pull request #3060 from TaizoSimpson/issue-3501
When selecting items to modify, use configured order
2018-10-24 21:26:18 -04:00
Adrian Sampson
0a74e0fd3f Style fixes for latest pycodestyle changes 2018-10-24 17:05:38 -04:00
Taizo Simpson
b901eb3723
Added check to remove duplicate changes 2018-10-24 14:12:32 -04:00
Taizo Simpson
fd56b1d677
Added changelog entry for issue 3051 2018-10-24 14:07:27 -04:00
milesial
d4e615feba
Fixed typo in convert when copying cover art 2018-10-24 19:07:12 +02:00
Adrian Sampson
d8df9f1b72
Merge pull request #3061 from pieqq/docs-pip
docs: update the pip install instructions
2018-10-23 22:52:44 -04:00
Pierre
8f6c7cb8cd docs: update the pip install instructions
Using ``sudo`` to install Python packages using pip is not a good
practice security-wise. This commit will suggest an alternative way
using ``--user`` to make sure the package is installed locally.
2018-10-24 10:36:16 +08:00
Taizo Simpson
a9793067fa
When selecting items to modify, use configured order
Closes #3501
2018-10-22 20:34:21 -04:00
Patrick Heneghan
9c7a313b0d
Remove default arg for lastgenre --force flag 2018-10-16 18:51:39 +01:00
Adrian Sampson
1828114528
Merge pull request #3048 from samuelnilsson/subsonic
Subsonicupdate plugin: Added context path and fixed bug in port configuration
2018-10-11 07:41:33 -04:00
Samuel Nilsson
a928dbc470 Added contextpath configuration to subsonicupdate plugin. Fixed bug in
subsonicupdate port configuration.
2018-10-10 21:22:31 +02:00
David Logie
27f0b57d2b Remove pointless print call. 2018-10-10 15:40:21 +01:00
Adrian Sampson
b0add60332 Merge pull request #3030 from projectgus/remove_missing_albumart
move_art: Remove missing album art
2018-10-09 16:58:59 -04:00
Adrian Sampson
a7e44e8058
Merge pull request #3046 from jackwilsdon/fix-typos
Fix miscellaneous typos
2018-10-08 21:10:31 -04:00
Jack Wilsdon
5ad16983d4
Fix miscellaneous typos 2018-10-09 01:11:06 +01:00
Adrian Sampson
49ec10eb88 Merge branch 'master' of github.com:beetbox/beets 2018-10-08 17:45:48 -04:00
Adrian Sampson
5cb1bea1a6 Add a warning to the bucket docs (fix #3045) 2018-10-08 17:45:27 -04:00
Adrian Sampson
54cf6d4d44
Merge pull request #3043 from beetbox/aunique-format
Make `%aunique` work with `-f/--format` options.
2018-09-27 10:29:33 -04:00
Adrian Sampson
dc661ec132
Merge pull request #3044 from beetbox/delete-fixed-attributes
Allow "deleting" fixed attributes via `beet modify`.
2018-09-27 09:57:05 -04:00
David Logie
b347908af7 Address PR comments. 2018-09-27 14:54:23 +01:00
David Logie
882849433e Remove unneeded line. 2018-09-27 14:30:38 +01:00
David Logie
932609933f Allow "deleting" fixed attributes via beet modify.
Deleting a fixed field isn't possible so we just reset the
field back to it's "null" value.

Fixes #2497.
2018-09-27 11:22:17 +01:00
David Logie
760bdd5420 Add a reference to the bug. 2018-09-27 10:29:43 +01:00
David Logie
54624a879d Make %aunique work with -f/--format options. 2018-09-26 14:17:57 +01:00
Adrian Sampson
3b78d933cf Fix #3041: only try to close opened archives
The "finally" clause here only wants to apply when `archive` is
assigned. Otherwise, we were getting a NameError trying to refer to the
appropriate variable.
2018-09-21 15:55:09 -04:00
Angus Gratton
e58ddbfa1a move_art: Remove missing album art
Prevents a fatal file system error if the album art has been moved or renamed
and the beets library hasn't been manually updated.
2018-09-18 20:32:48 +10:00
Adrian Sampson
6a92fa8b70
Merge pull request #3028 from arogl/master
mbsync no longer queries MusicBrainz when the either the mb_albumid or mb_trackid field is invalid
2018-09-16 18:23:20 -07:00
Adrian Sampson
62772ceece Merge branch 'master' into arogl-master 2018-09-16 20:56:17 -04:00
Adrian Sampson
8b59b20ef8 Tiny style fix for #3028 2018-09-16 20:56:06 -04:00
Adrian Sampson
dc45119a8d Avoid comparing patterns in a test
As pointed out here:
https://github.com/beetbox/beets/pull/3028#issuecomment-420257867
2018-09-16 20:52:31 -04:00
Adrian Sampson
e993e252f6
Merge pull request #3032 from FichteForks/pr/run-37-tests
Actually run tests on Python 3.7
2018-09-13 18:14:38 -04:00
FichteFoll
d0ed5cbb9a
Actually run tests on Python 3.7 2018-09-13 23:42:42 +02:00