Commit graph

8756 commits

Author SHA1 Message Date
Adrian Sampson
15f86c411e Appveyor: fix version specifier syntax 2019-03-30 12:57:51 -04:00
Adrian Sampson
9b3bebfcd7 Travis: fix shell syntax for version specifier 2019-03-30 12:48:34 -04:00
Adrian Sampson
db107e3c46 Appveyor: temporarily pin tox version
As in 777cfbbf61 for Travis.
2019-03-30 12:40:52 -04:00
Adrian Sampson
ccbab10090 Add the full set of __future__ imports in new file 2019-03-30 12:39:42 -04:00
Adrian Sampson
777cfbbf61 Travis: temporarily pin tox to <=3.8.1
To avoid a Python 2 bug introduced in tox 3.8.2 but not fixed yet:
https://github.com/tox-dev/tox/issues/1234
2019-03-30 12:37:53 -04:00
Alexei Datskevich
be12a89372 Fix PyYAML yaml.load(input) Deprecation 2019-03-30 08:34:13 +01:00
Adrian Sampson
9abfc45adc Changelog issue link for #3189 2019-03-26 22:11:12 -04:00
Adrian Sampson
f842551915
Merge pull request #3189 from jroitgrund/dont-move-album-art-twice
beets update: dont move album art twice
2019-03-26 22:10:08 -04:00
jroitgrund@gmail.com
31b393586a Changelog 2019-03-27 01:43:42 +00:00
jroitgrund@gmail.com
ea307f62d1 Don't move album art twice 2019-03-27 01:41:42 +00:00
Heinz Wiesinger
439d4c1061 Performance improvement: Type cast properties on demand 2019-03-24 15:55:58 +01:00
Heinz Wiesinger
29425edff4
Merge pull request #2798 from pprkut/query_perf
Small performance optimization when fetching items from library.
2019-03-23 20:54:58 +01:00
Heinz Wiesinger
7c568aa528 Account for items that do not have flexible attributes 2019-03-23 20:22:23 +01:00
Heinz Wiesinger
5494c8b260 Improve documentation 2019-03-23 20:22:23 +01:00
Heinz Wiesinger
31ec222e0e Query flexible attributes already in _fetch()
This resolves the query length and potential security problems,
while keeping the performance benefits.
2019-03-23 20:22:23 +01:00
Heinz Wiesinger
1e1ddd276e Small performance optimization when fetching items from library.
Fetch flexible attributes once for all items instead of once per
item. For queries with larger result sets this drastically cuts
down the number of issued sqlite queries.
2019-03-23 20:22:23 +01:00
Adrian Sampson
572835c1f7
Merge pull request #3187 from jroitgrund/patch-1
Clarify description of incremental_skip_later
2019-03-23 12:22:55 -04:00
jroitgrund
6a8444a3fd
Further clarify 2019-03-23 15:03:57 +00:00
jroitgrund
a46d5282be
Clarify description of incremental_skip_later 2019-03-23 14:57:56 +00:00
Adrian Sampson
6ee824fb0f Fix #3184: AttributeError in error handler 2019-03-14 09:53:32 -04:00
Adrian Sampson
e09e697607 Changelog/thanks for #3092 2019-03-13 20:54:42 -04:00
Adrian Sampson
7d8524deab Merge pull request #3092 from zhelezov/2826-deprecation-warnings
Fix #2826
2019-03-13 20:53:41 -04:00
Adrian Sampson
1e075675d0
Merge pull request #3179 from malan88/patch-1
Improve specifications in the matches.ignored setting
2019-03-07 10:56:49 -05:00
malan88
d1ba56e246
Simplify wording, exclude ref to distance_weights
Per conversation with Adrian, simplify the wording of the change.
2019-03-07 10:41:37 -05:00
malan88
2cef079603
Improve specifications in the matches.ignored setting
The setting is quite confusing. After having difficulty getting the autotagger to accept an id for a specific release that I knew was correct, I investigated and count [this closed issue][0] that totally explains the problem.

To clarify the issue, I quoted Adrian from the issue and elaborated a bit, providing the solution. Unfortunately, the solution is undocumented. I'd like to document it, but I am unsure what the actual weighting system in `distance_weights` is. Adrian says 0.9 to ignore missing_tracks, which implies it's similar to the distance weighting in the other settings, but other settings in the default config are set to multiples of 1, implying it is not.

[0]: https://github.com/beetbox/beets/issues/3064
2019-03-07 09:39:34 -05:00
Vladimir Zhelezov
8ae2b474cb Move ArgSpec declaration to module level 2019-03-06 08:18:28 +01:00
Vladimir Zhelezov
520befb30a Fix #2826: introduce beets.util.inspect wrapper 2019-03-05 08:31:44 +01:00
Vladimir Zhelezov
3eb5907da8 Merge branch 'master' of https://github.com/beetbox/beets into 2826-deprecation-warnings 2019-03-04 21:01:19 +01:00
Adrian Sampson
f6ad98a4a5
Merge pull request #3167 from jackwilsdon/fix-hook-unicode
Fix hook byte string interpolation
2019-02-25 11:09:12 -05:00
Adrian Sampson
9f2c7727cd
Merge pull request #3169 from beetbox/munkres-versions
More complex version dependencies for munkres
2019-02-25 11:08:29 -05:00
Adrian Sampson
f312b1f0b7 Fix #3168: several versions of munkres
Require different version constraints for Pythons <3.5, =3.5, and >3.5.
2019-02-25 10:06:14 -05:00
Jack Wilsdon
25549a656f
Add test for interpolating byte strings in hook plugin 2019-02-25 14:42:20 +00:00
Jack Wilsdon
9bb6c29d22
Always use custom formatter for formatting hook commands 2019-02-25 14:41:59 +00:00
Adrian Sampson
80f4f0a0f2 badfiles: Fix decoding for command output
Probably fixes #3165. There were several things going wrong here:

1. For some reason, this was using the *filesystem* encoding, which is
   what you use to decode filenames. But this was general command
   output, not filenames.
2. Errors in decoding threw exceptions, even though all we do with this
   output is show it to the user.
3. The prints were using `displayable_path`, even though the lines are
   *already* Unicode strings.

Hopefully this cleans up that mess.
2019-02-24 16:06:36 -05:00
Adrian Sampson
3973efc25f
Merge pull request #3159 from Holzhaus/fix-badfiles-plugin
badfiles: Fix #3158 by calling superclass __init__ method
2019-02-21 11:00:13 -05:00
Jan Holthuis
3e10d5d39f badfiles: Fix #3158 by calling superclass __init__ method 2019-02-21 12:40:54 +01:00
Adrian Sampson
be118b922a
Merge pull request #3155 from Holzhaus/fetchart-error-handling
fetchart: Add some error handling to prevent crashes
2019-02-20 08:45:22 -05:00
Jan Holthuis
9b5e681f86 docs: Add fetchart error handling fix to changelog
The changelog entry also mentions that this fixes #1579.
2019-02-20 07:50:58 +01:00
Adrian Sampson
9d0f2c1354
Merge pull request #3006 from bemeurer/parallel-bad
Parallelize the badfiles plugin
2019-02-19 22:25:24 -05:00
Bernardo Meurer
c3c7aa619d
Updated changelog 2019-02-19 18:49:31 -08:00
Bernardo Meurer
9374983e9d
Fixed import order 2019-02-19 18:49:29 -08:00
Bernardo Meurer
e209fe5886
Parallelized beet bad 2019-02-19 18:47:47 -08:00
Adrian Sampson
10bc466573 Refine docs for #3153 2019-02-19 18:36:19 -05:00
Adrian Sampson
7a857548b3 Merge pull request #3153 from bemeurer/parallel-map
Add parallel map utility
2019-02-19 18:33:00 -05:00
Jan Holthuis
c07903ed66 fetchart: Add some error handling to prevent crashes
Today I had some network problems regarding dbpedia.org, which made
beets crash because a requests.exceptions.ConnectionError was raised
("[Errno 113] No route to host"). This commits adds some error handling
around network requests to prevent further crashes in the future.
2019-02-19 16:16:56 +01:00
Bernardo Meurer
1dad5ded03
Move absubmit plugin parallelization to util.par_map 2019-02-18 22:42:20 -08:00
Bernardo Meurer
c4506558f5
Added par_map utility 2019-02-18 22:32:05 -08:00
Adrian Sampson
81c5ae3fdf
Merge pull request #3151 from Holzhaus/playlist-plugin-additions
playlist: Add auto-update functionality and more tests
2019-02-18 08:40:55 -05:00
Jan Holthuis
4ba5dfaa43 playlist: Remove leftover print call and fix 'auto' option access style 2019-02-18 09:13:39 +01:00
Jan Holthuis
7bca5cf549 playlist: Don't use syspath() when checking if path is absolute 2019-02-17 22:28:39 +01:00