Commit graph

8756 commits

Author SHA1 Message Date
Adrian Sampson
4d55702497 don't save sentinels in incremental history
This was doing nothing silently before, but the call to tuple(None) threw an
unhandled exception.
2013-02-03 18:22:26 -08:00
Adrian Sampson
48194a128e changelog and docs for #89 2013-02-03 12:23:09 -08:00
Adrian Sampson
55ff2784d3 docstring and style fixes (#89)
This uses a simpler way to sort lists case-insensitively. It also sorts the
*files* in a case-insensitive way for consistency.
2013-02-03 12:13:11 -08:00
Adrian Sampson
6ff1ba0474 break up multidisc collapsing tests
Now we can see which aspect fails in bite-sized pieces.
2013-02-03 12:06:10 -08:00
Adrian Sampson
fab52572d3 legibility refactoring in albums_in_dir (#89) 2013-02-03 11:58:49 -08:00
Adrian Sampson
99ed9e03de rename ImportTask.path to paths (#89) 2013-02-03 11:22:27 -08:00
Adrian Sampson
33c24235da Merge pull request #89 from mrmachine/multi-disc
Improved multi-disc album detection.
2013-02-03 11:11:22 -08:00
Adrian Sampson
c706c1f15a changelog entry / tiny doc tweaks for #90 2013-02-03 10:31:15 -08:00
Adrian Sampson
88bd1fdf3b Merge pull request #90 from dangmai/pluginchain
Allow plugins to execute in predictable order
2013-02-03 10:27:23 -08:00
Dang Mai
24bc084724 Add small docs for smartplaylist about chaining 2013-02-03 10:10:29 -05:00
Dang Mai
ea3a7ea45d Run plugins in predictable order
In the config file, if 2 plugins listen to the same event, make sure the
one that is listed first is executed earlier.
2013-02-03 10:00:44 -05:00
Tai Lee
23cd5453d9 Improved multi-disc album detection.
- Remove "part", "volume", "vol." multi-disc markers. These are often
  part of album titles, and not necessarily indicative of a multi-disc
  album. Only look for "CD X" and "disc X" (case insensitive), ignoring
  white space and other non-word characters.

- Don't only expect each disc to be in a subdirectory of a common parent
  directory, with all siblings belonging to the same release. Also match
  any consecutive siblings (even when the parent contains other albums)
  that are named with the same prefix and multi-disc marker.

- The `albums_in_dir(path)` function now always yields a list of paths
  along with each list of items. `ItemTask.path` is now always a list of
  paths.

- The `displayable_path(path)` function now accepts a list of paths, and
  will join them with "; " by default. This can be changed with the
  `separator` argument.

- The `sorted_walk()` function now does a case insensitive sort on
  directories, but still returns case sensitive results. This allows
  better multi-disc album detection.

- The `art_for_album()` function now takes a list of paths as its second
  argument, instead of a single path.
2013-02-03 23:51:31 +11:00
Adrian Sampson
4f7e738f82 changelog and doc fixes for #88 2013-02-02 12:56:08 -08:00
Adrian Sampson
0be319767f fixes and refactoring for lastgenre.source (#88)
This provides a default for source, preventing a crash when not present in the
user's config.

It also refactors the source decision to a helper function, _lastfm_obj, to
avoid copypasta.
2013-02-02 12:52:43 -08:00
Adrian Sampson
a21e3ca344 Merge pull request #88 from pdf/lastgenre_source_selection
Allow selection of source for genre information (ie - artist vs album)
2013-02-02 12:44:02 -08:00
Adrian Sampson
50a89e790c both release and release group disambig (#87)
This joins the two strings with a comma if both are present.
2013-02-02 12:42:53 -08:00
Adrian Sampson
89f1ae302e changelog and partial reversion of #87
This pull request made two changes. This commit reverts one of them to make the
changes orthogonal.
2013-02-02 12:37:28 -08:00
Adrian Sampson
5f5d3f13c5 Merge pull request #87 from pscn/master
Use release disambiguation not release-group disambiguation and more
2013-02-02 12:33:03 -08:00
Adrian Sampson
89689899c9 changelog note and indentation fix for #86 2013-02-02 12:27:42 -08:00
Adrian Sampson
52dc2f6b0b Merge pull request #86 from steinitzu/master
AlbumArtist tag browsing in bpd
2013-02-02 12:25:01 -08:00
Adrian Sampson
44d195a119 suffix-based colorization for numeric value diffs 2013-02-02 12:24:05 -08:00
Adrian Sampson
d050211c2c length_diff_thresh moved to config
This was previously hard-coded as 2.0 seconds, which was way too low.
2013-02-02 12:07:58 -08:00
Adrian Sampson
afd35ee17a don't colorize filenames in track diff display 2013-02-02 12:02:58 -08:00
Adrian Sampson
f54d9bc096 refactoring and commenting for legibility (#82) 2013-02-02 11:43:19 -08:00
Adrian Sampson
3ef423b735 update changelog note for #82 2013-02-02 11:20:12 -08:00
Adrian Sampson
13c71757f2 cross-platform and error-tolerant width check (#82) 2013-02-02 11:19:23 -08:00
Adrian Sampson
0512ab712b merge 2013-02-02 11:08:51 -08:00
Adrian Sampson
1614313540 Merge pull request #82 from mrmachine/align-changes
Improved change alignment. Align "->" when possible, otherwise split acr...
2013-02-02 11:08:17 -08:00
Adrian Sampson
2ea190ceba better error message when using real tabs 2013-02-02 10:37:02 -08:00
Adrian Sampson
887d1c1287 fix inline and rewrite for instance fields
I'm transitioning to using exclusively instance-level fields instead of
class-level fields in plugin objects, but I neglected to bring inline and
rewrite into the future. This manifested as silent inaction on the part of
these plugins.

This change restores the old behavior (for compatibility) but also updates the
plugins to use the new behavior.
2013-02-02 08:35:54 -08:00
Adrian Sampson
e850e1aab8 changelog note for #85 2013-02-02 08:23:52 -08:00
Adrian Sampson
f59ff7e89e importfeeds: use bytestring paths 2013-02-02 08:22:51 -08:00
Fabrice Laporte
8eabbf64cc Merge branch 'lyrics' 2013-02-02 10:48:58 +01:00
Fabrice Laporte
bc82e04077 importfeeds: fix UnicodeDecodeError when creating symlinks 2013-02-02 10:31:36 +01:00
Fabrice Laporte
cf73d7cb08 replace \r by \n 2013-02-02 09:38:49 +01:00
Peter Fern
eb1fbbac24 Add documentation for lastgenre source 2013-02-02 14:40:32 +11:00
Peter Fern
ef5dfa3fcf Allow selection of source for genre information (ie - artist vs album)
If config is set to:

   lastgenre:
     source: artist

The genre will be fetched for the artist, rather than the album.  This
allows for filesystem org like:

   genre/artist/album

Currently defaults to previous behaviour for anything other than
`artist`
2013-02-02 14:31:45 +11:00
Tai Lee
06976bb49d De-duplicate loop functionality. One logic loop and one display loop. 2013-02-02 09:11:12 +11:00
Peter Schnebel
663574c7ff Adapted test to pull request #87 2013-02-01 18:10:11 +01:00
Peter Schnebel
9fa3aa7428 Prefix media with number of media if >1 (e.g. 2xCD, 3xVinyl...)
Show MBs disambiguation if set.
2013-02-01 15:48:15 +01:00
Peter Schnebel
430b578bd2 Use release disambiguation not release-group disambiguation.
I found 2 examples why I would prefer the release disambiguation:
  http://musicbrainz.org/release-group/d3f057b4-7e89-3018-9f84-9835ed9b4732
  http://musicbrainz.org/release-group/6792b6d1-4e65-3c3c-9d20-d08aa1dcfc60
I did not find an example where the release-group disambiguation would be important (of course, that doesn't prove anything ;))
2013-02-01 15:14:42 +01:00
Tai Lee
8afe1c71b1 Improved change alignment. Align "->" when possible, otherwise split across two lines. 2013-02-01 17:29:30 +11:00
steini
476adf40af Support for AlbumArtist and AlbumArtistSort tag listings. 2013-02-01 02:35:19 +00:00
Adrian Sampson
3fec79fee7 Merge pull request #85 from dangmai/mpdupdate
Fix mpdupdate to update mpd whenever the database changes (not just import)
2013-01-31 16:33:04 -08:00
Adrian Sampson
8ae40e9945 changelog and style fix for #81 2013-01-31 16:25:02 -08:00
Adrian Sampson
20dd71fcfd Merge pull request #81 from pscn/master
Show media in candidates disambiguation
2013-01-31 16:04:17 -08:00
Dang Mai
d4004f10fa Update comments to reflect config migration 2013-01-31 18:17:00 -05:00
Dang Mai
ef8ef4c747 Update MPD whenever database changes 2013-01-31 18:16:21 -05:00
Dang Mai
7de2727572 Fix smartplaylist to use lib param from cli_exit 2013-01-31 18:09:17 -05:00
Adrian Sampson
66eb2c5bae Merge pull request #84 from dangmai/better_cli_exit
Add lib parameter for cli_exit
2013-01-31 15:06:30 -08:00