Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-10 10:32:34 +01:00
Code Issues Projects Releases Wiki Activity
8694 commits 43 branches 64 tags 62 MiB
Commit graph

2088 commits

Author SHA1 Message Date
wordofglass
5f21bd3ccd test_edit: Add a test for retagging. 2017-08-24 15:03:18 +02:00
wordofglass
b903b44a0c test_edit: Fix test that intended to change one item but affected two. 
This didn't manifest as a testing failure since the plugin (mostly
silently) drops id changes.
 2017-08-22 23:34:35 +02:00
wordofglass
c811102eb2 test_edit: Expect mtime to change, unbreaks the multiple-item tests. 2017-08-22 23:34:06 +02:00
wordofglass
18c82cab5f test_edit: Add a comment explaining why I didn't change the writing behaviour 
I was midway through writing a test when realizing that it's best
the way it is...
 2017-08-22 23:24:33 +02:00
wordofglass
7d4627bb8f Ensure mtime is non-zero for Items in test fixtures. 
mtime == 0 is the "this Item contains newer metadata than the file's
tags" marker. Setting this to something else than 0 emulates the state
of Items freshly read from the database.

Breaks 4 of the edit plugin tests.
 2017-08-22 23:24:33 +02:00
Antoine Beaupré
914dba4152
add tests for slug function, failing 2017-07-18 16:32:47 -04:00
Adrian Sampson
8085d1318b Fix ipfs test to sort items in order 2017-06-20 16:19:31 -04:00
Adrian Sampson
2a9be17cf6 Fix some brittle query tests 
These were written to incidentally depend on Nones; the behavior they're
actually testing doesn't really have anything to say about None-ness.
 2017-06-20 15:56:33 -04:00
euri10
6664b656f4 Merge branch 'relativedate' 
Solved conflicts with upstream of new parse classmethod of DateQuery

# Conflicts:
#	beets/dbcore/query.py
 2017-06-15 08:59:43 +02:00
Adrian Sampson
ace5656e36 Complete set of __future__ imports 2017-06-14 19:08:27 -04:00
A.L. Kleijngeld
2eb4e3d515 Merge branch 'master' into master 2017-06-13 14:43:10 +02:00
Bart Kleijngeld
762f9ca054 revised to fix flake8 warnings 2017-06-13 14:33:08 +02:00
Adrian Sampson
dfde9ce916 Merge pull request #2510 from SpirosChadoulos/master 
New export command (issue #435)
 2017-06-11 12:21:06 -04:00
Adrian Sampson
389aed8d5d Merge pull request #2528 from discopatrick/query-datetime-parser 
Query datetime parser
 2017-06-10 20:57:29 -04:00
Adrian Sampson
15a7dfccff Merge pull request #2583 from yacoob/master 
Fix a lastgenre crash
 2017-06-10 20:47:19 -04:00
Adrian Sampson
0e47095bb0 Merge pull request #2560 from autrimpo/r128 
RFC: replaygain: R128 support
 2017-06-10 20:32:42 -04:00
Adrian Sampson
ca4f96e33c Consolidate export tests into MoveTest 
Just one new flag.
 2017-06-10 20:26:41 -04:00
Adrian Sampson
730c84e5e5 Correct tests for export mode 
The old tests were wrong but the incorrectness was hidden by the incorrect
parameter passing fixed in the previous commit. Now we actually test that the
item's path did not change.
 2017-06-10 20:25:48 -04:00
Adrian Sampson
714560aace Fix parameter order and binding 
The calls didn't match up with the parameter order.
 2017-06-10 20:19:27 -04:00
Adrian Sampson
b25eb87f60 Remove unnecessary output capture 2017-06-10 20:05:17 -04:00
Adrian Sampson
29d6c27d02 Fix some spurious whitespace changes 2017-06-10 20:03:01 -04:00
discopatrick
291b287f56 Add a test for a non-range date query 2017-06-05 16:31:37 +01:00
Jakub Turski
f6830b4bc3 Here, flake8, be happy. 2017-06-02 16:27:49 +01:00
Jakub Turski
0e7a0a62d4 Fix excessive line length. 2017-06-02 16:04:05 +01:00
Jakub Turski
a43f5fdace Remove unnecessary test setup parameter. 2017-06-02 15:50:58 +01:00
Jakub Turski
ee46a5150f Don't crash if non-canonical genre and prefer_specific: yes. 
Also, add a test for this.
 2017-06-02 15:48:05 +01:00
discopatrick
e1101d4e95 Update assertion with correct error name 2017-06-01 12:33:23 +01:00
Bart Kleijngeld
c64878179e finished tests for set_fields on importer 2017-06-01 11:57:24 +02:00
discopatrick
fbb868e5ed Merge branch 'master' into query-datetime-parser 2017-06-01 04:37:45 +01:00
Michal Koutenský
ddfe44266b r128 gain tags in mediafile test 2017-05-17 21:41:12 +02:00
Adrian Sampson
9840964f51 Fix #2562: avoid crash with newlines in templates 
Turns out! The $ character in Python regexes also matches before the last
newline at the end of a string, not just at the end of a string. The \Z entity
does what we really want: the *real* end of the string.
 2017-05-16 14:00:10 -04:00
Adrian Sampson
9ccaad27d3 Undo some noisy whitespace changes 2017-05-12 10:42:50 -04:00
Adrian Sampson
0cb643f35e Merge pull request #2529 from dosoe/master 
Add composer_sort as a tag
 2017-05-12 10:34:46 -04:00
SpirosChadoulos
8f62e8bc68 Requested changes done 2017-05-12 14:49:03 +03:00
SpirosChadoulos
c4ef23d9f7 Minor Flake fixes 2017-05-11 12:45:03 +03:00
SpirosChadoulos
51835e762f Minor fixes to move tests 2017-05-11 12:30:21 +03:00
SpirosChadoulos
0dc948d9d3 Made sure that the destination directory will exist 2017-05-11 12:11:21 +03:00
SpirosChadoulos
f5b23fffd4 Replaced all AssertNotExists with AssertExists 2017-05-06 15:03:42 +03:00
Fabrice Laporte
409f070970 Remove lyrics.com source 2017-05-03 22:54:09 +02:00
Fabrice Laporte
fc6b65d592 Merge pull request #2538 from Kraymer/lyrics-test 
Tests to track whether lyrics websites are correctly fetched
 2017-05-03 20:02:03 +02:00
Fabrice Laporte
8f32bfed82 Reactivate test of LyricsCom and MusiXmatch sources 2017-05-03 07:42:50 +02:00
Fabrice Laporte
f53ab801b8 Add indent 2017-05-03 00:11:26 +02:00
Fabrice Laporte
b3fbdbae5a Fix flake8 2017-05-03 00:02:09 +02:00
Fabrice Laporte
3e38a33c4a Fix PEP8 2017-05-02 23:37:20 +02:00
Fabrice Laporte
11eb90c758 Fix PEP8 2017-05-02 07:46:51 +02:00
Fabrice Laporte
3e3ad6974c Fix PEP8 2017-05-02 07:30:40 +02:00
Fabrice Laporte
fa9262d61b Disable tests that do real requests to lyrics sites by default. 
Set BEETS_TEST_LYRICS_SOURCES environment variable to '1' to not skip the
tests.
 2017-05-02 01:05:18 +02:00
Fabrice Laporte
d88cabc846 Divide LyricsGooglePluginTest into two classes. 
Move existing tests into LyricsGooglePluginMachineryTest.
Create LyricsPluginSourcesTest class to check fetching of each source.
Some code was supposed to do that until now but was never executed as we
exited early at the "if not check_lyrics_fetched():" check.
 2017-05-02 01:03:26 +02:00
Fabrice Laporte
a85dcd88c4 Store whole expected lyrics, not just keywords, but randomized 2017-05-02 00:56:56 +02:00
Fabrice Laporte
4e0527f07d Docstrings style 2017-05-02 00:54:58 +02:00
Fabrice Laporte
f8862ac0ea Sort imports 2017-05-02 00:52:07 +02:00
Adrian Sampson
84febb13c1 Merge pull request #2523 from discopatrick/rename-error 
Rename error
 2017-05-01 15:29:21 -04:00
SpirosChadoulos
a88192240e ExportTest correction 2017-04-30 15:14:17 +03:00
SpirosChadoulos
bab99f546f Added a test for the new export feature 2017-04-30 15:02:50 +03:00
dosoe
813b078d02 added composer_sort on test_mediafile.py since there is artist_sort 2017-04-29 18:47:03 +02:00
Jack Wilsdon
f622e42a88 Replace blind excepts with generic Exception excepts in tests 2017-04-29 00:12:14 +02:00
dosoe
23f172d03d if there is no artist_sort, there should not be a composer_sort. 2017-04-28 13:49:50 +02:00
dosoe
4a17da8e10 requested changes: where there is no artist_sort, there is no need for composer_sort; cleaning up whitespaces. 2017-04-28 13:41:54 +02:00
dosoe
d4ff82e46f adding image stuff for composer_sort 2017-04-28 12:45:31 +02:00
dosoe
e3c37981bb little indentation stuff 2017-04-28 12:13:27 +02:00
dosoe
c51ecd46e3 add composer_sort tag# 2017-04-28 12:10:02 +02:00
discopatrick
50a2e37a4d Keep function names lowercase to pass flake8 tests 2017-04-27 15:58:08 +01:00
discopatrick
6e6dd76513 Remove space separator tests from test_x_precision_intervals tests 
This is not the correct place for space separator tests. Each test
should test one thing only. Space separator tests are now in a separate
test case.
 2017-04-27 11:36:03 +01:00
discopatrick
5a3b74f681 Test an invalid datetime separator raises error 2017-04-27 11:29:45 +01:00
discopatrick
1ab913b200 Test each valid datetime separator 2017-04-27 11:28:10 +01:00
discopatrick
24890c77f1 Add a date query precision of ‘second’ 2017-04-27 00:24:17 +01:00
discopatrick
02bd19fb32 Allow minute precision queries to use space separator 2017-04-27 00:06:36 +01:00
discopatrick
c3771f722c Allow hour precision queries to use space separator 2017-04-27 00:04:46 +01:00
discopatrick
b8e1c5675e Fix tests 2017-04-25 02:25:50 +01:00
discopatrick
ba324df0d1 Add a date query precision of ‘minute’ 2017-04-25 01:38:31 +01:00
discopatrick
5f2c47ec18 Test further hour precision intervals 2017-04-25 01:38:31 +01:00
discopatrick
61b832990f Add a date query precision of ‘hour’ 2017-04-25 01:38:24 +01:00
discopatrick
58417526cb Rename InvalidQueryArgumentTypeError to InvalidQueryArgumentValueError 
The way we use `InvalidQueryArgumentTypeError` is more akin to a `ValueError` than a `TypeError`. For example, we try to parse a string as an int, float, or date, but the parsing fails - there was nothing wrong with the type of the variable (string), but its contents were not parseable into the type we wanted - there was a problem with the value of the string.
 2017-04-22 18:07:30 +01:00
Adrian Sampson
78f19db511 Merge pull request #2521 from tweitzel/master 
add --yes argument to play command
 2017-04-19 18:59:50 -04:00
xarph
02aa6191c1 rename --force to --yes in play plugin 
fix some pep8 goo
 2017-04-19 10:51:44 -07:00
Adrian Sampson
31c7330de4 Merge pull request #2517 from discopatrick/date-value-field-validation 
Date value field validation
 2017-04-19 11:36:18 -04:00
xarph
ffcaf33845 add -f argument to play command 2017-04-18 15:30:24 -07:00
Adrian Sampson
0cbb40869a Merge pull request #2403 from antlarr/master 
Run python2 or python3 depending on what's being used
 2017-04-15 11:28:45 -04:00
Adrian Sampson
fb7296711c Fix Windows encoding in convert stub (#2516) 2017-04-15 11:27:19 -04:00
discopatrick
d466f8802c passes flake8 2017-04-14 14:45:51 +01:00
discopatrick
ff4c0abcf1 tests ‘added’ instead of ‘mtime’ , and uses a correct date format 2017-04-14 13:05:13 +01:00
discopatrick
ed0ea1dee5 tests more invalid date queries 2017-04-14 01:49:58 +01:00
discopatrick
8e6909bf4b raises error when date string has too many components 2017-04-14 01:32:18 +01:00
discopatrick
a3251ef7c6 skips tests for now 2017-04-14 01:13:02 +01:00
discopatrick
1744ca6e88 raises error when dates passed to query as long numbers 2017-04-14 00:40:06 +01:00
Antonio Larrosa
85e0c0dcee Fixed E501 and E305 PEP8 errors 2017-04-04 09:08:30 +02:00
Antonio Larrosa
fa468ce9d1 Properly quote executable and command line parameter 
Use shlex.quote (on python3) or pipes.quote (on python2) to properly
quote the python executable and parameter instead of using single quotes
 2017-04-04 09:08:30 +02:00
Antonio Larrosa
44ddd2e8f5 Shell-escape sys.executable 
sys.executable needs to be shell-escaped on windows.
 2017-04-04 09:08:30 +02:00
Antonio Larrosa
42b4e54391 Use sys.executable instead of composing the executable name 
Better use sys.executable than using sys.version_info.major and compose
the name of the python executable.
 2017-04-04 09:08:30 +02:00
Antonio Larrosa
1e4378d636 Run python2 or python3 depending on what's used 
On a system with dependencies installed for python3 but not for python2,
we have to make sure python3 is used everywhere since 'python' might be running
the python2 interpreter.

This helps with some problems in #2400, but doesn't fix the issue completely.
 2017-04-04 09:08:30 +02:00
Aaron
64d69f0817 embedart: Added test case for inputting “no” option interactively. 2017-03-10 23:30:49 -08:00
Aaron
f6df3befac Added interactive test method for embedart plugin. 2017-03-08 19:06:09 -08:00
Adrian Sampson
5a71ce722a Simplify embedart test changes for #2422 
Whenever possible, it's nice to avoid using DummyIO---it can make debugging
difficult.
 2017-03-06 23:55:14 -05:00
Adrian Sampson
74df2788c0 Merge branch 'master' into Stunner-master 2017-03-06 23:51:10 -05:00
Adrian Sampson
17ad3e83db Test updates for #2466 fix 2017-03-03 12:10:26 -06:00
Aaron Jubbal
864aa11ec5 Merge branch 'master' into master 2017-02-21 04:43:45 -08:00
Jacob Gillespie
1fd22604fb Fix linter issues 2017-02-19 17:33:26 -06:00
Jacob Gillespie
902b955696 Fix test_hardlink_arrives 2017-02-19 17:22:01 -06:00
Jacob Gillespie
ccd0f5d129 Remove not-found hardlink test (the OS prevents this from happening) 2017-02-19 17:19:42 -06:00
Jacob Gillespie
b4efecb709 Add option to hardlink when importing 2017-02-19 15:56:13 -06:00
Aaron
d1ac893915 Style changes to pass PEP8 tests. 2017-02-13 01:58:31 -08:00
Aaron
9c97f95073 Updated embedart test cases to accomodate confirmation prompt. 2017-02-13 01:58:31 -08:00
euri10
d2cd4c0f21 Change relative date's format to further simplify it 
A relative date doesn't need to be prefixed by @ anymore.
The relative date pattern now displays named groups.
Digits have been change to [0-9] to avoid other digit characters.
Removed the @ character in tests.
Updated subsequent documentation.
 2017-01-31 16:56:03 +01:00
wordofglass
c252b9256b Merge pull request #2415 from beetbox/fetchart_cleanup 
fetchart: Clean-up data structures
 2017-01-30 10:18:33 +01:00
wordofglass
7c79d8ce89 fetchart: minor restructuring of tests. 2017-01-30 10:01:19 +01:00
euri10
e4a7d37a6d implementing changes asked 
corrected rst
fixed flake8 in test
 2017-01-29 11:49:22 +01:00
euri10
d48d1f8e3c fixed E226 flake8 2017-01-29 03:54:10 +01:00
euri10
af679de8ec using a pattern may avoid copy-paste error when used 3 times after 
fixed an error with the weeks that didn't use the sign correctly
added more tests, this is where py.test fixtures would shine
 2017-01-29 03:51:24 +01:00
euri10
3e76c219fb without dateutil 2017-01-28 22:39:37 +01:00
euri10
2b89b90ab6 tests flake8 fixed I think finally 2017-01-28 21:47:01 +01:00
euri10
8d054f3656 tests flake8 issues 
added some doc
 2017-01-28 21:40:26 +01:00
euri10
868746bb51 tests 2017-01-28 21:23:03 +01:00
wordofglass
bc582701ff fetchart: Internally pass settings in a cleaner way. 
Dump the 'extra' dictionary which only duplicated attributes of the
plugin onject in favor of passing a reference to the plugin directly.
 2017-01-25 00:01:05 +01:00
Adrian Sampson
3a6967eb7a Remove dependencies from convert_stub.py 
See: https://github.com/beetbox/beets/pull/2403#issuecomment-274358494
 2017-01-22 12:59:04 -08:00
diomekes
04f7915d41 change no-bracket argument from white space to empty 2017-01-20 22:47:47 -05:00
diomekes
eaa2161a90 fix empty disambig string test 2017-01-20 19:40:09 -05:00
diomekes
d10df34c65 add test for aunique without brackets 2017-01-20 09:06:38 -05:00
diomekes
3a967df396 simplify check for empty disam_val, update changelog and docs, add change bracket test 2017-01-19 20:41:44 -05:00
diomekes
377a2a6964 add bracket argument to aunique 2017-01-19 20:39:12 -05:00
Steve Johnson
e3707e45f3 Maybe fix code and tests for Windows 2017-01-15 11:21:59 -08:00
Steve Johnson
6b7a6baaf2 Add test for /item/path/ endpoint 2017-01-15 11:21:59 -08:00
Steve Johnson
05bc4996a8 Rename and invert new config option 2017-01-15 11:21:33 -08:00
Steve Johnson
cedd93b778 Add tests for exclude_paths_from_items 2017-01-15 11:21:33 -08:00
Adrian Sampson
0f1a93c666 Add missing unittest suite declaration (#2389) 2017-01-14 17:33:36 -08:00
Adrian Sampson
703f47ae97 Use flexible attribute for track_alt 
No need for a built-in field for a simple string-type optional field like
this.
 2017-01-10 21:01:36 -05:00
Mike Cameron
bba5a7c712 Fixed (?) failing test where 
umber was 	rack_alt was missing during import.
 2017-01-10 19:08:18 -05:00
Mike Cameron
3cd4f1c091 Fixed failing test where track number was missing from mocked data. 2017-01-10 18:57:42 -05:00
Mike Cameron
3f67a27989 Fixed failing test because mocked data was missing property 
umber.
 2017-01-10 18:21:28 -05:00
Adrian Sampson
f7ebf5524f flake8 fix for #2379 2017-01-10 13:25:24 -05:00
Adrian Sampson
f137f87878 More test docs about the image.* mixin 2017-01-10 12:41:34 -05:00
Adrian Sampson
5863859a5d Remove image tests for DSF (#2379) 
There isn't currently an `image.dsf`, so those tests fail.
 2017-01-10 12:38:44 -05:00
Adrian Sampson
5e20cfd26e flake8 fixes for 2379 2017-01-10 12:33:23 -05:00
Adrian Sampson
96350ab7db Merge pull request #2379 from docbobo/feature/dsf-support 
Support for DSF files
 2017-01-10 12:28:29 -05:00
Boris Pruessmann
e0a4dc67a8 Test improvements for DSF. 
- Fixed unparseable.dsf
- Added DSF feature detection to test_mediafile.py
 2017-01-10 11:21:40 +01:00
Adrian Sampson
a2d37dd588 Document how to add tests for a new format (#2379) 2017-01-09 13:02:28 -05:00
Boris Pruessmann
1e10e62d82 Added DSF to test_mediafile 2017-01-09 18:54:30 +01:00
Adrian Sampson
e5e710033c Remove old test for misspelled config option 
See 6b9d766, which removed the option.
 2017-01-07 17:19:02 -05:00
Adrian Sampson
fbc0f322f6 Merge branch 'tigranl-https_fix' 2017-01-02 20:54:17 -05:00
Adrian Sampson
33a8e81f08 Simplify test changes 
We don't need quite so many checks now that SSL isn't conditional most of the
time.
 2017-01-02 20:49:12 -05:00
Diego M. Rodriguez
37cb1c295f
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions 
Conflicts:
	docs/changelog.rst
	test/test_discogs.py
 2016-12-30 10:42:50 +01:00
Diego M. Rodriguez
0a9cb1fd3d
discogs: revise subtrack merging based on subindex 
Modify the coalescing of subtracks by taking into account the subindices
of the subtracks for deciding if they represent "logical" tracks
(merging them into one single track, as previously) or if they represent
physical tracks (treating them as individual tracks).
Add unit tests for nested logical/physical subtracks, and disc titles.
 2016-12-29 18:03:54 +01:00
Diego M. Rodriguez
4364757fcc
Merge remote-tracking branch 'upstream/master' into discogs-relax-assumptions 
Conflicts:
	docs/changelog.rst
 2016-12-29 13:27:06 +01:00
Diego M. Rodriguez
30f238151e
discogs: additional sanity checks parsing release 
Add extra checks for the presence of specific field (artists, title,
id, tracklist) when parsing a Release from discogs, failing gracefully
if the fields could not be found.
Add a test for releases without required fields.
 2016-12-29 13:19:01 +01:00
Diego M. Rodriguez
02666424d4
discogs: improve robustness when parsing an album 
Improve the robustness of `get_album_info()` by preferring the use of
`get()` over accesing the dictionary keys directly for several fields,
plus adding extra checks for fields that depend on nested containers on
the Release data.
Add a test for parsing a release that contains a minimal amount of
fields.
 2016-12-28 21:07:18 +01:00
Adrian Sampson
8763be5423 Revert "Fix tests for new prompt order" 
This reverts commit a357cc4e1a.

We no longer need the tests to change---I was able to fix the order by
bringing the "abort" action into the standard list of options.
 2016-12-28 14:33:11 -05:00
Adrian Sampson
a357cc4e1a Fix tests for new prompt order 2016-12-28 14:23:22 -05:00
Adrian Sampson
7c6eafa285 Refactor manual search options to use Proposal 
This is the first step to making them behave like plugin actions.
 2016-12-28 13:50:53 -05:00
Adrian Sampson
8408264142 Update test file for new set of tags 
The new MediaFile tags in #2333 mean that the `test_unicode_path` test will
write new tags to this test fixture file.
 2016-12-26 17:41:44 -05:00
Josh Brown
7833469261 add confirmation for empty query 2016-12-26 14:13:01 -06:00
Josh Brown
2903925e2f Rewrite zero plugin manual mode 2016-12-26 13:34:34 -06:00
Josh Brown
ef80229350 additional zero tests 2016-12-26 12:10:19 -06:00
Josh Brown
4cc4fe1290 added zero subcommand 2016-12-26 12:10:18 -06:00
nathdwek@laptop
7de97df209 Zero: rewrite tests. 
Rely on plugin interface only.
Unregister listeners by hand for the moment.
 2016-12-25 17:10:16 +01:00
Adrian Sampson
10f0d03d79 Test "true" FLAC bitrate from Mutagen 1.35 
Fix #2343.
 2016-12-23 20:23:23 -05:00
Shen-Ta Hsieh
7060b512b8 Add Composer, Lyricist and Arranger tags 
MusicBrainz provids composer, lyricist and arranger infomations related
to individual recordings. This commit adds query parameters to fetch them, and
write down to media files.

Tagging mapping is implemented according MusicBrainz Picard's data:
https://picard.musicbrainz.org/docs/mappings/

Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
 2016-12-21 01:52:42 +08:00
tigranl
0868299e92 PEP8 corrections 2016-12-10 20:08:27 +03:00
tigranl
68b4a03ecd Add tests for https 2016-12-10 19:54:44 +03:00
Adrian Sampson
4bbb05b009 Merge pull request #2303 from tweitzel/master 
Decompose unicode paths and unidecode each component. Fixes #1087 #1159 #1541 #2286
 2016-12-08 21:35:01 -05:00
tigranl
9bba178b5c Add tests for https 2016-12-08 18:44:17 +03:00
xarph
53a677b8fd * break the asciify-paths code out into the util.asciify_paths function 
* make asciifying handle both os.sep and os.altsep (testing needed as I
  don't have a windows box handy)
* make %asciify{} use the same code path as the asciify_paths goop.
* added a discrete test to %asciify{} so my life acts as a warning to
  others
* changelog note now with 80% less antihistamine-induced runon sentences
 2016-12-07 20:59:33 -08:00
xarph
cb8e57536c remove unused unicode_path_sep.mp3 2016-12-05 22:04:07 -08:00
xarph
4461835cda sampsyo's better test of unicode path escaping 
revert my lame test
 2016-12-05 22:03:00 -08:00
Adrian Sampson
ae5e55cad6 Always use syspath to construct MediaFile 
Related to #1966. Previously, we used a `syspath` call inside MediaFile, which
probably wasn't right: the constructor should behave like `open` in that we
need to use pass an OS path.
 2016-12-04 21:00:56 -05:00
xarph
87942af4c4 fix line wrapping for py34-flake8 2016-12-03 16:15:40 -08:00
xarph
edd34267c6 modify DestinationTest.test_asciify_and_replace to include unicode 
titles that decode to path separator.

Added an empty .mp3 file with problematic characters for asciify_paths
in id3v2 tags for future tests if needed.
 2016-12-03 15:29:27 -08:00
Adrian Sampson
9de27c6b70 Sync up with separate MediaFile repository 2016-11-26 20:48:12 -05:00
Adrian Sampson
d8c0a42e6c Avoid TestHelper dependency in MediaFile tests 
Part of #1966. This also introduces a nicer, more lightweight way to create and
destroy temporary directories, decoupling that functionality from the
giant morass that is TestHelper.
 2016-11-26 18:55:58 -05:00
Adrian Sampson
a88682e7bb Undo from _common import unittest indirection 
This was a vestige from when we used to need the unittest2 library for pre-2.7
compatibility. Now that we require Python 2.7, we aren't using that library
and this indirection wasn't doing any good.
 2016-11-26 18:46:44 -05:00
Adrian Sampson
24940c0de7 In MediaFile tests, use simpler import path 
This will make it easier to copy these tests into their own repository.
 2016-11-26 18:27:20 -05:00
Adrian Sampson
788654736d Obviate the need for a beets utility in MF tests 
Even more on #1966.
 2016-11-26 18:26:18 -05:00
Adrian Sampson
47049e1ff1 Avoid one last beets utility in MediaFile tests 
This is a little dirty, what with the hard-coded encoding, but I don't feel
too bad about it because we're only manipulating our test fixtures and
temporary directory that way.

More on #1966.
 2016-11-26 18:23:46 -05:00
Adrian Sampson
54cb0b2a15 Separate beets-specific MediaFile tests 
Part of the #1966 separation effort.
 2016-11-26 18:08:00 -05:00
Adrian Sampson
fc6658c110 Add a missing __future__ import 2016-11-26 17:31:54 -05:00
Adrian Sampson
d54ef99ea5 Fix a forgotten test 2016-11-25 21:33:44 -05:00
nathdwek@laptop
eb1ea6177d acousticbrainz: drop DefaultList, be explicitly careful 
* I don't see DefaultList be really helpful in many other cases, so having
  a beets.util.collections module (which could also conflict with the collections
  module from standard library) with only that in it is a little silly.
* It was elegant and concise, but there are implementation issues: it is not
  recommended to subclass builtin types, but the alternatives differ between python
  2 and 3 (subclass sequence or container or collections.abc?), moreover,
  interpreters can differ in the way they map syntaxic sugar to magic functions.
* Also, slicing and negative indexing could do weird things, so the class wouldn't
  be really intuitive and simple at the same time
 2016-11-20 22:03:41 +01:00
nathdwek@laptop
51243240f6 acousticbrainz: Test _map_data_to_scheme with real data 2016-11-20 22:03:41 +01:00
nath@home
4586e2df5a acousticbrainz: Add unit tests 2016-11-20 22:03:41 +01:00
Christoph Reiter
31f91129f3 Use mutagen id3 encoding constants 2016-11-19 10:36:31 +01:00
Christoph Reiter
31898111ed mediafile: prefer latin-1 encoding for ID3 APIC descriptions. Fixes #899 
iTunes has problems with everything but latin-1
Try to use latin-1 if possible and fall back to utf-16.
 2016-11-18 01:09:53 +01:00
Nathan Dwek
2eae2d6d17 Merge pull request #2262 from beetbox/fix-2260 
Convert: Don't prompt for confirmation if query result is empty
Fix #2260
 2016-11-13 20:37:09 +01:00
nathdwek@laptop
a0a9f5a7a8 Fix typos in tests 2016-11-13 17:49:18 +01:00
nathdwek@laptop
8067d82be8 convert: test for #2260 2016-11-13 17:47:07 +01:00
Adrian Sampson
d6242ec207 Tiny whitespace fix 2016-11-11 20:00:14 -05:00
michaelbub
58fe63764e reduced line length 2016-11-11 22:34:46 +01:00
michaelbub
0a88338f8b obey style guide 2016-11-11 16:23:32 +01:00
michaelbub
28d18b7c64 update test to run with python 3.5.2 2016-11-11 15:53:14 +01:00
michaelbub
0bdc621d99 sanitizing playlist name AFTER values have been filled in and updated test accordingly 2016-11-11 15:21:34 +01:00
michaelbub
5942adba01 fixed/updated test to consider sanitized playlist names 2016-11-11 10:07:25 +01:00
nathdwek@laptop
e782885e50 embedart: Adapt tests for #2254 2016-11-08 18:48:44 +01:00
nathdwek@laptop
a0877dc092 images: Make sure all jpegs work everywhere 
Apply #1545 to a public function used everywhere
 2016-11-08 18:48:44 +01:00
Dang Mai
04560bd88e Stop passing in fields to be stored for Item.move and Album.move 2016-10-23 15:52:27 -04:00
Dang Mai
f42f558db2 Fix long line for flake8 2016-10-20 21:21:50 -04:00
Dang Mai
406f3ce843 Add tests and make sure they pass 2016-10-20 21:07:12 -04:00
Dang Mai
679918f191 Fix some test failures 2016-10-20 00:28:28 -04:00
Diego Moreda
fc9f061574 discogs: add tests for medium, medium_total 
Add three tests for the setting of tracks' medium and medium_total on
the discogs plugin. test_parse_medium_numbers_single_medium is meant
to fail due to #587.
 2016-10-17 19:48:06 +02:00
Diego Moreda
f4907ca5d0 discogs: handle nested subtracks, add try block 
Modify coalesce_tracks() in order to handle the case where subtracks
are defined inside an index track (as `sub_tracks` attribute),
reorganizing the if logic to avoid duplicated code.

Add a try..catch block enclosing the call to clean_tracklist, as a
measure for avoiding side effects (and reverting to just parsing the
raw_list if there are any problems).
 2016-10-10 19:59:42 +02:00
Diego Moreda
fb398c5f2c discogs: add medium_total to tracks (#415) 2016-10-10 17:46:41 +02:00
Diego Moreda
1148acaaf1 discogs: revise position regexp, add tests, tox 
Revise the regular expression used for extracting information from a
discogs position, making the subtrack_index only be matched if one of
the other groups is matched as well. Split the definition into several
lines in order to try to document it a bit more clearly.
Add unit tests for position parsing and non standard positions.
Fix the underscore on tox dependency.
 2016-10-10 17:42:27 +02:00
Diego Moreda
1c63d0bbab discogs: add more unit tests 
Add unit tests covering the discogs standard positions (12.2.9). Clean
up a bit the helper methods (unused parameters, documentation).

https://www.discogs.com/help/submission-guidelines-release-trk.html#Position
 2016-10-07 18:44:55 +02:00
Diego Moreda
9c88998a5d discogs: add initial unit test skeleton 
Add a first skeleton for providing unit tests for the discogs plugin,
heavily inspired by test_mb, which adds a couple of method for creating
very simple and not comprehensive Bags that mimic discogs_client.Release
and discogs_client.Track.
Add a test for checking the problem of setting media for the Tracks.
 2016-10-06 19:31:55 +02:00