Commit graph

7812 commits

Author SHA1 Message Date
Max Ammann
7242c5ed03 Revert "Expose the relative path to the library instead of omitting the 'path' variable"
This reverts commit 5e8ac9e4a5, because of
a slowdown. Resolves #2182.
2016-10-26 23:08:44 +02:00
Adrian Sampson
bb9a107c56 Slight rewording in docs about SIP 2016-10-26 13:40:45 -04:00
Adrian Sampson
c4a5dc2436 "macOS" 2016-10-26 13:37:09 -04:00
Adrian Sampson
c2dbe8375b Merge pull request #2239 from claman/master
Add workaround for SIP
2016-10-26 13:36:08 -04:00
Alex Claman
ee22165876 Add workaround for SIP 2016-10-26 11:52:45 -05:00
Adrian Sampson
c426b76cce Changelog/thanks for #2231 2016-10-23 16:38:17 -04:00
Adrian Sampson
dab54043a1 Merge pull request #2231 from dangmai/selective-update
Selective field updates
2016-10-23 16:36:33 -04:00
Adrian Sampson
eef5746ae6 Merge pull request #2233 from beetbox/drop-reduce
Drop `reduce` imports
2016-10-23 16:16:38 -04:00
Dang Mai
05377ee7c4 Fixing line too long 2016-10-23 16:00:36 -04:00
Dang Mai
04560bd88e Stop passing in fields to be stored for Item.move and Album.move 2016-10-23 15:52:27 -04:00
nathdwek@laptop
cee6c5fe52 Rewrite match_by_id to fix next vs __next__ 2016-10-22 12:37:38 +02:00
nathdwek@laptop
e94676e322 Refactor match_by_id:
* Drop reduce
* Readability
2016-10-22 10:37:53 +02:00
Dang Mai
f91362a069 Cosmetic refactors based on feedback 2016-10-21 16:56:03 -04:00
Dang Mai
8d07bfe693 Documentation for new flag 2016-10-20 23:33:20 -04:00
Dang Mai
f42f558db2 Fix long line for flake8 2016-10-20 21:21:50 -04:00
Dang Mai
406f3ce843 Add tests and make sure they pass 2016-10-20 21:07:12 -04:00
Dang Mai
f17601e4cd Fix update test failures 2016-10-20 20:25:38 -04:00
Dang Mai
679918f191 Fix some test failures 2016-10-20 00:28:28 -04:00
Dang Mai
acd2b0ef77 First attempt for selective field updates 2016-10-20 00:04:07 -04:00
Diego M. Rodríguez
6402e05d5a Merge pull request #2228 from diego-plan9/discogs-disc0
discogs: set `track.medium` correctly for single medium albums
2016-10-19 14:58:55 +02:00
Diego Moreda
2604bc8e73 discogs: update changelog for medium 2016-10-17 20:02:39 +02:00
kooimens
373cf19f8b Fix discogs disc field is set to zero
Fixes #587. The disc field is only zero when there is only one medium, so I think this will do the trick. I wasn't able to reproduce the real problem within the code. This is just a small workaround.
2016-10-17 19:51:03 +02:00
Diego Moreda
fc9f061574 discogs: add tests for medium, medium_total
Add three tests for the setting of tracks' medium and medium_total on
the discogs plugin. test_parse_medium_numbers_single_medium is meant
to fail due to #587.
2016-10-17 19:48:06 +02:00
Diego M. Rodríguez
89c40914a5 Merge pull request #2222 from diego-plan9/discogs-fixes
Several discogs fixes
2016-10-17 16:55:43 +02:00
vapniks
44f33cabc7 Update _beet
update documentation
2016-10-10 19:45:03 +01:00
Diego Moreda
1f4bef9e61 discogs: docstring style fix 2016-10-10 20:30:21 +02:00
Diego Moreda
c5ae9c5bee discogs: update changelog 2016-10-10 20:27:42 +02:00
Diego Moreda
f4907ca5d0 discogs: handle nested subtracks, add try block
Modify coalesce_tracks() in order to handle the case where subtracks
are defined inside an index track (as `sub_tracks` attribute),
reorganizing the if logic to avoid duplicated code.

Add a try..catch block enclosing the call to clean_tracklist, as a
measure for avoiding side effects (and reverting to just parsing the
raw_list if there are any problems).
2016-10-10 19:59:42 +02:00
Diego Moreda
fb398c5f2c discogs: add medium_total to tracks (#415) 2016-10-10 17:46:41 +02:00
Diego Moreda
1148acaaf1 discogs: revise position regexp, add tests, tox
Revise the regular expression used for extracting information from a
discogs position, making the subtrack_index only be matched if one of
the other groups is matched as well. Split the definition into several
lines in order to try to document it a bit more clearly.
Add unit tests for position parsing and non standard positions.
Fix the underscore on tox dependency.
2016-10-10 17:42:27 +02:00
Diego Moreda
e7f2a111e4 discogs: add test dependencies, fix spelling 2016-10-09 17:57:36 +02:00
Adrian Sampson
13cf1bff8f Tiny text simplifications (#2223) 2016-10-08 18:41:16 -04:00
Nathan Dwek
4b88a879eb Merge pull request #2223 from beetbox/doc-play-small-fixes
Misc fixes to play documentation.
2016-10-08 20:44:26 +02:00
nath@home
8bd6181c6a doc-play: Fix a header level. 2016-10-08 14:47:38 +02:00
nath@home
f30c5da2ab doc-play: Fix an error and clarity:
{} is not used any more to determine the location of parameters
passed with --args.
Fix two sentences for clarity/fluidity. Display the plugin's
abilities in the intro.
2016-10-08 14:37:57 +02:00
Diego Moreda
be223d966e discogs: coalesce subtracks (#1543)
Detect subtracks and merge them into a single track, taking into account
the index tracks if present. This includes a revision of the regular
expression used for converting a discogs "position" into medium, medium
index and subtrack index pieces, following the standard discogs
positions (12.2.9).
2016-10-07 19:09:09 +02:00
Diego Moreda
c55885c9e8 discogs: take into account two-sided media (#1762)
Revise the discogs plugin so two-sided mediums are taking into account
and each pair of consecutive *sides* is treated as single *medium*.
2016-10-07 19:01:50 +02:00
Diego Moreda
1c63d0bbab discogs: add more unit tests
Add unit tests covering the discogs standard positions (12.2.9). Clean
up a bit the helper methods (unused parameters, documentation).

https://www.discogs.com/help/submission-guidelines-release-trk.html#Position
2016-10-07 18:44:55 +02:00
Diego Moreda
911117ef49 discogs: set media on tracks (#1921)
Set the media for all the tracks when fetching a release using discogs,
as autotag.apply_metadata requires it in order to work properly.
2016-10-06 19:49:43 +02:00
Diego Moreda
9c88998a5d discogs: add initial unit test skeleton
Add a first skeleton for providing unit tests for the discogs plugin,
heavily inspired by test_mb, which adds a couple of method for creating
very simple and not comprehensive Bags that mimic discogs_client.Release
and discogs_client.Track.
Add a test for checking the problem of setting media for the Tracks.
2016-10-06 19:31:55 +02:00
Diego M. Rodríguez
9dcd4f7367 Merge pull request #2213 from diego-plan9/template-comma-behaviour
Revise comma handling on templates
2016-10-04 18:17:49 +02:00
Diego Moreda
f0a14bfdd5 Fix documentation issues for %first
Fix a formatting problem related to sphinx not allowing spaces at the
beginning or end of an inline literal, and removed an extra sentence
at th end of the %first template function documentation.
2016-10-04 16:20:52 +02:00
Diego Moreda
0eb0353453 Revise documentation for commas in Parser 2016-10-04 16:17:26 +02:00
Diego Moreda
550206adb5 Add changelog for unescaped commas in Parser 2016-10-03 23:31:47 +02:00
Diego Moreda
c5da6296c4 Use flag instead of subclass for comma in Parser
Use a `in_argument` flag on Parser constructor for specifying if the
parser should treat commas as a special character, including the logic
in parse_expression.
2016-10-03 23:01:50 +02:00
Diego M. Rodríguez
36bc800309 Merge pull request #2215 from diego-plan9/types_queries
Do not attempt matching unset fields on DateQuery
2016-10-03 20:58:20 +02:00
Diego Moreda
b9b6dc47d1 Add changelog for #1938 2016-10-03 20:43:35 +02:00
Diego Moreda
bc8f422433 Do not attempt matching unset fields on DateQuery
Add a comparison at DateQuery.match in order to avoid comparing if the
field is not in the item.
Revise the existing types_plugin unit tests for explicitely checking the
behaviour when the values are unset.
2016-10-03 19:52:44 +02:00
vapniks
8671c83817 Delete _beet_cached 2016-10-02 19:54:39 +01:00
vapniks
5282d2882e Automatically generate cache file
This makes updating cache files easier; you just delete the old one and try completing again.
2016-10-02 19:54:10 +01:00