Adrian Sampson
66a22dffd9
Merge pull request #1711 from diego-plan9/editor
...
editor: add unit tests, minor changes
2015-11-09 17:11:04 -08:00
Diego Moreda
41b4987990
edit: add initial black-box tests
...
* Add tests for the edit plugin, including a helper for bypassing the manual
yaml editing. Tests are focused on "black-box" functionality, running the
command and making assertions on the changes made to the library.
2015-11-09 21:51:14 +01:00
Adrian Sampson
98f48237f5
Tiny docs tweaks for #1708
2015-11-08 13:04:26 -08:00
Adrian Sampson
9165b7cf45
Trailing comma ( #1708 )
2015-11-08 13:02:07 -08:00
Adrian Sampson
5bf344e149
Merge pull request #1708 from m-urban/config_va_name
...
Made various artist title configurable
2015-11-08 13:00:51 -08:00
Diego Moreda
1c09eeb714
edit: delete temporary files, minor style fixes
...
* Delete NamedTemporaryFiles once they are not needed on several functions
(change_objs(), vimdiff(), html()).
* Fix use of reserved word "id" on same_format().
* Colorize "really modify" prompt with action_default.
2015-11-08 19:37:10 +01:00
Manfred Urban
57faf015d9
Adapted va_name in other files
2015-11-08 17:28:55 +01:00
Manfred Urban
95b80b37aa
Updated documentation
2015-11-08 17:04:36 +01:00
Manfred Urban
485870f288
Made various artist title configurable
2015-11-08 16:22:36 +01:00
Diego Moreda
a71b2e1046
editor: update plugin name on examples on docs
2015-11-08 16:09:41 +01:00
Adrian Sampson
34e6e39fe5
mbsync: Debug logging
...
Log *something* for each album, so you can tell that it's doing something even
when there are no changes. To help diagnose #1707 .
2015-11-07 15:37:13 -08:00
Fabrice Laporte
57cf702668
Update index.rst
2015-11-07 23:18:30 +01:00
Adrian Sampson
80bfd186ae
Use should_write for modify, update, and mbsync
...
This should address the surprising situation in #1697 , where `import` went
fine but then `update` unexpectedly changed filenames.
2015-11-07 13:34:47 -08:00
Adrian Sampson
d78ee1cf28
Add a corresponding should_move wrapper
2015-11-07 13:26:21 -08:00
Adrian Sampson
9f7aa866bd
Use ui.should_write everywhere
...
There sure are a lot of plugins that want to write metadata!
2015-11-07 13:20:09 -08:00
Adrian Sampson
5b761f029e
A new should_write configuration wrapper
...
The idea is that it is so common to check whether we need to write tags (or
move files), and we're constantly re-implementing the same logic everywhere.
It's not even the prettiest logic, as it commingles the importer settings with
general settings. So it's important that we encapsulate the decision so we can
make it better in the future.
2015-11-07 13:14:33 -08:00
Adrian Sampson
331ced3cca
Use existing query mechanism
2015-11-07 12:51:22 -08:00
Adrian Sampson
417eb5e588
Remove use of nonexistent option
2015-11-07 12:46:35 -08:00
Adrian Sampson
519df6da04
Use standard output format for confirmation
2015-11-07 12:45:39 -08:00
Adrian Sampson
7de33c83c4
Remove an unused parameter
2015-11-07 12:39:31 -08:00
Adrian Sampson
fefb2e9914
A little cleanup for legibility and style
2015-11-07 12:36:22 -08:00
Adrian Sampson
cb6edb46ef
Use ` instead of * for plugin event names
2015-11-07 12:12:48 -08:00
Adrian Sampson
4e20ddcef9
Doc refinements for #1499
2015-11-07 12:11:05 -08:00
Adrian Sampson
4baf9eba56
Move changelog entry for #1499
2015-11-07 12:07:17 -08:00
Adrian Sampson
b2512b3271
Merge pull request #1499 from m-urban/tag-change-hook
...
#872 : Tag change hooks
2015-11-07 12:06:17 -08:00
Manfred Urban
6e980a977e
Reverted to original approach
2015-11-07 19:28:34 +01:00
Manfred Urban
d8851b97b8
Fixed Travis errors
2015-11-07 17:59:25 +01:00
Manfred Urban
b2efd60162
Needed to find new spot to emit events because hooks.*_for_id -methods are only called when searching for explicit IDs
2015-11-07 17:51:44 +01:00
Manfred Urban
e9ddb92c2d
- Simplified code
...
- Fixed wrong event being emitted
2015-11-07 15:37:12 +01:00
Adrian Sampson
1f6a26d2b4
Spruce up the docs for #1692
2015-11-06 13:04:06 -08:00
Adrian Sampson
7413e17782
Merge pull request #1692 from kooimens/patch-2
...
Discogs: change album artist to musicbrainz naming
2015-11-06 13:01:23 -08:00
kooimens
1150f65ee3
Update changelog.rst
2015-11-06 20:01:56 +01:00
kooimens
7d02d7da29
Update changelog.rst
2015-11-06 20:00:36 +01:00
kooimens
c204795153
Update changelog
2015-11-06 19:56:19 +01:00
kooimens
b11533b98f
Update discogs docs
2015-11-06 19:45:05 +01:00
kooimens
414ae131a5
Fix style error
2015-11-06 19:27:36 +01:00
Fabrice Laporte
d84c776dc1
list options in alphabetic order
2015-11-06 13:44:38 +01:00
Adrian Sampson
33d3ebf53f
Link to a 3rd-party plugin: beets-usertag ( #1694 )
2015-11-05 18:31:16 -08:00
jmwatte
f95611dde4
fixed albumid needs to be int
2015-11-05 16:51:33 +01:00
Manfred Urban
17b38a6be8
Minor layout fixes to documentation
2015-11-05 16:43:28 +01:00
Manfred Urban
5e4c41ffe8
Clarified documentation
2015-11-05 16:37:35 +01:00
Manfred Urban
ae0babb17e
Less duplicated text in documentation
2015-11-05 16:17:19 +01:00
jmwatte
17a32e33c5
added grouping of fields and "$BROWSER" and "$EDITOR"
2015-11-05 15:41:33 +01:00
jmwatte
51658a7ea6
Merge branch 'editor' of https://github.com/jmwatte/beets into editor
2015-11-05 15:18:46 +01:00
Manfred Urban
1708939f99
- Added hooks to manipulate fetched album and track info
...
- Integrated support for plugins
- Added documentation
- Updated changelog
2015-11-05 15:17:58 +01:00
jmwatte
ab3bc356b2
updateMerge branch 'master' of https://github.com/sampsyo/beets into editor
2015-11-05 15:13:07 +01:00
kooimens
da0360bd90
Update discogs.py
2015-11-05 14:50:40 +01:00
Adrian Sampson
7d52fa72ae
Fix #1699 : Outdated API call
...
get_fields() was removed in 5420599839 .
2015-11-04 20:25:17 -08:00
Adrian Sampson
19cf37263d
Fix #1700 : Tolerate missing Location in iTunes
2015-11-04 20:11:58 -08:00
Adrian Sampson
be49955884
metasync: More precise exception catching ( #1700 )
2015-11-04 20:07:49 -08:00