Commit graph

6139 commits

Author SHA1 Message Date
Adrian Sampson
6e3d72afa6 Merge pull request #1846 from diego-plan9/interactiveedit
edit: allow interactive editing during the importer
2016-02-07 14:34:54 -08:00
Adrian Sampson
314521b6ae replaygain: Fix obvious typo (fix #1873, I hope) 2016-02-07 14:28:33 -08:00
Adrian Sampson
9fb54b2b30 Merge pull request #1869 from svenstaro/patch-4
Add some more docs to canonicalization with example
2016-02-06 09:46:51 -08:00
Sven-Hendrik Haase
945ef18164 Some typesetting 2016-02-06 08:45:32 +01:00
Sven-Hendrik Haase
14db7ea6ec Add snippets for canonicalization 2016-02-06 08:44:17 +01:00
Adrian Sampson
33f03ebd3a Merge pull request #1868 from SJoshBrown/master
Use beets API key for lastimport plugin.
2016-02-05 23:20:38 -08:00
Sven-Hendrik Haase
10d44fe526 Add some more docs to canonicalization with example
It really didn't make sense to me before I did some further research. You shouldn't have to do further research to understand this apart form reading the docs.
2016-02-06 07:46:31 +01:00
Josh Brown
94b9d786b5 add to changelog 2016-02-06 00:42:23 -06:00
Josh Brown
ea36c5a825 Allow default lastfm key to be overridden in config 2016-02-06 00:41:59 -06:00
Josh Brown
0f155ce3b9 Use beets API key for lastimport plugin. 2016-02-05 23:50:24 -06:00
Diego Moreda
763813fdf7 edit: add documentation
* Add documentation to plugins/edit.rst about the execution of the
plugin during the importer.
2016-02-05 13:12:46 +01:00
Diego Moreda
7f75a066bd edit: RETAG importer fixes and docstrings
* Remove the RETAG-specific logic on align_album_level_fields, assuming
that the user will always make sure to have proper data on the first
item.
* Revise some docstrings and comments in order to clarify the use of
RETAG.
2016-02-05 12:38:50 +01:00
Diego Moreda
8d3f9a573c edit: revert album-field changes, use temporary id
* Revert the changes related to allowing the album- and item-level
fields to be edited at the same time, as the increase in complexity
was deemed excesive during review.
* Modify the interactive execution so temporary Item.id's are used,
removing the extra functionality needed for dealing with both id and
path as reference fields.
* Docstrings and comments cleanup.
2016-02-05 12:35:11 +01:00
Adrian Sampson
19a5d8c45f Add failing test for #1865 2016-02-04 11:35:23 -08:00
Adrian Sampson
25045245d6 Use two items when testing path queries 2016-02-04 11:29:11 -08:00
Adrian Sampson
cf4e075b3f Merge pull request #1864 from pkess/doc_for_move_and_modify
Documentation for changes by #1843
2016-02-04 09:44:39 -08:00
Peter Kessen
f6b81c1bdd Made changes suggested by @sampsyo 2016-02-04 18:35:01 +01:00
Peter Kessen
fac814421a Added documentation for changes by #1843 2016-02-04 17:59:59 +01:00
Peter Kessen
19f2cea5bf Merge branch 'selective_modify2'
Conflicts:
	docs/changelog.rst

closes #1843
2016-02-04 17:57:35 +01:00
Adrian Sampson
f9b9731b5a Merge pull request #1860 from svenstaro/patch-3
Link to nested genre names
2016-02-03 19:33:59 -08:00
Sven-Hendrik Haase
45cc4300b7 Link to nested genre names
The internal whitelist is already linked, this one should be, too!
2016-02-04 03:39:51 +01:00
Adrian Sampson
bd32066c91 Merge pull request #1857 from svenstaro/patch-1
Fix grammar
2016-02-03 14:24:31 -08:00
Adrian Sampson
60c26c65f1 Merge pull request #1858 from svenstaro/patch-2
Fix typo
2016-02-03 14:22:54 -08:00
Sven-Hendrik Haase
38a86054a5 Fix typo 2016-02-03 22:30:25 +01:00
Sven-Hendrik Haase
a942719ffc Fix grammar 2016-02-03 20:38:29 +01:00
Peter Kessen
89d38caea6 added comment 2016-02-03 19:14:12 +01:00
Diego Moreda
7b6c2c36d3 edit: fix Plugin not unloaded during tests 2016-02-03 19:05:38 +01:00
Peter Kessen
f550dfecf1 changed prompt for input_select_items
moved question mark and removed word "item"
2016-02-03 18:53:31 +01:00
Diego Moreda
0ba8f83929 edit: allow edit album+item fields in single yaml
* Add support for editing both the item fields and the album fields in
a single YAML file, by appending an Album-like object as the front of
the objects to be edited.
* The FakeAlbum class provides that object, mimicking the original
Album behaviour and including an _apply_changes() method that propagates
the changes read from the yaml onto the Items.
* Modify edit_objects() so the flattening of the objects takes into
account the type of object, using different fields for Albums and for
Items.
* Renamed apply() to apply_() to prevent an IDE warning about reusing a
reserved built-in symbol.
2016-02-03 17:34:39 +01:00
Diego Moreda
32f9bd5077 edit: add tests for interactive importer execution
* Add EditDuringImporterTest test case, covering the running of the
plugin during an import session. Includes editing the "album" field
and applying/discarding for both editing from items and editing from
a candidate; and editing and applying for singletons for both editing
from items and editing from a candidate.
2016-02-03 17:17:48 +01:00
Diego Moreda
0e649e549a edit: add RETAG support for singleton, fix logic
* Add support for the RETAG action to SingletonImportTask.
* Modify ImportTask.align_album_level_fields() so the source of the
information is a bit more intelligent in the RETAG case instead of
always assuming the items come from applied metadata.
2016-02-03 17:13:33 +01:00
Adrian Sampson
09a21eac56 Stray trailing whitespace 2016-02-02 08:16:02 -08:00
Adrian Sampson
60888274c4 lyrics: Re-disable Genius backend
As #1854 pointed out, the Genius API service is down *again*.
2016-02-02 08:14:22 -08:00
Adrian Sampson
0aea7e398b replaygain: Handle missing GStreamer data (#1855) 2016-02-02 08:08:58 -08:00
Diego Moreda
b8ec22ca34 edit: use action.RETAG, cleanup
* Make the edit plugin return action.RETAG when invoked during an
interactive import session, making the importer handle the writing of
the tags to the files (if needed) properly.
* Move the logic relative to the "reference field" to
_set_reference_field(), simplifying a bit the functions that depend on
this field.
* Hide the "edit Candidates" choice if no candidates are found.
2016-02-01 18:57:03 +01:00
Diego Moreda
e23718dc0c Add importer RETAG action
* Add importer "RETAG" action, to represent the case where the files
metadata has been modified by some mean other than applying metadata
(via a plugin), and as a result needs to be written to disk if the
"write" config flag is set.
2016-02-01 18:51:24 +01:00
Adrian Sampson
e3e34b13e4 Merge pull request #1853 from stragu/patch-1
typo: "how" -> "show"
2016-01-31 16:28:59 -08:00
Stéphane Guillou
694738504a typo: "how" -> "show" 2016-02-01 10:19:51 +10:00
Peter Kessen
8412bd0f23 renamed print_modify_item to print_and_modify 2016-01-30 09:45:50 +01:00
Diego Moreda
b472e1e450 Merge branch 'master' of github.com:sampsyo/beets into interactiveedit 2016-01-29 20:20:56 +01:00
Adrian Sampson
da46a62772 Merge pull request #1848 from diego-plan9/master
Update documentation copyright year to 2016
2016-01-29 11:18:26 -08:00
Diego Moreda
6eed42d2ab Update documentation copyright year to 2016 2016-01-29 20:11:26 +01:00
Diego Moreda
30927a901f Fix flake8 error 2016-01-29 19:54:23 +01:00
Diego Moreda
98abe69520 edit: invoke editor during importer, on Items
* Initial draft for invoking the edit plugin during an importer session.
* Add prompt choices for editing the original file tags ("eDit") and
apply a candidate and then edit ("edit Candidates").
* Modify plugin (_get_fields, apply_data, edit_objects) so "path" can be
used as a reference field instead of "id", as the Items are not still on
the database when the plugin is invoked via the importer.
* Modify ImportTask.manipulate_files() with a temporary flag for writing
the item tags even if ASIS was selected.
2016-01-29 17:09:12 +01:00
Peter Kessen
34e455b2ea changed docstring for print_modify_item 2016-01-29 16:21:39 +01:00
Peter Kessen
5747c6ae68 changed "Selecive" to "Select items" in ui 2016-01-29 16:19:31 +01:00
Adrian Sampson
d093ef9a47 A little more documentation for fields (#1818) 2016-01-28 13:52:07 -08:00
Adrian Sampson
7b88dc5760 Couple printer function with fields_func (#1818)
This isn't really a generic utility, since it is hard-coded to print the "key"
field of the result. So let's pair it with the place it's used.
2016-01-28 13:50:10 -08:00
Adrian Sampson
5ff14742b8 Simpler row lookup (#1818) 2016-01-28 13:48:20 -08:00
Adrian Sampson
6707eda4e4 Merge pull request #1818 from GuilhermeHideki/fields-print-flexattr
beet fields: Print flexible attributes
2016-01-28 13:46:40 -08:00