Johnny Robeson
69c9fb8b07
check dirname result against b'' in fetchart
2016-06-10 02:52:58 -04:00
Johnny Robeson
5e62b39f75
replace TEMPORARY with FIXME in discogs plugin
...
We're more likely to search for this later by FIXME.
NOTE: the bug is fixed, but the versions with the fix may not be widely
distributed yet
2016-06-10 02:30:00 -04:00
Johnny Robeson
5485bdb706
add missing b' in discogs query regex
2016-06-10 02:23:14 -04:00
Johnny Robeson
ab67727283
wrap the cover_names map with a list in fetchart
...
most `cover_names` users expect to operate on a list
2016-06-10 00:09:15 -04:00
Johnny Robeson
02165fc3a9
open lastgenre whitelist in binary mode
2016-06-09 23:53:40 -04:00
Adrian Sampson
f400a2431e
fetchart: Fix path types on Windows
2016-06-08 10:20:25 -07:00
Johnny Robeson
790b1b5153
replace some filter/map calls with list comps
...
These are places where the surrounding/calling code needs a list, not an iter.
2016-06-08 00:17:18 -04:00
Adrian Sampson
b752a58ed6
Improve a couple of docstrings
2016-06-05 12:16:41 -07:00
Adrian Sampson
0051bdb506
lyrics: Avoid a spurious warning
2016-06-02 21:33:33 -07:00
Adrian Sampson
ae7990322a
Merge pull request #2032 from pszxzsd/bs1770
...
make bs1770gain calculate sample peak instead of true peak
2016-06-02 16:17:04 -07:00
Adrian Sampson
581fba6288
lyrics: Avoid crash when enabling google
...
If you *both* haven't set an API key *and* BeautifulSoup wasn't
installed, the list.remove() call would crash. (This came up when
running the tests on a fresh machine without many dependencies.)
2016-06-02 11:58:14 -07:00
pszxzsd
8dcd50b18f
make bs1770gain calculate sample peak instead of true peak
2016-06-01 20:00:08 +02:00
Adrian Sampson
33a4767eaf
Portable mock command for testing convert plugin
2016-05-31 11:48:29 -07:00
Adrian Sampson
395877d903
Remove the Echo Nest plugin 😢 ( #1920 )
2016-05-30 22:25:58 -07:00
Johnny Robeson
81484529c9
remove b' from a few more stdlib calls
2016-05-31 00:13:09 -04:00
Johnny Robeson
330306bbe2
remove bytes casts from object/method resolution code
2016-05-30 23:21:24 -04:00
Johnny Robeson
e6ab231f72
Revert "Remove bytes casting for non-path command args/opts"
...
This reverts commit 2a6e74bc27 .
2016-05-30 22:00:42 -04:00
Johnny Robeson
2a6e74bc27
Remove bytes casting for non-path command args/opts
2016-05-30 21:42:44 -04:00
Johnny Robeson
94bab42f97
use strings (not bytes) for flask responder names
2016-05-30 21:19:15 -04:00
Adrian Sampson
71b9fd785c
Revert "Do __name__ comparison with bytes and not unicode"
...
This reverts commit 9c41c39913 .
That commit used byte strings for the `if __name__ == '__main__'` pattern,
which was necessary when we were doing unicode_literals. But it is wrong on
Python 3, and now that we're liberated from unicode_literals, we need to go
back to native strings for this comparison.
2016-05-29 19:19:59 -07:00
Adrian Sampson
59435792e9
Merge pull request #2010 from sumpfralle/web-api-unique-results
...
web: add API functions for retrieving unique values of specific keys
2016-05-27 00:15:34 -07:00
Johnny Robeson
a405a072f7
use reduce() from functools
2016-05-26 23:52:35 -04:00
Lars Kruse
d50923553d
web: add API functions for retrieving unique values of specific keys
...
the following API paths are added:
* /item/values/FIELD
* /album/values/FIELD
Both paths will deliver a json dictionary with the key 'values' containing a
list of unique values belonging to the requested table and field.
Sorting is possible by supplying the query argument "sort_key".
This feature is useful for remote clients, e.g. Mopidy-Beets:
* track genres: /item/unique/genre
* track languages: /album/unique/language
* album artists: /album/unique/albumartist?sort_key=albumartist_sort
* album years: /album/unique/year
2016-05-27 04:12:09 +02:00
Lars Kruse
be4dc227fc
web: handle missing art gracefully
2016-05-24 03:05:51 +02:00
Frederik “Freso” S. Olesen
37b9360706
acousticbrainz plugin: Access acousticbrainz.org over HTTPS.
2016-05-20 01:08:15 +02:00
Adrian Sampson
ef7cca4c12
Fix #2005 : list AIFF as a lossless format
2016-05-18 11:24:34 -07:00
Jack Wilsdon
5f3c27990d
Merge pull request #1974 from jackwilsdon/make-convert-extension-optional
...
Make convert extension optional
2016-05-08 16:30:30 +01:00
Jack Wilsdon
982272deb3
Merge pull request #1981 from jackwilsdon/fix-hook-unicode
...
Fix command formatting for hook plugin
2016-05-03 17:45:38 +01:00
Profpatsch
2d36626d25
convert plugin: Change the default ogg quality
...
According to the `oggenc(1)` man page (in vorbis-tools), the default quality is 3, not 2. So we should use that.
2016-05-02 01:53:20 +02:00
Jack Wilsdon
92af723682
Format individual command pieces instead of whole command
2016-05-01 23:04:22 +01:00
Jack Wilsdon
9f0db13675
Remove unnecessary variable
2016-05-01 21:44:40 +01:00
Jack Wilsdon
63caf1fceb
Add documentation for coding formatter
2016-05-01 21:44:05 +01:00
Jack Wilsdon
ba7004de6e
Remove unneeded AutoFieldCountFormatter
2016-05-01 21:33:06 +01:00
Jack Wilsdon
e66981c4d8
Use beets shlex_split instead of shlex.split
2016-05-01 21:31:53 +01:00
Jack Wilsdon
b4715d61e1
Fix over-indentation of wrapped code
2016-05-01 21:30:20 +01:00
Jack Wilsdon
576ec92992
Fix encoding for hook plugin
...
- Add a AutoFieldCountFormatter formatter for auto field
incrementation.
- Add a CodingFormatter for formatting encoded strings.
- Fix encoding for hook plugin using CodingFormatter.
2016-05-01 21:21:40 +01:00
Adrian Sampson
04bbdede38
hook: Typed configuration accessors
2016-05-01 13:04:35 -07:00
Jack Wilsdon
b9464d1ea4
Use unicode for command formatting
2016-05-01 18:26:06 +01:00
Patrik
2f608fce0a
convert.py: Fix error message
2016-05-01 01:53:03 +02:00
Patrik
4f596725ae
convert.py: Fix error message
2016-05-01 01:27:02 +02:00
Adrian Sampson
950e1b5e85
Merge pull request #1603 from jackwilsdon/add-hook-plugin
...
Add hook plugin (fixes #1561 )
2016-04-30 15:03:42 -07:00
wordofglass
1dd6739218
lyrics: fix a bug where the lyricswiki fetcher would try to unescape an empty (None) response and crash
2016-04-30 01:25:02 +02:00
Jack Wilsdon
ae9ece1e62
Make format extension optional
...
The format extension defaults to the name of the format if it is not
provided.
2016-04-29 14:51:13 +01:00
wordofglass
c3c7da8061
lyrics: simplify source handling a little
2016-04-28 18:31:22 +02:00
wordofglass
2928a16bd5
lyrics: actually disable translation when there's no langdetect
2016-04-28 17:22:55 +02:00
wordofglass
c4b11f889f
lyrics: clean up import handling and source removal
2016-04-28 17:15:25 +02:00
Jack Wilsdon
7c9440cf13
Merge master back in to fork
2016-04-28 04:15:02 +01:00
Jack Wilsdon
48fff93e78
Merge pull request #1961 from jackwilsdon/pep8-naming
...
Add flake8 check for pep8 naming
2016-04-28 04:07:17 +01:00
Jack Wilsdon
79d602b2a0
Use correct methods for ImageMagick and PIL info
2016-04-27 20:41:09 +01:00
Jack Wilsdon
8317a20bcd
Use correct methods from art resizer
2016-04-27 20:34:28 +01:00