Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-22 08:34:23 +01:00
Code Issues Projects Releases Wiki Activity
9149 commits 41 branches 64 tags 68 MiB
Commit graph

2921 commits

Author SHA1 Message Date
Carl Suster
36c85a8aeb Fix beets.util.inspect for Python 3 
Under the original compatibility shim we weren't correctly inclusing
`self` in the argument list for bound methods.
 2019-04-02 10:11:43 +11:00
Carl Suster
9622e7433b bpd: return real audio data 2019-04-02 09:44:34 +11:00
Carl Suster
e839e4ea19 bpd: improve exception handling 
Check function signature instead of using TypeError to crudely guess
that the wrong number of arguments were provided.

Prevent bpd from crashing when trying to log a traceback. The
`traceback.format_exc` function takes an optional argument which is
supposed to be an integer restricting the length of the backtrace to
show. Instead we were passing the exception object to this function and
causing a new exception to be raised.
 2019-04-02 09:39:07 +11:00
Carl Suster
146c5f5e13 bpd: fix repeat, consume and single in reverse 
These flags are all relevant to the 'previous' command as well as the
'next' command.
 2019-04-01 18:05:10 +11:00
Carl Suster
12e49b3c88 bpd: skipping backwards through zero keeps playing 
Previously issuing the 'previous' command when at position 0 on the
playlist would cause bpd to stop playing. MPD instead just restarts the
currently playing song instead, so we now match this behaviour.
 2019-04-01 17:51:21 +11:00
Carl Suster
a4fe6875a1 bpd: fix bug in bounds check of current song index 
The songs are indexed starting from zero for the play command, however
the bound check was off by one. An index matching the length of the
playlist would crash the server instead of responding with an error
message over the protocol.
 2019-04-01 17:41:25 +11:00
Carl Suster
0c3a63ef9f bpd: fix repeat mode behaviour 
The repeat flag indicates that the entire playlist should be repeated.
If both the repeat and single flags are set then this triggers the old
behaviour of looping over a single track.
 2019-04-01 17:39:35 +11:00
Carl Suster
b245c0e755 bpd: test fields returned by status command 2019-04-01 16:42:39 +11:00
Carl Suster
bae9c40600 bpd: support the single command 
This command instructs bpd to stop playing when the current song
finishes. In the MPD 0.20 protocol this flag gains a value 'oneshot' but
for now we just support its older version with a boolean value.
 2019-04-01 16:30:02 +11:00
Carl Suster
71e7621642 bpd: no-op support for persistent playlists 
The real MPD offers persistent playlist manipulation, storing the
playlists in a directory set in the config file. If that directory is
not available then the feature is disabled and the relevant commands all
respond with errors. Based on this, the initial support in bpd just
returns errors matching the MPD server in the disabled mode.

For playlistadd, extend the _bpd_add helper to work with playlists other
than the queue in order to support testing the real implementations of
these commands in the future.
 2019-04-01 16:30:02 +11:00
Carl Suster
859e16d1e3 bpd: support consume command 2019-04-01 16:30:02 +11:00
Carl Suster
e5851866d7 bpd: add replay_gain_* commands 
There's a special status command for checking the replay gain mode,
which can be set to one of a short list of possible values. For now at
least we can ignore this feature, but track the setting anyway.
 2019-04-01 14:49:27 +11:00
Carl Suster
67a0b38d20 bpd: add dummy command for volume 
MPD supports a deprecated command 'volume' which was used to change the
volume by a relative amount unlike its replacement 'setvol' which uses
an absolute amount. As far as I can tell 'volume' always responds with a system
error message "No mixer".
 2019-04-01 14:49:27 +11:00
Carl Suster
1511e313f7 bpd: add mixramp commands 
These are a more sophisticated version of crossfade so we're free to
ignore them, at least for now. We now track the values of the two
settings, and show them in the status output. Like MPD, we suppress the
mixrampdb value if it's set to nan, which is how it signals that the
feature should be turned off.
 2019-04-01 14:49:27 +11:00
Carl Suster
0f53ae9a87 bpd: error instead of crashing on extra argument 
If an MPC client is expecting a command to take an argument that bpd
isn't expecting (e.g. because of a difference in protocol versions) then
bpd currently crashes completely. Instead, do what the real MPD does and
return an error message over the protocol.
 2019-04-01 14:49:27 +11:00
Carl Suster
d94a5393b2 bpd: fix crossfade command 
Although crossfade is not implemented in bpd, we can store the setting
and repeat is back to clients. Also log a warning that the operation is
not implemented.

The real MPD doesn't show the crossfade in status if it's zero since
that means no crossfade, so now we don't either.
 2019-04-01 14:49:27 +11:00
Adrian Sampson
c74a7059b4 Merge pull request #3192 from translit/yaml-safe-load 
Fix PyYAML yaml.load(input) Deprecation
 2019-03-31 21:46:29 -04:00
Adrian Sampson
0208ec69ef Merge pull request #3197 from arcresu/deprecation 
Fix several deprecation warnings
 2019-03-31 21:44:37 -04:00
Adrian Sampson
0042f3205e Merge pull request #3196 from arcresu/bpd-log 
bpd: use plugin logger instead of global logger
 2019-03-31 21:41:22 -04:00
Carl Suster
b4c4f3ca19 bpd: use plugin logger instead of global logger 2019-03-31 22:06:43 +11:00
Carl Suster
a6305c36e1 Fix deprecated plistlib function 
https://docs.python.org/3.7/library/plistlib.html#plistlib.readPlist
 2019-03-31 19:53:17 +11:00
Carl Suster
e4c03fd63f Fix deprecated placement of inline regex flags 
https://bugs.python.org/issue22493
 2019-03-31 19:44:49 +11:00
Carl Suster
ca60555ffa Fix deprecated call log.warn -> log.warning 
https://bugs.python.org/issue13235
 2019-03-31 19:44:40 +11:00
Carl Suster
7557bb06d6 bpd: use log instead of stdout 2019-03-31 18:43:18 +11:00
Carl Suster
0b4293de6e
the: log a debug only when text is changed 
Previously the `the` plugin would log a debug message when the text _didn't_ get changed by the plugin, whereas I think what was intended was the opposite. With this change the logged messages show the actual transformations made by the plugin.
 2019-03-31 18:19:09 +11:00
Alexei Datskevich
be12a89372 Fix PyYAML yaml.load(input) Deprecation 2019-03-30 08:34:13 +01:00
Adrian Sampson
6ee824fb0f Fix #3184: AttributeError in error handler 2019-03-14 09:53:32 -04:00
Jack Wilsdon
9bb6c29d22
Always use custom formatter for formatting hook commands 2019-02-25 14:41:59 +00:00
Adrian Sampson
80f4f0a0f2 badfiles: Fix decoding for command output 
Probably fixes #3165. There were several things going wrong here:

1. For some reason, this was using the *filesystem* encoding, which is
   what you use to decode filenames. But this was general command
   output, not filenames.
2. Errors in decoding threw exceptions, even though all we do with this
   output is show it to the user.
3. The prints were using `displayable_path`, even though the lines are
   *already* Unicode strings.

Hopefully this cleans up that mess.
 2019-02-24 16:06:36 -05:00
Jan Holthuis
3e10d5d39f badfiles: Fix #3158 by calling superclass __init__ method 2019-02-21 12:40:54 +01:00
Adrian Sampson
be118b922a
Merge pull request #3155 from Holzhaus/fetchart-error-handling 
fetchart: Add some error handling to prevent crashes
 2019-02-20 08:45:22 -05:00
Bernardo Meurer
9374983e9d
Fixed import order 2019-02-19 18:49:29 -08:00
Bernardo Meurer
e209fe5886
Parallelized beet bad 2019-02-19 18:47:47 -08:00
Jan Holthuis
c07903ed66 fetchart: Add some error handling to prevent crashes 
Today I had some network problems regarding dbpedia.org, which made
beets crash because a requests.exceptions.ConnectionError was raised
("[Errno 113] No route to host"). This commits adds some error handling
around network requests to prevent further crashes in the future.
 2019-02-19 16:16:56 +01:00
Bernardo Meurer
1dad5ded03
Move absubmit plugin parallelization to util.par_map 2019-02-18 22:42:20 -08:00
Adrian Sampson
81c5ae3fdf
Merge pull request #3151 from Holzhaus/playlist-plugin-additions 
playlist: Add auto-update functionality and more tests
 2019-02-18 08:40:55 -05:00
Jan Holthuis
4ba5dfaa43 playlist: Remove leftover print call and fix 'auto' option access style 2019-02-18 09:13:39 +01:00
Jan Holthuis
7bca5cf549 playlist: Don't use syspath() when checking if path is absolute 2019-02-17 22:28:39 +01:00
Jan Holthuis
ee2cce4280 playlist: Work around Windows' Mandatory File Locking on playlist updates 2019-02-17 22:12:13 +01:00
Jan Holthuis
d991e2a7d8 playlist: Normalize path before lookup in changes dict 2019-02-17 21:51:09 +01:00
Adrian Sampson
9320db21eb
Merge pull request #3150 from beetbox/named-query 
Add support for "named queries" and use them in the playlist plugin
 2019-02-17 15:08:31 -05:00
Adrian Sampson
55ef2ffd39 Add future imports to playlist plugin 2019-02-17 14:02:26 -05:00
Adrian Sampson
7efc67eb03 playlist: Use new "named query" functionality 2019-02-17 13:52:00 -05:00
Jan Holthuis
6d42028057 playlist: Add playlist auto-update functionality 2019-02-17 19:38:21 +01:00
Adrian Sampson
00667bda0f Merge pull request #3145 from Holzhaus/playlist-plugin 
Playlist plugin
 2019-02-17 13:16:26 -05:00
Jan Holthuis
4f1a468aa9 playlist: Restore case sensitivity in col_clause method 2019-02-17 17:34:36 +01:00
Jan Holthuis
055f2d3702 playlist: Also catch IOErrors to restore Python 2.7 compatiblity 2019-02-17 16:00:04 +01:00
Jan Holthuis
f9f2fa0e26 playlist: Restructure playlist reading code and add error handling 2019-02-17 15:17:10 +01:00
Jan Holthuis
19b92e1199 playlist: Improve speed in PlaylistQuery class 
Implement the col_clause method for faster, sqlite-based querying. This
will only make a difference if the "fast" kwarg is set to True.
 2019-02-17 14:38:36 +01:00
Jan Holthuis
a80a07f093 playlist: Add playlist plugin 
Adds M3U playlist support as a query to beets and thus partially
resolves issue #123. The implementation is heavily based on #2380 by
Robin McCorkell.

It supports referencing playlists by absolute path:

    $ beet ls playlist:/path/to/someplaylist.m3u

It also supports referencing playlists by name. The playlist is then
seached in the playlist_dir and the ".m3u" extension is appended to the
name:

    $ beet ls playlist:anotherplaylist

The configuration for the plugin looks like this:

    playlist:
        relative_to: library
        playlist_dir: /path/to/playlists

The relative_to option specifies how relative paths in playlists are
handled. By default, paths are relative to the "library" directory. It
also possible to make them relative to the "playlist" or set the option
or set it to a fixed path.
 2019-02-17 14:38:36 +01:00
Adrian Sampson
69fbba1eed
Merge pull request #3144 from Holzhaus/add-id3v23-to-convert 
Add id3v23 option to convert plugin
 2019-02-15 09:51:46 -07:00
Jan Holthuis
7afeb9b2ac convert: Add id3v23 config option to convert plugin 2019-02-14 23:42:36 +01:00
Adrian Sampson
f54042f194 Make a comment into a full sentence 2019-02-08 18:18:30 -08:00
jan
5ace667757 add forgotten request_finished 2019-02-08 01:09:07 +01:00
jan
9bc3898951 add request_finished function, rename wait_for_rate_limiter to request_start, add doc and changelog 2019-02-08 01:02:33 +01:00
jan
77fd5ee548 keep discogs requests below rate limit 2019-02-08 00:05:07 +01:00
Samuel Nilsson
93007bfdd5 ReplayGain: fixed error caused by per_disc option 2019-02-06 13:17:34 +01:00
Samuel Nilsson
24f02cb5cd ReplayGain refactoring 2019-02-06 10:12:06 +01:00
Samuel Nilsson
31326ebb20 Simplified album ReplayGain code 2019-02-06 10:06:48 +01:00
Samuel Nilsson
d910ed3ecf Merge branch 'master' of github.com:beetbox/beets into replaygain 2019-02-06 09:27:45 +01:00
Samuel Nilsson
3d842db8d8 Added per disc album_gain support 2019-02-06 09:27:24 +01:00
Adrian Sampson
c7c90a51c6
Merge pull request #3135 from wildthyme/master 
Support ipfs add --nocopy in ipfs plugin
 2019-02-01 10:04:00 -05:00
Jack Wilsdon
2bc04bb605
Use "==" when comparing strings 2019-01-31 00:15:55 +00:00
Jack Wilsdon
768770d561
Fix incorrect indentation 2019-01-31 00:15:42 +00:00
Iris Wildthyme
2b82831b7b added --nocopy support 2019-01-30 16:36:46 -05:00
Rahul Ahuja
5fbb28637d Set Spotify AlbumInfo.mediums 2019-01-23 19:54:14 -08:00
Rahul Ahuja
6a9b62a9c2 Specify None rtype in doscstrings 2019-01-22 20:54:46 -08:00
Rahul Ahuja
8c6cc6573c Unidecode query string 2019-01-22 19:42:25 -08:00
Rahul Ahuja
b91406b252 Backwords-compatible str/unicode 2019-01-22 18:59:15 -08:00
Rahul Ahuja
c6b8f6d143 Fix formatting/spelling 2019-01-22 18:09:10 -08:00
Rahul Ahuja
f7d20090e6 Fix _handle_response reauth bug and empty str query construction 2019-01-22 12:14:52 -08:00
Rahul Ahuja
7b57b0b608 Appease Flake8 2019-01-22 10:53:18 -08:00
Rahul Ahuja
3a67eae46d Use track attrs directly, better naming/docstrings 2019-01-22 10:41:18 -08:00
Rahul Ahuja
09fc53eaea Only parse Spotify ID when necessary 2019-01-21 23:53:19 -08:00
Rahul Ahuja
96fda0df0d Docstring formatting 2019-01-21 23:36:51 -08:00
Rahul Ahuja
77f9a930b7 Fix remaining test, use official doc wording 2019-01-21 23:15:08 -08:00
Rahul Ahuja
0527edbd48 Fix test index, add docstrings 2019-01-21 23:05:47 -08:00
Rahul Ahuja
f63beca39a Switch filter ordering in test 2019-01-21 22:35:12 -08:00
Rahul Ahuja
48401c60dc Switch query filter ordering for tests 2019-01-21 22:27:31 -08:00
Rahul Ahuja
42e852cc7e Clarify _search_spotify return type 2019-01-21 22:12:56 -08:00
Rahul Ahuja
aa18f9116d Refine doc wording 2019-01-21 22:01:30 -08:00
Rahul Ahuja
265fcc7cea utilize track_for_id in item_candidates 2019-01-21 21:45:50 -08:00
Rahul Ahuja
5472a49991 Add candidates and item_candidates, modularize Search API queries 2019-01-21 21:24:41 -08:00
Rahul Ahuja
dab62f2194 inline auth_header property 2019-01-21 09:23:38 -08:00
Rahul Ahuja
b50e148bec use official client ID/secret, remove usage from docs 2019-01-21 08:32:57 -08:00
Rahul Ahuja
cb8b0874d4 naming 2019-01-21 01:56:57 -08:00
Rahul Ahuja
415b21cbc1 fix var reference, add docstring 2019-01-21 01:30:37 -08:00
Rahul Ahuja
844b940832 capture TrackInfo.medium_total 2019-01-20 15:32:07 -08:00
Rahul Ahuja
dbf17f760e add TrackInfo.medium 2019-01-20 15:09:51 -08:00
Rahul Ahuja
78a46fd4d0 doc typo 2019-01-20 15:02:19 -08:00
Rahul Ahuja
b4d54b0950 set TrackInfo.index in track_for_id 2019-01-20 15:00:32 -08:00
Rahul Ahuja
082357b063 document new functionality, use Spotify ID for AlbumInfo.album_id 2019-01-20 12:40:11 -08:00
Rahul Ahuja
287c767a6d fix formatting 2019-01-20 11:24:33 -08:00
Rahul Ahuja
695dbfaf80 copy album_distance, track_distance from Beatport plugin 2019-01-20 03:20:18 -08:00
Rahul Ahuja
bb1ed67e2d use open.spotify.com URL for data_url 2019-01-20 02:43:54 -08:00
Rahul Ahuja
02aa79ae61 add more docstrings 2019-01-20 02:28:59 -08:00
Rahul Ahuja
b95eaa8ffe fix test, document Spotify ID 2019-01-20 02:20:10 -08:00
Rahul Ahuja
9a30000b56 better naming, formatting 2019-01-20 02:04:46 -08:00
Rahul Ahuja
60c9201e4a modularize Spotify ID parsing 2019-01-20 01:54:08 -08:00
Rahul Ahuja
91b2e33569 support album autotagging 2019-01-20 01:33:19 -08:00
Rahul Ahuja
e95b8a6ee0 add docstrings, separate TrackInfo generation 2019-01-20 00:41:14 -08:00
Rahul Ahuja
3309c555ed better naming, documentation 2019-01-20 00:05:56 -08:00
Rahul Ahuja
104f6185ab revert unnecessary double --> single quotes 2019-01-19 23:57:36 -08:00
Rahul Ahuja
337cf2a1c3 appease Flake8 2019-01-19 23:35:06 -08:00
Rahul Ahuja
dc77943da2 try oauth token mock 2019-01-19 23:21:02 -08:00
Rahul Ahuja
e6c8f79a07 resolve python2/3 bytes/str incompatibilities, simplify authentication 2019-01-19 22:55:40 -08:00
Rahul Ahuja
c1cb7a2941 address py3 compatibility later 2019-01-19 19:29:35 -08:00
Rahul Ahuja
8bdd927d20 try b64 encode/decode 2019-01-19 19:17:34 -08:00
Rahul Ahuja
160d66d05c b64encode with bytes 2019-01-19 19:04:15 -08:00
Rahul Ahuja
3639971391 remove unused import 2019-01-19 18:48:46 -08:00
Rahul Ahuja
1a9f20edfe unregister import_begin listener 2019-01-19 18:42:29 -08:00
Rahul Ahuja
82319734cb black -S -l 79 autoformat 2019-01-19 18:32:41 -08:00
Rahul Ahuja
204a1453c4 Update spotify.py 2019-01-19 18:06:17 -08:00
Adrian Sampson
8cfbc8274e
Merge pull request #3099 from regagain/fetchart_respect_ignore_settings 
Fetchart respect ignore settings
 2018-12-21 11:45:40 -05:00
Reg
2ea77652a7 Fetchart: Respect ignore and ignore_hidden settings when fetching art 
from the local filesystem.
 2018-12-20 18:44:46 +01:00
Reg
21145731e4 Fixed docstring typo. 2018-12-20 18:19:00 +01:00
Jan Holthuis
d2521d9256 Fix acoustid_fingerprint type confusion 
Since pyacoustid returns the fingerprint as bytes (and thus causes the
database to store a bytes/BLOB object), but the tag value is a string,
the acoustid_fingerprint tag always causes file change when using beet's
"write" command, even if the actual value didn't change.

Issue #2942 describes the problem.

This commit fixes that issue for newly imported/fingerprinted files. However,
you still need to change the type of all acoustid_fingerprint fields
that are already present in the database:

    $ sqlite3 beets.db
    SQLite version 3.26.0 2018-12-01 12:34:55
    Enter ".help" for usage hints.
    sqlite> UPDATE items SET acoustid_fingerprint = CAST(acoustid_fingerprint AS TEXT);
 2018-12-19 10:30:50 +01:00
Adrian Sampson
17d9882389 Make the path-field-remover function more obvious 
An amendment to #3084.
 2018-12-01 16:57:25 -05:00
Domen
5de3ee9a5f Export plugin can now export path from library, if explicitly specified as field to export. Info plugin behaviour is unchanged. 2018-11-28 20:19:37 +01:00
milesial
d5caae12bd
Now logs both the source and the destination 2018-10-25 15:29:28 +02:00
milesial
d4e615feba
Fixed typo in convert when copying cover art 2018-10-24 19:07:12 +02:00
Patrick Heneghan
9c7a313b0d
Remove default arg for lastgenre --force flag 2018-10-16 18:51:39 +01:00
Samuel Nilsson
a928dbc470 Added contextpath configuration to subsonicupdate plugin. Fixed bug in 
subsonicupdate port configuration.
 2018-10-10 21:22:31 +02:00
Jack Wilsdon
5ad16983d4
Fix miscellaneous typos 2018-10-09 01:11:06 +01:00
Adrian Sampson
8b59b20ef8 Tiny style fix for #3028 2018-09-16 20:56:06 -04:00
Andrew Rogl
865940746c More clean up requests 2018-09-11 18:52:55 +10:00
Andrew Rogl
308dccab95 Address requested changes from Adrian 2018-09-10 20:47:58 +10:00
Andrew Rogl
c43a957f46 Clean up flake errors 2018-09-09 15:48:07 +10:00
Andrew Rogl
919f3f9c34 mbsync no longer queries MusicBrainz when the either the mb_albumid or mb_trackid field is invalid 2018-09-09 15:20:26 +10:00
Adrian Sampson
e8ffaf9984
Merge pull request #3020 from Archer4499/master 
chroma: Bias toward looking up more relevant releases using date/country
 2018-08-31 22:39:45 -04:00
Derek King
549c115752 Return tuple of numbers instead of string for release_key 2018-09-01 04:10:29 +10:00
Adrian Sampson
eec5bfe73a Fiddle with some whitespace 2018-08-30 14:58:12 -04:00
Derek King
7a8f980323 chroma: Allow releases to be sorted by date/country 
Uses
match:preferred:countries/original_year:
config options to determine whether the releases should be sorted by their respective fields.
The behaviour is the same as before when the default config is used.
 2018-08-31 00:39:47 +10:00
L Maffeo
7369933232 Updated documentation 2018-08-28 21:50:24 +02:00
L Maffeo
c7aa248a77 Configuration defaults review 2018-08-28 21:34:58 +02:00
L Maffeo
39e8a8389b Code cleanup 2018-08-26 17:38:17 +02:00
L Maffeo
b747291468 Passed tox tests 2018-08-26 15:22:22 +02:00
L Maffeo
bd5ab43bc6 Removed logging (needs additional testing) 2018-08-26 14:34:47 +02:00
Io Ii
7bfb7e12e7 Minor fix in config 2018-08-26 09:13:23 +02:00
Io Ii
10c40b1575 Second review by @sampsyo 2018-08-26 08:35:16 +02:00
Adrian Sampson
1f37cb61a3
Merge branch 'master' into master 2018-08-25 06:55:12 -07:00
Martin Haaß
a3770686b4 to fix the peak calculation also delete the division 2018-08-20 23:39:34 +02:00
Martin Haaß
f58f03dbfd replaygain: albumpeak on large collections is calculated as average, not maximum (bug 3008) 2018-08-20 23:06:11 +02:00
L Maffeo
d4cecccdac Renamed plugin, added comments and minor fixes. 2018-08-18 14:22:25 +02:00
L Maffeo
fc1592adbe Renamed plugin, added default configuration and comments 2018-08-18 14:17:00 +02:00
Adrian Sampson
890ba85c79
Merge pull request #3004 from thetarkus/gmusic-additions-2 
gmusic plugin fixes and additions
 2018-08-15 12:03:13 -04:00
thetarkus
e824132137 Rename oauth_filepath to oauth_file, update gmusic doc 2018-08-15 11:42:04 -04:00
Adrian Sampson
cab6910866
Merge pull request #2718 from beetbox/fix-itunes 
fetchart: Restore iTunes Store source
 2018-08-15 10:34:07 -04:00
nath@dp7510
399bfb985e fetchart: fix itunes debug info 
Some typos + make it more useful overall
 2018-08-15 13:56:39 +02:00
nath@dp7510
0107262ed3 fetchart: restore itunes art source 
Reimplement minimalistic itunes scraper from scratch
 2018-08-15 13:55:55 +02:00
thetarkus
abffb29a3f gmusic plugin addition: add oauth_filepath option, better device_id 
guessing
 2018-08-14 23:30:54 -04:00
thetarkus
b7354fef23 gmusic plugin: only authenticate when needed 2018-08-14 22:35:10 -04:00
Adrian Sampson
69c8684302 Revise comment 2018-08-14 10:19:13 -04:00
Adrian Sampson
4242a6b202 Merge pull request #3003 from bemeurer/master 
Parallelize absubmit
 2018-08-14 10:18:46 -04:00
Adrian Sampson
86d353717a
Merge pull request #3002 from thetarkus/gmusic-additions-1 
Add uploader_id, uploader_name, and device_id for gmusicapi auth in gmusic plugin
 2018-08-14 09:17:45 -04:00
Bernardo Meurer
4eafa40ff2
Revert to sequential behavior for Python 2 2018-08-14 00:05:00 -03:00
Bernardo Meurer
0803ba74e2
Attempt at Python2 and 3 compatibility 2018-08-13 23:58:38 -03:00
Bernardo Meurer
a9f56db11e
Attempt to use ThreadPoolExecutor 2018-08-13 23:50:51 -03:00
Bernardo Meurer
31c95482d9
Fix imports 2018-08-13 23:23:41 -03:00
Bernardo Meurer
6c2daa061e
Moved from Pool to ThreadPool 2018-08-13 23:22:40 -03:00
Bernardo Meurer
22a6a0e6ef
Parallelized absubmit 2018-08-13 22:44:45 -03:00
Adrian Sampson
bac8faad78 Resolve W605: invalid escape sequence 
This came up in lots of regexes that weren't using "raw" literals.
 2018-08-13 10:41:01 -04:00
thetarkus
b1d5cc1485 Add uploader_id, uploader_name, and device_id for gmusicapi auth. 2018-08-13 02:52:16 -04:00
L Maffeo
67568b4f4c Passed tox tests 2018-08-12 19:37:31 +02:00
L Maffeo
5617eef6c7 Added subsonic plugin 2018-08-12 17:48:53 +02:00
Scott Carlson
a605a1ba55
Fixing Flake8 spacing complaint 2018-08-09 21:28:35 -05:00
Scott Carlson
cfe8ed9c34
Gmusic fixes based on review and changelog addition 
* Fixes based on review and changelog addition
 2018-08-06 16:41:09 -05:00
Scott Carlson
ef4490087b
Fixing Flake8 line issues 2018-08-05 00:17:19 -05:00
Scott Carlson
61363c8cd9
Fixing user messages to be more explicit 2018-08-04 23:54:58 -05:00
Scott Carlson
4fc15d2b17
Adding auto to default configs 2018-08-04 23:49:59 -05:00
Scott Carlson
69b4c68b63
Adding autoupload method to upload on import 2018-08-04 21:58:29 -05:00
Ryan Veach
1505ff071d changed flask cors import 2018-07-10 10:32:21 -05:00
Zsin Skri
ceabc72feb lastgenre: remove unnecessary check 
In _resolv_genres wo do not have to explicitly check if self.c14n_branches is
not empty. The tree will have been loaded when self.canonicalize is truthy. Also
if self.c14n_branches would be empty the canonicalization is a no-op anyway...
 2018-07-01 09:15:05 +02:00
Zsin Skri
cef9a3311c LastGenre: allow prefer_specific without canonical 
This improves lastgenre's behaviour when the configuration option
`prefer_specific` is set but `canonical` is not.
Previously it would not set any tags. Now it does apply tags, sorted using the
canonicalization tree, but not canonicalized.

For this the default tree is loaded even when `canonical` is not set.
An extra check is added to only use it for canonicalization when `canonical` is
set.
 2018-06-30 22:27:29 +02:00
Mike
1d32849daa Add ability for play plugin to emit utf8 BOM 2018-06-08 23:26:48 -06:00
Adrian Sampson
7d607b4c5d Merge pull request #2813 from autrimpo/issue2757 
Use NullPaddedInt for R128 tags
 2018-05-31 10:13:20 -04:00
Abra
3348a466f4 Make lyrics plugin group songs by 'albumartist' rather than 'artist' 
when writing ReST
 2018-05-14 11:18:34 +04:00
Bin Jin
69d6dfe097 mbsync: fix updating album with invalid first track MBID 
MBID of recording could become invalid after merging. The existing
code always copies metadata from first track after updating. But for
albums with invalid track MBID that happens to be the first track,
MusicBrainz changes won't be applied to whole album, only whose
tracks with valid MBID. This is particularly annoying since those
changes are actually displayed for every `beet mbsync` run, but never
get applied.

Fix this issue by finding any track that get MusicBrainz updates, and
apply it to whole album.
 2018-05-10 16:38:30 +08:00
Jérémie Detrey
3b03372502 mbsync: Use release-track-id to construct track mapping. 
Fixes #1234 by following recording MBIDs changes.
 2018-05-08 16:30:07 +02:00
rachmadaniHaryono
e90a547642 chg: dev: fix list item remove error 2018-05-03 09:46:03 +08:00
Dmitry Bogdanov
a840bc700b
Merge branch 'master' into discogs_original_year 2018-05-02 17:41:07 +02:00
Jérémie Detrey
9f4c5c8096 Do not rely on positional arguments for TrackInfo. 2018-04-30 18:37:27 +02:00
Adrian Sampson
f1d5c2f398 Fix #2537: keyfinder uses imported_items() 2018-04-29 13:45:39 -04:00
Dmitry Bogdanov
6aba118e94 Fetch original_year from master releases for Discogs (#1122) 
This adds an additional Discogs API call inside get_album_info().
Assume that original_year equals to year for releases without a
master release.
 2018-04-29 18:18:15 +02:00
Dmitry Bogdanov
f9b6473893 Some more code style fixes 2018-04-28 19:03:32 +02:00
Dmitry Bogdanov
7ac2aff50c Fix a few code style issues 2018-04-28 14:06:29 +02:00
Dmitry Bogdanov
0ea5882bc0 Better comments in code explaining Discogs track IDs (#2336) 2018-04-28 02:32:42 +02:00
Dmitry Bogdanov
09ee194142 Make Discogs medium indexing code easier to understand 2018-04-28 02:23:46 +02:00
Dmitry Bogdanov
48140f11e7 Use releasegroup_id to store master release IDs from Discogs 
Master releases roughly correspond to MusicBrainz' release groups.
It will be usefull to store master IDs, for example to retrieve
original release dates (#1122).
 2018-04-27 21:56:51 +02:00
Dmitry Bogdanov
2e422122b3 Invent our own track IDs for Discogs 
Discogs does not provide track IDs. As a workaround, invent our own
IDs by combining release ID with original track position strings
returned by Discogs (#2336).
 2018-04-27 20:30:35 +02:00
Dmitry Bogdanov
676536efa7 Fix incorrect indexing of two-sided mediums 
Fix incorrect split of a tracklist by medium for the case of
two-sided mediums (#2887).

Following the discussion in #2887, the 'medium_total' value should
contain the number of tracks on the medium to which each particular
track belongs, not the total number of different mediums present on
a release.

Fix unit tests accordingly.
 2018-04-27 19:28:35 +02:00
Tobias Sauerwein
499b3867b2 Remove unused import. 2018-04-20 08:25:08 +02:00
Tobias Sauerwein
4748a68b6b Remove exception handling. 2018-04-20 08:16:56 +02:00
cgtobi
7d45eabb25
Merge branch 'master' into sonos 2018-04-20 07:44:21 +02:00
Tobias Sauerwein
5e084b7186 Fix exception handling and add docs to the toc. 2018-04-20 07:39:12 +02:00
Tobias Sauerwein
c420f6bf99 Add sonos updater plugin. 2018-04-19 23:58:40 +02:00
Cédric Schieli
b9bac391a9
Really fix album replaygain calculation with gstreamer backend. 
Fixes #2845
 2018-03-19 21:09:35 +01:00
Waweic
06d4fe254d Implement recommendations by sampsyo 
Implemented all recommendations.
 2018-03-06 17:49:20 +01:00
Waweic
3c3e579dcc Make programming style pep8 compliant 2018-03-01 20:20:38 +01:00
Waweic
d0fd41b474 Add unicode support for Python 2 and 3 
Converts bytes to unicode using util.text_string, assuming that the
string is a UTF-8 string.
If that fails, it falls back to a hardcoded fallback filename.
 2018-03-01 19:45:44 +01:00
Waweic
4df313e3ce Fix unicode problems in web plugin 
Added Exception to the web plugin to catch non latin-1 characters and change them to ascii chars.
Added Description to the changelog file
 2018-03-01 11:56:38 +01:00
Waweic
b94227a53d Merge https://github.com/waweic/beets into patch-2 
Catch up
 2018-02-27 22:03:50 +01:00
Adrian Sampson
453fd372a3 Flatten a config view (#2821) 2018-02-26 18:00:59 -05:00
Adrian Sampson
3b49da0c52 Merge pull request #2821 from Konubinix/master 
Add a support for supports_credentials
 2018-02-26 17:59:57 -05:00
Samuel Loury
e3599742b4 Add a support for supports_credentials 
If the web plugin is behind a credential based http server and is
accessed by another in-browser client in another domain, the
specification of CORS requires the server to indicate it supports
such credentials.
 2018-02-26 21:08:02 +01:00
waweic
be96c1022a
Fix album_art() in __init__.py 
flask.send_file() expects a string, g.lib.get_album() returns bytes. Added decode() to album_art(). 

If g.lib.get_album() gets a non-existing id, it returns None. Python would throw an error in this case. Added check to prevent this.
 2018-02-26 18:33:30 +01:00
waweic
df83516086
Fix jumping time in beets.js 
Round was used instead of floor
 2018-02-26 17:01:06 +01:00
wisp3rwind
318f0c4d16 Advanced fetchart source config: pep8 2018-02-24 11:26:50 +01:00
wordofglass
e7a3e27ed9 Advanced fetchart source config: Actually use the new syntax 2018-02-24 11:26:50 +01:00
wordofglass
2c1e4d878b Advanced fetchart source config: add the (still unused) match_by constructor argument 2018-02-24 11:26:50 +01:00
Adrian Sampson
f2733883ef Merge branch 'master' of github.com:beetbox/beets 2018-02-23 18:19:11 -05:00
Adrian Sampson
a6be28a65e Fix #2817: drop in configuration was ignored 
This was overridden by the default CLI option. Now the default for the
config option is None, meaning no change to the config.
 2018-02-23 18:18:32 -05:00
David Logie
d6b6ebbeb9 mbcollection: Make sure missing albums are removed from collections correctly. 2018-02-23 12:34:33 +00:00
Michal Koutenský
d4625bced0 Have convert plugin run early in the pipeline 2018-02-19 10:46:06 +01:00
Michal Koutenský
8350ed6baf Unique debug messages for R128 functions 2018-02-18 20:09:58 +01:00
Kovrinic
ace7fab4d8 PlexUpdate: token redacted 2018-01-31 00:49:55 -06:00
Adrian Sampson
3f2cefd985 Merge pull request #2601 from m42i/m42i/importadded 
Fix #1918: ValueError on trying to import
 2018-01-30 22:55:28 -05:00
Adrian Sampson
224d782c2c Fix #2771: handle errors in genius lyrics source 2018-01-30 22:37:44 -05:00
Adrian Sampson
277d81b4d6 lyrics: Don't write ReST by default! 2018-01-30 22:33:32 -05:00
Adrian Sampson
e7417e3683 lyrics: Don't crash when BeautifulSoup isn't found 2018-01-30 22:31:15 -05:00
Adrian Sampson
b28e0b43ff Merge pull request #2778 from ylep/replaygain-options 
Add --force, --write and --nowrite options to replaygain plugin
 2018-01-02 14:50:27 -05:00
Yann Leprince
d9bec61e98 Merge branch 'master' of https://github.com/beetbox/beets into replaygain-options 2018-01-02 12:35:27 +01:00
Yann Leprince
499cd378b7 fix the default write behaviour to the importer configuration 2018-01-02 12:11:47 +01:00
Yann Leprince
079e167b6b Merge branch 'master' of https://github.com/beetbox/beets into fix-bs1170gain 2018-01-02 10:54:40 +01:00
Yann Leprince
3ef4b70439 Fix coding style 2017-12-31 14:51:14 +01:00
Yann Leprince
1f6335581e Add --force, --write and --nowrite options to replaygain plugin 2017-12-31 12:00:02 +01:00
Yann Leprince
05775ccac6 Fix fragile parsing of bs1770gain output 
bs1770gain is sorting the filenames internally, so in some corner cases it returns the results in a different order from the command-line arguments.

This patch uses the --xml option of bs1770gain (introduced in 0.4.6) in order to read the filenames reliably.
 2017-12-31 11:27:42 +01:00
Vrihub
d0af7a7bd3 Merge branch '2738-filename-tracknumber' of https://github.com/Vrihub/beets into 2738-filename-tracknumber 2017-12-21 15:20:35 +01:00
Vrihub
4ee5f2ca88 Fix "line too long" Travis CI error 2017-12-21 15:18:25 +01:00
Vrihub
9cd7473c6b
Merge branch 'master' into 2738-filename-tracknumber 2017-12-21 15:02:09 +01:00
Vrihub
84cf3361ce Refactored some regular expressions. Added changelog entry 
Some more changes to the regular expressions in the "PATTERNS" list.
Also allow "_" as a separator, where only "-" was allowed.
Replaced similar regexps containing different combinations of \s, "-", "."
with a single regexp using a set of characters [\s.\-_].
 2017-12-21 14:47:41 +01:00
Constantine Evans
dd2b44ef20 minor fixes and changelog entry 2017-12-11 13:31:40 -08:00
Vrihub
7132ad094b First tentative fix for issue 2738. 
Don't ignore anymore filenames such as "01.mp3", instead use the number
in the filename as track number.
 2017-12-11 19:32:53 +01:00
Constantine Evans
c9b4e9b414 only use tiebreak if tiebreak includes an entry for the kind being considered, otherwise use default (eg, if only items is specified, and -a is being used, use default order of priority 2017-12-10 12:28:47 -08:00
Adrian Sampson
d932aa4f5c
Merge pull request #2750 from woparry/master 
Add tags configuration to acousticbrainz plugin
 2017-12-02 22:19:23 -05:00
Owen Parry
1f45ea00f4 use as_str_seq and fix line length 2017-12-02 11:31:31 -08:00
Aaron Jubbal
e24f732014 Changed dont_convert to no_convert. 2017-11-29 20:08:50 -08:00
Aaron Jubbal
0998d9f8ef Added default value for dont_convert option, addressing crashes. 2017-11-29 17:53:50 -08:00
Aaron Jubbal
7265077e75 dont_convert option implemented. 
Local testing indicates success.
 2017-11-29 16:13:38 -08:00
Owen Parry
eaa84178f7 split long line 2017-11-27 09:11:53 -08:00
Owen Parry
325ae6f0ee Add tags configuration to acousticbrainz plugin 2017-11-27 07:55:38 -08:00
Barry Broderick
530beb6312 removed whitespaces from empty line 2017-11-22 10:10:28 -05:00
Barry Broderick
a7818027ab replaced the exception test in convert_field with an isinstance test 2017-11-20 23:09:36 -05:00
Barry Broderick
585d4ba89d attempted fix for #2740 2017-11-20 09:56:40 -05:00
David Logie
c10e62f212 mbcollection: Fix default 'remove' value. 
If the default is not None the value cannot be overriden by the user's
config.yaml.
 2017-11-13 15:48:22 +00:00
test
842f6afd7f Fix indentation 2017-11-10 14:04:16 +01:00
test
8544b3a830 Fix long line and add changelog entry 2017-11-10 13:46:26 +01:00
test
54297dbab4 Tentative fix for issue 2734: also check for RETAG 2017-11-05 12:04:40 +01:00
Adrian Sampson
14476e2f8a scrub: Handle MutagenError (fix #2716) 
In older versions of Mutagen, an IOError indicated things like
permissions errors. Now, a custom MutagenError is raised. Now we handle
both.
 2017-10-20 14:49:53 -04:00
Adrian Sampson
d02bef1aec Merge pull request #2709 from lmagno/master 
Fetch lyrics from Genius through scraper
 2017-10-09 18:50:58 -04:00