Sebastian Reuße
c40ea4f22a
mediafile._safe_cast: be safer when converting to int
...
The regex «[\+-]?[0-9]*» possibly matches a single minus/plus, which would then
be passed on to int(), raising a ValueError from within _safe_cast. The test
suite covered this for float, but not for int.
We now make sure we actually have a number after the sign by using a Kleene
plus.
2017-11-19 09:21:07 +01:00
Meet Udeshi
70f0bc5b6c
Implement album merging for duplicates
...
Fixes #112
2017-11-01 02:00:48 +05:30
konman2
578143ae12
updated to pass pep8 checks
2017-10-07 21:28:33 -07:00
konman2
fdeef05cc9
clearart asks for permission before deleting embedded albumart
2017-10-07 20:42:01 -07:00
zigarrre
b376139663
Refactored move functions for clarity according to #2682
...
The move functions in library.py and manipule_files in importer.py where
changed to use a single parameter for the file operation instead of
multiple boolean flags.
A typo in the documentation of the Album.move and Item.move functions
confusing True and False when describing the store parameter was fixed
as well.
2017-09-11 17:03:44 +02:00
euri10
25fb2453b4
Modified the name of the fetchart plugin switch from missing to quiet
2017-09-05 18:27:47 +02:00
euri10
b2fd274e2c
Added a missing switch to the fetchart command so that only missing albums
...
are displayed
2017-09-05 16:34:26 +02:00
wordofglass
8833fef249
Merge pull request #2668 from wordofglass/edit_logic
...
Edit plugin logic: Regression from previous PR; incorrect diffs
2017-08-25 15:52:40 +02:00
wordofglass
5f21bd3ccd
test_edit: Add a test for retagging.
2017-08-24 15:03:18 +02:00
wordofglass
b903b44a0c
test_edit: Fix test that intended to change one item but affected two.
...
This didn't manifest as a testing failure since the plugin (mostly
silently) drops id changes.
2017-08-22 23:34:35 +02:00
wordofglass
c811102eb2
test_edit: Expect mtime to change, unbreaks the multiple-item tests.
2017-08-22 23:34:06 +02:00
wordofglass
18c82cab5f
test_edit: Add a comment explaining why I didn't change the writing behaviour
...
I was midway through writing a test when realizing that it's best
the way it is...
2017-08-22 23:24:33 +02:00
wordofglass
7d4627bb8f
Ensure mtime is non-zero for Items in test fixtures.
...
mtime == 0 is the "this Item contains newer metadata than the file's
tags" marker. Setting this to something else than 0 emulates the state
of Items freshly read from the database.
Breaks 4 of the edit plugin tests.
2017-08-22 23:24:33 +02:00
Antoine Beaupré
914dba4152
add tests for slug function, failing
2017-07-18 16:32:47 -04:00
Adrian Sampson
8085d1318b
Fix ipfs test to sort items in order
2017-06-20 16:19:31 -04:00
Adrian Sampson
2a9be17cf6
Fix some brittle query tests
...
These were written to incidentally depend on Nones; the behavior they're
actually testing doesn't really have anything to say about None-ness.
2017-06-20 15:56:33 -04:00
euri10
6664b656f4
Merge branch 'relativedate'
...
Solved conflicts with upstream of new parse classmethod of DateQuery
# Conflicts:
# beets/dbcore/query.py
2017-06-15 08:59:43 +02:00
Adrian Sampson
ace5656e36
Complete set of __future__ imports
2017-06-14 19:08:27 -04:00
A.L. Kleijngeld
2eb4e3d515
Merge branch 'master' into master
2017-06-13 14:43:10 +02:00
Bart Kleijngeld
762f9ca054
revised to fix flake8 warnings
2017-06-13 14:33:08 +02:00
Adrian Sampson
dfde9ce916
Merge pull request #2510 from SpirosChadoulos/master
...
New export command (issue #435 )
2017-06-11 12:21:06 -04:00
Adrian Sampson
389aed8d5d
Merge pull request #2528 from discopatrick/query-datetime-parser
...
Query datetime parser
2017-06-10 20:57:29 -04:00
Adrian Sampson
15a7dfccff
Merge pull request #2583 from yacoob/master
...
Fix a lastgenre crash
2017-06-10 20:47:19 -04:00
Adrian Sampson
0e47095bb0
Merge pull request #2560 from autrimpo/r128
...
RFC: replaygain: R128 support
2017-06-10 20:32:42 -04:00
Adrian Sampson
ca4f96e33c
Consolidate export tests into MoveTest
...
Just one new flag.
2017-06-10 20:26:41 -04:00
Adrian Sampson
730c84e5e5
Correct tests for export mode
...
The old tests were wrong but the incorrectness was hidden by the incorrect
parameter passing fixed in the previous commit. Now we actually test that the
item's path did not change.
2017-06-10 20:25:48 -04:00
Adrian Sampson
714560aace
Fix parameter order and binding
...
The calls didn't match up with the parameter order.
2017-06-10 20:19:27 -04:00
Adrian Sampson
b25eb87f60
Remove unnecessary output capture
2017-06-10 20:05:17 -04:00
Adrian Sampson
29d6c27d02
Fix some spurious whitespace changes
2017-06-10 20:03:01 -04:00
discopatrick
291b287f56
Add a test for a non-range date query
2017-06-05 16:31:37 +01:00
Jakub Turski
f6830b4bc3
Here, flake8, be happy.
2017-06-02 16:27:49 +01:00
Jakub Turski
0e7a0a62d4
Fix excessive line length.
2017-06-02 16:04:05 +01:00
Jakub Turski
a43f5fdace
Remove unnecessary test setup parameter.
2017-06-02 15:50:58 +01:00
Jakub Turski
ee46a5150f
Don't crash if non-canonical genre and prefer_specific: yes.
...
Also, add a test for this.
2017-06-02 15:48:05 +01:00
discopatrick
e1101d4e95
Update assertion with correct error name
2017-06-01 12:33:23 +01:00
Bart Kleijngeld
c64878179e
finished tests for set_fields on importer
2017-06-01 11:57:24 +02:00
discopatrick
fbb868e5ed
Merge branch 'master' into query-datetime-parser
2017-06-01 04:37:45 +01:00
Michal Koutenský
ddfe44266b
r128 gain tags in mediafile test
2017-05-17 21:41:12 +02:00
Adrian Sampson
9840964f51
Fix #2562 : avoid crash with newlines in templates
...
Turns out! The $ character in Python regexes also matches before the last
newline at the end of a string, not just at the end of a string. The \Z entity
does what we really want: the *real* end of the string.
2017-05-16 14:00:10 -04:00
Adrian Sampson
9ccaad27d3
Undo some noisy whitespace changes
2017-05-12 10:42:50 -04:00
Adrian Sampson
0cb643f35e
Merge pull request #2529 from dosoe/master
...
Add composer_sort as a tag
2017-05-12 10:34:46 -04:00
SpirosChadoulos
8f62e8bc68
Requested changes done
2017-05-12 14:49:03 +03:00
SpirosChadoulos
c4ef23d9f7
Minor Flake fixes
2017-05-11 12:45:03 +03:00
SpirosChadoulos
51835e762f
Minor fixes to move tests
2017-05-11 12:30:21 +03:00
SpirosChadoulos
0dc948d9d3
Made sure that the destination directory will exist
2017-05-11 12:11:21 +03:00
SpirosChadoulos
f5b23fffd4
Replaced all AssertNotExists with AssertExists
2017-05-06 15:03:42 +03:00
Fabrice Laporte
409f070970
Remove lyrics.com source
2017-05-03 22:54:09 +02:00
Fabrice Laporte
fc6b65d592
Merge pull request #2538 from Kraymer/lyrics-test
...
Tests to track whether lyrics websites are correctly fetched
2017-05-03 20:02:03 +02:00
Fabrice Laporte
8f32bfed82
Reactivate test of LyricsCom and MusiXmatch sources
2017-05-03 07:42:50 +02:00
Fabrice Laporte
f53ab801b8
Add indent
2017-05-03 00:11:26 +02:00
