Commit graph

1725 commits

Author SHA1 Message Date
jmwatte
5eca75321e simplify by removing sum-option and renaming for clarity 2015-11-13 17:56:03 +01:00
jmwatte
024ab0159b remove webbrowser for opening default editor/browser 2015-11-13 15:03:27 +01:00
jmwatte
386578d69c change opts.extra to type choice 2015-11-13 11:24:19 +01:00
Diego Moreda
1c09eeb714 edit: delete temporary files, minor style fixes
* Delete NamedTemporaryFiles once they are not needed on several functions
(change_objs(), vimdiff(), html()).
* Fix use of reserved word "id" on same_format().
* Colorize "really modify" prompt with action_default.
2015-11-08 19:37:10 +01:00
Adrian Sampson
331ced3cca Use existing query mechanism 2015-11-07 12:51:22 -08:00
Adrian Sampson
417eb5e588 Remove use of nonexistent option 2015-11-07 12:46:35 -08:00
Adrian Sampson
519df6da04 Use standard output format for confirmation 2015-11-07 12:45:39 -08:00
Adrian Sampson
7de33c83c4 Remove an unused parameter 2015-11-07 12:39:31 -08:00
Adrian Sampson
fefb2e9914 A little cleanup for legibility and style 2015-11-07 12:36:22 -08:00
jmwatte
f95611dde4 fixed albumid needs to be int 2015-11-05 16:51:33 +01:00
jmwatte
17a32e33c5 added grouping of fields and "$BROWSER" and "$EDITOR" 2015-11-05 15:41:33 +01:00
jmwatte
51658a7ea6 Merge branch 'editor' of https://github.com/jmwatte/beets into editor 2015-11-05 15:18:46 +01:00
jmwatte
ab3bc356b2 updateMerge branch 'master' of https://github.com/sampsyo/beets into editor 2015-11-05 15:13:07 +01:00
Adrian Sampson
7d52fa72ae Fix #1699: Outdated API call
get_fields() was removed in 5420599839.
2015-11-04 20:25:17 -08:00
Adrian Sampson
19cf37263d Fix #1700: Tolerate missing Location in iTunes 2015-11-04 20:11:58 -08:00
Adrian Sampson
be49955884 metasync: More precise exception catching (#1700) 2015-11-04 20:07:49 -08:00
reiv
81a72f74c9 Merge branch 'master' into 314-reimport-art 2015-11-04 18:37:06 +01:00
reiv
0ebc4c799d fetchart: in auto, ignore albums with art
When re-importing an album, we don't want fetchart to interfere
with any existing album art.
2015-11-04 15:08:42 +01:00
Adrian Sampson
a735a6b4a2 discogs: Better exception logging
Might have helped diagnose #1669 more easily.
2015-11-03 22:38:31 -08:00
Adrian Sampson
023a33ca31 Revert "Fix #1656, maybe: encode Discogs token strings"
This reverts commit f784cd1a22.
2015-11-03 22:29:33 -08:00
jmwatte
1f3a42faf0 Update edit.py 2015-11-03 14:57:07 +01:00
jmwatte
5a8a534a3f Delete yamleditor.py 2015-11-03 14:05:06 +01:00
jmwatte
00b21dfa51 Merge branch 'editor' of https://github.com/jmwatte/beets into editor 2015-11-03 13:59:38 +01:00
jmwatte
2d77861e4d renamed and updated editplugin 2015-11-03 13:55:08 +01:00
Adrian Sampson
38edb18a74 Merge pull request #1683 from sampsyo/1264-unnecessary-resize
Fix #1264: Avoid unnecessary art resizes
2015-11-02 22:39:06 -08:00
reiv
1625dfc17e Merge branch 'master' into 1264-unnecessary-resize 2015-11-03 02:46:33 +01:00
reiv
19dcc25a93 fetchart: Improve validation of image dimensions
This avoids images being resized unnecessarily if the dimensions
are correct.
2015-11-03 02:19:47 +01:00
Adrian Sampson
d79d11fb15 Docstring and rewrap for #1675 2015-11-02 16:45:45 -08:00
Adrian Sampson
e84414c822 Fix syntax (and unused variable) in #1675 2015-11-02 16:44:02 -08:00
Adrian Sampson
efcea9a57f Merge pull request #1675 from kooimens/patch-1
Embedart: remove_art_file on import
2015-11-02 16:42:59 -08:00
kooimens
bcef3a7123 Create function remove_artfile
Damn it, that was really hard for me:D. First time seriously using python. Please review it carefuly.
2015-11-02 23:56:38 +01:00
jmwatte
fdbf9e59e7 Update yamleditor.py
polishing
2015-11-02 23:11:42 +01:00
jmwatte
fe012eae77 new plugin yamleditor 2015-11-02 21:13:58 +01:00
Adrian Sampson
a18506f471 Fix #1686: thumbnails using unicode paths 2015-11-02 11:03:43 -08:00
reiv
db08896d8c fetchart: add docstring to helper function
_is_valid_image_candidate() now has three different return values.
These are documented here.
2015-11-02 03:04:45 +01:00
reiv
9182fd8f04 PEP8 amendments 2015-11-01 16:20:48 -08:00
reiv
3250fa80ae fetchart: Only resize when necessary
Fixes #1264: When a re-import triggers fetchart, the existing album art is no
longer resized if it already has the correct dimensions. This avoids creating
new album art files with unique filenames ("cover.n.jpg").
2015-11-01 16:20:18 -08:00
reiv
269d0e5403 fetchart: Check if album art file actually exists
Fixes #1126.
2015-11-01 16:14:51 -08:00
Adrian Sampson
c617033476 convert: Add some comments 2015-11-01 11:01:40 -08:00
Adrian Sampson
5f5a8946c3 convert: Debug log when embedding images
To help diagnose #1671.
2015-10-30 15:25:01 -04:00
kooimens
0257b1077f Simplify some code 2015-10-30 17:49:57 +01:00
kooimens
0ed98515ad Embedart: remove_art_file on import
Should fix #1662.

I think the fix is easy. Don't know if it's clean though. Did some tests (+/- 10 albums), all successful. This is the first time I'm using python so please let me know what I should improve:)
2015-10-30 17:04:11 +01:00
Adrian Sampson
16ad174d29 A debug message for ReplayGain 2015-10-29 17:43:31 -04:00
Frederik “Freso” S. Olesen
5f5365021d lastgenre: Clean up Spanish reggae in the genre list.
* Add missing subgenres to whitelist and tree.
* Use proper terminology.
  * Add English term as child of Spanish one.

Source: https://en.wikipedia.org/wiki/Reggae_en_Espa%C3%B1ol
2015-10-29 05:00:33 +01:00
Frederik “Freso” S. Olesen
1aa808f37b lastgenre: Add raggamuffin.
Already recognised by the genres.txt whitelist, and is a more proper
term for `ragga`.

https://en.wikipedia.org/wiki/Ragga
2015-10-29 04:58:44 +01:00
Frederik “Freso” S. Olesen
1678c1d847 lastgenre: Replace top-level genre ska with reggae
… and move relevant genres from the tree to be children of the `reggae`
top-level genre as well as add `roots reggae` to the list.

See discussion at https://github.com/sampsyo/beets/issues/1661
2015-10-29 04:55:57 +01:00
Frederik “Freso” S. Olesen
b187251a7e lastgenre: Remove dance hall and polish reggae.
Neither of the two are recognised in the genres.txt whitelist.
2015-10-29 04:53:14 +01:00
Frederik “Freso” S. Olesen
004fb7d1c8 lastgenre: Fix up ragga jungle.
* Move `ragga jungle` to beneath `oldschool jungle`.
* Remove `ragga-jungle` which isn't recognised by the genre whitelist.

https://en.wikipedia.org/wiki/Ragga_jungle
2015-10-29 04:44:15 +01:00
Adrian Sampson
f784cd1a22 Fix #1656, maybe: encode Discogs token strings 2015-10-24 12:07:40 -07:00
Alex Nerten
a4ae7fa891 Update plexupdate.py
Fix #1649
2015-10-19 15:24:59 +03:00