stlutz
5d306d6fd9
Remove debugging statement and conform to line length.
2020-05-16 17:48:56 +02:00
stlutz
15402f6aa7
Add alternative scraping algorithm to deal with Genius's new song page html layout.
2020-05-16 17:15:45 +02:00
stlutz
46143d9762
Remove unnecessary intermediate web request to genius.com when fetching lyrics.
...
The search results already include the correct song page url, making it superfluous to do another request via the /song api just to get it.
2020-05-16 16:28:17 +02:00
stlutz
ac043f9be0
When fetching lyrics from Genius, search for title and artist.
...
Searching only for the title and just verifying the artist afterwards leads to songs with very common titles not being found, since Genius limits the amount of returned hits.
An example would be 'Saviour' by 'Circa Waves'.
2020-05-16 13:26:09 +02:00
Thorsten
05d202760b
Update genres.txt
...
Added more heavy metal genres: https://en.wikipedia.org/wiki/Heavy_metal_genres
2020-05-16 00:34:10 +02:00
soergeld
fe418b946e
forgot one mb_workid_current occurence
2020-05-14 22:40:37 +02:00
Adrian Sampson
b3656bcab9
Merge pull request #3586 from dosoe/beet_update_parentwork
...
Fetching parentwork if changed, even if not force
2020-05-14 08:26:30 -04:00
Adrian Sampson
1dcfa03b5b
Merge branch 'master' of github.com:beetbox/beets
2020-05-13 08:21:09 -04:00
Adrian Sampson
5db2b4ccaa
Fix new flake8 warnings
2020-05-13 08:20:50 -04:00
soergeld
918fea5eca
small changes, documentation
2020-05-12 16:05:08 +02:00
Adrian Sampson
4ea69da745
Merge pull request #3588 from MrNuggelz/subsonicplaylist
...
Fix: subsonicplaylist wrong song selection
2020-05-11 19:11:19 -04:00
MrNuggelz
fd1fd2182b
changed "SubstringQuery" to "MatchQuery" to prevent wrong song selection
2020-05-11 20:09:04 +02:00
soergeld
1f93ce5a49
small changes, docs
2020-05-11 16:14:52 +02:00
soergeld
c948530279
Fetching parentwork if changed, even if not force
2020-05-10 13:05:55 +02:00
Adrian Sampson
a907dac16c
Merge pull request #3568 from dosoe/beet_test_new_albuminfo
...
First try adding new albuminfo and trackinfo class
2020-05-09 10:53:43 -04:00
Adrian Sampson
31a264b299
Merge pull request #3425 from MrNuggelz/subsonicplaylist
...
Subsonic Playlist Plugin
2020-05-09 10:52:10 -04:00
MrNuggelz
5d90296a20
fixed flake8 issues
2020-05-09 13:16:56 +02:00
Dorian Soergel
d07c1dece9
Merge branch 'master' into beet_test_new_albuminfo
2020-05-09 12:45:13 +02:00
MrNuggelz
4933671c10
review: updated subsonicplaylist.py
2020-05-08 21:37:05 +02:00
soergeld
7c71bb87a2
cleaning up, renaming dup_XXInfo() to copy()
2020-05-08 16:32:12 +02:00
pants108
1a79ae5a9f
code review 1
2020-05-05 18:39:05 +00:00
pants108
a553693677
fetchart: clean up invalid tmp files
2020-05-03 17:58:44 +00:00
MrNuggelz
5c3debe236
removed unused imports
2020-05-03 16:07:27 +02:00
Joris
08180f2b5d
Merge branch 'master' into subsonicplaylist
2020-05-03 14:59:22 +02:00
MrNuggelz
13b4a1413d
update all songs in one transaction
2020-05-03 14:58:34 +02:00
MrNuggelz
cb7dfe3f6f
review: updated subsonicplaylist.py
2020-05-03 14:05:22 +02:00
Sören Tempel
6a03afc65d
web plugin: support path queries by separating them with a backslash
...
Without this change the web plugin does not support path queries as
slashes are currently used for joining keywords in the QueryConverter.
Moreover, flask cannot distinguish between an URL encoded and a plain
'/' character during routing [0]. To work around this issue without
introducing a breaking change (i.e. removing the QueryConverter) use the
backslash character for path queries and convert it later on.
Fixes #3566
[0]: https://github.com/pallets/flask/issues/900
2020-04-27 13:36:36 +02:00
soergeld
f507f04639
reintroduce default arguments, adapt all occurences of TrackInfo and AlbumInfo to the absence of positional arguments
2020-04-27 11:21:13 +02:00
Adrian Sampson
47deb2f084
Switch log level for #3563 , fix #3533
2020-04-23 08:03:51 -04:00
Michal Koutenský
5143e630d8
Fix #3533 - crash when calculating RG/R128 mix
2020-04-23 11:05:33 +02:00
Adrian Sampson
99dbe93f85
Merge pull request #3559 from somasis/master
...
fetchart: improve description of -q flag
2020-04-19 20:47:32 -04:00
Kylie McClain
1c03f58e0d
fetchart: improve description of -q flag
2020-04-19 14:56:15 -04:00
Ashhar Hasan
625e9253c0
Add tests for artist_sort as lyrics search fallback
...
Adjust doc comment to highlight that artist_sort is used as a fallback
2020-04-19 19:19:07 +05:30
Ashhar Hasan
45c8e51d6c
Fix redundant requests for artist == artist_sort
2020-04-19 19:14:00 +05:30
Ashhar Hasan
a5ef8c7b09
Add artist_sort as the last entry in the artists to search
...
This will handle cases where the artist name includes some
characters which can cause a search failure for some
websites - mainly unicode.
Fixes https://github.com/beetbox/beets/issues/3340 .
2020-04-19 00:50:14 +05:30
Adrian Sampson
269e309513
Slight simplification for #3554
2020-04-17 18:28:21 -04:00
lijacky
9ec0d725e5
Changes given feedback on https://github.com/beetbox/beets/pull/3554 and trimmed sample html
2020-04-17 17:14:21 -04:00
lijacky
8e28f0b694
added null check for genius lyrics scrape
2020-04-16 19:06:17 -04:00
Jack Wilsdon
333d5d1dd3
fetchart: Add Last.fm artwork source
2020-03-30 20:20:59 +01:00
Andrew Rogl
f306591a99
add the extra_tags option to all required plugins
2020-03-28 17:36:02 +10:00
Justin Mayer
f465c90e78
Enforce PEP-8 compliance on Fish completion plugin
2020-03-04 07:15:46 +01:00
Justin Mayer
05db0d18eb
Don't escape question marks in Fish completions
...
Fish shell previously interpreted question marks as glob characters, but
that behavior has been deprecated and will soon be removed. Plus, the
completion for `help` and its alias `?` does not currently seem to behave
as expected anyway and is thus, at present, of limited utility.
2020-03-04 07:15:46 +01:00
Justin Mayer
82c3867fc0
Rewrite Fish completion plugin docs & code comments
2020-03-04 07:15:46 +01:00
jmwatte
d2d2b646c1
Add plugin for Fish shell tab completion
2020-03-02 09:51:36 +01:00
Daniel Barber
fe8ba17ced
Add quality setting to fetchart plugin
2020-02-22 13:36:35 -05:00
Daniel Barber
96b0e8a33e
No longer need to pass a default quality here
2020-02-18 16:44:45 -05:00
Daniel Barber
036202e1c5
Default quality to 0 which means don't specify
...
From the ImageMagick docs: "The default is to use the estimated quality
of your input image if it can be determined, otherwise 92."
In order to get the original behaviour we need to conditional add the
quality parameter to the `magick` call. The quality range can be
anything from 1 to 100, which gives us the convenience of using 0 to
specify no specific quality level.
2020-02-18 14:50:57 -05:00
Daniel Barber
86946ad4b7
Allow the quality to be set for embedded/fetched cover art
2020-02-17 21:12:20 -05:00
Aidan Epstein
535af4bdb2
parentwork: Only call store when the metadata has changed.
...
Otherwise, this rewrites all your files every time.
2020-02-17 09:05:52 -08:00
Adrian Sampson
d43d54e21c
Try to work around a Werkzeug change?
2020-02-06 22:22:54 -05:00