Commit graph

11595 commits

Author SHA1 Message Date
Tianon Gravi
db8a81a721 Fix minor "cover_art_arl" typos in changelog 2023-09-09 00:57:53 -07:00
Jesse Bannon
f72261e44f
Add support for artists and albumartists multi-valued tags (#4743)
Adds the following fields with id3v2.4 multi-valued tag support to autotag:
    - artists, artists_sort, artists_credit
    - albumartists, albumartists_sort, albumartists_credit
    - mb_artistids, mb_albumartistids

MusicBrainz support to populate + write the above multi-valued tags by default. Can be toggled to use id3v2.3 or id3v2.4 tags via the existing beets configuration option `id3v23`.

Big thanks to @JOJ0, @OxygenCobalt, @arsaboo for testing + @sampsyo for the initial code review .
2023-09-09 09:46:26 +02:00
Arno Hautala
7ff20c5e45 fix exclude-fields argument 2023-09-08 22:41:56 -04:00
Arno Hautala
4beee232cf debug 2023-09-08 22:40:45 -04:00
Arno Hautala
4f7d94257e option for excluding fields from updates 2023-09-08 22:18:42 -04:00
Adrian Sampson
b31ddf4f03
Merge pull request #4890 from samtaylorr/patch-1
Correcting pip specific version install from "=" to "==" in Contributing.rst
2023-09-08 16:34:42 -04:00
J0J0 Todos
626fce56b4
Merge pull request #4668 from fdaniele85/substitute_plugin
Substitute plugin
2023-09-08 19:34:46 +02:00
J0J0 Todos
c185b4fba5 Final take on rewording rewrite plugin docs
on whether it modifies metadata or not. Let's also leave a link to the issue
here to make it superclear and researchable for anyone stumbling across it.

Also suggest the substitute plugin as an alternative.
2023-09-08 19:24:34 +02:00
J0J0 Todos
f18d974310 Rough draft of new docs main chapter Team 2023-09-07 08:53:39 +02:00
Arno Hautala
d8eba458bd use ui.should_write() to control restore during import 2023-09-06 18:50:01 -04:00
Sam Taylor
97ac7543b6
Update CONTRIBUTING.rst
Changed line 291 from  ``python -m pip install tox=3.8.3`` to  ``python -m pip install tox==3.8.3`` as shown in the 7th example: https://pip.pypa.io/en/stable/cli/pip_install/#examples, this is the correct way to install specific versions.
2023-09-01 08:52:25 +01:00
J0J0 Todos
4f4e4cdc70 Fix docstring issues in substitute module
to finally make linter happy.
2023-08-31 09:26:42 +02:00
J0J0 Todos
6e983d8615 Fix title underline in substitute plugin docs 2023-08-31 08:59:36 +02:00
J0J0 Todos
54efb279ff Try to clarify the bevhavior of the rewrite plugin
in the plugin docs as was discovered in #2786 (Metadata being modified).
2023-08-31 08:45:05 +02:00
J0J0 Todos
442a535b3e Add substitute plugin to the docs' plugins index 2023-08-31 08:27:33 +02:00
J0J0 Todos
a7e02461ee Add changelog for substitute plugin
While rebasing master into this feature branch I removed fdaniele85's
original version(s) of the changelog to make conflict resolvement
easier. This is a slightly extended version of the latest version I
found in the original commits.
2023-08-31 08:04:24 +02:00
Daniele Ferone
f3f6118b8f Linting fixes in substitute plugin 2023-08-31 08:04:24 +02:00
Daniele Ferone
a4363fb680 Fixes in substitute plugin docs 2023-08-31 08:04:10 +02:00
Daniele Ferone
20c1a3e8a0 Wording fix in substitute plugin docs 2023-08-31 07:17:37 +02:00
Daniele Ferone
bd568ad817 Changed docs of substitute plugin 2023-08-31 07:09:12 +02:00
Daniele Ferone
07c33756b7 _substitute_rules became a class field 2023-08-31 07:08:10 +02:00
Daniele Ferone
249b420b19 Added plugin 2023-08-31 07:07:09 +02:00
Adrian Sampson
0e5ade4f71
Merge pull request #4883 from shoriminimoe/fix-4402
Add embyupdate `userid` config option
2023-08-27 15:07:13 -04:00
Sam Caldwell
fbd179f44a docs[embyupdate]: add docs for userid option 2023-08-24 20:12:04 -07:00
Sam Caldwell
b7e3d37c1b feat[embyupdate]: add handling for private users
Adds a `userid` config option for the `embyupdate` plugin. When the
`userid` is provided, the Emby user lookup is bypassed. This avoids a
failure to get the user ID for private users.

Closes: #4402
2023-08-24 18:50:29 -07:00
J0J0 Todos
62859f4389
Merge pull request #4823 from JOJ0/album_flex_streamline
Streamline album attributes modification behaviour and allow override via CLI
2023-08-23 09:14:26 +02:00
J0J0 Todos
717f379435
Merge pull request #4866 from JOJ0/duplicates_verbose 2023-08-23 09:05:08 +02:00
J0J0 Todos
ef5c4de225 Add docs for duplicate_verbose_prompt option in #4866 2023-08-23 07:55:26 +02:00
J0J0 Todos
cd2db68d07 Add changelog for #4866 2023-08-23 07:55:20 +02:00
J0J0 Todos
38f30b2c13 Handle singletons in duplicate verbose prompt 2023-08-23 07:54:26 +02:00
J0J0 Todos
245d777185 Make verbose duplicates prompt configurable 2023-08-23 07:54:26 +02:00
J0J0 Todos
d91a3e0fba Show details in resolve_duplicates prompt 2023-08-23 07:54:26 +02:00
J0J0 Todos
d7b7d60111 Refactor Album.store for code readability 2023-08-23 06:36:39 +02:00
J0J0 Todos
9616afd339 Fixes in docs for #4823
as suggested by @sampsyo.

Co-authored-by: Adrian Sampson <adrian@radbox.org>
2023-08-23 06:36:39 +02:00
J0J0 Todos
ad3199941d Clarify Album.store() docstring and comments,
explaining the inherit flag, fixed/flex attrs and the strict exclusion
of the id field.
2023-08-23 06:36:39 +02:00
J0J0 Todos
31cd0ecb4e Add docs for mod -a --noinherit option
and further clarify `mod -a` docs:
Even though e39dcfc002 and the linked discussion
already does a very good job on clarifying what is actually happening when `mod
-a` is issued, this commit adds further details about the difference between
the album query and what is actually modified.
2023-08-23 06:36:39 +02:00
J0J0 Todos
7b49b8680c Add changelog for #4823 2023-08-23 06:36:29 +02:00
J0J0 Todos
8d835b8cab Fix ipfs plugin and test_ipfs
by using store(inherit=False) for the creation of a new "ipfs album" as well as
when test_ipfs creates album+items to compare with.
Or put differently: Make ipfs and test_ipfs keep the old store() behaviour for
which the plugin initially was built for.
2023-08-23 06:34:16 +02:00
J0J0 Todos
94d00418b4 Fix test_albuminfo_change_artist_does_not_change_items
by adding (inherit=True) to fit with the new behaviour of the store() method
and add a second test that checks the opposite.
2023-08-23 06:34:16 +02:00
J0J0 Todos
3c7f1223f6 Fix failing test_a_album*_edit_apply tests by
excluding 'id' fields when storing within the Album model.
2023-08-23 06:34:16 +02:00
J0J0 Todos
3587067c1f Option to override album mods propagation to items
Adds a cli option to the modify command that prevents inheriting `modify -a`
changes to album-tracks.
2023-08-23 06:34:16 +02:00
J0J0 Todos
56c1ff8819 Propagate album flex attr mods to items
It seems that _deleting_ flex attrs from an album already propagate to items.
Now also _modifications_ of album flex attrs propagate to items.
2023-08-23 06:34:16 +02:00
Adrian Sampson
684fab47bd
Merge pull request #4876 from beetbox/fix4875
lyrics: Bypass None values in Google backend
2023-08-14 19:00:21 -04:00
Adrian Sampson
49846e7851
lyrics: Bypass None values in Google backend
Fixes #4875.
2023-08-13 18:52:39 -04:00
Benedikt
f75dc3d2c1
Merge pull request #4871 from luzpaz/typos
Fix various typos
2023-08-10 17:58:15 +02:00
Benedikt
290c1df10d
Merge pull request #4868 from mweinelt/pillow10-compat
Fix compatibility with pillow 10
2023-08-10 11:10:10 +02:00
luzpaz
8419149c7a
Fix various typos 2023-08-09 21:26:15 -04:00
Martin Weinelt
c2118a8b9c
Fix compatibility with pillow 10
The `ANTIALIAS` attribute has long been deprecated, and was finally
removed in pillow 10.0.

The recommendation is to migrate to `Resampling.LANCZOS` instead.
2023-08-07 22:19:21 +02:00
Adrian Sampson
a4e61e8bc7
Merge pull request #4867 from beetbox/flake8-fix
Adapt to some recent flake8/pycodestyle changes
2023-07-31 11:17:09 -07:00
Adrian Sampson
af0df4ca03
Missed a couple of cases in tests 2023-07-31 10:26:59 -07:00