Commit graph

694 commits

Author SHA1 Message Date
Jan Holthuis
74e549838c feat(import): Add support for reading skipped paths from logfile
Fixes #4379.
2022-06-26 19:38:23 +02:00
Duncan Overbruck
795bc2efc1
compile modify templates only once 2021-12-15 14:31:15 +01:00
Duncan Overbruck
636e36ef7a
allow templates/formatting when setting fields with modify 2021-10-27 00:10:25 +02:00
Andrew Rogl
910354a6c6 fix unused import and flake8 2021-08-25 19:07:55 +10:00
Andrew Rogl
432fa55725 pyupgrade ui directory 2021-08-25 18:56:32 +10:00
Adrian Sampson
75c41c0546
Remove most six.PY2 checks 2021-08-19 16:45:11 -04:00
Ryan Lanny Jenkins
c8fa1b2809 Raise PluginConflictException instead of the generic Exception for new hook. 2021-03-29 18:12:30 -05:00
Ryan Lanny Jenkins
79616b42ed Use simpler approach of asserting that at most one handler of import_task_before_choice returns an action. 2021-03-28 16:53:01 -05:00
Ryan Lanny Jenkins
1d4a2c3e2a Add a new hook for badfiles pre-import user interaction, instead of flagging the task. 2021-03-27 11:37:26 -05:00
Ryan Lanny Jenkins
e96b5a7eba Check files during import, show checker warnings and errors along with tagging choices. 2021-03-23 21:55:51 -05:00
Adrian Sampson
374f211135 Merge pull request #3783 from Sudo-kun/feature/3569
Changed the phrasing asked in Issue 3569
2020-10-25 06:57:06 -04:00
Sudo-kun
e49ee7c686 Removed white-space sensitivity in the if-clause 2020-10-25 11:02:12 +01:00
Georg Schwitalla
d51e44b9e6 Issue #3569 changed the the text from Keep both to keep all 2020-10-24 13:29:44 +02:00
Georg Schwitalla
e898f4396e forgot the second blank line 2020-10-24 13:19:29 +02:00
Georg Schwitalla
9c1b39a96e had a slight typo 2020-10-24 12:56:37 +02:00
Georg Schwitalla
8e17d445ff Added a check if config_out was empty 2020-10-24 12:47:59 +02:00
wisp3rwind
822bc1ce88 add possibility to select individual items to the remove CLI command 2020-09-13 14:26:00 +02:00
Jamie Quigley
e83959ab75
Add changelog item and merge if statements 2020-09-07 22:11:15 +01:00
Jamie Quigley
1ab162743a
Convert to kHz and meet line limit 2020-09-07 17:42:56 +01:00
Jamie Quigley
c8443332de
Added flac-specific samplerate-bitdepth reporting for duplicate imports 2020-09-07 17:32:03 +01:00
Logan Arens
b2ef1941aa
Changed library check from existence to directory 2019-10-12 14:00:44 -04:00
Logan Arens
baf4953ac0
Library path is printed if update cannot find it 2019-10-12 12:25:18 -04:00
Logan Arens
0030a2218c
Small cosmetic changes to meet flake8 standards 2019-10-09 23:17:07 -04:00
Logan Arens
8700e271d9
"beet update" now confirms that the library path exists before updating.
Fixes #1934.
2019-10-09 22:47:50 -04:00
unknown
c9468350ec Timid always prompts. Clarify docstring. 2019-09-07 11:49:54 -04:00
unknown
80e51027e6 remove debug line 2019-09-02 20:17:00 -04:00
unknown
7754dd27c5 Make none_rec_action respect timid. #3242 2019-09-02 20:15:35 -04:00
wisp3rwind
0bc3727fcf Correctly display track number 0 in show_change
fixes issue #3346: When the per_disc_numbering option was set, the UI would
previously show a #0 -> #1 change when actually the index would be set
to 0 (a valid index, such as for hidden tracks).  Now, properly
distinguish index 0 and None (i.e. not set)
2019-08-20 00:02:32 +02:00
FichteFoll
aa31fea037
Update a lot of URLs to use HTTPS
*All* URLs were checked manually, but only once per domain!

I mostly concerned myself with URLs in documentation rather than source
code because the latter may or may not have impactful changes, while the
former should be straight forward.

Changes in addition to simply adding an s:

- changed pip and pypi references as their location has changed
- MPoD (iOS app) url redirects to Regelian, so I replaced those
- updated homebrew references

Notable observations:

- beets.io does have HTTPS set up properly (via gh-pages)
- beatport.py uses the old HTTP url for beatport
- as does lyrics.py for lyrics.wikia.com
- https://tomahawk-player.org/ expired long ago, but the http page
  redirects to https regardless
- none of the sourceforge subdomains have https (in 2019!)
2019-06-05 03:11:49 +02:00
Carl Suster
5b7b5061e7 Avoid using an internal confuse function 2019-06-02 23:16:30 +10:00
Carl Suster
a82002e6c1 confit: replace with confuse in core beets 2019-06-01 09:51:56 +10:00
jroitgrund@gmail.com
ea307f62d1 Don't move album art twice 2019-03-27 01:41:42 +00:00
RollingStar
f5086d0bc6 Changelog and linting 2019-01-18 17:15:29 -05:00
RollingStar
a4100a28a5 More verbose move message 2019-01-16 17:56:27 -05:00
Taizo Simpson
b901eb3723
Added check to remove duplicate changes 2018-10-24 14:12:32 -04:00
Taizo Simpson
a9793067fa
When selecting items to modify, use configured order
Closes #3501
2018-10-22 20:34:21 -04:00
jams2
68590e10ab remove unnecessary list comp, add descriptive variable names 2018-06-20 18:21:04 +01:00
jams2
b6947ddc2e change ui.commands.show_change to align missing tracks by length of longest track name to print 2018-06-20 18:07:03 +01:00
jams2
df2172baaa add variable width justification to missing tracks dialog 2018-06-20 12:55:51 +01:00
jams2
e085368326 fix style 2018-06-19 09:45:50 +01:00
jams2
399fdc9793 add space-padding to missing tracks dialog 2018-06-19 09:11:55 +01:00
David Logie
33ddfe4145 Display the artist credit when matching albums if the user prefers artist credits. 2018-06-11 13:37:10 +01:00
8h2a
38b36a92de Add catalognumber to disambiguation string
when selecting candidates
2018-06-08 22:18:30 +02:00
Adrian Sampson
e8190b5c1a Avoid a crash when mediums is none 2018-04-29 13:37:59 -04:00
jhermann
245cf1a74d Partial fix for cmd names with dashes (ref #2836)
This patch avoids errors during completion when a plugin
uses names like "sub-command". It does not make completion
fully working for such commands though, thus no close.
2018-03-11 16:02:10 +01:00
Adrian Sampson
d29776ee23 Merge pull request #2803 from beetbox/2793-unicodepaths
Use import argument paths as bytestrings on Python 3
2018-02-05 11:49:58 -05:00
Adrian Sampson
0f8b5b30d9 Merge pull request #2731 from beetbox/2441-search-edit-candidates
Modify task recommendation and candidates
2018-01-30 22:48:24 -05:00
Adrian Sampson
2f2388fc2c py3: Use import argument paths as bytestrings 2018-01-30 21:52:31 -05:00
tummychow
e848adab04 Implement from_scratch option
Fixes #934, and also helps with #1173.
2017-12-07 14:46:40 -05:00
Adrian Sampson
0d8d1c3aee Modify task recommendation and candidates
This way, subsequent candidates can be exposed to plugins instead of
just used locally to interact with the user.
2017-11-01 19:13:42 -04:00
Meet Udeshi
70f0bc5b6c Implement album merging for duplicates
Fixes #112
2017-11-01 02:00:48 +05:30
zigarrre
b376139663 Refactored move functions for clarity according to #2682
The move functions in library.py and manipule_files in importer.py where
changed to use a single parameter for the file operation instead of
multiple boolean flags.

A typo in the documentation of the Album.move and Item.move functions
confusing True and False when describing the store parameter was fixed
as well.
2017-09-11 17:03:44 +02:00
A.L. Kleijngeld
2eb4e3d515 Merge branch 'master' into master 2017-06-13 14:43:10 +02:00
Bart Kleijngeld
52d5d2310b refactoring according to feedback in pull request 2017-06-12 16:46:09 +02:00
Adrian Sampson
dfde9ce916 Merge pull request #2510 from SpirosChadoulos/master
New export command (issue #435)
2017-06-11 12:21:06 -04:00
Adrian Sampson
714560aace Fix parameter order and binding
The calls didn't match up with the parameter order.
2017-06-10 20:19:27 -04:00
Adrian Sampson
231528784d Simplify implementation of export behavior 2017-06-10 20:15:02 -04:00
Bart Kleijngeld
91722aea36 added documentation 2017-05-30 21:29:49 +02:00
Bart Kleijngeld
1da972f4bb implemented set_field cli parsing 2017-05-30 16:15:28 +02:00
SpirosChadoulos
7c91989344 Minor flake fixes 2017-05-12 15:25:36 +03:00
SpirosChadoulos
169cf596b0 Fixed bool variable error 2017-05-12 15:08:06 +03:00
SpirosChadoulos
8f62e8bc68 Requested changes done 2017-05-12 14:49:03 +03:00
SpirosChadoulos
0dc948d9d3 Made sure that the destination directory will exist 2017-05-11 12:11:21 +03:00
SpirosChadoulos
167ae91b8d Changes at line 1486 2017-05-05 00:36:36 +03:00
SpirosChadoulos
90c30d8564 Added an if album: statement 2017-05-04 19:08:23 +03:00
Adrian Sampson
8e78cfdac7 Always pass unicode to print_
Introduced in #2495.
2017-04-29 21:13:34 -04:00
Adrian Sampson
dd7b129e21 Turn off unnecessary execute bit 2017-04-29 18:29:47 -04:00
Adrian Sampson
e9c3d69e59 Fix a typo 2017-04-29 18:29:36 -04:00
SpirosChadoulos
60318f1e02 fixed line length 2017-04-19 13:07:04 +03:00
SpirosChadoulos
de57602e34 fixed certain errors 2017-04-19 12:54:03 +03:00
SpirosChadoulos
3e9076b451 deleted else 2017-04-19 12:47:31 +03:00
SpirosChadoulos
70183070b2 deleted else 2017-04-19 12:35:07 +03:00
SpirosChadoulos
53618258fa added 1 line before for loop 2017-04-19 11:31:08 +03:00
SpirosChadoulos
a99b7e9e40 Provided default value for export. 2017-04-16 15:53:11 +03:00
SpirosChadoulos
d4413a2bc4 obj instead of item 2017-04-15 00:54:09 +03:00
SpirosChadoulos
8f3ca12179 Put export before confirm 2017-04-14 12:19:16 +03:00
SpirosChadoulos
4745c262e2 New export command 2017-04-13 12:51:11 +03:00
SpirosChadoulos
218968235e small changes for the bell issue 2017-03-28 01:09:14 +03:00
SpirosChadoulos
c605a918c8 Added an if statement that allows the bell ring according to the user's configuration. 2017-03-27 20:49:28 +03:00
SpirosChadoulos
28c423b527 Added bell when user interaction is needed 2017-03-27 01:06:30 +03:00
SpirosChadoulos
5128b9567c Added bell when user interaction is needed 2017-03-27 01:02:18 +03:00
SpirosChadoulos
2fbc7f0e70 Added a terminal bell if interaction from the user is required 2017-03-26 13:40:40 +03:00
karpinski
88d26e7694 Adding a move option to the importer's CLI and updating the docs. 2017-02-07 21:19:45 +01:00
Adrian Sampson
63f50287d5 Rename some choice-related variables
These are no longer "extra"---they're *all* the choices that will be used.
2016-12-28 14:54:25 -05:00
Adrian Sampson
c98972894a Better prompt order 2016-12-28 14:49:26 -05:00
Adrian Sampson
f5e4853bb3 Move as-is and skip choices to declarative choices
That's all the standard choices that don't depend on which prompt you're
looking at! Woohoo!
2016-12-28 14:46:33 -05:00
Adrian Sampson
1e8be0a19f Use declarative style for ALBUMS/TRACKS choices
This unifies the set of choices that are shown at each prompt variant in
`choose_candidate`, making its code much shorter. Declarative programming FTW.
2016-12-28 14:40:06 -05:00
Adrian Sampson
9dff841afe Fix class anme of PromptChoice 2016-12-28 14:33:55 -05:00
Adrian Sampson
e5a12615e4 Subsume abort action into declarative style 2016-12-28 14:32:41 -05:00
Adrian Sampson
6afe407f45 Remove one last duplicated set of prompts 2016-12-28 14:16:33 -05:00
Adrian Sampson
8937eec50a Refactor built-in stnadard choices 2016-12-28 14:15:40 -05:00
Adrian Sampson
2f6538aee2 Refactor search options to ordinary choices
`PromptChoice`s can now return `Proposal` values, which makes these two
options just "normal" actions that could be provided by plugins.
2016-12-28 14:08:09 -05:00
Adrian Sampson
6c825970ac Tolerate missing AlbumInfo.mediums field 2016-12-28 13:54:04 -05:00
Adrian Sampson
7c6eafa285 Refactor manual search options to use Proposal
This is the first step to making them behave like plugin actions.
2016-12-28 13:50:53 -05:00
Adrian Sampson
22610b7684 Refactor extra choice return value
The `choose_candidate` function now returns the `PromptChoice` object instead
of a short letter that selects the `PromptChoice`.
2016-12-28 13:34:27 -05:00
Adrian Sampson
3578f0d429 Introduce a new Proposal type for tag results
tag_album and tag_item now return a Proposal. The idea is that plugin actions
should also be able to return Proposal values, just like the built-in actions.
2016-12-28 13:21:55 -05:00
Adrian Sampson
9b0a867c73 Expand some comments in choose_match 2016-12-28 12:40:33 -05:00
Adrian Sampson
55d9233e39 Capitalize Python 2016-11-25 21:06:01 -05:00
walt
c3b70b5098 Removed call to .decode('utf-8') when printing flexible attributes 2016-11-16 11:33:16 +01:00
Dang Mai
04560bd88e Stop passing in fields to be stored for Item.move and Album.move 2016-10-23 15:52:27 -04:00