Commit graph

5505 commits

Author SHA1 Message Date
Yevgeny Bezman
2f9fe91121 replaygain: restore flake8 cleanliness 2014-06-27 20:02:11 +03:00
Yevgeny Bezman
b019e6a5c0 replaygain: silenced errors during import. Fixes #732 2014-06-27 19:50:41 +03:00
Adrian Sampson
16f6a3daa7 Note about group-albums and import log (#825) 2014-06-25 10:05:31 -07:00
Pierre Rust
18539b0bd1 Fix flake8 warnings. 2014-06-15 22:32:26 +02:00
Pierre Rust
69213ad574 Add tests for computed attributes. 2014-06-15 22:32:26 +02:00
Pierre Rust
936acf0236 Fix typo in common utility function for tests 2014-06-15 22:32:26 +02:00
Pierre Rust
728797718e Add tests cases for sort on albums.
On fixed and flex attributes.
2014-06-15 22:32:26 +02:00
Pierre Rust
ad1c0b3831 Add unit tests for fixef and flex field sort 2014-06-15 22:32:26 +02:00
Pierre Rust
1a995ed8d4 Fix sorting without using the MultipleSort object.
SQL syntax error when using a simple FlexFieldSort.
2014-06-15 22:32:26 +02:00
Pierre Rust
a90991b296 Removes unused import (flake8 warning) 2014-06-15 22:32:25 +02:00
Pierre Rust
ebd2da14dc Fix error on default sort configuration
Fix crash when using several criteria for default sort in the
configuration file.
2014-06-15 22:32:25 +02:00
Pierre Rust
1d61088cfc Sort on computed field implementation.
Sort is implemented in python.
When combining sorts on fixed, flex and computed field, make as
much as possible in sql and finishes the job in python.
2014-06-15 22:32:25 +02:00
Pierre Rust
486289b11a Add documentation about default sort configuration. 2014-06-15 22:32:25 +02:00
Pierre Rust
86c34f8740 Moves default sort specification from code to conf
Default sort order can be set in configuration file with the
`sort_album` and `sort_item` keys.
2014-06-15 22:32:25 +02:00
Pierre Rust
3426363775 Add documentation about sort specification. 2014-06-15 22:32:25 +02:00
Pierre Rust
4958ce83c3 Add defaut sort on artist_sort field.
For items and albums, defaulting on artist field if artist field
is empty.
2014-06-15 22:32:25 +02:00
Pierre Rust
3d7814c32e Use implicit continuation for sql generation.
Avoid newlines in the query string.
2014-06-15 22:32:25 +02:00
Pierre Rust
1303a915c1 Sort implementation
* sort can be sepcified using the 'field_name'(+|-) syntax
 * supports fixed fields and flexible attributes
 * includes plugins fix for API changes (might have missed some)
2014-06-15 22:32:25 +02:00
Adrian Sampson
eb5c37ecc0 Fix broken docs references 2014-06-14 16:17:28 +01:00
Adrian Sampson
4940958148 Fix #822: scrub/convert plugin conflict
We now correctly scrub the destination of a conversion, not the source.
2014-06-14 16:08:49 +01:00
Heinz Wiesinger
bd55fadafb Changelog for #812 2014-06-14 12:07:16 +02:00
Heinz Wiesinger
d36b54cd56 Make beet write not show item names for items without changes. 2014-06-09 13:27:10 +02:00
Heinz Wiesinger
527fb7a335 Also check whether new fields are in the restricted field list (Fix #812) 2014-06-09 13:26:43 +02:00
Adrian Sampson
30c5f4ddf4 Changelog for #810 (fix #320) 2014-06-08 17:27:06 +01:00
Adrian Sampson
3056da2d1d Merge pull request #810 from brunal/show-path-on-delete
Show file path when deleting items
2014-06-08 17:25:58 +01:00
Adrian Sampson
3e1e8eea16 Changelog for #811 (fix #475) 2014-06-08 17:24:22 +01:00
Adrian Sampson
41666fe2f3 Merge pull request #811 from brunal/zero-conserve-important-fields
Zero plugin: do not zero important fields
2014-06-08 17:23:27 +01:00
Bruno Cauet
469ec40c0f Zero plugin: do not zero important fields
Prevent zeroing fields id, album_id and path.

Fix issue #475.
2014-06-08 17:26:17 +02:00
Bruno Cauet
f40517b09e Show file path when deleting items
Using `beets remove -d <target>" now shows the file path when asking for
confirmation.

The format string is '$path - $title'.

Fix issue #320.
2014-06-08 17:22:15 +02:00
Adrian Sampson
63af350eaa Diff output shows formatted values for strings
This is why, in #807, the album field was appearing to "work" while the year
field was displaying the issue. We were colorizing the wrong value.

Now, of course, we need to fix the underlying issue: we're confusingly
displaying album-level information for these items.
2014-06-05 16:53:23 -07:00
Adrian Sampson
29e11f1ddb Changelog for #772/#806 2014-06-04 17:16:47 -07:00
Adrian Sampson
94ceba40d4 Merge pull request #806 from kljohann/on_stop
mpdstats: update rating on 'stop' (e.g. last song in playlist)
2014-06-04 17:14:31 -07:00
Johann Klähn
b590cfebf2 mpdstats: update rating on 'stop' (e.g. last song in playlist)
Fixes #772
2014-06-04 15:41:15 +02:00
Adrian Sampson
ee16396f8c Update Confit to "next generation"
These recent updates vastly simplify validation in the configuration system.
We should now be able to validate whole subtrees of the configuration at a
time.
2014-06-03 21:35:00 -07:00
Adrian Sampson
48189b4a54 keyfinder: Unicode literals in logging call
Log messages should *always* be Unicode. I wish we had a flake8 checker for
this...
2014-06-02 22:12:57 -07:00
Adrian Sampson
0c5fbdcefd Merge pull request #802 from geigerzaehler/embed
Merge pull request #802
2014-06-02 21:30:28 -07:00
Thomas Scholtes
2813cd26c1 Refactor embedart to work at item level
Embedding images now triggers the `*_write` plugin events. This
allows *beets-check* to update the checksum. See the [beets-check
issue][1].

[1]: https://github.com/geigerzaehler/beets-check/issues/7
2014-06-02 17:10:48 +02:00
Thomas Scholtes
f19fa1567e Test converter embeds album art 2014-06-02 17:09:16 +02:00
Thomas Scholtes
9c6491a65d Embedart TestCase 2014-06-02 16:04:55 +02:00
Adrian Sampson
d2b1fd4da9 Merge branch 'master' of github.com:sampsyo/beets 2014-06-01 12:04:48 -07:00
Adrian Sampson
61083325e3 Fix #796: flat import of empty directories 2014-06-01 12:04:16 -07:00
Adrian Sampson
85ee7b2b0c Merge pull request #794 from drm00/beets-on-openbsd
beets installation instructions on openbsd
2014-05-29 09:23:22 -07:00
Nils R
96fd33903b beets installation instructions on openbsd 2014-05-29 13:30:28 +02:00
Adrian Sampson
632d3a9612 dbcore: Add shared instances of common types
Following click's example:
https://github.com/mitsuhiko/click/blob/master/click/types.py#L414
2014-05-25 16:38:47 -07:00
Adrian Sampson
23d884b6e8 Move MusicalKey type out of dbcore module
This is library-specific.
2014-05-25 16:25:47 -07:00
Adrian Sampson
394e4e45eb dbcore: Add types for non-fixed fields
The base Type class now serves as the catch-all logic for untyped fields.
2014-05-25 16:23:15 -07:00
Adrian Sampson
429188e8e1 Changelog for #776 2014-05-25 15:44:21 -07:00
Lucas Duailibe
e3c86f24ae Fix lint error :) 2014-05-25 19:30:16 -03:00
Lucas Duailibe
d1d166b5b5 Enable use of files with play -a (closes #776)
This commit changes the output of the play plugin to always use files instead of folders when generating a playlist when using the `-a` option. A new `use_folders` option was added to preserve the old behavior for anyone who wishes it.
2014-05-25 18:47:02 -03:00
Adrian Sampson
a71f929a3c Merge branch 'master' of github.com:sampsyo/beets 2014-05-24 17:07:52 -07:00