Commit graph

9323 commits

Author SHA1 Message Date
Daniel Barber
a30c90e615 Fix one of the failing tests 2020-02-17 22:22:47 -05:00
Daniel Barber
86946ad4b7 Allow the quality to be set for embedded/fetched cover art 2020-02-17 21:12:20 -05:00
Adrian Sampson
de6173a6f4
Merge pull request #3492 from aereaux/parentwork_only_store_if_changed
parentwork: Only call store when the metadata has changed.
2020-02-17 10:24:20 -08:00
Aidan Epstein
535af4bdb2 parentwork: Only call store when the metadata has changed.
Otherwise, this rewrites all your files every time.
2020-02-17 09:05:52 -08:00
Adrian Sampson
ddfb715e32 Style fixes for #3491 2020-02-17 06:49:26 -08:00
Adrian Sampson
3b5641246d Merge pull request #3491 from adamjakab/docs-dev
Added beets-bpmanalyser to the list of 'other plugins'
2020-02-17 06:48:58 -08:00
Adam Jakab
9426ad7345 Added beets-bpmanalyser to the list of 'other plugins' 2020-02-17 09:40:30 +01:00
Adrian Sampson
d43d54e21c Try to work around a Werkzeug change? 2020-02-06 22:22:54 -05:00
Adrian Sampson
91be732bf4 Fix whitespace (#3453) 2020-02-06 22:18:15 -05:00
Adrian Sampson
f9088a3eb7
Merge pull request #3453 from faulkt/master
added merge_environment_settings call
2020-02-06 21:54:14 -05:00
Tyler Faulk
964a6c2e63 restored whitespace to please style checker 2020-02-06 12:10:38 -05:00
Adrian Sampson
817bef25ea
Merge pull request #3480 from ybnd/bs1770gain-v0.6.0-parsing
Update Bs1770gainBackend to handle bs1770gain v0.6.0 XML output
2020-02-05 16:52:32 -05:00
ybnd
63ea17365a Modify patched stdout in test_malformed_output 2020-02-05 09:04:24 +01:00
ybnd
7005691410 Add comment to clarify unexpected AttributeError handling 2020-02-05 08:52:50 +01:00
ybnd
1ab46c69be Merge remote-tracking branch 'origin/master' into bs1770gain-v0.6.0-parsing
# Conflicts:
#	docs/changelog.rst
2020-02-05 08:45:30 +01:00
ybnd
9465e933ba Add to changelog 2020-02-05 08:36:44 +01:00
Adrian Sampson
95e0f54d7c Fix too-long lines (#3448) 2020-02-02 21:04:55 -05:00
Adrian Sampson
d4d04c61aa
Merge pull request #3448 from xhocquet/genius-lowercase-artist-fix
Genius lyrics fix for API capitalization behaviors
2020-02-02 20:46:24 -05:00
Xavier Hocquet
9f43408f1b Changelog and cleanup 2020-02-02 15:57:43 -07:00
ybnd
bef473c8e8 Remove spliced progress regex and add --suppress-progress flag 2020-01-31 07:42:50 +01:00
ybnd
506be02597 Remove packaging dependency 2020-01-30 20:11:09 +01:00
ybnd
c3817a4c06 Implement review comments
* safer version comparison

* regex bytes directly

* handle b'\x08 ...' case

* test_replaygain.py: injected command output should match the type of the actual output
2020-01-30 19:21:53 +01:00
ybnd
c1cb78c908 Small fixes in replaygain.Bs1770gainBackend and test_replaygain.py
* Fix unspecified `gain_adjustment` when method defined in config

* Fix difference between dB and LUFS values in case of mismatched `target_level`/`method`:

  ```
  db_to_lufs( target_level <dB> ) - lufs_to_dB( -23 <LUFS> )
  ```

* Ignore single assertion in case of bs1770gain

(cherry picked from commit 2395bf224032c44f1ea5d28e0c63af96a92b96df)
2020-01-30 17:59:57 +01:00
ybnd
c78afb1a97 Don't call bs1770gain outside of try statement 2020-01-30 17:02:28 +01:00
ybnd
53820c0a98 Handle bs1770gain v0.6.0 XML output
* Remove `0%\x08\x08` from output (backspace code doesn't resolve; progress percentages get spliced in)

* Handle changed attributes/fields:
  * `sample-peak` attribute `factor` is called `amplitude` instead
  * Album summary is not included in a `summary` tag now, but in two separate `integrated` and `sample-peak` tags

* Handle `lu` attribute

* Get bs1770gain version
  * If v0.6.0 or later, add `--unit=ebu` flag to convert `db` attributes to LUFS
  * May be useful later on

### Output examples

Track:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
  <track total="1" number="1" file="02 tïtle 0.mp3">
    <integrated lufs="-70.00" lu="52.00"/>
    <sample-peak spfs="-72.28" amplitude="0.00"/>
  </track>
  <integrated lufs="-70.00" lu="52.00"/>
  <sample-peak spfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```

Album:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
  <track total="2" number="1" file="02 tïtle 0.mp3">
    <integrated dbfs="-70.00" db="52.00"/>
    <sample-peak dbfs="-72.28" amplitude="0.00"/>
  </track>
  <track total="2" number="2" file="02 tïtle 1.mp3">
    <integrated dbfs="-70.00" db="52.00"/>
    <sample-peak dbfs="-72.28" amplitude="0.00"/>
  </track>
  <integrated dbfs="-70.00" db="52.00"/>
  <sample-peak dbfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```
2020-01-30 16:13:29 +01:00
Adrian Sampson
c1937e1b01
Merge pull request #3477 from ybnd/master
Remove --replaygain flag when checking bs1770gain availability
2020-01-29 09:45:55 -06:00
ybnd
a4a0a4bd28 Remove --replaygain flag when checking bs1770gain availability
bs1770gain exits with error 1 when called without data, interpreted as unavailable
2020-01-28 09:45:20 +01:00
Adrian Sampson
ca3142b1d9
Merge pull request #3467 from BrainDamage/keyfinder-cli
support for keyfinder-cli, which doesn't want the -f flag for paths
2020-01-14 08:24:54 -05:00
BrainDamage
f118314682 support for keyfinder-cli, which doesn't want the -f flag for paths 2020-01-14 05:07:33 +01:00
Adrian Sampson
a08f2315ea Simplify Confuse usage (#3463) 2019-12-26 20:44:14 -05:00
Adrian Sampson
f0eede2ab4 Merge pull request #3463 from mathieupinet/fetchart_highresolution
fetchart: New high_resolution config option (#3391)
2019-12-26 20:43:51 -05:00
Mat
2593a5be34 Use a local var to use high resolution option 2019-12-26 21:55:48 +00:00
Mat
7ad3f7f728
Apply suggestions from code review
Fix wording in docs

Co-Authored-By: Adrian Sampson <adrian@radbox.org>
2019-12-26 21:09:26 +00:00
Mat
3570f5cd56 New high_resolution config option in fetchart 2019-12-26 17:36:56 +00:00
Adrian Sampson
a9b19e1678
Merge pull request #3459 from cole-miller/index-tracks
discogs: Add `index_tracks` option (closes #3458)
2019-12-18 15:59:35 -05:00
Cole Miller
ea02890be6 Merge remote-tracking branch 'origin/index-tracks' into index-tracks 2019-12-18 14:46:15 -05:00
Cole Miller
49d9f474a5 Update changelog 2019-12-18 14:44:57 -05:00
Cole Miller
e945ed894d
Add trailing comma
Co-Authored-By: Adrian Sampson <adrian@radbox.org>
2019-12-18 14:31:59 -05:00
Cole Miller
6c948764fe Wrap comment lines 2019-12-17 17:56:56 -05:00
Cole Miller
614289af5f Remove use of `list.clear()' for compatibility 2019-12-17 17:46:43 -05:00
Cole Miller
3ccafa2495 Fix `str.join' usage 2019-12-17 17:40:16 -05:00
Cole Miller
5f74edf2d9 One more documentation typo 2019-12-17 17:01:34 -05:00
Cole Miller
67e402bbae Fix typo in new documentation 2019-12-17 16:57:24 -05:00
Cole Miller
90fb79f408 Document `index_tracks' option 2019-12-17 16:54:56 -05:00
Cole Miller
8805ba28fd Add comments 2019-12-17 16:33:41 -05:00
Cole Miller
02e03be93d Incorporate divisions into track titles 2019-12-17 15:38:54 -05:00
Cole Miller
e31695b606 Trace hierarchy of index tracks 2019-12-17 15:27:26 -05:00
Cole Miller
6889b9ffdc Add `index_tracks' configuration option 2019-12-17 13:43:53 -05:00
Adrian Sampson
20630d1947
Merge pull request #3457 from mathieupinet/patch-1
Wording/grammar
2019-12-16 17:07:25 -05:00
Mat
e760fc6947
Wording/grammar 2019-12-16 21:47:13 +00:00