Justin Mayer
f465c90e78
Enforce PEP-8 compliance on Fish completion plugin
2020-03-04 07:15:46 +01:00
Justin Mayer
05db0d18eb
Don't escape question marks in Fish completions
...
Fish shell previously interpreted question marks as glob characters, but
that behavior has been deprecated and will soon be removed. Plus, the
completion for `help` and its alias `?` does not currently seem to behave
as expected anyway and is thus, at present, of limited utility.
2020-03-04 07:15:46 +01:00
Justin Mayer
82c3867fc0
Rewrite Fish completion plugin docs & code comments
2020-03-04 07:15:46 +01:00
jmwatte
d2d2b646c1
Add plugin for Fish shell tab completion
2020-03-02 09:51:36 +01:00
Daniel Barber
fe8ba17ced
Add quality setting to fetchart plugin
2020-02-22 13:36:35 -05:00
Daniel Barber
96b0e8a33e
No longer need to pass a default quality here
2020-02-18 16:44:45 -05:00
Daniel Barber
036202e1c5
Default quality to 0 which means don't specify
...
From the ImageMagick docs: "The default is to use the estimated quality
of your input image if it can be determined, otherwise 92."
In order to get the original behaviour we need to conditional add the
quality parameter to the `magick` call. The quality range can be
anything from 1 to 100, which gives us the convenience of using 0 to
specify no specific quality level.
2020-02-18 14:50:57 -05:00
Daniel Barber
86946ad4b7
Allow the quality to be set for embedded/fetched cover art
2020-02-17 21:12:20 -05:00
Aidan Epstein
535af4bdb2
parentwork: Only call store when the metadata has changed.
...
Otherwise, this rewrites all your files every time.
2020-02-17 09:05:52 -08:00
Adrian Sampson
d43d54e21c
Try to work around a Werkzeug change?
2020-02-06 22:22:54 -05:00
Adrian Sampson
91be732bf4
Fix whitespace ( #3453 )
2020-02-06 22:18:15 -05:00
Adrian Sampson
f9088a3eb7
Merge pull request #3453 from faulkt/master
...
added merge_environment_settings call
2020-02-06 21:54:14 -05:00
Tyler Faulk
964a6c2e63
restored whitespace to please style checker
2020-02-06 12:10:38 -05:00
ybnd
63ea17365a
Modify patched stdout in test_malformed_output
2020-02-05 09:04:24 +01:00
ybnd
7005691410
Add comment to clarify unexpected AttributeError handling
2020-02-05 08:52:50 +01:00
ybnd
1ab46c69be
Merge remote-tracking branch 'origin/master' into bs1770gain-v0.6.0-parsing
...
# Conflicts:
# docs/changelog.rst
2020-02-05 08:45:30 +01:00
Adrian Sampson
95e0f54d7c
Fix too-long lines ( #3448 )
2020-02-02 21:04:55 -05:00
Adrian Sampson
d4d04c61aa
Merge pull request #3448 from xhocquet/genius-lowercase-artist-fix
...
Genius lyrics fix for API capitalization behaviors
2020-02-02 20:46:24 -05:00
Xavier Hocquet
9f43408f1b
Changelog and cleanup
2020-02-02 15:57:43 -07:00
ybnd
bef473c8e8
Remove spliced progress regex and add --suppress-progress flag
2020-01-31 07:42:50 +01:00
ybnd
506be02597
Remove packaging dependency
2020-01-30 20:11:09 +01:00
ybnd
c3817a4c06
Implement review comments
...
* safer version comparison
* regex bytes directly
* handle b'\x08 ...' case
* test_replaygain.py: injected command output should match the type of the actual output
2020-01-30 19:21:53 +01:00
ybnd
c1cb78c908
Small fixes in replaygain.Bs1770gainBackend and test_replaygain.py
...
* Fix unspecified `gain_adjustment` when method defined in config
* Fix difference between dB and LUFS values in case of mismatched `target_level`/`method`:
```
db_to_lufs( target_level <dB> ) - lufs_to_dB( -23 <LUFS> )
```
* Ignore single assertion in case of bs1770gain
(cherry picked from commit 2395bf224032c44f1ea5d28e0c63af96a92b96df)
2020-01-30 17:59:57 +01:00
ybnd
c78afb1a97
Don't call bs1770gain outside of try statement
2020-01-30 17:02:28 +01:00
ybnd
53820c0a98
Handle bs1770gain v0.6.0 XML output
...
* Remove `0%\x08\x08` from output (backspace code doesn't resolve; progress percentages get spliced in)
* Handle changed attributes/fields:
* `sample-peak` attribute `factor` is called `amplitude` instead
* Album summary is not included in a `summary` tag now, but in two separate `integrated` and `sample-peak` tags
* Handle `lu` attribute
* Get bs1770gain version
* If v0.6.0 or later, add `--unit=ebu` flag to convert `db` attributes to LUFS
* May be useful later on
### Output examples
Track:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
<track total="1" number="1" file="02 tïtle 0.mp3">
<integrated lufs="-70.00" lu="52.00"/>
<sample-peak spfs="-72.28" amplitude="0.00"/>
</track>
<integrated lufs="-70.00" lu="52.00"/>
<sample-peak spfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```
Album:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
<track total="2" number="1" file="02 tïtle 0.mp3">
<integrated dbfs="-70.00" db="52.00"/>
<sample-peak dbfs="-72.28" amplitude="0.00"/>
</track>
<track total="2" number="2" file="02 tïtle 1.mp3">
<integrated dbfs="-70.00" db="52.00"/>
<sample-peak dbfs="-72.28" amplitude="0.00"/>
</track>
<integrated dbfs="-70.00" db="52.00"/>
<sample-peak dbfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```
2020-01-30 16:13:29 +01:00
BrainDamage
f118314682
support for keyfinder-cli, which doesn't want the -f flag for paths
2020-01-14 05:07:33 +01:00
Adrian Sampson
a08f2315ea
Simplify Confuse usage ( #3463 )
2019-12-26 20:44:14 -05:00
Mat
2593a5be34
Use a local var to use high resolution option
2019-12-26 21:55:48 +00:00
Mat
3570f5cd56
New high_resolution config option in fetchart
2019-12-26 17:36:56 +00:00
Cole Miller
e945ed894d
Add trailing comma
...
Co-Authored-By: Adrian Sampson <adrian@radbox.org>
2019-12-18 14:31:59 -05:00
Cole Miller
6c948764fe
Wrap comment lines
2019-12-17 17:56:56 -05:00
Cole Miller
614289af5f
Remove use of `list.clear()' for compatibility
2019-12-17 17:46:43 -05:00
Cole Miller
3ccafa2495
Fix `str.join' usage
2019-12-17 17:40:16 -05:00
Cole Miller
8805ba28fd
Add comments
2019-12-17 16:33:41 -05:00
Cole Miller
02e03be93d
Incorporate divisions into track titles
2019-12-17 15:38:54 -05:00
Cole Miller
e31695b606
Trace hierarchy of index tracks
2019-12-17 15:27:26 -05:00
Cole Miller
6889b9ffdc
Add `index_tracks' configuration option
2019-12-17 13:43:53 -05:00
Tyler Faulk
a1af5d280e
added merge_environment_settings call in fetchart plugin to handle connections with proxy servers
2019-12-10 22:54:31 -05:00
Adrian Sampson
9739e9be9b
Docs tweaks for #3449
2019-12-09 15:55:31 -05:00
Jef LeCompte
89f21d9601
Updated documentation
2019-12-09 07:13:25 -05:00
Jef LeCompte
5a38e1b35c
Refactored token generation and updated comments based on suggestions.
...
Also updated documentation to note the password options.
2019-12-06 18:30:52 -05:00
Jef LeCompte
1690c08e77
Added URL to config and deprecated old configuration
2019-12-06 15:05:36 -05:00
Xavier Hocquet
c8e8e587f8
Add debug logger for Genius lyrics no-match
2019-12-05 20:06:49 -07:00
Xavier Hocquet
d43cf35ad2
Strip and lowercase Genius lyrics artist comparison
2019-12-05 20:06:46 -07:00
Aidan Epstein
9c479659b2
Increment playlist_version when a track is consumed.
...
This fixes the playlist not updating when in consume mode, at least in
ncmpcpp.
2019-11-24 19:27:09 -08:00
msil
1f665b0290
adding discogs_labelid and discogs_artistid fields
2019-10-24 10:13:37 +00:00
Adrian Sampson
a7671e16a6
Merge pull request #3409 from jackwilsdon/hook-check-call
...
hook: switch to using check_call
2019-10-17 11:12:06 -04:00
Jack Wilsdon
430eab2cf0
Switch to using check_call for hooks
2019-10-17 11:00:59 +01:00
Austin Marino
c1b646ff27
Merge branch 'master' into Extended_Export_Plugin_Support
2019-10-15 15:35:42 -07:00
Austin Marino
7f6630c006
removed xml configs from doc and code
2019-10-15 14:16:23 -07:00