Commit graph

3221 commits

Author SHA1 Message Date
yoasif
b843071100 Fixed "hacking" link to point to Developers section 2014-03-19 23:01:15 -04:00
brilnius
e1878b34e7 Merge pull request #618 from brilnius/fix615
lastgenre plugin: separator in genre lists can now be configured
2014-03-19 22:22:41 +01:00
Bruno Tournay
81b74151ca Genre separator from config must be unicode string 2014-03-19 22:16:02 +01:00
Bruno Tournay
3348c0e3c2 Typo correction 2014-03-19 22:12:56 +01:00
Adrian Sampson
b0fd64662d update docs for #619 2014-03-19 10:34:03 -07:00
Thomas Scholtes
51647e6514 Changelog for 0daea144e8 2014-03-19 17:30:15 +01:00
Thomas Scholtes
0daea144e8 Fix album import feed with slashes
Makes tests from f2da1922b28571216c7bc0eaa71f56a316dc0d5d pass.
Fixes #610 and supersedes #611.
2014-03-19 17:26:11 +01:00
Thomas Scholtes
b131922b90 Add failing importfeed tests for albums with slashes
Isolates bug in #610
2014-03-19 17:26:11 +01:00
Adrian Sampson
5b42796eea Merge pull request #619 from brilnius/fix324
Replace option: leading whitespaces are also removed by default
2014-03-18 23:22:45 -07:00
Bruno Tournay
41e7611ead Replace option: leading whitespaces are also removed by default 2014-03-18 22:25:06 +01:00
Bruno Tournay
26abd603c8 Changelog for previous change (lastgenre separator) 2014-03-18 22:12:16 +01:00
Bruno Tournay
618708916b Separator in genre lists can now be configured 2014-03-18 22:03:11 +01:00
Kristoffer Grönlund
5a095a8719 Log release ID for invalid MBIDs 2014-03-18 09:58:25 +01:00
Andrew Sutherland
e290f8dfad Use _safe_cast to avoid dying on illegal dates. 2014-03-18 01:38:04 -04:00
Adrian Sampson
03fa8d809b tests: properly install & restore some fixtures
Brought up while investigating #612.
2014-03-15 12:30:06 -07:00
Adrian Sampson
5eb7b4204b Merge pull request #612 from AgathaTheWitch/test_failures
Updated test_importer for Various Artists
2014-03-15 12:22:51 -07:00
Agatha
7f19194403 Updated test_importer for Various Artists
All py.test tests should pass now
2014-03-15 14:23:27 -04:00
Adrian Sampson
cc1780f328 changelog for #586 2014-03-14 09:50:41 -07:00
Pedro Silva
e8f6781fa0 fix #568: ignore items with all keys null 2014-03-14 12:04:43 +01:00
Thomas Scholtes
e2718d792e Prevent plugin classes from being loaded twice 2014-03-12 14:17:16 +01:00
Thomas Scholtes
2dc0e4998d Determine StorageStyle from mutagen class
Further decouples MediaFile from MediaFiled and StorageStyle. The latter know
only has knowledge of mutagen.
2014-03-12 13:59:39 +01:00
Thomas Scholtes
41045ec33d Remove tests for editing list of tags by reference
See discussion in #605

Commit 3000: Wooho
2014-03-12 13:35:49 +01:00
Adrian Sampson
c64e9ed789 MediaFile: remove out_type from StorageStyle
This eliminates a little bit of state redundancy in which StorageStyles needed
to know about their field's externally visible type. Now the MediaField itself
is *solely* responsible for external-type-related conversions; StorageStyles
need only worry about their *internal* types.

(I hope I didn't mess up any essential design decisions, @geigerzaehler.)
2014-03-11 22:09:22 -07:00
Thomas Scholtes
d091c7e5b4 Remove unused plugin configure method 2014-03-11 22:29:44 +01:00
Thomas Scholtes
4205d1a7b9 Plugins can change task.choice_flag in import_task_choice handler 2014-03-11 19:18:19 +01:00
Thomas Scholtes
559a3eb0a0 Revert exception handling in importer
This reverts commit 6bd6618c14.

I will think of a better way to handle this and open a PR.
2014-03-11 16:29:29 +01:00
Thomas Scholtes
d95d4428fe Add more documentation to MediaFile 2014-03-11 16:28:47 +01:00
Adrian Sampson
b70b133f6e fill in some code documentation in MediaFile 2014-03-10 22:05:57 -07:00
Thomas Scholtes
4c41a02c72 Changelog for 002d3600 2014-03-11 00:11:03 +01:00
Thomas Scholtes
0012ba5bd9 Prevent tests from cluttering the working directory 2014-03-11 00:03:20 +01:00
Thomas Scholtes
002d360039 Show only changed and writable values with the write command 2014-03-10 23:57:19 +01:00
Thomas Scholtes
6bd6618c14 Catch all exceptions when writing files during import
Import should not abort when an exception (other then IOError) was raised. This
is particularly useful for plugins that want to prevent beets from writing
files [1].

`except` code was copied from `ui.commands.write_items`.

[1]: https://github.com/geigerzaehler/beets-check/blob/master/beetsplug/check.py#L74
2014-03-10 23:47:25 +01:00
Thomas Scholtes
371f297af2 Add 'responses' to test requirements
Requirement was introduced in 3367dad0a4
2014-03-10 23:37:42 +01:00
brilnius
b8ef621941 Merge pull request #599 from brilnius/spl_auto
Ability to disable auto regeneration of smartplaylist
2014-03-10 22:46:55 +01:00
Bruno Tournay
0d2f18efb5 Added mention that smartplaylist auto-regeneration can be disabled 2014-03-10 22:45:27 +01:00
Bruno Tournay
865ea40eab Simplified config access 2014-03-10 22:44:38 +01:00
geigerzaehler
4a5a203907 Merge pull request #600 from geigerzaehler/after-write-hook
Add after_write plugin event
2014-03-10 17:31:12 +01:00
Thomas Scholtes
ff9e4f4dcb Add after_write plugin event 2014-03-10 16:34:12 +01:00
Johannes
856a28a8a0 Revert "no module-global session (#597)"
This reverts commit c56412a1d5.

 - The Requests library advertises itself as thread safe.
 - Cookies aren't so interesting, but keep-alive /
   connection pooling would be nice to have.
2014-03-10 08:53:12 +00:00
Bruno Tournay
33632e0caf We can now disable auto regeneration of smartplaylist 2014-03-09 22:57:07 +01:00
Adrian Sampson
fb038ecc30 changelog & style tweaks for album_query (#595) 2014-03-09 13:22:34 -07:00
Adrian Sampson
aa01906761 Merge pull request #595 from brilnius/spl_album_query
smartplaylist album_query parameter
2014-03-09 13:17:49 -07:00
Bruno Tournay
8a73a173df Attempt to factorize duplicate code 2014-03-09 20:15:51 +01:00
Adrian Sampson
c56412a1d5 no module-global session (#597)
This might have been perfectly correct, but I read that requests.Session
objects share cookies between requests. That makes me nervous for two reasons:
- thread safety (does requests lock the cookie jar internally? who knows?!?)
- leaking cookies could have privacy/performance implications; we don't need
  'em anyway
2014-03-09 11:54:31 -07:00
Adrian Sampson
01a713df91 changelog and docs for #597 2014-03-09 11:49:50 -07:00
Adrian Sampson
7ddb8676c4 Merge pull request #597 from johtso/fetchart-requests-plus-useragent
Switch fetchart to requests and send user-agent
2014-03-09 11:43:51 -07:00
Thomas Scholtes
4abc849a51 Genre list support for WMA 2014-03-09 14:27:49 +01:00
Thomas Scholtes
610e4f14eb Merge branch 'image-tags'
Conflicts:
	beets/mediafile.py
2014-03-09 14:13:12 +01:00
Thomas Scholtes
0335059293 Add tiff image fixture 2014-03-09 14:09:31 +01:00
Thomas Scholtes
ee40050d4b Remove unused methods 2014-03-09 14:08:43 +01:00