Commit graph

1692 commits

Author SHA1 Message Date
reiv
1625dfc17e Merge branch 'master' into 1264-unnecessary-resize 2015-11-03 02:46:33 +01:00
reiv
19dcc25a93 fetchart: Improve validation of image dimensions
This avoids images being resized unnecessarily if the dimensions
are correct.
2015-11-03 02:19:47 +01:00
Adrian Sampson
a18506f471 Fix #1686: thumbnails using unicode paths 2015-11-02 11:03:43 -08:00
reiv
db08896d8c fetchart: add docstring to helper function
_is_valid_image_candidate() now has three different return values.
These are documented here.
2015-11-02 03:04:45 +01:00
reiv
9182fd8f04 PEP8 amendments 2015-11-01 16:20:48 -08:00
reiv
3250fa80ae fetchart: Only resize when necessary
Fixes #1264: When a re-import triggers fetchart, the existing album art is no
longer resized if it already has the correct dimensions. This avoids creating
new album art files with unique filenames ("cover.n.jpg").
2015-11-01 16:20:18 -08:00
reiv
269d0e5403 fetchart: Check if album art file actually exists
Fixes #1126.
2015-11-01 16:14:51 -08:00
Adrian Sampson
c617033476 convert: Add some comments 2015-11-01 11:01:40 -08:00
Adrian Sampson
5f5a8946c3 convert: Debug log when embedding images
To help diagnose #1671.
2015-10-30 15:25:01 -04:00
Adrian Sampson
16ad174d29 A debug message for ReplayGain 2015-10-29 17:43:31 -04:00
Frederik “Freso” S. Olesen
5f5365021d lastgenre: Clean up Spanish reggae in the genre list.
* Add missing subgenres to whitelist and tree.
* Use proper terminology.
  * Add English term as child of Spanish one.

Source: https://en.wikipedia.org/wiki/Reggae_en_Espa%C3%B1ol
2015-10-29 05:00:33 +01:00
Frederik “Freso” S. Olesen
1aa808f37b lastgenre: Add raggamuffin.
Already recognised by the genres.txt whitelist, and is a more proper
term for `ragga`.

https://en.wikipedia.org/wiki/Ragga
2015-10-29 04:58:44 +01:00
Frederik “Freso” S. Olesen
1678c1d847 lastgenre: Replace top-level genre ska with reggae
… and move relevant genres from the tree to be children of the `reggae`
top-level genre as well as add `roots reggae` to the list.

See discussion at https://github.com/sampsyo/beets/issues/1661
2015-10-29 04:55:57 +01:00
Frederik “Freso” S. Olesen
b187251a7e lastgenre: Remove dance hall and polish reggae.
Neither of the two are recognised in the genres.txt whitelist.
2015-10-29 04:53:14 +01:00
Frederik “Freso” S. Olesen
004fb7d1c8 lastgenre: Fix up ragga jungle.
* Move `ragga jungle` to beneath `oldschool jungle`.
* Remove `ragga-jungle` which isn't recognised by the genre whitelist.

https://en.wikipedia.org/wiki/Ragga_jungle
2015-10-29 04:44:15 +01:00
Adrian Sampson
f784cd1a22 Fix #1656, maybe: encode Discogs token strings 2015-10-24 12:07:40 -07:00
Alex Nerten
a4ae7fa891 Update plexupdate.py
Fix #1649
2015-10-19 15:24:59 +03:00
Adrian Sampson
000487c757 Merge pull request #1639 from sadatay/genius_lyrics
Add Genius as a lyric source
2015-10-17 14:51:01 -07:00
Adrian Sampson
8c35a24073 zero: Check for conflicts only once (#1641)
The old version would trigger the warning twice.
2015-10-17 14:39:53 -07:00
Joe LaSala
3ab9932059 Add Genius as a lyric source
Makes use of the Genius API and genius-api.com, a separate resource that
provides readable lyrics.
2015-10-13 19:14:08 -05:00
Adrian Kowalski
d180d42ddb Fix flake8 complaint about line length 2015-10-12 09:50:12 +02:00
Adrian Kowalski
da655534ae Change function name and correct documentation style 2015-10-12 09:39:20 +02:00
Adrian Kowalski
158486319f Improve code quality, separate shared logic into functions 2015-10-09 21:23:59 +02:00
Adrian Kowalski
9f51e46bae Add whitelist feature to zero plugin 2015-10-09 18:41:42 +02:00
Aaron Cruz
5fd836b173 Remove yaml keys without sublists 2015-10-07 12:15:09 +02:00
Adrian Sampson
3475b91c00 Remove unused import
Oops. I was trying to use shlex.quote, but that's Python 3.3+.
2015-09-30 10:32:37 -07:00
Adrian Sampson
2607bee997 Tiny fixes for play 2015-09-30 10:11:17 -07:00
Peter Kessen
6993449602 removed deprecated checko for mtime!=None 2015-09-30 16:40:30 +02:00
Adrian Sampson
c7603fcbd5 Merge pull request #1595 from jackwilsdon/add-plex-library-config
Add `library_name` configuration property to PlexUpdate plugin (fixes #1572)
2015-09-09 19:41:34 -07:00
Adrian Sampson
225ba282cd Fix #1592 again: wrap title_gain in handler 2015-09-08 12:07:03 -07:00
Jack Wilsdon
764fcc6b4c Add library_name configuration property 2015-09-08 12:48:24 +01:00
Adrian Sampson
b41259623d Merge pull request #1577 from nathdwek/play-warn-tresh
play: make the many files warning configurable
2015-09-07 14:39:05 -07:00
Adrian Sampson
2140bb27a3 Fix #1592: unhandled exception in PyAudioTools 2015-09-07 14:15:46 -07:00
Jack Wilsdon
64e33b2d9a Remove unused import 2015-09-07 01:55:44 +01:00
Jack Wilsdon
38926caebe Reset album art to None when removed 2015-09-07 01:52:03 +01:00
Jack Wilsdon
9eb4fc530b Wrap line to ensure it is less than 80 characters 2015-09-06 21:53:34 +01:00
Jack Wilsdon
420b0724a0 Add remove_art_file configuration property 2015-09-06 21:45:15 +01:00
nath@home
ff4fda1bb5 play: make the many files warning configurable
The warning_treshold key in the play configuration defines the
minimum number of file before a warning is issued (default 100).
A zero value means no warning is ever issued.

This is the first commit for this feature, and this should fully
implement it.
2015-09-03 22:19:51 +02:00
Adrian Sampson
854a4539cb Fix #1588: fetchart gets PNGs, not GIFs 2015-09-02 12:45:35 -07:00
nath@home
b9bc06d9d8 play-raw: Rename the command target:
passed_to_command -> open_args
2015-09-01 23:42:43 +02:00
nath@home
9c663432bd Refactor util/interactive_open: multiple targets
interactive_open should now be invoked with at least the list of
targets and optionally the command to open the targets with.
This allows beets-play to pass multiple file paths directly to
the configured command.

The changes to the existing invocations are pretty trivial in
order to comply to this refactor.
2015-09-01 23:42:42 +02:00
nath@home
4eb563a08c pep8: Correct camelCase to snake_case 2015-09-01 23:42:42 +02:00
nath@home
a23c5d4f67 play-raw: Call vlc with one file par arg 2015-09-01 23:42:42 +02:00
nath@home
18d5c3b0a0 play-raw: Add the option to play the raw queried pathes
I slightly rewrote the play plugin in order to improve
the readability and to introduce the "raw" play config
option which makes beet simply pass a list of pathes
to the play command rather than a playlist.
2015-09-01 23:42:42 +02:00
Adrian Sampson
e32744a66a Fix extra parameter introduced for #1581 2015-08-30 11:55:06 -07:00
Adrian Sampson
9ce49b7ef0 fetchart: Do not emable Wikipedia by default
Because DBpedia seems to be down (it's responding very slowly with errors),
this seems like a good defensive action. It narrows the default sources to
those that resolve quickly, with only a couple of HTTP requests. We can
re-enable this again in the future if things seem to stabilize over at
DBpedia.
2015-08-29 12:52:57 -07:00
Adrian Sampson
e249fcb06f fetchart: Fix #1581, splitting in Wikipedia source 2015-08-29 12:45:10 -07:00
Adrian Sampson
b5cb4e4cc4 Slightly more efficient image streaming 2015-08-29 12:41:54 -07:00
Adrian Sampson
3d20f25f06 fetchart: Fix bungled Requests API 2015-08-29 12:27:37 -07:00
Adrian Sampson
75e810409b fetchart: Use a mixin for even more logging 2015-08-29 12:13:28 -07:00