Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-20 23:53:15 +01:00
Code Issues Projects Releases Wiki Activity
9849 commits 43 branches 64 tags 67 MiB
Commit graph

9849 commits

This branch
This branch
All branches
Author SHA1 Message Date
Daniel Barber
a30c90e615 Fix one of the failing tests 2020-02-17 22:22:47 -05:00
Daniel Barber
86946ad4b7 Allow the quality to be set for embedded/fetched cover art 2020-02-17 21:12:20 -05:00
Adrian Sampson
de6173a6f4
Merge pull request #3492 from aereaux/parentwork_only_store_if_changed 
parentwork: Only call store when the metadata has changed.
 2020-02-17 10:24:20 -08:00
Aidan Epstein
535af4bdb2 parentwork: Only call store when the metadata has changed. 
Otherwise, this rewrites all your files every time.
 2020-02-17 09:05:52 -08:00
Adrian Sampson
ddfb715e32 Style fixes for #3491 2020-02-17 06:49:26 -08:00
Adrian Sampson
3b5641246d Merge pull request #3491 from adamjakab/docs-dev 
Added beets-bpmanalyser to the list of 'other plugins'
 2020-02-17 06:48:58 -08:00
Adam Jakab
9426ad7345 Added beets-bpmanalyser to the list of 'other plugins' 2020-02-17 09:40:30 +01:00
Adrian Sampson
d43d54e21c Try to work around a Werkzeug change? 2020-02-06 22:22:54 -05:00
Adrian Sampson
91be732bf4 Fix whitespace (#3453) 2020-02-06 22:18:15 -05:00
Adrian Sampson
f9088a3eb7
Merge pull request #3453 from faulkt/master 
added merge_environment_settings call
 2020-02-06 21:54:14 -05:00
Tyler Faulk
964a6c2e63 restored whitespace to please style checker 2020-02-06 12:10:38 -05:00
Adrian Sampson
817bef25ea
Merge pull request #3480 from ybnd/bs1770gain-v0.6.0-parsing 
Update Bs1770gainBackend to handle bs1770gain v0.6.0 XML output
 2020-02-05 16:52:32 -05:00
ybnd
9b283be7bf Add to changelog 2020-02-05 10:22:02 +01:00
ybnd
63ea17365a Modify patched stdout in test_malformed_output 2020-02-05 09:04:24 +01:00
ybnd
7005691410 Add comment to clarify unexpected AttributeError handling 2020-02-05 08:52:50 +01:00
ybnd
1ab46c69be Merge remote-tracking branch 'origin/master' into bs1770gain-v0.6.0-parsing 
# Conflicts:
#	docs/changelog.rst
 2020-02-05 08:45:30 +01:00
ybnd
9465e933ba Add to changelog 2020-02-05 08:36:44 +01:00
ybnd
9bd78424c1 Handle keyboard interrupts more cleanly 2020-02-04 19:16:33 +01:00
Adrian Sampson
95e0f54d7c Fix too-long lines (#3448) 2020-02-02 21:04:55 -05:00
Adrian Sampson
d4d04c61aa
Merge pull request #3448 from xhocquet/genius-lowercase-artist-fix 
Genius lyrics fix for API capitalization behaviors
 2020-02-02 20:46:24 -05:00
Xavier Hocquet
9f43408f1b Changelog and cleanup 2020-02-02 15:57:43 -07:00
ybnd
4970585b0a Remove temporary workaround for silent exceptions 2020-01-31 14:08:28 +01:00
ybnd
4a427182cd Handle exceptions in pooled threads 
* ExceptionWatcher instance running in parallel to the pool, monitoring a queue for exceptions
* Pooled threads push exceptions to this queue, log non-fatal exceptions
* Application exits on fatal exception in pooled thread

* More front end info logs in the CLI
 2020-01-31 13:50:38 +01:00
ybnd
bef473c8e8 Remove spliced progress regex and add --suppress-progress flag 2020-01-31 07:42:50 +01:00
ybnd
b39df01d35 Add to documentation 2020-01-30 20:31:12 +01:00
ybnd
506be02597 Remove packaging dependency 2020-01-30 20:11:09 +01:00
ybnd
f51a68c7e1 Implement comments 2020-01-30 19:53:05 +01:00
ybnd
c3817a4c06 Implement review comments 
* safer version comparison

* regex bytes directly

* handle b'\x08 ...' case

* test_replaygain.py: injected command output should match the type of the actual output
 2020-01-30 19:21:53 +01:00
ybnd
65ffca215a Exception handling in main & worker threads 
* With `bs1770gain` installed the `Bs1770gainBackend` tests fail, but this should be fixed by https://github.com/beetbox/beets/pull/3480.
 2020-01-30 18:04:20 +01:00
ybnd
c1cb78c908 Small fixes in replaygain.Bs1770gainBackend and test_replaygain.py 
* Fix unspecified `gain_adjustment` when method defined in config

* Fix difference between dB and LUFS values in case of mismatched `target_level`/`method`:

  ```
  db_to_lufs( target_level <dB> ) - lufs_to_dB( -23 <LUFS> )
  ```

* Ignore single assertion in case of bs1770gain

(cherry picked from commit 2395bf224032c44f1ea5d28e0c63af96a92b96df)
 2020-01-30 17:59:57 +01:00
ybnd
c78afb1a97 Don't call bs1770gain outside of try statement 2020-01-30 17:02:28 +01:00
ybnd
53820c0a98 Handle bs1770gain v0.6.0 XML output 
* Remove `0%\x08\x08` from output (backspace code doesn't resolve; progress percentages get spliced in)

* Handle changed attributes/fields:
  * `sample-peak` attribute `factor` is called `amplitude` instead
  * Album summary is not included in a `summary` tag now, but in two separate `integrated` and `sample-peak` tags

* Handle `lu` attribute

* Get bs1770gain version
  * If v0.6.0 or later, add `--unit=ebu` flag to convert `db` attributes to LUFS
  * May be useful later on

### Output examples

Track:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
  <track total="1" number="1" file="02 tïtle 0.mp3">
    <integrated lufs="-70.00" lu="52.00"/>
    <sample-peak spfs="-72.28" amplitude="0.00"/>
  </track>
  <integrated lufs="-70.00" lu="52.00"/>
  <sample-peak spfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```

Album:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
  <track total="2" number="1" file="02 tïtle 0.mp3">
    <integrated dbfs="-70.00" db="52.00"/>
    <sample-peak dbfs="-72.28" amplitude="0.00"/>
  </track>
  <track total="2" number="2" file="02 tïtle 1.mp3">
    <integrated dbfs="-70.00" db="52.00"/>
    <sample-peak dbfs="-72.28" amplitude="0.00"/>
  </track>
  <integrated dbfs="-70.00" db="52.00"/>
  <sample-peak dbfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```
 2020-01-30 16:13:29 +01:00
ybnd
b903584163 Fix --threads argument handling 2020-01-30 13:31:14 +01:00
ybnd
b126ecafdd Clean up single/multithreaded execution selection logic 
As suggested in https://github.com/beetbox/beets/pull/3478#discussion_r372467445
 2020-01-30 12:38:20 +01:00
ybnd
0fede91bbd Workaround to pass ReplayGainLdnsCliMalformedTest.test_malformed_output ~ Python 3.8 2020-01-30 12:07:42 +01:00
ybnd
79c5535cf6 Open/close pool at begin/end of import session 2020-01-30 09:35:22 +01:00
ybnd
388d2d2c0d Consolidate ThreadPool checking, opening and closing into methods 2020-01-30 09:35:22 +01:00
ybnd
42e895c239 Match --jobs default & signature to that of convert plugin (--threads) 
And change local function `func` to `ReplayGainPlugin` method `replaygain_func` so that `self` is passed explicitly
 2020-01-30 09:35:22 +01:00
Adrian Sampson
c1937e1b01
Merge pull request #3477 from ybnd/master 
Remove --replaygain flag when checking bs1770gain availability
 2020-01-29 09:45:55 -06:00
ybnd
d95bb5683b Analyze replaygain in parallel with multiprocessing.pool.ThreadPool 
* Add `--jobs` or `-j` to `replaygain`-> set the pool size
* Single-threaded execution by default, if `--jobs` is unset

* If multithreaded, calls `Backend.compute_album_gain` or `Backend.compute_track_gain` asynchronously with metadata storing/writing in the callback
 2020-01-28 21:20:21 +01:00
ybnd
a4a0a4bd28 Remove --replaygain flag when checking bs1770gain availability 
bs1770gain exits with error 1 when called without data, interpreted as unavailable
 2020-01-28 09:45:20 +01:00
Adrian Sampson
ca3142b1d9
Merge pull request #3467 from BrainDamage/keyfinder-cli 
support for keyfinder-cli, which doesn't want the -f flag for paths
 2020-01-14 08:24:54 -05:00
BrainDamage
f118314682 support for keyfinder-cli, which doesn't want the -f flag for paths 2020-01-14 05:07:33 +01:00
MrNuggelz
6d69d01016 added database changed event to subsonicplaylist 2020-01-13 15:43:20 +01:00
Adrian Sampson
a08f2315ea Simplify Confuse usage (#3463) 2019-12-26 20:44:14 -05:00
Adrian Sampson
f0eede2ab4 Merge pull request #3463 from mathieupinet/fetchart_highresolution 
fetchart: New high_resolution config option (#3391)
 2019-12-26 20:43:51 -05:00
Mat
2593a5be34 Use a local var to use high resolution option 2019-12-26 21:55:48 +00:00
Mat
7ad3f7f728
Apply suggestions from code review 
Fix wording in docs

Co-Authored-By: Adrian Sampson <adrian@radbox.org>
 2019-12-26 21:09:26 +00:00
Mat
3570f5cd56 New high_resolution config option in fetchart 2019-12-26 17:36:56 +00:00
Adrian Sampson
a9b19e1678
Merge pull request #3459 from cole-miller/index-tracks 
discogs: Add `index_tracks` option (closes #3458)
 2019-12-18 15:59:35 -05:00