Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-31 21:12:43 +01:00
Code Issues Projects Releases Wiki Activity
5011 commits 42 branches 64 tags 76 MiB
Commit graph

1540 commits

Author SHA1 Message Date
Amish Bhadeshia
6365a9b538 Added indice into curly brackets, for py26 compatabiity 2015-03-27 20:54:42 +00:00
Amish Bhadeshia
232ff05766 Added tests and simplified implementation method 2015-03-27 17:59:35 +00:00
Bruno Cauet
e707342bf9 Add call to g_type_init() for glib < 2.36 2015-03-27 16:33:51 +01:00
Bruno Cauet
2e5803cfad Thumbnails: unicode → bytes filename 2015-03-27 14:00:22 +01:00
Bruno Cauet
f41ec9bbf6 ctpyes: set argtypes & restype 2015-03-27 14:00:13 +01:00
Pedro Silva
9999460cb4 hash attribute values as tuples instead of stringifying on SOH char 2015-03-27 11:48:51 +01:00
Pedro Silva
fb0e03dd6b remove redundant plugin name from logging 2015-03-27 11:47:40 +01:00
Pedro Silva
66e06baca7 fix #1000: provide --strict option (don't match on null attributes) 2015-03-27 11:34:45 +01:00
Mara Kim
ddca1b2e13 Add 'tmpdir' option to convert plugin 
Closes sampsyo/beets#1382

Add tmpdir setting

document tmpdir setting
 2015-03-27 02:11:33 -05:00
Bruno Cauet
07ee934352 Thumbnails: improve log readability 2015-03-25 20:14:23 +01:00
Bruno Cauet
4b349771ff thumbnails plugin setup: log tools chosen 2015-03-25 20:14:19 +01:00
Bruno Cauet
11a4777219 URI: use gio/gio.h's g_file_get_uri if available 2015-03-25 20:14:16 +01:00
Bruno Cauet
265fa962eb Merge branch 'master' into thumbnails 2015-03-25 18:17:12 +01:00
Tom Jaspers
944d38064d Config: implement redacted fields more idiomatic 
- `add_redacted_fields(self, *field_names)` to use argument unpacking
- foo =| bar instead of foo = foo | bar
 2015-03-25 14:55:29 +01:00
Bruno Cauet
8f5bae26fd Smartplaylists: improve tests & code modularization 2015-03-25 10:44:33 +01:00
Tom Jaspers
f4ed3e16b1 Config: Add redacted fields from included plugins 2015-03-24 17:01:33 +01:00
Amish Bhadeshia
d2a95158f2 Updated ftintitle plugin to follow a format 2015-03-21 15:36:39 +00:00
Adrian Sampson
a70f8bb91f Fix #1365: lastimport config 2015-03-20 19:52:36 -04:00
Bruno Cauet
bcd57bd2b5 Test queries building sort management in smartplaylist 
Slighly modify Sort parsing: avoid building MultiplSort() instances
comptised of a single sort, but return that sort instead, since it wraps
things with any gain.
 2015-03-18 18:53:41 +01:00
Bruno Cauet
45c0c9b3cb Deal with sorting 
Try to follow any sort found & manage absence of sort. When there are
multiple sort directives given, concatenate them.

Tests not extended yet.
 2015-03-18 18:09:42 +01:00
Bruno Cauet
65b52b9c48 python 2.6 compat: don't use set literals 
In smartplaylist and test_smartplaylist.
 2015-03-16 19:42:54 +01:00
Bruno Cauet
b79c025142 CLI tests for smartplaylist plugin 
No import CLI test.
 2015-03-16 18:36:08 +01:00
Bruno Cauet
40e793cdb1 Fix flake8 errors 2015-03-16 16:25:43 +01:00
Bruno Cauet
774decda7d Smartplayist: parse_query_parts() → ...ry_string() 2015-03-16 16:21:49 +01:00
Bruno Cauet
2d9f665848 Smartplaylist: offer "splupdate <playlist names>" 
splupdate command of the SmartPlaylistPlugin looks in "args" for matches
of playlist names.
 2015-03-16 16:03:14 +01:00
Bruno Cauet
f06c33cb71 Smartplaylist: update only if item changed 2015-03-16 15:16:40 +01:00
Bruno Cauet
4bfa439ee1 database_change: send model that changed 2015-03-16 14:32:37 +01:00
Adrian Sampson
f6df14a798 Isolate bugs in pylast 
Should fix crashes like this:
http://hastebin.com/nizusukuli.log
 2015-03-14 15:13:07 -07:00
Adrian Sampson
736eab412c Bytes arguments to bs1770gain command 2015-03-14 14:43:00 -07:00
Tom Jaspers
96a565a614 info: error msg instead of traceback on IOError 
IOErrors were previously not caught, displaying full traceback to the user
 2015-03-13 17:55:09 +01:00
David Logie
ee6fba1e82 Fix call to add_format_option() missing plugin. 2015-03-08 12:59:00 +00:00
Bruno
f6c6c35614 Merge pull request #1346 from brunal/subcommand-auto-format-path 
Generalize --path, --format and --album options
 2015-03-07 14:05:05 +01:00
Bruno Cauet
1722c26ffe Fix DiscogsPlugin.setup() arguments 
Session is optional. This fixes re-authorization.

Improve #1347.
 2015-03-07 14:00:47 +01:00
Adrian Sampson
bcc591bf97 Generalize exception handler for #1347 2015-03-06 12:01:09 -08:00
Bruno Cauet
d1f6bbaf01 Discogs plugin: catch client lib ValueErrors 
When search fails, log the query which caused it and return an empty
result.

Kind of fixes #1347.
 2015-03-06 11:16:20 +01:00
Bruno Cauet
58b39f1000 Merge branch 'master' into subcommand-auto-format-path 2015-03-05 17:53:31 +01:00
Bruno Cauet
7798a521b5 Fix convert plugin 2015-03-05 17:40:32 +01:00
Bruno Cauet
ea1dc1eb19 Plugins conversion cont. 2015-03-05 17:40:32 +01:00
Bruno Cauet
650305c9a1 All suitable plugins use CommonOptionsParser features 2015-03-05 17:03:02 +01:00
Bruno Cauet
6234fee67d Option parser: add common options with a method 
Add a new OptionParser subclass: CommonOptionsOptionParser, which
provides facilities for adding --album, --path and --format options. The
last one is quite versatile.

Update base commands (from beets.ui.commands) to use those.
 2015-03-05 15:01:20 +01:00
Bruno Cauet
9750351a1b beets.util.command_output() & related receives bytes 
- May fail with unicode, esp. will non-ascii system path entry.
- Only send it bytes.
- Also applies to subprocess.Popen() & co.
 2015-03-04 15:15:46 +01:00
Adrian Sampson
8113c7ba85 Roll back whitespace changes from #1343 2015-03-03 10:41:30 -08:00
jmwatte
5d7d402adb correct typing error 2015-03-03 13:11:25 +01:00
jean-marie winters
a3e32fd410 added fatalreplaygainerror 2015-03-03 11:23:45 +01:00
jean-marie winters
80c49ab360 removed line 288 2015-03-03 11:04:03 +01:00
jean-marie winters
0d49c830d8 just an updateMerge remote-tracking branch 'upstream/master' 2015-03-03 10:49:35 +01:00
jean-marie winters
5bc8ef7009 fix some formating 2015-03-02 22:11:33 +01:00
Adrian Sampson
8bd0633496 replaygain: Fix super call in AudioTools 
Fix #1342.
 2015-03-02 11:30:14 -08:00
jean-marie winters
1416846283 Merge branch 'bs1770gainsupport' 
Conflicts:
	beetsplug/replaygain.py
 2015-03-02 16:34:46 +01:00
jean-marie winters
72c5db8876 add doc, clean-up code 2015-03-02 15:38:33 +01:00
jean-marie winters
1385ce11ca Added support for bs1770gain, a loudness-scanner 2015-02-28 15:35:48 +01:00
Bruno Cauet
65a88e2bf4 Fix StrubPlugin.write_item() expected arguments 
Fix #1338.
 2015-02-24 19:30:51 +01:00
mried
c91e8cb782 Sometimes the extract art test failed because the file type of the extracted image might be PNG or JPG. Belongs to #1328. 2015-02-19 19:43:07 +01:00
Adrian Sampson
ccd8a7e1d4 Merge pull request #1328 from mried/extractart-unicode 
Fix a crash when extracting album art
 2015-02-18 10:33:33 -08:00
mried
53cefa328e Changed the path format from unicode to bytes. 2015-02-18 19:06:58 +01:00
Bruno Cauet
457afdc55d Auto re-auth for discogs plugin upon error 401 
This goes in the direction of #1299 and #1305.
 2015-02-18 15:11:52 +01:00
Adrian Sampson
ca0e9a8c03 Merge pull request #1329 from brunal/play-interactive 
play command is now interactive

Conflicts:
	docs/changelog.rst
 2015-02-17 17:22:03 -05:00
Adrian Sampson
171ded17b6 Merge pull request #1320 from brunal/multiple-logging-levels 
Multiple logging levels
 2015-02-17 17:10:31 -05:00
Adrian Sampson
31500a741e Merge pull request #1318 from jaquer/no-apply-replaygain 
Stop applying mp3gain directly to files. Fixes #1316
 2015-02-17 17:03:57 -05:00
Marvin Steadfast
b9174d176f The permissions plugin now uses startswith for finding ancestors in the library path. 2015-02-17 11:45:21 +01:00
Marvin Steadfast
dd0de2f04b Made the permissions plugin simpler. Got rid of some non-needed code and use the ancestors function instead of writing something new. 2015-02-17 11:41:15 +01:00
Marvin Steadfast
8b08ec568c permissions plugin now uses a set instead of a OrderedDict to find duplicates in a list 2015-02-17 11:41:15 +01:00
Marvin Steadfast
21aedeb51a Updated permissions plugin to change directory permissions too. 2015-02-17 11:41:15 +01:00
Tom Jaspers
12ecb2ce35 Fix formatting to new PEP8 version (1.6.2) 
PEP8 1.6.2 (2015-02-15):
- added check for breaking around a binary operator

This caused Travis to fail on "W503 line break before binary operator"
 2015-02-16 18:21:56 +01:00
Bruno Cauet
39a6145d2d Plugin play uses default item sort in album mode 
Offer library.get_default_{item,album}_sort for that purpose.
 2015-02-16 12:26:23 +01:00
Bruno Cauet
c47221555f Add beets.util.interactive_open() find cmd + execute 
interactive_open() takes a target and an optional command, if it does not
receive a command then it uses open_anything().

It parses command and lexes it with shlex.split(), revieling the client
from that task.

"config -e" command uses it, and gives a better error message in case of
problem. "play" plugin uses it as well, as side-effect being that the
command is now interactive, as requested in issue #1321.

Fix issue #1321.
 2015-02-16 12:26:17 +01:00
Bruno Cauet
5d9128aff3 util.interactive_open() return open/xdg-open/start 
Depending on the platform return the correct automatic execution
command.
 2015-02-16 11:35:13 +01:00
Bruno Cauet
1d8160f9ff Play plugin: use OO, don't pass log around 2015-02-16 10:50:41 +01:00
Malte Ried
eafdd9e379 Extraction of cover art of albums with non ascii characters lead to a crash. 2015-02-15 19:39:39 +01:00
Bruno Cauet
13e47472ac Play plugin: byte newlines in files written 
Avoid unicode errors when writing '\n' around file paths.
 2015-02-15 15:49:46 +01:00
Bruno Cauet
d267741ff3 Delete 'format' variables that shadow the built-in 
Also cleanup the 'the' plugin a bit: delete unused variables.

Relates to #1300.
 2015-02-11 16:26:16 +01:00
Bruno Cauet
5a1f499c64 Discogs plugin: fix event listener params 
Also delete related deprecated comment.
 2015-02-11 09:11:20 +01:00
Bruno Cauet
327b62b610 Improve logging management for plugins: fixes 
Delete the remaining usages of BeetsPlugin.listen().

Since BeetsPlugin.listeners are wrapped by a loglevel-setting function,
we cannot easily check their unicity anymore.
BeetsPlugin._raw_listeners set holds the raw listeners.

Legacy plugins that did not handle enough arguments in their listenings
functions may break: dedicated code is now deleted for it would not work
with the decorated listeners.

Tests got fixed. Some modifications were done empirically: if it passes
then it's okay.
 2015-02-10 16:55:06 +01:00
Arturo R
60b1819db0 Stop applying mp3gain directly to files. Fixes #1316 
Update docs to remove non-existent `apply` option.
 2015-02-09 12:51:27 -08:00
Bruno Cauet
c6455c269f Merge branch 'master' into thumbnails 
Conflicts:
	docs/changelog.rst
 2015-02-09 16:08:29 +01:00
Tom Jaspers
6572e1bf5a Fetchart: add empty album check to iTunes art 
Was causing some tests to fail in test_art.py:CombinedTest
 2015-02-09 14:59:56 +01:00
Adrian Sampson
66b7e4cd39 Merge branch 'master' of github.com:sampsyo/beets 2015-02-07 12:52:20 -08:00
Adrian Sampson
e7f8a627e9 Style fixes for pep8 1.6 2015-02-07 12:51:54 -08:00
David Logie
9b9c033df6 importfeeds: Fix Unicode error when writing files. 2015-02-07 15:13:01 +00:00
Adrian Sampson
0247785440 discogs: Catch JSON decode errors 
Fix #1305 *again*.
 2015-02-03 23:42:47 -08:00
Adrian Sampson
cc01d87209 discogs: Catch *another* exception (fix #1305) 
Everything but requests is a travesty.
 2015-02-03 23:04:14 -08:00
Adrian Sampson
a7878b0eba A couple of explanatory comments for #1292 2015-02-03 09:50:36 -08:00
Adrian Sampson
82e89b8960 Merge pull request #1292 from mried/import-autosingleton 
Allow plugins to change the created import tasks
 2015-02-03 09:49:13 -08:00
Tom Jaspers
50dbd18493 Duplicates: fix error caused by formatting 
Function arguement `format` was shadowing the built-in format function

Fix #1300
 2015-02-03 13:31:54 +01:00
Adrian Sampson
77833f6c05 Oops 😳 #1299 2015-02-02 22:34:22 -08:00
Adrian Sampson
8151a40f1f discogs: Catch socket errors (#1299) 
See also:

https://github.com/discogs/discogs_client/issues/44
 2015-02-02 22:27:14 -08:00
Adrian Sampson
313c3807aa scrub: Use syspath in beet scrub (#1297) 2015-02-02 10:42:31 -08:00
Adrian Sampson
465719a208 scrub: Catch IOErrors in command (fix #1297) 2015-02-02 10:13:48 -08:00
geigerzaehler
46ba99ce79 Merge pull request #1295 from sampsyo/more-info 
Info plugin can filter properties in output
 2015-02-01 21:19:24 +00:00
Thomas Scholtes
482008bf1d Info plugin can filter properties in output 
Resolves #1287
 2015-02-01 21:51:26 +01:00
Malte Ried
e681449785 Added documentation 
FileFilterPlugin uses the new return value feature
Some tweaks to get the code more readable
 2015-02-01 17:01:06 +01:00
Thomas Scholtes
51ab099145 Extend item.write() to embed images without changing item 
Fixes #1241 and geigerzaehler/beets-check#14

Before, `embed_item` would add the images to the item and then call
`item.write()` to write the item data, including the image, to the
file. This would trigger `item.store()` in the `after_write` hook of
the check plugin. This would in turn try to persist the temporary
`images` attribute of the item, resulting in an SQL error.
 2015-02-01 15:35:24 +01:00
Adrian Sampson
336bb9255c chroma: Fix refactored beet submit 
Fix #1293.
 2015-01-31 13:04:11 -08:00
Adrian Sampson
14ce6a557e Merge pull request #1183 from marcaddeo/refactor-ftintitle 
Refactor ftintitle

Conflicts:
	beetsplug/ftintitle.py
 2015-01-31 12:51:15 -08:00
Bruno Cauet
a72ae5991f Add send_art event for embedart and thumbnails 
Album.set_art() sends a 'art_sent' event, with the album as a
parameter. embedart and thumbnails listen to that event, instead of
listening to 'album imported'. Consequences:
- 'embedart' and 'thumbnails' don't have to be after 'fetchart' on the
  plugins config line.
- embedart and thumbnails work event when a "beets fetchart" command is
  issued.
- if another plugin ever set art then embedart and thumbnails will "just
  work" with it.
 2015-01-31 21:06:01 +01:00
Tom Jaspers
927a53d59b Merge pull request #1281 from tomjaspers/configurable-colors 
Colors are now user configurable.

Conflicts:
	beets/ui/__init__.py
	beets/ui/commands.py
 2015-01-30 13:48:19 +01:00
Bruno Cauet
d299f40a72 Fix PNG metadata type: string only 
instead of int
 2015-01-29 16:00:05 +01:00
Tom Jaspers
f483012183 Colorize is now to be called with the abstract color_name instead of the color. 
E.g., `colorize('text_success', 'hello world')`

To ensure compatibility with 3rd party plugins, a valid color ('red') can still be passed,
but it will be logged.
 2015-01-29 14:33:57 +01:00
Bruno Cauet
9bdeb01689 Improve thumbnails logging 
No info message printed twice per cover art (once for the normal
thumbnail and once for the big one)
 2015-01-29 13:11:14 +01:00
Bruno Cauet
a78cc65826 Merge freedesktop plugin into thumbnails 
Add test for that new code, update docs, update the changelog.
 2015-01-29 13:08:02 +01:00