Commit graph

9823 commits

Author SHA1 Message Date
soergeld
a8b81ca193 style 2020-12-22 12:19:26 +01:00
soergeld
18bfefece7 revert changes to working version with external mock 2020-12-22 11:51:24 +01:00
ybnd
cc18beb12a Reference issue 2020-12-21 19:33:23 +01:00
ybnd
93101e7ea6 Disable replaygain parallelism during import 2020-12-21 19:19:20 +01:00
Adrian Sampson
10e81a55dd
Disable Python 3.5 CI on Windows
It was broken and is not worth fixing.
2020-12-21 08:49:14 -05:00
Adrian Sampson
1c0a4708db
Merge pull request #3817 from wisp3rwind/fix-replaygain-test
replaygain: Use on-disk database
2020-12-21 08:48:45 -05:00
Adrian Sampson
206b1c1099
Merge pull request #3816 from ybnd/parallel-replaygain-fix-import-write
Fix logic for replaygain auto-compute on import
2020-12-21 08:48:03 -05:00
wisp3rwind
30baf22e77 replaygain: Use on-disk database
there can only be a single connection to an in-memory database, but the
parallel replaygain code accesses the db from different threads
2020-12-21 11:13:45 +01:00
ybnd
12db40fa67 Remove .get() when checking config values 2020-12-21 08:50:39 +01:00
ybnd
1dfd79e658 Fix logic for replaygain auto-compute on import 2020-12-20 19:38:21 +01:00
Adrian Sampson
48222153ae
Merge pull request #3812 from billyjanitsch/fix-fish-completions
Fix escape helper in fish completion plugin
2020-12-16 08:10:48 -05:00
Adrian Sampson
bfa2068ec1
Merge pull request #3811 from sentriz/master
lastgenre: Make TitleCasing optional
2020-12-16 07:54:44 -05:00
Billy Janitsch
c94809f6da Fix escape helper in fish completion plugin 2020-12-16 02:15:26 -05:00
sentriz
95677c8626
lastgenre: Make TitleCasing optional 2020-12-15 23:37:16 +00:00
Adrian Sampson
2928cef383
Merge pull request #3810 from beetbox/sam/fast-plugin-setup
Use caching in plugins.find_plugins()
2020-12-15 08:27:34 -05:00
Sam Thursfield
3fec6d347a Use caching in plugins.find_plugins()
This function is called from library.Item._getters(), making it a hot
path when exporting data. We cache plugin instances but previously we
reran `import` for each module on each call. We now return the cached
values providing a speed boost for `beet export`.

This has a small effect on `beet ls` speed: for me it went 11.00s ->
10.40.

It had a significant effect on `beet export` speed when combined with
https://github.com/beetbox/beets/pull/3762/.

Before:

    $ time /home/sam/.local/bin/beet 'export' '--library' '--format' 'jsonlines' '--include-keys' 'artist,title,path,mb_artistid,mb_trackid' 'artist+ title+' > /dev/null
    Executed in   25.13 secs

After:

    $ time /home/sam/.local/bin/beet 'export' '--library' '--format' 'jsonlines' '--include-keys' 'artist,title,path,mb_artistid,mb_trackid' 'artist+ title+' > /dev/null
    Executed in   10.49 secs
2020-12-15 14:16:09 +01:00
Adrian Sampson
8645f56512
Merge pull request #3478 from ybnd/parallel-replaygain
Implement parallel replaygain analysis
2020-12-14 17:41:11 -05:00
ybnd
e3205aacbd Merge remote-tracking branch 'origin/master' into parallel-replaygain 2020-12-14 22:19:28 +01:00
ybnd
363f71af2e Move OperationalError handler to test_replaygain.py 2020-12-14 22:10:54 +01:00
Adrian Sampson
ed18551c1c
Merge pull request #3805 from adammillerio/master
keyfinder: Catch output from keyfinder-cli with no key
2020-12-08 07:37:22 -05:00
Adam Miller
c1d93165f0 Fix line length 2020-12-07 22:11:08 -05:00
Adam Miller
e11687f80a keyfinder: Catch output from keyfinder-cli with no key 2020-12-07 22:04:05 -05:00
Adrian Sampson
9657919968
Merge pull request #3088 from rubdos/reflink
Add reflink option
2020-11-27 13:29:10 -05:00
Ruben De Smet
5efaa09482 Note installing pyreflink in docs 2020-11-26 13:45:33 +01:00
Ruben De Smet
30a2dd9998 assert False on unknown move operation 2020-11-26 13:05:10 +01:00
Adrian Sampson
297ff603df
Merge pull request #3794 from rachmadaniHaryono/feature/copyartifact-doc
change copyartifact doc
2020-11-11 18:24:34 -05:00
rachmadaniHaryono
76a5b055f4 Revert "new: doc: changelog"
This reverts commit 4acbd2a8b3.
2020-11-12 06:26:47 +08:00
rachmadaniHaryono
4acbd2a8b3 new: doc: changelog 2020-11-11 12:28:16 +08:00
rachmadaniHaryono
bb80fe5c5b fix: doc: copyartifacts fork 2020-11-11 12:16:30 +08:00
Adrian Sampson
f7e3932c17
Merge pull request #3792 from benneti/master
escape ? in fish completion
2020-11-09 21:29:31 -05:00
Benedikt Tissot
020c082f3f make CI happy 2020-11-09 17:12:44 +01:00
Benedikt Tissot
57a1b3aca8 escape using helper function 2020-11-09 17:07:00 +01:00
Benedikt Tissot
8f8fd4231a escape ? in fish completion 2020-11-09 15:55:21 +01:00
Adrian Sampson
78722b079e
Merge pull request #3790 from AnonTester/master
lyrics: Strip \u2005 (four-per-em space) in lyrics (Issue 3789)
2020-11-08 09:14:11 -05:00
AnonTester
ecfafb5041 Adjust comment to pass lint test 2020-11-07 21:48:21 +00:00
AnonTester
176fa55bf6 lyrics: Strip \u2005 (four-per-em space) in lyrics (Issue 3789)
https://github.com/beetbox/beets/issues/3789
2020-11-07 21:41:16 +00:00
Adrian Sampson
b63b66a391
Merge pull request #3786 from aereaux/add_genres
Add use_mb_genres config option.
2020-10-31 13:06:33 -04:00
Aidan Epstein
ceb046d60c Add musicbrainz genre config option. 2020-10-30 08:27:04 -07:00
Aidan Epstein
0a8c755a6b Apply suggestions from code review
Co-authored-by: Adrian Sampson <adrian@radbox.org>
2020-10-30 08:27:04 -07:00
Aidan Epstein
a79b239d4f Add musicbrainz genre config option. 2020-10-30 08:27:04 -07:00
Adrian Sampson
627005d4d1
Merge pull request #3774 from beetbox/normalize-str
Try normalizing the dbcore String type
2020-10-28 18:51:13 -04:00
Adrian Sampson
072e1dfead
Merge pull request #3781 from aereaux/add_genres
Add genre support using musicbrainz tags.
2020-10-28 18:51:01 -04:00
Adrian Sampson
8ac14a39b6
Merge branch 'master' into normalize-str 2020-10-28 15:44:13 -04:00
Aidan Epstein
d011a4e577
Update beets/autotag/mb.py
Co-authored-by: Adrian Sampson <adrian@radbox.org>
2020-10-28 19:31:31 +00:00
Adrian Sampson
be0003aba3
Merge pull request #3784 from jackwilsdon/fix-pil-image-quality
Fix PIL image quality
2020-10-28 15:16:59 -04:00
Jack Wilsdon
f2dabfef53
Fix PIL image quality 2020-10-28 18:15:29 +00:00
Aidan Epstein
d70287df00 Add genre support using musicbrainz tags.
This requires this PR: https://github.com/alastair/python-musicbrainzngs/pull/266
2020-10-28 09:49:06 -07:00
Adrian Sampson
2cbec2d838 Changelog entry 2020-10-26 20:25:25 -04:00
Adrian Sampson
c3a54cc45b Merge branch 'master' into normalize-str 2020-10-26 20:23:46 -04:00
Jack Wilsdon
769e4246c1
Merge pull request #3765 from jackwilsdon/plugins-flag
Add --plugins flag
2020-10-25 16:39:46 +00:00