Commit graph

12502 commits

Author SHA1 Message Date
J0J0 T
e41525adbc convert: playlist: Remove clutter from test
- Remove comments in tearDown
- Don't test for converted.mp3, it's done in a separate test already, we
  only want to test for the playlist file here.
2023-03-29 07:21:27 +02:00
J0J0 T
9930a5da59 convert: playlist: Test playlist existence
Broken commit around writing a unittest that checks for existence of an
m3u file after convert has been called with --playlist option.
2023-03-29 07:21:27 +02:00
J0J0 T
5dfff50005 convert: playlist: Refactor m3u writing to class
and also implement a currently untested load() method.
2023-03-29 07:21:27 +02:00
J0J0 T
c251ed19c4 convert: playlist: Generate m3u file in one batch
to avoid any possible interference with the threaded file conversion
mechanism.
2023-03-29 07:21:27 +02:00
J0J0 T
d589e77ade convert: playlist: Fix redundant join path
It's done in _get_opts_and_config already.
2023-03-29 07:21:27 +02:00
J0J0 T
c0b1bc9867 convert: playlist feature: Better relative path gen
Use Item.destination method for generation of relative paths to media
files in playlist. The fragment keyword enables returning the path as
unicode instead of bytes, let's keep that in mind.
2023-03-29 07:21:27 +02:00
J0J0 T
16e25bb61b convert: playlist feature: Fix relative paths
pointing to media files in playlist. Also refine code comment and move
to a better fitting place.
2023-03-29 07:21:27 +02:00
J0J0 T
fd8fe69738 convert: Playlist feature linting fixes 2023-03-29 07:21:27 +02:00
J0J0 T
d448e0c4de convert: Refine and fix playlist feature
- Improve --help text
- Use unicode instead of bytes when adding media file paths to the
  playlist file.
- The "standard" (?) of m3u8 defines that unicode should ensure support
  of special characters in media file names. util.displayable_path() is
  used to do the conversion from bytes. We save everything in bytes in
  the config since it seemes to be the way this plugin or beets in
  general likes to save paths.
- Join dest and playlist in the config reader method already to have it
  ready in both methods that require the full path to the playlist file.
2023-03-29 07:21:27 +02:00
J0J0 T
861bc69df5 convert: Add a quick & dirty m3u playlist feature 2023-03-29 07:21:27 +02:00
Alok Saboo
3b39a4fe66 Raise OSError 2023-03-28 13:23:26 -04:00
Alok Saboo
2fcdb8c2ca Add FilesystemError handling 2023-03-28 09:22:51 -04:00
Alok Saboo
6626b76182 Update documents and add changelog entry 2023-03-27 20:03:31 -04:00
Alok Saboo
a4b4df8b12 More error handling 2023-03-27 19:28:09 -04:00
elyang0214
6e1d1a5c31
Merge branch 'beetbox:master' into master 2023-03-27 13:26:51 -04:00
Alok Saboo
2e2a3bf223 Add additional error handling 2023-03-27 11:56:26 -04:00
J0J0 Todos
ed1202bc94
Merge pull request #4733 from snejus/fixup-beetcamp-url
Update beetcamp URL in id_extractors
2023-03-27 16:19:34 +02:00
Šarūnas Nejus
4e519b200d
Update beetcamp URL in id_extractors 2023-03-27 02:27:32 +01:00
root
6539cdcfc5 added to changelog 2023-03-26 14:20:10 -04:00
root
c59ca0fca1 enforced utf-8 encoding on imported files 2023-03-26 14:13:20 -04:00
J0J0 Todos
34227cfabc
Merge pull request #4708 from JOJ0/mb_external_ids
Save external ID's via MusicBrainz
2023-03-26 14:25:15 +02:00
J0J0 Todos
5bf4e3d92f Dedicated flex attrs for Deezer, Beatport album ID
- Similar to what the Spotify plugin does, on imports we save to a field
  `..._album_id` (spotify_album_id, deezer_album_id, beatport_album_id)
- It would be good to submit such a change to the 3rd-party plugins beetcamp
  and beatport4 as well (beatport_album_id, bandcamp_album_id).
- We might need to investigate why none of these
  flex attr fields get populated to the beets album level (`beet info -a`,
  album_attributes db table), it is only available at the item level (`beet
  info`, item_attributes db table). This should be tackled in a future
  issue/PR.
2023-03-26 13:20:07 +02:00
Andrew Rogl
e5f2e6d37b Updated comments to attempt to be more self contained 2023-03-26 18:35:29 +10:00
J0J0 Todos
2e5394246f Docs for #4708 2023-03-25 20:51:52 +01:00
J0J0 Todos
348a9fbf13 Changelog for #4708 2023-03-25 20:51:52 +01:00
J0J0 Todos
6acee803f7 Exclude ID's when preserving flexible attributes
- Bandcamp, Spotify, Deezer and Beatport ID's are saved in the library as
  flexible attributes.
- On _reimports_ the method importer.ImportTask.reimport_metadata() takes care
  of preserving existing values for flexible attributes instead of applying new
  (and potentially empty) values.
- In this case we don't want this behaviour and need to make sure that new
  values are applied. Therefore we check whether such ID's of metadata services
  are present in the reimported items and exclude them in reimport_metadata().
2023-03-25 20:51:52 +01:00
J0J0 Todos
fd4cecc29e Make external IDs fetching via MB configurable
- By default no external URLs will be looked for in the 'url-relation-list' of
  the releae dictionary.
- Enabling is possible per each external service.
2023-03-25 20:51:52 +01:00
J0J0 T
6f2c31926e Fetch more external IDs via MusicBrainz
Add retrieval and ID extraction of Bandcamp, Spotify, Deezer and Beatport URLs
while retrieving a MusicBrainz release.
2023-03-25 20:51:16 +01:00
Andrew Rogl
4338ef3e35 Address comments from @sampsyo 2023-03-25 13:36:27 +10:00
Adrian Sampson
4194914e94
Merge pull request #4712 from arsaboo/convert_negation
Add additional example to convert plugin
2023-03-24 16:55:36 -07:00
J0J0 Todos
e51206ae16
Merge pull request #4723 from arsaboo/jiosaavn
Add JioSaavn to the community plugins list
2023-03-23 12:28:53 +01:00
J0J0 Todos
1dd75d687a
Merge pull request #4705 from arsaboo/installation
Add instructions to install directly from Github.
2023-03-23 12:26:25 +01:00
Alok Saboo
5231037591 Add JioSaavn as a tag source 2023-03-20 17:32:45 -04:00
Alok Saboo
2060e047d2 Update parser options 2023-03-19 10:21:32 -04:00
Alok Saboo
2d942ce722 Move import inside the function 2023-03-19 09:15:38 -04:00
Alok Saboo
59d5d23bb3 Update embedart.py 2023-03-18 19:12:29 -04:00
Alok Saboo
64c2ae138d Update embedart.py 2023-03-18 19:11:24 -04:00
Alok Saboo
81835b0721 Update embedart.py 2023-03-18 19:08:46 -04:00
Alok Saboo
4dd165495f Update embedart.py 2023-03-18 19:00:28 -04:00
Alok Saboo
feeeb4080c Update embedart.py 2023-03-18 18:58:32 -04:00
Alok Saboo
f051d67947 Add option to import using URL 2023-03-18 18:23:53 -04:00
Alok Saboo
9f4b43c540 Point to latest docs 2023-03-18 10:56:16 -04:00
Alok Saboo
6d0e5ba8ca Change to GitHub 2023-03-17 11:06:46 -04:00
Alok Saboo
5f87371229 rephrase 2023-03-14 20:57:34 -04:00
Alok Saboo
05cdecfb7c Add more examples to convert plugin 2023-03-14 20:39:47 -04:00
Alok Saboo
53911c74dd Link to dev docs 2023-03-13 11:33:45 -04:00
Alok Saboo
36daf93828 Add instructions to install directly from Github. 2023-03-12 16:28:29 -04:00
J0J0 T
c2c617594f Save Discogs Release ID via MusicBrainz
- Enable fetching 'url-rels' from the MusicBrainz release endpoint.
- A MusicBrainz release might contain a link to a Discogs release
  which we save to the discogs_albumid attribute of the info object.
- For extraction of the release ID from the Discogs URL, we use the method
  provided in the id_extractors util module.
2023-03-12 12:03:31 +01:00
Adrian Sampson
2e18f84b38
Merge pull request #4698 from ghbrown/discogs_client_check
discogs_client version check
2023-03-10 21:56:48 -08:00
ghbrown
f1b7832d52 Change minimum discogs_client version to 2.3.15 2023-03-10 15:28:29 -06:00