Commit graph

13297 commits

Author SHA1 Message Date
Bootjewolf
5f74bf4394 Added the remixer field from musicbrainz 2022-11-15 17:41:49 +01:00
Luke Harder
43f1a8412a bug 4406 fix v3 2022-11-10 14:53:50 -05:00
Luke Harder
22a5a7f9f4 bug 4406 fix v2 2022-11-10 14:46:36 -05:00
Luke Harder
252121f537 bug 4406 fix 2022-11-10 12:54:45 -05:00
Adrian Sampson
e201dd4fe5
Merge pull request #4534 from RollingStar/patch-3
Sort and comment "replace"
2022-10-31 09:50:58 -07:00
RollingStar
409f2f85cb
Update config_default.yaml 2022-10-30 20:43:05 -04:00
RollingStar
9757bc0002
Sort and comment "replace" 2022-10-29 03:01:34 -04:00
Adrian Sampson
bcfc86df04
Merge pull request #4525 from phillprice/master
Corrects popularity service from spotify to deezer to match plugin
2022-10-20 17:38:01 -07:00
Phill Price
867656eef7
Update index.rst
Corrects popularity service from spotify to deezer to match plugin
2022-10-20 23:05:33 +01:00
Adrian Sampson
e9576e6c57
Merge pull request #4521 from aereaux/patch-1
Fix recent bug that would not transcode when format was wrong
2022-10-19 09:46:02 -07:00
Aidan Epstein
c906e55ba9 Fix recent bug that would not transcode when format was wrong
Bug introduced in c6d623241b, should_transcode would return False even when the format was different.

Also fix up tests and documentation.
2022-10-19 08:55:51 -07:00
Adrian Sampson
407b1fd013
Merge pull request #4510 from KucharczykL/KucharczykL-remove-duplicate-triphop
Remove duplicate "Trip-hop" genre
2022-10-03 11:13:06 -07:00
Adrian Sampson
e7290c3469
Merge pull request #4504 from Tomasito665/fix_max_bitrate_default
Fix #4472 - set 'max_bitrate' default param to none
2022-10-03 11:11:08 -07:00
Adrian Sampson
ad1f57f8bb
Changelog for #4510 2022-10-03 11:03:55 -07:00
Adrian Sampson
1ebcbf6944
Merge branch 'master' into fix_max_bitrate_default 2022-10-03 11:02:07 -07:00
Lukáš Kucharczyk
a41a9b7aa1
Remove duplicate "Trip-hop" genre 2022-10-03 19:58:23 +02:00
Adrian Sampson
7db020961d
Merge pull request #4496 from beetbox/ignored_alias_types
Add a `import.ignored_alias_types` option to ignore alias types.
2022-10-03 10:52:37 -07:00
Adrian Sampson
a86476c78b
Merge pull request #4502 from beetbox/aura-cors-docs
AURA: document cors for local browser clients
2022-10-03 10:49:47 -07:00
Adrian Sampson
04ad5a0f5a
Merge branch 'master' into ignored_alias_types 2022-10-03 10:44:21 -07:00
Adrian Sampson
4a9e7c1d33
Merge pull request #4507 from beetbox/arg-encoding-experiment
Use Python's standard filesystem encoding for command-line arguments
2022-10-03 10:44:01 -07:00
Jordi Ortolá Ankum
95e0161876
Merge branch 'master' into fix_max_bitrate_default 2022-10-03 10:49:51 +02:00
Adrian Sampson
1a73a4550a
Changelog for #4507 2022-10-01 17:30:53 -07:00
Adrian Sampson
8baf3e302d
Skip an unhelpful test on Windows
On Windows, converting command-line arguments (hopefully!!!) only needs
to deal with valid strings from the OS. So it is not really relevant to
test with non-UTF-8, non-surrogate bytes.
2022-10-01 17:13:57 -07:00
Adrian Sampson
086bab55b1
Standardize on Python's fsencode for arguments
This can apparently never be `None`, as of Python 3.2.
2022-10-01 16:42:43 -07:00
Adrian Sampson
82d41446a2
Use fsdecode for template substitution
The idea in this PR is to converge on Python's `fsdecode` and `fsencode`
for argument manipulation. This seems to match up with the Python
standard library's assumptions: namely, on Windows, we use `fsdecode` to
get back to Unicode strings:
54bbb5e336/Lib/subprocess.py (L561)

So let's start by dropping this utility and going straight for
`fsdecode` here to match.
2022-10-01 16:37:47 -07:00
Adrian Sampson
c8ab0cfa6b
Merge pull request #4506 from beetbox/replaygain-fix-exc
replaygain: Fix error handling for parallel runs
2022-10-01 16:35:38 -07:00
Adrian Sampson
675dd7b9a9
Add logging for command output on errors 2022-10-01 16:08:32 -07:00
Adrian Sampson
eaabf291f7
Changelog for #4506 2022-10-01 15:51:44 -07:00
Adrian Sampson
9803939a1c
replaygain: Fix error handling for parallel runs
The parallelism strategy in #3478, in retrospect, used a pretty funky
way to deal with exceptions in the asynchronous work---since
`apply_async` has an `error_callback` parameter that's meant for exactly
this. The problem is that the wrapped function would correctly log the
exception *and then return `None`*, confusing any downstream code.
Instead of just adding `None`-awareness to the callback, let's just
avoid running the callback altogether in the case of an error.
2022-10-01 15:47:41 -07:00
Adrian Sampson
7f977079c3
Merge pull request #4505 from beetbox/fix-unidecode
Adapt tests to latest Unidecode version
2022-10-01 10:44:20 -07:00
Adrian Sampson
5ae1e0f3c8
Adapt tests to latest Unidecode version
Unidecode 1.3.5 (a yanked PyPI version) changed the behavior of
Unidecode for some specific characters:

> Remove trailing space in replacements for vulgar fractions.

As luck would have it, our tests used the 1/2 character specifically to
test the behavior when these characters decoded to contain slashes. We
now pin a sufficiently recent version of Unidecode and adapt the tests
to match the new behavior.
2022-10-01 10:33:26 -07:00
Jordi
c6d623241b Fix beets#4472 - set 'max_bitrate' default param to none 2022-10-01 01:20:30 +02:00
Callum Brown
aa09d2a9eb AURA: document cors for local browser clients 2022-09-28 21:04:33 +01:00
David Logie
cfb32d9bc5 Add a import.ignored_alias_types option to ignore alias types.
Sometimes a user may want to use an artist's locale-specific alias but
*not* want to use their legal name, for example.
2022-09-24 15:36:46 +01:00
Benedikt
b11df49705
Merge pull request #4492 from arsaboo/spotify_date
Fix spotify_updated bug so that the date is not "null"
2022-09-18 12:03:13 +02:00
Alok Saboo
4692199166 Add dateype back 2022-09-17 21:05:16 -04:00
Alok Saboo
e4063b5880 remove datetype 2022-09-17 20:56:48 -04:00
Alok Saboo
85b500e41a Fix spotify_updated bug 2022-09-17 20:25:36 -04:00
Adrian Sampson
44a7cc74bf
Merge pull request #4485 from c00ldude1oo/master
Fix typo in albumtypes plugin docs
2022-09-14 16:13:29 -07:00
Chris
f5d7967646
Fix typo in albumtypes plugin docs 2022-09-14 04:06:16 -04:00
Adrian Sampson
50bd693057
Merge pull request #4456 from arsaboo/mbsubmit
Extend mbsubmit plugin to run after initial import
2022-08-27 13:18:24 -07:00
Adrian Sampson
b65bdd7f06
Add plugin link to changelog for #4456 2022-08-27 13:16:42 -07:00
Adrian Sampson
0c8bf6d7c7
Remove a stray dot 2022-08-27 13:16:02 -07:00
Adrian Sampson
010bacd1ea
Merge pull request #4457 from konlaasz/patch-1
Fix typo
2022-08-26 08:17:36 -07:00
László Koncz
27bc317fed
Fix typo 2022-08-26 12:04:47 +02:00
Alok Saboo
1a2fcdd4e3 Adjust line length 2022-08-24 10:04:01 -04:00
Alok Saboo
8ee1a9e508 Updated docs 2022-08-24 09:39:25 -04:00
Alok Saboo
f01eca756f Update changelog.rst 2022-08-24 09:34:06 -04:00
Alok Saboo
d267f9a8a9 Remove f-string 2022-08-24 09:32:39 -04:00
Alok Saboo
9d8ce14e9a Cleanup mbsubmit 2022-08-24 09:24:33 -04:00