Adrian Sampson
854fec2634
Merge pull request #4826 from wisp3rwind/dbcore_typing_0
...
typings: corrections for dbcore/queryparse
2023-06-23 17:44:13 -07:00
Adrian Sampson
17e1d404b7
Fix flubbed merge
2023-06-23 17:30:27 -07:00
Adrian Sampson
6c77e1a78d
Merge branch 'master' into dbcore_typing_0
2023-06-23 17:27:34 -07:00
Adrian Sampson
511824028c
Merge pull request #4827 from wisp3rwind/dbcore_typing_1
...
dbcore/query: remove spurious dependency on library
2023-06-23 17:17:22 -07:00
wisp3rwind
bc7c447b3c
beetsplug/playlist: actually use SQL clause
...
As far as I can tell, the fast SQL path was never used before, since a
query would use the default `clause()` implementation. It is only the
`FieldQuery.clause()` that could delegate to `col_clause()`, but
`PlaylistQuery` is not a `FieldQuery`.
2023-06-23 11:00:09 +02:00
wisp3rwind
09d2c87f29
typings: corrections for dbcore/queryparse
...
- Add NamedQuery abstract class to be able to express the expectation
that a query should be such a query (and have a specific constructor
signature) in construct_query_part
- slightly (and probably completely irrelevantly) improve Query.__hash__
- also, sprinkle some ABC/abstractmethod around to clarify things
2023-06-23 10:59:51 +02:00
wisp3rwind
7b4c0592eb
dbcore/query: remove spurious dependency on library
...
It seems like `Query`s and `Sort`s should really be generic over
`Model`.
Also, make use of the postponed evaluation of annotations that we get
with `from future import __annotations__`.
2023-06-23 10:27:46 +02:00
Benedikt
7d05e01b85
Merge pull request #4825 from JOJ0/fix_convert_auto_keep
...
Fix ValueError in convert plugin auto_convert_keep
2023-06-22 15:26:32 +02:00
J0J0 Todos
0d8f8a3cff
Fix ValueError in convert plugin auto_convert_keep
2023-06-22 09:13:09 +02:00
fence
dccc62443d
fix tests
2023-06-19 20:13:16 +02:00
fence
206ed23810
refactor based on review
2023-06-19 19:27:27 +02:00
fence
e992b82bdf
resolve transl-tracklisting relations for pseudo releases
2023-06-19 19:27:25 +02:00
Adrian Sampson
79435c3b6f
Merge pull request #4819 from lonebyte/fix-fanarttv-sorting
...
Fix fanarttv sorting
2023-06-16 20:17:27 -04:00
Jan Müller
8c6c2f0083
Update changelog.rst
2023-06-14 23:01:48 +02:00
lonebyte
2c3aca23e1
Fix the sorting of fanart.tv covers
...
fanart.tv uses a string to output the number of likes (see https://fanart.tv/api-docs/api-v3/ ). In order to sort numerically we need to convert the string into an int.
2023-06-14 20:25:18 +02:00
Adrian Sampson
0c3f428a60
Merge pull request #4816 from beetbox/release_group_title-album-tag
...
Make sure release_group_title is applied to album objects.
2023-06-06 06:34:58 -07:00
David Logie
c575d4d016
Make sure release_group_title is applied to album objects.
2023-06-06 09:15:16 +01:00
Adrian Sampson
fc51a9327c
Merge pull request #4809 from beetbox/releasegroup_title-field
...
Store the release group's title.
2023-06-04 09:03:43 -07:00
Alok Saboo
4c113dcf19
Update comment explaining how to extend import fields
2023-06-04 11:23:32 -04:00
David Logie
7ec93d6049
Store the release group's title.
...
beets does not currently store the "canonical" release group title,
only each release's title and disambiguation. Oddly, beets does store
the release group disambiguation.
Without this there is no way to determine a release group's title
without separately querying a data source.
2023-06-04 12:20:06 +01:00
Adrian Sampson
63587f6951
Merge pull request #4810 from plenaerts/master
...
Elaborated multidisc FAQ
2023-06-03 14:59:56 -07:00
Adrian Sampson
0e446fd16a
Simplify wording a bit
2023-06-03 14:59:25 -07:00
Pieter Lenaerts
12db5fc4c9
Reverting dicussions extlink
...
Discussions on github can be referenced as issues. The discussions
extlink was therefore not needed.
2023-06-03 08:20:00 +02:00
Pieter Lenaerts
1411510d55
Elaborated multidisc FAQ with github discussions extlink
2023-06-03 08:14:36 +02:00
Serene
f68ff90899
Merge pull request #4495 from Serene-Arc/dbcore_typing
2023-06-02 16:23:31 +10:00
Serene-Arc
7915d7b5a5
Fix linter errors
2023-06-02 16:10:28 +10:00
Serene-Arc
3f4f559912
Remove unused import
2023-06-02 16:04:15 +10:00
Serene-Arc
2b29bccd14
Add requirement necessary for typings
2023-06-02 15:20:50 +10:00
Serene-Arc
25df001d54
Fix circular import
2023-06-02 15:15:43 +10:00
Serene-Arc
b9ae682f17
Fix too-new syntax
2023-06-02 15:15:43 +10:00
Serene-Arc
b172688a61
Fix circular import
2023-06-02 15:15:43 +10:00
Serene-Arc
0ccf0733af
Roll back to old syntax for unions
2023-06-02 15:15:43 +10:00
Serene-Arc
eac46bf9dd
Fix some typings
2023-06-02 15:15:43 +10:00
Serene-Arc
1e9ff27f1a
Fix some typings
2023-06-02 15:15:43 +10:00
Serene-Arc
d6119ffce5
Fix typing
2023-06-02 15:15:43 +10:00
Serene-Arc
b2df67f270
Rename type alias to be less confusing
2023-06-02 15:15:43 +10:00
Serene-Arc
55bd6e157c
Fix typings
2023-06-02 15:15:43 +10:00
Serene-Arc
95803c5dcc
Fix more typings
2023-06-02 15:15:43 +10:00
Serene-Arc
5388743b84
Define keys as strings in typing
2023-06-02 15:15:43 +10:00
Serene-Arc
167866d2d4
Widen typing for parameter
2023-06-02 15:15:43 +10:00
Serene-Arc
ec9f23f422
Fix typings of real file manipulations
2023-06-02 15:15:43 +10:00
Serene-Arc
21f34c8402
Fix path typings
2023-06-02 15:15:43 +10:00
Serene
7e6d716f26
Update typing
...
Co-authored-by: Benedikt <wisp3rwind@posteo.eu>
2023-06-02 15:15:43 +10:00
Serene-Arc
d82e526044
Modify some typings according to mypy
2023-06-02 15:15:43 +10:00
Serene-Arc
d0ea71d5c9
Add typing for path functions
2023-06-02 15:15:43 +10:00
Serene-Arc
2d56e196a8
Remove wrong type
2023-06-02 15:15:43 +10:00
Serene-Arc
bd7350a67a
Add proper generator typing
2023-06-02 15:15:43 +10:00
Serene-Arc
736e93aa82
Fix some typings
2023-06-02 15:15:43 +10:00
Serene-Arc
3f8afb9a45
Fix and mark errors
2023-06-02 15:15:43 +10:00
Serene-Arc
13c1561390
Add more typings
2023-06-02 15:15:42 +10:00
