Adrian Sampson
5ca43c3cc0
Merge pull request #2605 from beetbox/fixednone
...
Always use specific null values for fixed fields
2017-06-21 10:15:03 -04:00
Adrian Sampson
336fdba9ed
Musical key field may be None
...
Fixes a `modify` test, of all things.
2017-06-20 16:31:00 -04:00
Adrian Sampson
8085d1318b
Fix ipfs test to sort items in order
2017-06-20 16:19:31 -04:00
Adrian Sampson
41bd6f9a97
Explicitly let artpath be missing
...
We really want `Album.artpath` to be None sometimes, and this was relying on
some accidental dbcore behavior before. Now, we explicitly mark the field as
nullable: it may be a path, or it may be None to indicate that there is no
art.
2017-06-20 16:04:25 -04:00
Adrian Sampson
2a9be17cf6
Fix some brittle query tests
...
These were written to incidentally depend on Nones; the behavior they're
actually testing doesn't really have anything to say about None-ness.
2017-06-20 15:56:33 -04:00
Adrian Sampson
b575a1ef75
Always use specific null values for fixed fields
...
This came out of an attempt to address the mysterious testing problems from
PR #2563 and turned into a big old debacle. As it turns out, the problem came
from calling Item.from_path and getting None for fields that weren't filled
out by the MediaFile data. Everywhere else, we fill out these fixed attributes
with the special null value for the field's type, so it's actually pretty
confusing that these could mysteriously become None. I think it will be saner
all around if we enforce this universally.
There were two possible fixes: one in __getitem__ to check for missing values
and one that set all the missing values in the constructor. I opted for the
former because it has a smaller footprint, but the latter might have slightly
better performance (depending on the ratio of constructions to lookups).
2017-06-20 15:50:37 -04:00
Adrian Sampson
7e8056b0e8
Version bump: 1.4.6
2017-06-20 14:49:19 -04:00
Adrian Sampson
4917bd30f7
Add date to changelog
2017-06-20 14:48:48 -04:00
Adrian Sampson
2cd3e13aa7
Spruce up changelog for release
2017-06-20 14:47:11 -04:00
masi
3bea876111
Fix #1918 : ValueError on trying to import
2017-06-17 23:20:46 +02:00
Adrian Sampson
d2106454c4
Fix path in read errors while writing ( #2599 )
2017-06-17 12:43:25 -04:00
Adrian Sampson
732f0174c8
Expand error message for FileTypeError ( #2599 )
...
...when Mutagen doesn't recognize the type at all.
2017-06-17 12:42:00 -04:00
Adrian Sampson
d31a48345f
Merge pull request #2598 from beetbox/relativedate
...
Relative date queries (continuation of #2418 )
2017-06-16 11:48:56 -04:00
Adrian Sampson
a52d3d532a
Changelog for relative dates ( #2418 , #2598 )
2017-06-16 11:13:01 -04:00
Adrian Sampson
b1b4272501
Refinements to the relative date docs
2017-06-16 11:11:12 -04:00
Adrian Sampson
690ed731d8
Move the relative date docs downward
...
It's important to introduce the .. syntax before we get here.
2017-06-16 11:07:24 -04:00
euri10
eaae3fbd30
Merge branch 'relativedate'
2017-06-16 09:15:38 +02:00
euri10
93f064f505
Renamed relative to relative_units
...
Changed the return in case of a relative date, by default precision is
to the second, aka 5
Removed old 'relative' precision that indeed isn't necessary anymore
Corrected doc according to current relative date format, no more @
2017-06-16 09:14:40 +02:00
euri10
01cf0d0a8f
Merge remote-tracking branch 'upstream/master'
2017-06-16 09:05:50 +02:00
Adrian Sampson
63692ff9a4
Changelog for #2596 ( fixes #2595 )
2017-06-15 21:04:16 -04:00
Adrian Sampson
f2b6801e6c
Merge pull request #2596 from aranc23/metasync-fixes
...
do not quote the value in xml, use quoteattr to add quotes as needed
2017-06-15 21:01:46 -04:00
Adrian Sampson
8ba0060f44
Wrap a long line
2017-06-15 20:46:54 -04:00
Adrian Sampson
130c581c28
Some formatting cleanup for relative dates
2017-06-15 18:15:51 -04:00
Adrian Sampson
8a6c8cde6a
Simplify the docs a bit for relative dates
2017-06-15 18:10:55 -04:00
Adrian Sampson
26940b6e10
Merge branch 'master' into relativedate
2017-06-15 18:06:51 -04:00
Adrian Sampson
949d7fbca5
More docstring whitespace
2017-06-15 18:05:47 -04:00
Adrian Sampson
6f977877fe
Merge branch 'master' into euri10-master
2017-06-15 18:00:50 -04:00
Adrian Sampson
2144882290
Correct some PEP8 post-docstring whitespace
...
To better match #2597 for a cleaner diff.
2017-06-15 17:59:40 -04:00
Adrian Sampson
009c6a4f6d
Slightly clearer layout for #2593 , and comments
2017-06-15 17:51:14 -04:00
Adrian Sampson
c840fea125
Changelog for #2593
2017-06-15 17:49:59 -04:00
Adrian Sampson
338d471dde
Merge pull request #2593 from robot3498712/develop
...
fix /issues/2592: web: Use Unicode paths to send files on Windows und…
2017-06-15 17:49:09 -04:00
Aran Cox
f36c70c754
do not quote the value in xml, use quoteattr to add quotes as needed
2017-06-15 09:00:59 -05:00
robot3498712
cafbb2438e
fixed failing test - line too long
2017-06-15 13:27:28 +02:00
robot3498712
bc8a8ecf5f
fix /issues/2592: web: Use Unicode paths to send files on Windows under Python 2
2017-06-15 12:49:00 +02:00
euri10
ae3f9bf9b6
Corrected some flake8 errors, overindentation and pycharm reformat
...
don't seem to play well
2017-06-15 09:59:53 +02:00
euri10
527d0a88f4
Corrected some flake8 errors
2017-06-15 09:31:41 +02:00
euri10
92c118f4a8
Corrected some flake8 errors
2017-06-15 09:11:28 +02:00
euri10
6664b656f4
Merge branch 'relativedate'
...
Solved conflicts with upstream of new parse classmethod of DateQuery
# Conflicts:
# beets/dbcore/query.py
2017-06-15 08:59:43 +02:00
Adrian Sampson
d9c8f97318
ReST syntax fix
2017-06-14 19:09:38 -04:00
Adrian Sampson
ace5656e36
Complete set of __future__ imports
2017-06-14 19:08:27 -04:00
Adrian Sampson
97cedce0f8
Changelog for #2586 ( fixes #2553 )
2017-06-14 19:07:34 -04:00
Adrian Sampson
1f2b8cef97
Tiny code and docs fixes for gmusic ( #2586 )
2017-06-14 19:05:38 -04:00
Adrian Sampson
4563e3b6dd
Merge pull request #2586 from tigranl/gmusic
...
Add Google Music plugin
2017-06-14 18:52:20 -04:00
Adrian Sampson
71d6dc3544
Docs refinements for #2581
2017-06-13 09:27:42 -04:00
Adrian Sampson
3f684455d2
Move changelog entry to the right position
2017-06-13 09:20:21 -04:00
Adrian Sampson
719b699d00
Teensy whitespace fix
2017-06-13 09:19:56 -04:00
Adrian Sampson
e0ce507055
Merge pull request #2581 from bartkl/master
...
Set field values on the import command line #1881
2017-06-13 09:18:48 -04:00
A.L. Kleijngeld
2eb4e3d515
Merge branch 'master' into master
2017-06-13 14:43:10 +02:00
Bart Kleijngeld
762f9ca054
revised to fix flake8 warnings
2017-06-13 14:33:08 +02:00
Tigran Kostandyan
2d7962c552
Update toctree
2017-06-13 02:48:43 +03:00
