Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-01-02 05:52:50 +01:00
Code Issues Projects Releases Wiki Activity

Replaygain tests: more careful plugins unloading

Browse source 
When plugins loading as failed plugins unloading may fail in
consequence, swallowing the loading error. This fixes it.
This commit is contained in:
Bruno Cauet 2015-03-04 12:15:56 +01:00
parent 69786b8538
commit f8e2ca2c94
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
test/test_replaygain.py
View file

@ -42,9 +42,18 @@ class ReplayGainCliTestBase(TestHelper):
try:
self.load_plugins('replaygain')
except:
self.teardown_beets()
self.unload_plugins()
raise
import sys
# store exception info so an error in teardown does not swallow it
exc_info = sys.exc_info()
try:
self.teardown_beets()
self.unload_plugins()
except:
# if load_plugins() failed then setup is incomplete and
# teardown operations may fail. In particular # {Item,Album}
# may not have the _original_types attribute in unload_plugins
pass
raise exc_info[1], None, exc_info[2]
self.config['replaygain']['backend'] = self.backend
album = self.add_album_fixture(2)